[koha-commits] main Koha release repository branch master updated. v3.22.00-88-gf0da781

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  f0da781368a187337236d64ee94d9c8cc65f90f7 (commit)
       via  a4f5564c855e31f6872fb5e3ef378381473f837c (commit)
      from  dcc10787cce9b6c3c1af5277fac73b248c949360 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f0da781368a187337236d64ee94d9c8cc65f90f7
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Nov 25 14:02:05 2015 +0100

    Bug 15252 - Add tests
    
    Tested 4 patches together, works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

commit a4f5564c855e31f6872fb5e3ef378381473f837c
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Wed Nov 25 12:34:18 2015 +0100

    Bug 15252 - Patron search on start with does not work with several terms
    
    When searching a patron, search type can be 'start with' and 'contain'.
    If the search text contains a space (or a coma), this text is splitted into several terms.
    
    Actually, the search on 'start with' with several terms never returns a result.
    
    It is because the search composes an "AND" SQL query on terms.
    For example (I display only the surname part) :
    search type = contain :
      'jean paul' => surname like '%jean% AND %paul%'
    search type = start with :
      'jean paul' => surname like 'jean% AND paul%'
    The query for 'start with' is impossible.
    
    I propose, for search with start with, to not split terms :
      jean paul => surname like 'jean paul%'
    
    One can always use '*' to add more truncation :
      jea* pau* => surname like 'jea% pau%'
    
    This bug affects a lot surnames with several terms like 'LE GUELEC' or 'MAC BETH'.
    
    Note that the patch moves :
      $searchmember =~ s/,/ /g;
    It removes the test "if $searchmember" because $searchmember is tested and set to empty string previously :
        unless ( $searchmember ) {
            $searchmember = $dt_params->{sSearch} // '';
        }
    
    Test plan :
    ==========
    - Create two patrons with firstname "Jean Paul"
    - Go to Patrons module
    - Choose "Starts with" in "Search type" filter
    - Perform a search on "Jean Paul"
    => without patch : you get no result
    => with this patch : you get the two results
    - Check you get the two results for search on "Jean Pau"
    - Check you get the two results for search on "Jea* Pau*"
    - Check you do not get results for search on "Jea Paul"
    - Choose "Contains" in "Search type" filter
    - Check you get the two results for search on "Jean Paul"
    - Check you get the two results for search on "Jean Pau"
    - Check you get the two results for search on "Jea* Pau*"
    - Check you get the two results for search on "Jea Paul"
    - Check you get the two results for search on "Paul Jean"
    
    Signed-off-by: Alex <alexklbuckley at gmail.com>
    
    Tested 4 patches together, works as expected
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Bug 15252 - Patron search on start with does not work with several terms - followup 1
    
    'start_with' is the default value of $searchtype, it can be explicit.
    
    Tested 4 patches together, works as expected
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Bug 15252 - correct UT searchtype value is contain and not contains
    
    Tested 4 patches together, works as expected
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Utils/DataTables/Members.pm            |   30 ++++++++----
 t/DataTables/Members.t                    |    2 +-
 t/db_dependent/Utils/Datatables_Members.t |   76 +++++++++++++++++++++++++----
 3 files changed, 89 insertions(+), 19 deletions(-)


hooks/post-receive
-- 
main Koha release repository