[koha-commits] main Koha release repository branch master updated. v3.22.00-142-gff1579d
Git repo owner
gitmaster at git.koha-community.org
Thu Dec 31 01:23:12 CET 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via ff1579de6d2e95158cf4f9e9261068bdeef31f53 (commit)
via c7ec79b8390817100b677530b88d1d4d02986b98 (commit)
from ff9d241239c6eba425755ca2bbde9c31203db151 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit ff1579de6d2e95158cf4f9e9261068bdeef31f53
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Thu Nov 26 08:26:34 2015 +0100
Bug 15258: Fix Perl scripts declaring unused variables
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
All affected files tested with `perl -c`.
Signed-off-by: Jesse Weaver <jweaver at bywatersolutions.com>
commit c7ec79b8390817100b677530b88d1d4d02986b98
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Thu Nov 26 07:30:42 2015 +0100
Bug 15258: Prevent unused declared variables
Add a perlcritic rule to 00-perlcritic.t to prevent unused declared
variable.
TO TEST:
- Apply the 1st patch (unit test)
- Run the UT:
prove -v t/00-testcritic.t
- Note that several Perl script fail
- Apply the 2nd patch
- Run the UT, and confirm it passes.
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
All tests pass successful.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Jesse Weaver <jweaver at bywatersolutions.com>
-----------------------------------------------------------------------
Summary of changes:
C4/SIP/Sip/MsgType.pm | 4 +--
Koha/MetaSearcher.pm | 1 -
Koha/QueryParser/Driver/PQF/Util.pm | 1 -
Koha/QueryParser/Driver/PQF/query_plan/modifier.pm | 1 -
Koha/Template/Plugin/Price.pm | 1 -
acqui/basketheader.pl | 1 -
acqui/invoice.pl | 1 -
acqui/spent.pl | 1 -
admin/aqplan.pl | 5 ----
admin/auth_subfields_structure.pl | 1 -
admin/koha2marclinks.pl | 1 -
admin/transport-cost-matrix.pl | 2 +-
basket/basket.pl | 1 -
catalogue/MARCdetail.pl | 1 -
cataloguing/addbiblio.pl | 3 --
cataloguing/merge.pl | 1 -
cataloguing/value_builder/macles.pl | 4 +--
.../value_builder/marc21_linking_section.pl | 1 -
cataloguing/value_builder/unimarc_field_4XX.pl | 1 -
circ/branchtransfers.pl | 1 -
circ/pendingreserves.pl | 13 --------
circ/waitingreserves.pl | 2 --
labels/label-item-search.pl | 4 +--
members/moremember.pl | 2 --
reserve/placerequest.pl | 1 -
reserve/request.pl | 3 --
serials/checkexpiration.pl | 1 -
serials/subscription-add.pl | 2 --
sms/sms_listen.pl | 2 --
t/00-testcritic.t | 31 +++++++++++++++-----
t/perlcriticrc | 5 ++--
31 files changed, 32 insertions(+), 67 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list