[koha-commits] main Koha release repository branch 3.22.x updated. v3.22.01-37-g95e9daf
Git repo owner
gitmaster at git.koha-community.org
Thu Dec 31 10:27:45 CET 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.22.x has been updated
via 95e9dafa38bf6f895cf62feac1df20e3b67a0640 (commit)
via 44202df6acdfcfb371eccc6b8e8007a871304e49 (commit)
from dbd07c4d089ca32d385c0f044bfb6a85ae547706 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 95e9dafa38bf6f895cf62feac1df20e3b67a0640
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 9 17:41:04 2015 +0000
Bug 15344: Remove some other calls of GetMemberDetails from pl scripts
Same as previously.
For these files it's a bit less obvious.
To make sure these changes won't introduce any regression, check that
the variable returned by GetMember is never used to get something
else than a borrower fields.
The 'flags' should not be get neither.
For opac-user.tt it's different, other keys are got but there are defined
in the pl script.
On the way:
- 'showname' is removed (never used)
- fix scope var issue in opac-user.tt (BORROWER_INF.OPACPatronDetails vs
OPACPatronDetails)
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit 010a32d95f871853f5c597b2670f3de4c62cfa51)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
commit 44202df6acdfcfb371eccc6b8e8007a871304e49
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Dec 9 17:00:10 2015 +0000
Bug 15344: Remove unucessary call to GetMemberDetails
This subroutine does a lot a processing and should only be called when
necessary.
In the get_template_and_user subroutine (so called from any pages of
Koha), it is call to pass the branchcode, title, firstname, surname and
borrowernumber values for the logged in user.
This subroutine calls GetMemberAccountRecords which retrieve the items
infos for all accountlines entries of the logged in user.
On members/members.pl, let's say you have 74 entries in the accountlines
tables, the page will execute 115 SELECT instead of 35 if you don't have any
accountlines entries.
With this patch, the number of SELECT is always 31.
To test this patch you should have technical skills to know what to do.
Note that USER_INFO was an array of... 1 element. Now it's a hashref.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
(cherry picked from commit ac541e0fa1c11254e110d94eed64c358e02e8aab)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Auth.pm | 10 ++---
C4/Members.pm | 10 -----
admin/aqbudgets.pl | 4 +-
admin/aqplan.pl | 6 +--
catalogue/detail.pl | 2 +-
circ/circulation.pl | 2 +-
circ/returns.pl | 8 ++--
circ/transferstoreceive.pl | 2 +-
circ/waitingreserves.pl | 2 +-
.../prog/en/includes/cateditor-ui.inc | 10 ++---
.../prog/en/modules/cataloguing/addbiblio.tt | 2 +-
.../prog/en/modules/cataloguing/addbooks.tt | 2 +-
.../opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-account.tt | 2 +-
.../bootstrap/en/modules/opac-downloadshelf.tt | 2 +-
.../bootstrap/en/modules/opac-messaging.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 6 +--
.../bootstrap/en/modules/opac-shareshelf.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +-
.../bootstrap/en/modules/opac-suggestions.tt | 2 +-
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 39 +++++++++-----------
offline_circ/list.pl | 2 +-
opac/opac-account.pl | 8 +---
opac/opac-ics.pl | 3 --
opac/opac-messaging.pl | 6 +--
opac/opac-passwd.pl | 3 +-
opac/opac-privacy.pl | 3 +-
opac/opac-user.pl | 6 +--
28 files changed, 61 insertions(+), 89 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list