From gitmaster at git.koha-community.org Sun Feb 1 04:28:46 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 01 Feb 2015 03:28:46 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-3-g10e13dd Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 10e13ddb74fb2a65892932fd0677dc94df3aec0f (commit) via 131050798d2933c02cdb2de853ae62e51b55ad37 (commit) from 59407a0e38da6f447650cdd30da9958fff20c5bc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 10e13ddb74fb2a65892932fd0677dc94df3aec0f Author: Jonathan Druart Date: Thu Jan 15 15:20:02 2015 +0100 Bug 12861: (follow-up) Noisy warn in error logs Completely get rid of warns. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit acff2645584043c8f34515e3326973f149dcf913) Signed-off-by: Chris Cormack commit 131050798d2933c02cdb2de853ae62e51b55ad37 Author: Chris Cormack Date: Wed Sep 3 09:49:41 2014 +1200 Bug 12861 : Noisy warn in the error logs To test Hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY Notice the warns in the error log Apply patch Reload the url Still works but no warns (cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d) Signed-off-by: Chris Cormack Reformatted to fix error M Tompsett spotted Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Instead of 10 warnings, I now have only 4 warnings. We're going in the right direction. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit b2ce6347e55c92c9974f64d272dedffda41e3b44) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 79 +++++++++++++++++++++++++++---------------------- 1 file changed, 43 insertions(+), 36 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Feb 2 09:50:53 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 02 Feb 2015 08:50:53 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-7-g46de4d2 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 46de4d267ade7cfc9a4302e522a040a6feb6cad1 (commit) via bc61da8b4aba76afe007af24f8754400b4ec0695 (commit) via 9977f217a5f6be5c181f544d1c1034770c46acf0 (commit) via 630fc320e30105f3ee2a0f3c69599dea9efd2698 (commit) from 10e13ddb74fb2a65892932fd0677dc94df3aec0f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 46de4d267ade7cfc9a4302e522a040a6feb6cad1 Author: Owen Leonard Date: Wed Jan 7 08:26:57 2015 -0500 Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly Date sorting of charges under Patron -> Fines -> Account is done based on formatted dates, so sorting is broken depending on your dateformat system preference. This patch implements the standard "title-string" date sorting method. To test, apply the patch and view the Account tab. Test sorting of charges under various settings of the dateformat system preference. Date sorting should work correctly in all cases. Signed-off-by: Katrin Fischer Works as described and fixes sorting problem. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 229cb65629c93d30191bc6c797d06021942239b2) Signed-off-by: Chris Cormack Conflicts: members/boraccount.pl commit bc61da8b4aba76afe007af24f8754400b4ec0695 Author: Justin Date: Wed Jan 14 23:16:29 2015 +0000 Bug - 11345 - Self registration captcha Test Plan - Open the opac site - Navigate to the self registration page (Home -> Register here) - Notice that there is no note stating that the verification box is case-sensitive - Apply patch - Refresh page - Notice that there is now an extra note stating that the verification box is case-sensitive. Followed test plan. Hint displays as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 580ed6360ddf0eac902fe807bc76abddec86529a) Signed-off-by: Chris Cormack commit 9977f217a5f6be5c181f544d1c1034770c46acf0 Author: Olli-Antti Kivilahti Date: Thu Jan 8 14:50:52 2015 +0200 Bug 13025 - Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 This error only appears when using the SIPServer, it doesn't manifest when using the SIP unit tests or when using the staff client. -------------------- ------------------ PREPARE THE TEST ------------------ -------------------- 0a. Find a borrower. 0b. Find an Item (cardnumber 'debar123') and check-out to the borrower 0c. Find a borrower and add a manual debarrment to it, indefinetely in effect. This is the default behaviour. 0d. Configure and start a SIP-server which you can access with telnet. See http://wiki.koha-community.org/wiki/Koha_SIP2_server_setup In this example, the Borrower defined as the Check-out/in machine has the following credentials: username: herkules password: palautathan branchcode: JOE_JOE but you are free to use your own, it doesn't affect this test plan. 0e. access your server with telnet ----------------------- --------------------- REPLICATE THE ISSUE --------------------- ----------------------- 1. Paste the following SIP-command to login: 9300CNherkules|COpalautathan|CPJOE_JOE| 2. Paste the following SIP-command to check-in the Item of the debarred Borrower: 09N20140721 07501620140721 075016AP|AO|ABdebar123|AC|BIN| 3. The connection should die and in the SIP Server's error log you can find the following error: Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 -------------------- ------------------ AFTER THIS PATCH ------------------ -------------------- Redo steps 1-2. 3. No error is given and the connection doesn't die. No unit tests included and never will, because setting up the test environment would be very tedious. It is entirely possible but the scaffolding required is beyond the scope of this patch. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Note: I did not test this patch with SIP, but I did not find any regression on checking or renewing an item. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 84064ae4e4b07d1fa07e9be01546e104e4e70a01) Signed-off-by: Chris Cormack commit 630fc320e30105f3ee2a0f3c69599dea9efd2698 Author: Abby Date: Thu Jan 15 20:28:54 2015 +0000 Bug 13587: Fix Authorised Values Toolbar To test: 1. Go to Home > Administration > Authorised Values 2. Notice no plus icons are appearing infront "New Authorised Value..." and "New Category" in the toolbar. 3. Apply the patch. 4. Check that the plus icons infront of "New Authorised Value..." and "New Category" in the toolbar are appearing as they should. Signed-off-by: Katrin Fischer Nice addition! I added spaces to match the formatting on the other pages a bit more closely. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 752d627266455d787ba5ce1d88ed0f98d1282b4a) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 4 ++-- .../intranet-tmpl/prog/en/modules/admin/authorised_values.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/members/boraccount.tt | 10 +++++++--- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 1 + members/boraccount.pl | 2 -- 5 files changed, 12 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Feb 2 19:43:45 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 02 Feb 2015 18:43:45 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-11-gf3b90f7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via f3b90f78f5010aaa9e705026e3db556a40fccaa1 (commit) via c619aa9f7fd3363975d6d2743fb024279aec85be (commit) via 754c44183f908647b8fa66b56aa4715709ee71e5 (commit) via d059d907e1d4bffa173c9b0a5d3a187d546df09d (commit) from 46de4d267ade7cfc9a4302e522a040a6feb6cad1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f3b90f78f5010aaa9e705026e3db556a40fccaa1 Author: Martin Renvoize Date: Tue Dec 30 13:54:50 2014 +0000 Bug 12954: Failed login should retain anonymous session A failed login should not leave the user in a half logged authenticated state, but rather return them to an anonymouse session as per the pre-login attempt state. To replicate error: 1. Try to log in with some nonexisting user id or wrong password in the OPAC 2. Go directly to /opac-user.pl (e.g., enter it in the browser address bar, or just click on the "Log in" link) 3. Observe a DBI error displayed on the screen 4. You are now in the "deadloop" of sorts (opac/opac-user.pl refuses to display the login screen, no matter how many times you try to reload it); to break the deadloop, one needs to: - remove session cookie from the browser (or cause the session to expire in some other way - closing browser window would be probably enough for that) - remove offending session on the server (from mysql sessions table, ..) - log in with proper credentials using some other page (like opac/opac-main.pl right-side panel), which does not involve opac/opac-user.pl being called without "userid" CGI parameter. To test: 1. Test as above, the DBI error should no longer be present 2. Check that search history works across failed and sucessful login attempts Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 229a3b329c9fbe1567a9cd0796dce7ddf1aca781) Signed-off-by: Chris Cormack commit c619aa9f7fd3363975d6d2743fb024279aec85be Author: Martin Renvoize Date: Tue Jan 6 06:54:00 2015 +0000 Bug 13521: Add missing semicolon Add a missing semicolon to the end of a template variable assignment line. This patch should not affect operation. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit f73dc51a88e63a7ef7cf30d3d88c09b30bb2c177) Signed-off-by: Chris Cormack commit 754c44183f908647b8fa66b56aa4715709ee71e5 Author: Martin Renvoize Date: Tue Jan 6 06:48:29 2015 +0000 Bug 13521: Removed superflous semicolon Removed an uneeded semicolon from the end of an 'if' block. This should not affect operation of the script. Note: With Bug 13499 we did a non-destructive perltidy, as such we only affected indenting and whitespace to maintain blame history. However, a number of minor code issues were also highlighted, in this series of patches I hope to correct other minor style issues. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit a36c7435f23b7d69e8286370774fbb8554e7f98f) Signed-off-by: Chris Cormack commit d059d907e1d4bffa173c9b0a5d3a187d546df09d Author: Martin Renvoize Date: Mon Jan 5 22:45:44 2015 +0000 Bug 13499: Tidy of Auth.pm This tidy should only change whitespace and not line breaks, thus retaining history. There are no code changes, and thus there should be no regressions to test for koha wise. To test the non-destrcutive nature of the patch, run a 'git blame -w' on the file before and after the patch. The resulting blame should include a comparabile history of the file, with only some additional blank lines being attributed to this commit. A 'git blame -wM' may also be useful for comparison purposes. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 1926bf9d0180315f6e51431e3d514a8d53ce3b9c) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 1236 ++++++++++++++++++++++++++++++++---------------------------- 1 file changed, 652 insertions(+), 584 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 3 23:55:43 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 03 Feb 2015 22:55:43 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-2-g74b78a4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 74b78a40818e762375830f6a5c92fc8f9dbbc0bb (commit) from 170ad570428c44a93fc97048b59f963d469734f1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 74b78a40818e762375830f6a5c92fc8f9dbbc0bb Author: Mason James Date: Wed Nov 26 13:51:45 2014 +1300 fix for 13331 [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks to test... 1/ attempt to add a new bib in the cataloguing editor, default framewok - observe 245b subfield is visible in the editor, for tab 2 2/ uncheck the OPAC visibility for 245b, within the framework editor - then save 3/ repeat step 1/ - observe that the 245b subfield has disappeared from the cataloguing editor! 4/ apply patch, 5/ repeat step 1/ - observe that the 245b subfield now displays correctly in the cataloguing editor note: this looks looks like a typo bug, that has been in koha for years Signed-off-by: wajasu Signed-off-by: Kyle M Hall Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: cataloguing/addbiblio.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 4 08:29:06 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 04 Feb 2015 07:29:06 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-14-gf530908 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via f5309088063b1ef36732f76cedf31d41cd10514a (commit) via c0de72a92e354e5cde47ef1eb23b61f50d1a1c29 (commit) via 70eced916d53e328762ae9e8ba5628c2e5085148 (commit) from f3b90f78f5010aaa9e705026e3db556a40fccaa1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit f5309088063b1ef36732f76cedf31d41cd10514a Author: Rafal Kopaczka Date: Tue Jan 20 10:49:34 2015 +0100 Bug 13373 - [QA Followup] - Update Polish web installer sample data files Fixed "Duplicate entry CF-952-i" error in marc21_simple_bib_frameworks.sql Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 72ca839518488eb98bd4bac3d770e893c7cababc) Signed-off-by: Chris Cormack commit c0de72a92e354e5cde47ef1eb23b61f50d1a1c29 Author: Rafal Kopaczka Date: Tue Dec 2 15:24:01 2014 +0100 Bug 13373 [2/2] - Update Polish web installer sample data files. Part 2/2 - optional files. Changes: - Deleted unnecessary files - Translated description files and some values in sql files To test: - Aplly patch - Run webinstaller on empty database (drop database and create new if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit af148f92b492aeea01119a9e7db15ebffcbb4517) Signed-off-by: Chris Cormack commit 70eced916d53e328762ae9e8ba5628c2e5085148 Author: Rafal Kopaczka Date: Tue Dec 2 14:14:23 2014 +0100 Bug 13373 [1/2] - Update Polish web installer sample data files. Part 1/2 - mandatory files. Changes: - Translated user permission and user flags. - Changed untranslated different files from en version - Deleted unnecessary files To test: - Aplly patch - Run webinstaller on empty database (drop database if necessary) - Verify everything works, especially verify you have permission to all modules, eg. Tools, Catalouging etc. - Check spelling and grammar if you can :) Signed-off-by: Chris Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit de08845edc543c449698e01c5ea1eec509c8b271) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: .../pl-PL/mandatory/message_transport_types.sql | 1 + .../data/mysql/pl-PL/mandatory/sample_notices.sql | 9 +- .../mysql/pl-PL/mandatory/system_preferences.sql | 20 --- .../mysql/pl-PL/mandatory/system_preferences.txt | 1 - installer/data/mysql/pl-PL/mandatory/userflags.sql | 39 +++--- .../data/mysql/pl-PL/mandatory/userpermissions.sql | 137 ++++++++++---------- .../marc21/optional/marc21_fastadd_framework.sql | 2 +- installer/data/mysql/pl-PL/optional/auth_val.sql | 39 ++++-- installer/data/mysql/pl-PL/optional/parameters.sql | 9 +- .../mysql/pl-PL/optional/patron_categories.txt | 32 ++--- .../data/mysql/pl-PL/optional/sample_budgets.sql | 11 -- .../data/mysql/pl-PL/optional/sample_budgets.txt | 1 - .../data/mysql/pl-PL/optional/sample_labels.sql | 21 --- .../data/mysql/pl-PL/optional/sample_labels.txt | 9 -- .../mysql/pl-PL/optional/sample_z3950_servers.sql | 19 ++- .../mysql/pl-PL/optional/sample_z3950_servers.txt | 7 +- 16 files changed, 161 insertions(+), 196 deletions(-) delete mode 100644 installer/data/mysql/pl-PL/mandatory/system_preferences.sql delete mode 100644 installer/data/mysql/pl-PL/mandatory/system_preferences.txt delete mode 100644 installer/data/mysql/pl-PL/optional/sample_budgets.sql delete mode 100644 installer/data/mysql/pl-PL/optional/sample_budgets.txt delete mode 100644 installer/data/mysql/pl-PL/optional/sample_labels.sql delete mode 100644 installer/data/mysql/pl-PL/optional/sample_labels.txt hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 4 19:47:45 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 04 Feb 2015 18:47:45 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-239-g02b7012 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 02b70129c94a0c77d4a3d6f81c88ac92c5a3561c (commit) via 6a7dbb3051bfa82f6ddcdfda907b4d95f1bf1d79 (commit) via 06f4950aa21ff889cff81f27b2f4e79788db193f (commit) via c9af47b86c653946916349ea021171b99f6bb44d (commit) from ac3f497f64c1854a275fe894c1070f5888c1c302 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 02b70129c94a0c77d4a3d6f81c88ac92c5a3561c Author: Jonathan Druart Date: Wed Jan 21 09:56:42 2015 +0100 Bug 13320: Fix "Tax inc." vs "Tax exc." The parcel page always displayes "Tax exc." even when values don't include taxes. Test plan: On the parcel page, verify that the string "Tax *" is correct. This appears in the already received order table. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 6a7dbb3051bfa82f6ddcdfda907b4d95f1bf1d79 Author: Jonathan Druart Date: Wed Jan 21 09:51:18 2015 +0100 Bug 13320: Move price calculation from tt to pl In parcel.tt, total are calculated for subtotal. This could be done in the pl script for more consistency. Test plan: Go on a parcel page with several already received orders. Orders must be linked to different funds. If possible ecost and unitprice (price on ordering and on receiving) should changed (different values will be displayed in the table). The values displayed before and after the patch must be the same. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 06f4950aa21ff889cff81f27b2f4e79788db193f Author: Kyle M Hall Date: Tue Jan 20 07:18:11 2015 -0500 Bug 13599 - Add patron cardnumber to self registration confirmation Some libraries wish to display the patron's cardnumber on the confirmation screen for patron self registration, rather than make the patron locate it his or her cardnumber by logging in and browsing to the personal details page. We should also add ids to these fields for easy css styling/hiding. Test Plan: 1) Apply this patch 2) Ensure that autoMemberNum is enabled 3) Self-register a new patron 4) Note confirmation screen now displays the patron cardnumber Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit c9af47b86c653946916349ea021171b99f6bb44d Author: Jonathan Druart Date: Fri Jan 9 16:01:35 2015 +0100 Bug 13544: Make it explicit that getauthtypes returns a hash ref Prior to perl 5.12 keys can only operate on a hash. Test plan: With perl 5.10, access to admin/auth_subfields_structure.pl. Without this patch, you get: Type of arg 1 to keys must be hash (not subroutine entry) at /home/koha/src/admin/auth_subfields_structure.pl line 102, near "getauthtypes)" Signed-off-by: Katrin Fischer Confirmed problem and tested patch on a sandbox, signed off locally. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: acqui/parcel.pl | 13 +++++--- admin/auth_subfields_structure.pl | 2 +- .../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 31 +++++--------------- .../en/modules/opac-registration-confirmation.tt | 19 ++++++++++-- 4 files changed, 34 insertions(+), 31 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 5 18:50:27 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Feb 2015 17:50:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-251-g522e9c58 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 522e9c5861854fad7c9b292f75ebd19968f5b11c (commit) via 74640683f0d7f4b9734a69763424b33977f66cfd (commit) via 01c7c2a12904fae5076914d839c5e829c54deb6f (commit) via bfb035511e8afd6716ea8d1b2de966f8950b74e6 (commit) via 6f57a2e09b7e9a87270eba1b04f75ae22fbbc999 (commit) via 42e9044f1195a512870d4e1dc01679a64d47f4d9 (commit) via f27d454048bca9d9ebdc1f781a688c2311952786 (commit) via 724f77ec43449144a2cccac048a57ffb19799fed (commit) via d85f757ce7bf446705a8d76bc0d2280705a2d88d (commit) via fee7bd7fdc822939b03a68db8cce61ab07db1893 (commit) via 03335ab401576355dfc5bcee1aa45714fd9fc411 (commit) via f4f1f5a3b3b750a2854d29962048c297c330f57b (commit) from 02b70129c94a0c77d4a3d6f81c88ac92c5a3561c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 522e9c5861854fad7c9b292f75ebd19968f5b11c Author: Jonathan Druart Date: Mon Nov 10 10:45:25 2014 +0100 Bug 12905: funds with children could not be deleted The interface should prevent to delete funds with children. Otherwise the relationship is broken and problems occur: 1/ You don't see the orphan fund in the fund list 2/ You cannot edit the orphan fund amount ('Fund amount exceeds parent allocation'). This patch: - adds a JS check, template side - adds a check in the perl script (should never be true) - adds an updatedatabase check, in order to alert users with inconsistent data. Test plan: Verify you are not allow to delete a fund with children. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 74640683f0d7f4b9734a69763424b33977f66cfd Author: Jonathan Druart Date: Tue Nov 25 12:23:45 2014 +0100 Bug 13333: Fix Display basket group for already received orders Bug 11111 adds a basket group column on the parcel page. But it seems that the already received orders never contain the value (always 'no basket group'). Test plan: Receive an order which is in a basket group and verify the basket group column is correctly filled. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 01c7c2a12904fae5076914d839c5e829c54deb6f Author: Mark Tompsett Date: Fri Dec 19 12:28:19 2014 -0500 Bug 13457 - Followup for CPL and S codes Based on comment #3, this corrects CPL and S issues if they do not exist in the DB. TEST PLAN --------- 0) Backup your DB. 1) Clear CPL and S from your DB. - delete from borrowers where categorycode='S'; - delete from categories where categorycode='S'; - delete from borrowers where branchcode='CPL'; - delete from branch where branchcode='CPL'; 2) prove t/db_dependent/Suggestions.t -- This should fail. 3) Apply patch 4) prove t/db_dependent/Suggestions.t -- This should work. 5) Intentionally add categorycode 'S' and branchcode 'CPL' back into the database. 6) prove t/db_dependent/Suggestions.t -- This should work. 7) run koha qa test tools. 8) Restore your DB :) Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit bfb035511e8afd6716ea8d1b2de966f8950b74e6 Author: Mark Tompsett Date: Fri Dec 12 17:03:17 2014 -0500 Bug 13457: Suggestions.t expects sample itemtypes TEST PLAN --------- 1) Make sure you have more than 8 item types, and preferably something with a non-sample default code for itemtypes. 2) prove t/db_dependent/Suggestions.t -- this will fail 3) Apply patch 4) prove t/db_dependent/Suggestions.t -- this will succeed 5) run koha qa test tools Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 6f57a2e09b7e9a87270eba1b04f75ae22fbbc999 Author: Thomas Date: Thu Jan 15 01:43:28 2015 +0000 Bug 10241 - Easy analyticals creates two 773 fields. Search/link from host to children is broken Hidden 'New child record' if 'EasyAnalytics' is set to display. Testing plan: -Turn on 'EasyAnalytics'. Check the drop down menu from the records page *The drop down menu should include 'Analyze items' and not include 'New child record' -Turn off 'EasyAnalytics'. Again check the drop down menu from the records page *The drop down menu should include 'New child record' and not inlucde 'Analyze items' Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 42e9044f1195a512870d4e1dc01679a64d47f4d9 Author: Jonathan Druart Date: Thu Dec 11 09:50:38 2014 +0100 Bug 13268: the size should not be emptied in pl script It duplicates what the first patch does. Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit f27d454048bca9d9ebdc1f781a688c2311952786 Author: Fridolin Somers Date: Mon Nov 17 16:32:20 2014 +0100 Bug 13268 - biblioitems.size value not correctly displayed (more) Bug partially corrected by Bug 11357. The size column in biblioitems is a bit problematic when used in TT, because instead of the size value from the biblio column it will give you the size of the variable or current loop. It's currently used in the templates like opac-topissues.tt : [% IF results_loo.size %][% results_loo.size %][% END %] This patch corrects by using item() TT method. See http://stackoverflow.com/questions/2311303/how-can-i-handle-hash-keys-containing-illegal-identifier-characters-in-template. Test plan : - Be sure there is a mapping between a MARC field and biblioitems.size - Create a record A with biblioitems.size defined : like "10x12" - Create a record B with no value in biblioitems.size - Check each modified page : => Without this patch : you see a number (loop size) for both records => With this patch : you only see the correct value for A and nothing for B Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 724f77ec43449144a2cccac048a57ffb19799fed Author: Owen Leonard Date: Thu Jan 22 14:25:29 2015 -0500 Bug 13339 - Cart button doesn't open the cart The link to open the cart no longer triggers the cart popup. Instead, in order to make it more usable with mobile devices, it triggers a menu which displays the count of items in the cart -- something which previously was done with a hover action (something touch-screen devices don't have). Clicking/tapping this menu item is what opens the cart window. Since the cart link is really now a menu trigger rather than just a link, it seems logical to add the small arrow which the lists link has indicating that the link triggers a menu. To test, apply the patch and view any page in a Cart-enabled OPAC. Confirm that the "caret" icon displays correctly when the cart is both empty and when it has contents. Followed test plan. Icon displays as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Works as described, good idea. Signed-off-by: Tomas Cohen Arazi commit d85f757ce7bf446705a8d76bc0d2280705a2d88d Author: Colin Campbell Date: Thu Oct 30 15:36:09 2014 +0000 Bug 7904 Change SIP modules to use standard LIB path For historical reasons the SIPServer and SIP modules have used an extra module path in addition to the standard Koha one. This has caused numerous irritants in attempting to set up scripts and basic tests. It does not help in attempting to modify or debug this code This patch changes the package value in the modules under the C4/SIP directory and makes calls to them use the full package name. Where the export mechanism was being short circuited routines have been explicitly exported and imported declarations of 'use ILS' when that module was not being used and which only generated warnings have been removed. As a lot of the changes affect lines where an object is instantiated with new. The opportunity has been taken to replace the ambiguous indirect syntax with the preferred direct call In intializing ILS the full path is added as this will not require any changes to existing configs. I suspect this feature is unused, and adds obfuscation rather than flexibility but have kept the feature as we need this change in order to rationalize and extend the testing of the server. The visible difference is that with the normal Koha PERL5LIB setting. Compilation of Modules under C4/SIP should be successful and not fail with unlocated modules, allowing developers to see any perl warnings All the SIP modules can now be run through the tests in t/00-load.t now except for SIPServer itself Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit fee7bd7fdc822939b03a68db8cce61ab07db1893 Author: Robin Sheat Date: Mon Nov 10 11:38:29 2014 +1300 Bug 7904 - remove unnecessary path from SIP script With the fixing of the namespace in the SIP code, we don't need to modify the PERL5LIB to have the old one. To test: * do a package install using this and the other patches on bug 7904 * enable SIP * make sure koha-start-sip and koha-stop-sip work Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 03335ab401576355dfc5bcee1aa45714fd9fc411 Author: Kyle M Hall Date: Wed Dec 10 12:27:59 2014 -0500 Bug 13432 - SIP Server does not respect timeout setting Koha's SIP server accepts timeout parameters, but those parameters are only used for the login portion of a telnet transport session. Other than that, they are ignored, and as long as whatever opened the connection keeps it open, it will stay open indefinitely. Test Plan: 1) Set the timeout setting on your SIP server to 10 seconds 2) Modify misc/sip_cli_emulator.pl, add "sleep 100;" directly after line 91 3) Start your SIP server 4) Run the modified sip script with valid parameters 5) Watch the SIP server stderr 6) Note that even though the script waits far too long before continuing, the SIP server never kills the connection, and the requests the cli script makes come back with valid data. 7) Apply this patch 8) Restart your SIP server 9) Repeat step 4 10) Note that this time you see "SIP Timed Out!" in the SIP server stderr and when the script finally makes it's request, it doesn't come back with valid data. Signed-off-by: Colin Campbell Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit f4f1f5a3b3b750a2854d29962048c297c330f57b Author: Jonathan Druart Date: Mon Sep 22 16:09:14 2014 +0200 Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/basketgroup.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Close the basket and create the corresponding basket groups. 4/ Print the basket group 5/ Verify you don't see any difference before and after applying the patch on the pdf file. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 14 ++-- C4/SIP/ILS.pm | 72 +++++++++--------- C4/SIP/ILS/Item.pm | 6 +- C4/SIP/ILS/Patron.pm | 2 +- C4/SIP/ILS/Transaction.pm | 2 +- C4/SIP/ILS/Transaction/Checkin.pm | 7 +- C4/SIP/ILS/Transaction/Checkout.pm | 7 +- C4/SIP/ILS/Transaction/FeePayment.pm | 5 +- C4/SIP/ILS/Transaction/Hold.pm | 7 +- C4/SIP/ILS/Transaction/Renew.pm | 6 +- C4/SIP/ILS/Transaction/RenewAll.pm | 8 +- C4/SIP/SIPServer.pm | 29 +++++--- C4/SIP/Sip.pm | 6 +- C4/SIP/Sip/Checksum.pm | 2 +- C4/SIP/Sip/Configuration.pm | 14 ++-- C4/SIP/Sip/Configuration/Account.pm | 2 +- C4/SIP/Sip/Configuration/Institution.pm | 2 +- C4/SIP/Sip/Configuration/Service.pm | 2 +- C4/SIP/Sip/Constants.pm | 2 +- C4/SIP/Sip/MsgType.pm | 78 ++++++++++---------- C4/SIP/example_institution_dump.sh | 8 +- C4/SIP/interactive_item_dump.pl | 4 +- C4/SIP/interactive_patron_check_password.pl | 6 +- C4/SIP/interactive_patron_dump.pl | 4 +- C4/SIP/interactive_renew_all_dump.pl | 4 +- C4/SIP/t/000_sc_config_auth.t | 4 +- C4/SIP/t/00sc_status.t | 2 + C4/SIP/t/01patron_status.t | 6 +- C4/SIP/t/02patron_info.t | 4 +- C4/SIP/t/03checkout.t | 4 +- C4/SIP/t/04patron_status.t | 4 +- C4/SIP/t/05block_patron.t | 6 +- C4/SIP/t/06patron_enable.t | 4 +- C4/SIP/t/07hold.t | 4 +- C4/SIP/t/08checkin.t | 4 +- C4/SIP/t/09renew.t | 4 +- C4/SIP/t/10renew_all.t | 4 +- C4/SIP/t/11item_info.t | 4 +- C4/SIP/t/SIPtest.pm | 6 +- C4/SIP/xmlparse.pl | 2 +- acqui/basketgroup.pl | 37 ++-------- admin/aqbudgets.pl | 6 ++ cataloguing/addbooks.pl | 3 - debian/scripts/koha-start-sip | 2 +- installer/data/mysql/updatedatabase.pl | 22 ++++++ .../intranet-tmpl/prog/en/includes/cat-toolbar.inc | 2 +- .../prog/en/modules/admin/aqbudgets.tt | 11 ++- .../prog/en/modules/cataloguing/addbooks.tt | 2 +- .../prog/en/modules/circ/view_holdsqueue.tt | 2 +- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- .../bootstrap/en/modules/opac-topissues.tt | 2 +- t/00-load.t | 3 +- t/SIP_Sip.t | 18 ++--- t/db_dependent/Acquisition/Invoices.t | 9 ++- t/db_dependent/Suggestions.t | 34 +++++++++ 56 files changed, 297 insertions(+), 221 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 5 19:21:50 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Feb 2015 18:21:50 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-260-g42c3429 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 42c342972ab9aed7f3674be4fc226a4806cb5ffc (commit) via d3c128af9d4e3890cf6cf84fc4bf2c1fc4f9d24c (commit) via 41181b27087b1b547e8a487afc3207e9677fab6d (commit) via 10280c091ce8d7cd6fca3d648b145713bb837157 (commit) via 135f98ee620cff5eb76d7fff64c767b0cb49cef1 (commit) via 6fd9c909014b488bb383e0488a539512fae39bc2 (commit) via e2968fe0812898d92ce8c63e9c7f0dedd244acc9 (commit) via 1c62f1a9783bb8a171352e0b66d910056ccfe0d4 (commit) via a7c41e6073a2719e21f86909a37daab6410b2b96 (commit) from 522e9c5861854fad7c9b292f75ebd19968f5b11c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 42c342972ab9aed7f3674be4fc226a4806cb5ffc Author: Tomas Cohen Arazi Date: Thu Feb 5 15:25:50 2015 -0300 Bug 13262: (QA followup) fix duplicate variable definition Running $ prove t/db_dependent/XSLT_Handler.t raises a couple warnings because of variable redefinitions. This small patch fixes that. Signed-off-by: Tomas Cohen Arazi commit d3c128af9d4e3890cf6cf84fc4bf2c1fc4f9d24c Author: David Cook Date: Mon Nov 17 13:59:49 2014 +1100 Bug 13262 - Add parameters to XSLT Handler transform method This patch adds an optional hashref argument to the XSLT_Handler transform() method. It allows you to send key => value pairs parameters to the XML::LibXSLT object, which you can reference in a XSLT via . The parameter value is evaluated as an XPath query, so you can only pass quoted strings (i.e. "'test'") or numbers. Otherwise, the XSLT engine will interpret it as a Xpath query and will run it on the XML that you're transforming. The most common use case is sending strings to a XSLT. In my case, this is an OAI-PMH identifier that comes in a OAI response but not the actual metadata. See the following link from the official POD: http://search.cpan.org/~shlomif/XML-LibXSLT-1.92/LibXSLT.pm#Parameters _TEST PLAN_ 1) Run "perl t/db_dependent/XSLT_Handler.t". If all tests pass, you should be free to sign off. Feel free to inspect the last test in XSLT_Handler.t and the XSL in test04.xsl to see how it works. If you really want to be thorough, you could write your own test cases using mine as an example. Alternatively, you could go into C4::XSLT, and try to pass a value to a parameter in the search results or the detail page, but that might be a bit over the top. It's a pretty simple patch. Signed-off-by: Tomas Cohen Arazi commit 41181b27087b1b547e8a487afc3207e9677fab6d Author: Tomas Cohen Arazi Date: Thu Feb 5 15:21:51 2015 -0300 Bug 12601: (RM followup) DBIx updates Signed-off-by: Tomas Cohen Arazi commit 10280c091ce8d7cd6fca3d648b145713bb837157 Author: Tomas Cohen Arazi Date: Thu Feb 5 15:17:47 2015 -0300 Bug 12601: DBRev 3.19.00.008 Signed-off-by: Tomas Cohen Arazi commit 135f98ee620cff5eb76d7fff64c767b0cb49cef1 Author: Jonathan Druart Date: Fri Jul 18 12:34:07 2014 +0200 Bug 12601: Add a foreign key for aqorders.budget_id When creating an order, the fund value is mandatory but the DB structure does not show this constraint. The aqorders.budget_id field should be linked to aqbudgets.budget_id. The updatedatabase.pl (entry 3.01.00.077) commented this constraint, certainly for a retro compatibility reason. Actually I found some cases (in production) where aqorders.budget_id is set to "0". To add this constraint, we should add a temporary fund to linked orphan orders. Test plan: 0/ Verify it is not possible to create an order not linked to a fund via the Koha interface. 1/ Using your SQL CLI (or equivalent), create or update 1+ orders and set "0" in the budget_id field. 2/ Execute the updatedabase script. 3/ Verify that your order is linked to a new fund (which is linked to a new budget). 4/ Verify the constraint has correctly been added (show create table aqorders). Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 6fd9c909014b488bb383e0488a539512fae39bc2 Author: Tomas Cohen Arazi Date: Thu Feb 5 15:15:22 2015 -0300 Bug 12905: DBRev 3.19.00.007 Signed-off-by: Tomas Cohen Arazi commit e2968fe0812898d92ce8c63e9c7f0dedd244acc9 Author: Jonathan Druart Date: Thu Jan 29 16:18:19 2015 +0100 Bug 12860: the export tools explodes if a field is not exported To reproduce: 1/ Go on tools/export.pl 2/ Export some records and specify you don't want the fields 245 (the whole field, do not specify a subfield). 3/ Export, BOOM Software error: Arguments must be MARC::Field object at /home/koha/src/tools/export.pl line 400. Test plan: Apply the patch and confirm the fields 245 are not exported and the export works as expected. Signed-off-by: Robin Sheat Export fails to asplode with this patch Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 1c62f1a9783bb8a171352e0b66d910056ccfe0d4 Author: Jonathan Druart Date: Mon Nov 17 17:17:49 2014 +0100 Bug 13270: Don't display "vendor note" label if nothing to display Bug 12111 removes the vendor note edition on receiving. The label should not be displayed when it's empty. Test plan: 1/ Receive an order without a vendor note and verify that the label is not displayed. 2/ Receive an order with a vendor note and verify that the note is displayed. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, small template change. Signed-off-by: Tomas Cohen Arazi commit a7c41e6073a2719e21f86909a37daab6410b2b96 Author: Kyle M Hall Date: Thu Jan 1 16:38:34 2015 -0500 Bug 13441 - Branchcodes should not be allowed to have spaces in them In multiple cases I've seen issues arise in Koha where a librarian accidentally puts a space at the end of a new branchcode. This of course causes endless confusion because the branchcode looks perfectly fine in every case unless you wrap the code with some characters to reveal the hidden space! Test Plan: 1) Try creating a new branch with one or more spaces in the branchcode 2) Note you are able to 3) Apply this patch 4) Repeat step 1 5) Note you are no longer able to Followed test plan with cache cleared. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: Koha/Schema/Result/Aqbudget.pm | 19 ++++++++- Koha/Schema/Result/Aqorder.pm | 22 ++++++++-- Koha/Schema/Result/AuthorisedValue.pm | 19 ++++++++- Koha/Schema/Result/ItemsSearchField.pm | 8 ++-- Koha/XSLT_Handler.pm | 16 ++++++-- installer/data/mysql/kohastructure.sql | 1 + installer/data/mysql/updatedatabase.pl | 43 +++++++++++++++++++- .../prog/en/modules/acqui/orderreceive.tt | 4 +- .../prog/en/modules/admin/aqbudgets.tt | 1 + .../prog/en/modules/admin/branches.tt | 20 +++++++-- kohaversion.pl | 2 +- t/db_dependent/XSLT_Handler.t | 25 +++++++++++- .../XSLT_Handler/{test03.xsl => test04.xsl} | 7 ++-- tools/export.pl | 2 +- 14 files changed, 163 insertions(+), 26 deletions(-) copy t/db_dependent/XSLT_Handler/{test03.xsl => test04.xsl} (77%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 5 19:45:46 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 05 Feb 2015 18:45:46 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-261-ge5b834a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via e5b834a1c474f761c9f9c8c01dd6abeb99ee5eac (commit) from 42c342972ab9aed7f3674be4fc226a4806cb5ffc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e5b834a1c474f761c9f9c8c01dd6abeb99ee5eac Author: Tomas Cohen Arazi Date: Thu Feb 5 15:50:30 2015 -0300 Bug 7904: (QA followup) fix tests The package name for SIP wasn't fixed in the tests by the original patches. This patch fixes it. To test: - Run $ prove t/db_dependent/SIP_ILS.t - Tests should pass with the patch. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: t/db_dependent/SIP_ILS.t | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Feb 9 17:39:01 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Feb 2015 16:39:01 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-277-g011d8e9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 011d8e9855ffeb1779f5c1aadc9f4367c298cee7 (commit) via 09edfe8d53f91d150c39be9ec41bc24c82ce93dd (commit) via 983f49d7b28e3bf65c799f7ff00d64bdb10429d0 (commit) via 6a68ac3e5ded2e56d9b9de8f6e1a6a9ed49ac327 (commit) via b6aae39c263eee482aaeb574c206fa0c2c69f120 (commit) via bc355fef2455b7b22c29a061db72d07046169738 (commit) via 945a0f09e73606907d6df72b873e478cc6763c14 (commit) via 381de54ed1f56f61f22a682147b67d3902f43604 (commit) via f70ad43f8fd49ad7fb43697c6953767e534f7368 (commit) via 58f7f56b8664810335f60f3fe5e43faa079f33bc (commit) via 28af6c4d01e0b1a31dece34031b6379fb9befebc (commit) via 12eb3cb440b254c06d9fdb6026bca52d058dfb59 (commit) via 926e97b9e94fede770c55e01c042b157ce9c22af (commit) via 273ead3084e7d3d573d89b80739a4dacd4f07044 (commit) via fe66114e210885324eb37773e2bd09e7e2190f59 (commit) via e2bbdc0b145fba30bd60110ad2d4fd8262107947 (commit) from e5b834a1c474f761c9f9c8c01dd6abeb99ee5eac (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 011d8e9855ffeb1779f5c1aadc9f4367c298cee7 Author: Kyle M Hall Date: Tue Jul 8 10:30:00 2014 -0400 Bug 12543 - Add userid as matchpoint for "Import patrons" tool The a patron's userid should be a matchpoint in the same manner as cardnumber. Though not enforced as a unique key by the database yet ( pending bug 1861 ), this field is effectively unique as uniqueness is enforced by Koha itself. Test Plan: 1) Apply this patch 2) Browse to tools/import_borrowers.pl 3) Download the starter CSV file 4) Edit the csv file to include 1 or more patrons * Make sure to leave the borrowernumber field empty * Make sure the userid field matches the patrons you wish to overwrite 5) From import_borrowers.pl, upload your file * Set "Field to use for record matching" to "Username" * Set "If matching record is already in the borrowers table" to "Overwrite the existing one with this" 6) Click "Import" 7) Verify the patrons in your file have been updated in Koha Signed-off-by: Frederic Demians Do exactly what's announced. This may help. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 09edfe8d53f91d150c39be9ec41bc24c82ce93dd Author: Marcel de Rooy Date: Mon Feb 9 09:26:04 2015 +0100 Bug 13404: [QA Follow-up] Minor rewording of some warnings Changes are confirmed with author (Mirko Tietgen). See Bugzilla. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit 983f49d7b28e3bf65c799f7ff00d64bdb10429d0 Author: Kyle M Hall Date: Thu Jan 1 21:06:58 2015 -0500 Bug 13404 [QA Followup] Signed-off-by: Tomas Cohen Arazi commit 6a68ac3e5ded2e56d9b9de8f6e1a6a9ed49ac327 Author: Mirko Tietgen Date: Sun Dec 7 18:39:51 2014 +0100 Bug 13404 - More System information about GRS1 vs DOM settings System information indicates missing and entries in koha-conf.xml. This patch - adds warnings about a possible mismatch between these settings and the actual setup - adds info about the actual setup/what values to use for and if they are not set. The assumption is that a path including 'zebra-*-dom.cfg' in the respective section indicates a DOM setup. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit b6aae39c263eee482aaeb574c206fa0c2c69f120 Author: Fridolin Somers Date: Fri Dec 5 15:50:05 2014 +0100 Bug 13401 - sort branches alphabetically in admin/authorised_values.pl This patch adds a sort of branches alphabetically by name in authorised values administration, like in many other pages. Also replaces var $branch (too ambigus) by $branchcode. Test plan : - Create 2 branches : code=AAA,name=Zbranch and code=ZZZ,name=Abranch - Create a new authorized value : admin/authorised_values.pl - Look at "Libraries limitation" : => Without patch branches are sorted by code : Zbranch then Abranch => Without patch branches are sorted by name : Abranch then Zbranch - Select a branch and save - Re-edit => Check the same branch is selected Followed test plan. Patch behaves as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit bc355fef2455b7b22c29a061db72d07046169738 Author: Katrin Fischer Date: Sun Feb 8 16:23:41 2015 +0100 Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)" Signed-off-by: Tomas Cohen Arazi commit 945a0f09e73606907d6df72b873e478cc6763c14 Author: Jonathan Druart Date: Mon Jan 26 10:28:27 2015 +0100 Bug 13352: On editing, prices should not be formatted Bug 12979 refactored the way to display prices. The price format configuration was duplicated everywhere it was used. All calls looks good except the one in admin/aqbudgetperiods.pl In this one, the prices are formatted for an edition field (input). This means the input is incorrectly filled even if the user does not update the field. At the end, maybe should we manage formatted prices everywhere, even in inputs, but it's not in the scope of this bug. Technically, a new subroutine format_for_editing is added to the Koha::Number::Price module. It should be called everywhere a price is displayed in an input field. At the moment, it only does a sprintf("%.2f"), but it is a first step to let the number of decimals to display configurable. To test: 1/ Verify the issue described is fixed (editing a budget with a total amount > 1000 (With CurrencyFormat is US or FR). 2/ Verify you can edit a fund with a total amount > 1000 Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 381de54ed1f56f61f22a682147b67d3902f43604 Author: Tomas Cohen Arazi Date: Mon Feb 9 13:32:50 2015 -0300 Bug 13602: (QA followup) take advantage of the defined-or operator Signed-off-by: Tomas Cohen Arazi commit f70ad43f8fd49ad7fb43697c6953767e534f7368 Author: Julian Maurice Date: Wed Jan 14 17:00:17 2015 +0100 Bug 13562: Fix item search on item MARC subfields Test plan: 1. Add 4 item search fields (in Administration ? Items search fields): a. 1 biblio field linked to a DB field b. 1 biblio field not linked to a DB field c. 1 item field linked to a DB field d. 1 item field not linked to a DB field 2. Make sure you have some data in those fields to search on. 3. Go to item search page and do a search using these new fields, make sure the result is correct. Signed-off-by: Nick Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 58f7f56b8664810335f60f3fe5e43faa079f33bc Author: Olli-Antti Kivilahti Date: Tue Jan 20 16:48:13 2015 +0200 Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences When editing a Patron's messaging preferences or borrower attributes, one cannot save changes because 'userid' is not given as a parameter. It shouldn't, but the Check_Userid($newdata{'userid'},$borrowernumber) -check must have it. REPLICATE THE ISSUE: 1. Find a Borrower. 2. Go to the details-tab. 3. Under "Patron messaging preferences" click edit to edit just the messaging preferences. 4. Just save, no need to make any modifications. 5. Observe the error "Username/password already exists" This happens to all/most of the sub-forms in the Borrower's Details-view. AFTER THIS PATCH: Check_Userid() get the $userid from the new parameters, or if not present, from the koha.borrowers-table. TEST FOR REGRESSION: 1. Edit a borrower normally. Notice no errors. 2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no errors. DISCLAIMER: You are free to steal/rip/modify/hack this patch to your soul's extent without my permission. As long as it makes to Koha I am happy. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 28af6c4d01e0b1a31dece34031b6379fb9befebc Author: Owen Leonard Date: Wed Jan 28 12:24:45 2015 -0500 Bug 13638 - Batch patron modification tool missing option to switch language The batch patron modification tool's template was created without the footer include at the bottom. Without the footer include the language toolbar will not be displayed. All page templates should include the global footer include: [% INCLUDE 'intranet-bottom.inc' %] To test: - Install at least a second language - Enable at least 2 languages (language system preference) - Go to tools > Batch patron modification - Verify that at the bottom of the page the language chooser is shown Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 12eb3cb440b254c06d9fdb6026bca52d058dfb59 Author: Jonathan Druart Date: Fri Dec 5 13:40:00 2014 +0100 Bug 13418: Clean C4::VirtualShelves::Page - Part 2 I don't understand at all the usefulness of $privshelflist and $privtotshelves in C4::VirtualShelves::Page They look useless. If you deep in the git history, you will find commit 25eb36f21fe952118327d2c84dfef5d38eee31a7 Bug #2531 Cannot delete private shelf I am not able to reproduce this issue after this patch Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 926e97b9e94fede770c55e01c042b157ce9c22af Author: Marcel de Rooy Date: Mon Jan 19 15:05:03 2015 +0100 Bug 13418: [QA Follow-up] Use unshift instead of push Some SQL parameters are added to the wrong side of the list. This effectively clears all private lists from view :) Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 273ead3084e7d3d573d89b80739a4dacd4f07044 Author: Jonathan Druart Date: Mon Dec 8 16:31:06 2014 +0100 Bug 13418: Clean C4::VirtualShelves::Page a bit I tried to reuse this package for a new development, I did not manage. It's a really hard to read and to understand. Here my first try, this patch only remove the call to _shelf_count in the GetShelves subroutine. Someone might want to get this value for another reason and from somewhere else. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit fe66114e210885324eb37773e2bd09e7e2190f59 Author: Kyle M Hall Date: Fri Jan 30 07:10:29 2015 -0500 Bug 13450 [QA Followup] - Remove tab character from start of line Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit e2bbdc0b145fba30bd60110ad2d4fd8262107947 Author: Marc V?ron Date: Tue Dec 30 00:04:53 2014 +0100 Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) (Missing added) Signed-off-by: Aleisha Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 32 +++++++++++-- C4/VirtualShelves.pm | 19 +++----- C4/VirtualShelves/Page.pm | 38 ++++++---------- Koha/Number/Price.pm | 15 ++++++ Koha/Template/Plugin/Price.pm | 9 +++- about.pl | 46 +++++++++++++++++++ admin/aqbudgetperiods.pl | 6 --- admin/aqbudgets.pl | 1 - admin/authorised_values.pl | 8 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 30 ++++++++++++ .../prog/en/modules/admin/aqbudgetperiods.tt | 7 ++- .../prog/en/modules/admin/aqbudgets.tt | 4 +- .../prog/en/modules/members/memberentrygen.tt | 23 ++-------- .../prog/en/modules/tools/import_borrowers.tt | 1 + .../prog/en/modules/tools/modborrowers.tt | 5 +- members/memberentry.pl | 7 ++- t/Prices.t | 9 +++- t/db_dependent/Items.t | 48 +++++++++++++++++++- tools/import_borrowers.pl | 5 ++ 19 files changed, 228 insertions(+), 85 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Feb 9 19:49:29 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Feb 2015 18:49:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-292-g314523f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 314523f9493e544ae79e64789a801c84418674fa (commit) via 761527b0267beedcd35dddde4388a855d35adbc3 (commit) via f7220ba07250ba4caa9a19e492f779240d04ffc2 (commit) via 311afaaf91bb55443a76729c64833cd8343f5692 (commit) via d8710b4febac5de51160351c9a60a205bb8e29c4 (commit) via 4d0162057958bacd825cfad160fa0d44ed217f10 (commit) via e30a020275ec06e4af6676f0700520a0e9074286 (commit) via fed02a5fc81f53beda13a12ae8ec4933659fdbfc (commit) via ff7c87d345fa621890f2d143a21efbec7bcbdbfb (commit) via c8053f3c8d215c5edcfd0946c640d0b8d0bba504 (commit) via 3cf719433597ad6bf558950270cd564a62164ab4 (commit) via f31e39246a6a77e8e10ed89c066b1c42481541e4 (commit) via d8e5f0cd9d5926fb3b72e47852eac6b6c4f59be9 (commit) via ddf909ae24df5a3185370f5c4916135bb94b67ae (commit) via f383fe0ffec1b78b30d0951f0b74c59eed10eda7 (commit) from 011d8e9855ffeb1779f5c1aadc9f4367c298cee7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 314523f9493e544ae79e64789a801c84418674fa Author: Tomas Cohen Arazi Date: Mon Feb 9 15:52:24 2015 -0300 Bug 13007: DBIC updates Signed-off-by: Tomas Cohen Arazi commit 761527b0267beedcd35dddde4388a855d35adbc3 Author: Tomas Cohen Arazi Date: Mon Feb 9 15:50:41 2015 -0300 Bug 13007: DBRev 3.19.00.009 Signed-off-by: Tomas Cohen Arazi commit f7220ba07250ba4caa9a19e492f779240d04ffc2 Author: Jonathan Druart Date: Tue Nov 18 10:20:56 2014 +0100 Bug 13007: Special case budgetid == '' In this special case (the suggestion is linked to "all funds"), the budgetid value should be NULL in DB. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Works as described, passes old and new tests. Signed-off-by: Tomas Cohen Arazi commit 311afaaf91bb55443a76729c64833cd8343f5692 Author: Jonathan Druart Date: Mon Sep 29 16:16:23 2014 +0200 Bug 13007: Add a foreign key for suggestions.budgetid The DB field suggestions.budgetid should be linked to aqbudgets.budget_id. If the fund is removed, this column should be set to NULL. Test plan: 1/ Using your SQL CLI (or equivalent), create or update 1+ suggestions and set "0" in the budgetid field (or a nonexistent budget id). 2/ Execute the updatedabase script. 3/ Verify that your suggestion is unlinked to the nonexistent fund. 4/ Verify the constraint has correctly been added (show create table suggestions). 5/ Check that this change does not affect the behavior on adding a suggestion (linked to a fund or not). Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit d8710b4febac5de51160351c9a60a205bb8e29c4 Author: Tomas Cohen Arazi Date: Fri Feb 6 10:58:15 2015 -0300 Bug 12944: (QA followup) fix POD errors from koha-qa.pl Signed-off-by: Tomas Cohen Arazi commit 4d0162057958bacd825cfad160fa0d44ed217f10 Author: Jonathan Druart Date: Mon Dec 29 11:12:13 2014 +0100 Bug 12944: Fix regression on translating This patch fixes the translation for the "Remove" button. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Tested: - acq history search with different searches - patron lists patron search Passes all tests and QA script. Signed-off-by: Tomas Cohen Arazi commit e30a020275ec06e4af6676f0700520a0e9074286 Author: Jonathan Druart Date: Tue Nov 4 14:59:43 2014 +0100 Bug 12944: The autocomplete should only be applied for the form If it's the result view, the autocomplete should not be apply to the input element (it does not exist). Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit fed02a5fc81f53beda13a12ae8ec4933659fdbfc Author: Owen Leonard Date: Wed Oct 29 10:53:07 2014 -0400 Bug 12944 [Patron lists follow-up] There is no way to search orders by creator This bug modifies not just the order search form but also the patron lists feature, making use of the new script for building a patron autocomplete form. However, the test plan does not specify that the patron lists form be tested as well, and it doesn't work. This patch corrects a minor flaw which broke the patron search autocomplete when adding patrons to a patron list. To test, create a new patron list if necessary. Click the "add patrons" button to add patrons to the list. In the patron search form type a partial patron name. You should get an autocomplete dropdown of existing patrons. Selecting one should work correctly. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit ff7c87d345fa621890f2d143a21efbec7bcbdbfb Author: Jonathan Druart Date: Wed Sep 17 17:13:00 2014 +0200 Bug 12944: Search orders by basket creator This patch adds the ability to search orders using the basket creator. Test plan: - go on the order advanced search form (acqui/histsearch.pl) - use the autocomplete input to search patrons - launch the search and verify the results are consistent with the values you have filled. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit c8053f3c8d215c5edcfd0946c640d0b8d0bba504 Author: Jonathan Druart Date: Wed Sep 17 17:12:42 2014 +0200 Bug 12944: Refactor the patron autocomplete The patron list feature uses an autocomplete field to search patron. This will be reused in the next patch. This patch should not introduce any behavior change. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Bug 12944 [QA Followup] - Rename patrons.pl to patrons.js Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 3cf719433597ad6bf558950270cd564a62164ab4 Author: Mark Tompsett Date: Wed Nov 19 13:28:12 2014 -0500 Bug 11954 - Clean up currency default files It makes no sense to have TRUNCATE or foreign key checks. TEST PLAN --------- 1) Back up your database 2) in an mysql client: use kohadata; SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql SET FOREIGN_KEY_CHECKS=1; QUIT -- These should all work without problem. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit f31e39246a6a77e8e10ed89c066b1c42481541e4 Author: Kyle M Hall Date: Wed Nov 19 08:28:32 2014 -0500 Bug 13299 - Add home library column to the holds ratios report It seems odd that only the holding libraries are listed on the holds ratios report, we should add the home libraries as well. Test Plan: 1) Apply this patch 2) Run the hold ratios report 3) Note the new home libraries column Signed-off-by: Heather Braum Signed-off-by: Jonathan Druart commit d8e5f0cd9d5926fb3b72e47852eac6b6c4f59be9 Author: Kyle M Hall Date: Wed Nov 19 08:16:17 2014 -0500 Bug 13298 - Holds ratios report ignores ordered items The holds ratio report ignores ordered items. This could cause a library to inadvertently order more copies of a title than they actually need. An option should be added to count ordered items ( i.e. any negative notforloan value ). Test Plan: 1) Apply this patch 2) Create a record with two items, one regular, one ordered. 3) Place 3 holds on the item 4) Run the reserve ratios report, by default you should see this record 5) Check the new 'include ordered' checkbox, rerun the report 6) Note that record is no longer displayed Signed-off-by: Heather Braum Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit ddf909ae24df5a3185370f5c4916135bb94b67ae Author: Jonathan Druart Date: Wed Nov 5 12:41:13 2014 +0100 Bug 13201: GetSuggestion takes suggestionid Having $ordernumber as the parameter in a function which is handling suggestions and it is used as a suggestion id is confusing to the coder and person trying to read the code. This patch corrects the confusion. REVISED TEST PLAN ----------------- 1) perldoc C4::Suggestions -- notice it says ordernumber for the GetSuggestions example. 2) Ensure you have CPL in your branches table. 3) prove -v t/db_dependent/Suggestions.t -- if you have more than 8 itemtypes in your database, two tests at the end will fail, but that is not relevant to the modified GetSuggestions code. 4) apply patch 5) perldoc C4::Suggestions -- notice it is corrected now. 6) prove -v t/db_dependent/Suggestions.t -- it should run with the same results as in step 3. That is, if you have 8 itemtypes, all pass, otherwise those two tests fail. 7) run koha qa test tool Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit f383fe0ffec1b78b30d0951f0b74c59eed10eda7 Author: Katrin Fischer Date: Thu Aug 28 15:17:10 2014 +0200 Bug 12842: Add DDC classification numbers to MARC21 XSLT detail page Patch will add DDC classifications, divided with | below the subjects in the OPAC and staff detail pages. To test: - catalogue a record with one or mulitple 082$a subfields - verify the classifications are displayed in OPAC and staff detail page - Add following CSS to OpacUserCSS or IntranetUserCSS: .results_summary.ddc { display:none; } - Verify the DDC classifications are now no longer displayed Signed-off-by: Frederic Demians Test plan ok. Repetions of $a subfield are separated by a space, which seems correct. I'm not sure whether other subfield than $a should be displayed on intranet. Whatever, this could be added later. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 26 +++++---- C4/Suggestions.pm | 10 ++-- Koha/Schema/Result/Aqbudget.pm | 19 ++++++- Koha/Schema/Result/Suggestion.pm | 29 ++++++++-- acqui/histsearch.pl | 2 + circ/reserveratios.pl | 56 +++++++++++--------- .../data/mysql/it-IT/necessari/parameters.sql | 4 -- installer/data/mysql/kohastructure.sql | 3 +- .../data/mysql/ru-RU/optional/sample_currency.sql | 2 - .../data/mysql/uk-UA/optional/sample_currency.sql | 2 - installer/data/mysql/updatedatabase.pl | 20 +++++++ koha-tmpl/intranet-tmpl/js/autocomplete/patrons.js | 48 +++++++++++++++++ .../prog/en/modules/acqui/histsearch.tt | 23 +++++++- .../prog/en/modules/circ/reserveratios.tt | 43 +++++++++------ .../prog/en/modules/patron_lists/list.tt | 42 +++------------ .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 16 ++++++ .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 17 ++++++ kohaversion.pl | 2 +- t/db_dependent/Suggestions.t | 15 ++++-- 19 files changed, 266 insertions(+), 113 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/js/autocomplete/patrons.js hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Feb 9 21:11:00 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Feb 2015 20:11:00 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-303-g8f690a1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8f690a135edf531ee3576bc1fb4fa81b0d954477 (commit) via cf8cc47f6d0e6c20a1d14959f2811e3d74b35e1e (commit) via bd769213eb3c361cc56128b24824ee502721c4a1 (commit) via 78d6d794fe79e1fb61f4e695f3d25d6c0a4a20bf (commit) via 78994d2ddaff12d7e196b4fb213311d6da8620d1 (commit) via fe285618972dde88e2aada5dd41d03d17aaedab5 (commit) via 57d411dcd6a60fa36033a92e6cd1901b0ec7c78d (commit) via d556f6a9f2ead235b9daf9df7217ebf2cd2b2b5c (commit) via 129fb1fbe211b136ccad4d214ee26b94e988e5e5 (commit) via 2d4d65d526e6f54a40ddec87a6d3207722234fd3 (commit) via e3bb1390807578e2b9898723e2816a58f2c01e57 (commit) from 314523f9493e544ae79e64789a801c84418674fa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8f690a135edf531ee3576bc1fb4fa81b0d954477 Author: Tomas Cohen Arazi Date: Mon Feb 9 16:59:21 2015 -0300 Bug 5511: DBRev 3.19.00.010 Signed-off-by: Tomas Cohen Arazi commit cf8cc47f6d0e6c20a1d14959f2811e3d74b35e1e Author: Jonathan Druart Date: Fri Aug 29 17:26:43 2014 +0200 Bug 10900: 2 occurrences more Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit bd769213eb3c361cc56128b24824ee502721c4a1 Author: Mark Tompsett Date: Mon May 12 17:57:51 2014 -0400 Bug 10900 - Follow up, since more has been added to master Booksellers.t and Koha_template_plugin_Branches.t both had function calls to ::set_userenv added to them. This patch handles those additions. TEST PLAN --------- 1) Branch a new git branch 2) prove -v t/db_dependent/Bookseller.t -- It should work. 3) prove -v t/db_dependent/Koha_template_plugin_Branches.t -- It should work. 4) Apply only the first patch. 5) Repeat steps 2 and 3. -- They should both FAIL! 6) Apply the second patch as well. 7) Repeat steps 2 and 3. -- The should both work. Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 78d6d794fe79e1fb61f4e695f3d25d6c0a4a20bf Author: Mark Tompsett Date: Fri Sep 20 21:36:46 2013 -0400 Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep "::set_userenv" `find .` grep "\->set_userenv" `find .` The first grep demonstrated that the smaller change is from :: to -> as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use ->) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. Rebase required because of shibboleth change in C4/Context.pm Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit 78994d2ddaff12d7e196b4fb213311d6da8620d1 Author: Brandon Date: Thu Jan 15 22:42:52 2015 +0000 Bug 10177 - Whitespace is accepted within the password but leading and trailing spaces are not. Test plan: 1: Go to your patron 2: Go to change username and/or password. 3: Change password to something with spaces in the middle. Notice it is invalid. 4: Apply this patch. 5: Change password again using spaces in the middle. Notice it is accepted. 6: Change password with leading and/or trailing spaces, notice they are not accepted. Applied bothe patches. Followed test plan. Patch behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit fe285618972dde88e2aada5dd41d03d17aaedab5 Author: Brandon Date: Wed Jan 14 22:30:01 2015 +0000 Bug 10177 - whitespace is a valid password causing pernicious perturbations. Test plan: Go to your patron, go to change username and/or password. change password to whitespace, notice it is accepted, apply this patch, change password again, to whitespace, notice password is not valid. Followed test plan. Patch behaves as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 57d411dcd6a60fa36033a92e6cd1901b0ec7c78d Author: Katrin Fischer Date: Tue Dec 30 09:14:15 2014 +0000 Bug - 5511 [Followup]: QA Fixes - Move database update entry to correct spot - Fix version number in database update - Fix capitalization in sys pref description - Fix sequence in sysprefs.sql Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi commit d556f6a9f2ead235b9daf9df7217ebf2cd2b2b5c Author: Martin Renvoize Date: Thu Dec 11 13:39:24 2014 +0000 Bug - 5511 [Followup]: Missed Instance There was an instance of the pragma missed which meant the the original patch set didn't actually solve the problem in a large number of cases This patch adds in the relevant statement. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 129fb1fbe211b136ccad4d214ee26b94e988e5e5 Author: Martin Renvoize Date: Tue Dec 9 13:48:29 2014 +0000 Bug - 5511 [Followup]: Switched defults Agree with Chris that the defualt should maintain the higher security and not reduce it. Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 2d4d65d526e6f54a40ddec87a6d3207722234fd3 Author: Amit Gupta Date: Tue Oct 8 09:36:59 2013 +0530 Bug - 5511: Added new system preference: SessionRestrictionByIP Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit e3bb1390807578e2b9898723e2816a58f2c01e57 Author: Amit Gupta Date: Tue Oct 8 09:33:54 2013 +0530 Bug - 5511: Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. To Test: 1) Enable the system preference SessionRestrictionByIP 2) Change your system IP. It will not checkout your system IP or signout. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 31 ++++++++++---------- C4/Context.pm | 8 +++-- C4/InstallAuth.pm | 6 ++-- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 7 +++++ .../prog/en/modules/admin/preferences/admin.pref | 7 +++++ .../prog/en/modules/members/member-password.tt | 5 ++++ kohaversion.pl | 2 +- t/Circulation_barcodedecode.t | 2 +- t/db_dependent/Bookseller.t | 4 +-- t/db_dependent/Circulation.t | 2 +- t/db_dependent/Koha_template_plugin_Branches.t | 2 +- t/db_dependent/Members.t | 4 +-- 13 files changed, 52 insertions(+), 29 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Feb 9 21:37:57 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Feb 2015 20:37:57 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-17-ge49a6b8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via e49a6b8ad46b3e5f92c7360d8d6d04c6972cac97 (commit) via eb7bc4ea3109afb8e90f684cd00e2494901bf90e (commit) via 1cf327125a2ab4175882355a2bd835aca2e7b47b (commit) from f5309088063b1ef36732f76cedf31d41cd10514a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e49a6b8ad46b3e5f92c7360d8d6d04c6972cac97 Author: Kyle M Hall Date: Wed Dec 10 12:27:59 2014 -0500 Bug 13432 - SIP Server does not respect timeout setting Koha's SIP server accepts timeout parameters, but those parameters are only used for the login portion of a telnet transport session. Other than that, they are ignored, and as long as whatever opened the connection keeps it open, it will stay open indefinitely. Test Plan: 1) Set the timeout setting on your SIP server to 10 seconds 2) Modify misc/sip_cli_emulator.pl, add "sleep 100;" directly after line 91 3) Start your SIP server 4) Run the modified sip script with valid parameters 5) Watch the SIP server stderr 6) Note that even though the script waits far too long before continuing, the SIP server never kills the connection, and the requests the cli script makes come back with valid data. 7) Apply this patch 8) Restart your SIP server 9) Repeat step 4 10) Note that this time you see "SIP Timed Out!" in the SIP server stderr and when the script finally makes it's request, it doesn't come back with valid data. Signed-off-by: Colin Campbell Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 03335ab401576355dfc5bcee1aa45714fd9fc411) Signed-off-by: Chris Cormack commit eb7bc4ea3109afb8e90f684cd00e2494901bf90e Author: Kyle M Hall Date: Tue Jan 20 07:18:11 2015 -0500 Bug 13599 - Add patron cardnumber to self registration confirmation Some libraries wish to display the patron's cardnumber on the confirmation screen for patron self registration, rather than make the patron locate it his or her cardnumber by logging in and browsing to the personal details page. We should also add ids to these fields for easy css styling/hiding. Test Plan: 1) Apply this patch 2) Ensure that autoMemberNum is enabled 3) Self-register a new patron 4) Note confirmation screen now displays the patron cardnumber Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 06f4950aa21ff889cff81f27b2f4e79788db193f) Signed-off-by: Chris Cormack commit 1cf327125a2ab4175882355a2bd835aca2e7b47b Author: Jonathan Druart Date: Fri Jan 9 16:01:35 2015 +0100 Bug 13544: Make it explicit that getauthtypes returns a hash ref Prior to perl 5.12 keys can only operate on a hash. Test plan: With perl 5.10, access to admin/auth_subfields_structure.pl. Without this patch, you get: Type of arg 1 to keys must be hash (not subroutine entry) at /home/koha/src/admin/auth_subfields_structure.pl line 102, near "getauthtypes)" Signed-off-by: Katrin Fischer Confirmed problem and tested patch on a sandbox, signed off locally. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi (cherry picked from commit c9af47b86c653946916349ea021171b99f6bb44d) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: C4/SIP/SIPServer.pm | 4 ++++ admin/auth_subfields_structure.pl | 2 +- .../en/modules/opac-registration-confirmation.tt | 19 ++++++++++++++++--- 3 files changed, 21 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Feb 9 21:45:53 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Feb 2015 20:45:53 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-20-g6da3dff Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 6da3dff2b18247441c719aa2eb74c7fc417d09f3 (commit) via 1a22fc87db69c6fe7c94fe820e1e0964c1596772 (commit) via 6801a2de20243601b9f8d6d863352b80021aee80 (commit) from e49a6b8ad46b3e5f92c7360d8d6d04c6972cac97 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6da3dff2b18247441c719aa2eb74c7fc417d09f3 Author: Jonathan Druart Date: Thu Dec 11 09:50:38 2014 +0100 Bug 13268: the size should not be emptied in pl script It duplicates what the first patch does. Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 42e9044f1195a512870d4e1dc01679a64d47f4d9) Signed-off-by: Chris Cormack commit 1a22fc87db69c6fe7c94fe820e1e0964c1596772 Author: Fridolin Somers Date: Mon Nov 17 16:32:20 2014 +0100 Bug 13268 - biblioitems.size value not correctly displayed (more) Bug partially corrected by Bug 11357. The size column in biblioitems is a bit problematic when used in TT, because instead of the size value from the biblio column it will give you the size of the variable or current loop. It's currently used in the templates like opac-topissues.tt : [% IF results_loo.size %][% results_loo.size %][% END %] This patch corrects by using item() TT method. See http://stackoverflow.com/questions/2311303/how-can-i-handle-hash-keys-containing-illegal-identifier-characters-in-template. Test plan : - Be sure there is a mapping between a MARC field and biblioitems.size - Create a record A with biblioitems.size defined : like "10x12" - Create a record B with no value in biblioitems.size - Check each modified page : => Without this patch : you see a number (loop size) for both records => With this patch : you only see the correct value for A and nothing for B Signed-off-by: Jonathan Druart Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit f27d454048bca9d9ebdc1f781a688c2311952786) Signed-off-by: Chris Cormack commit 6801a2de20243601b9f8d6d863352b80021aee80 Author: Owen Leonard Date: Thu Jan 22 14:25:29 2015 -0500 Bug 13339 - Cart button doesn't open the cart The link to open the cart no longer triggers the cart popup. Instead, in order to make it more usable with mobile devices, it triggers a menu which displays the count of items in the cart -- something which previously was done with a hover action (something touch-screen devices don't have). Clicking/tapping this menu item is what opens the cart window. Since the cart link is really now a menu trigger rather than just a link, it seems logical to add the small arrow which the lists link has indicating that the link triggers a menu. To test, apply the patch and view any page in a Cart-enabled OPAC. Confirm that the "caret" icon displays correctly when the cart is both empty and when it has contents. Followed test plan. Icon displays as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Works as described, good idea. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 724f77ec43449144a2cccac048a57ffb19799fed) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: cataloguing/addbooks.pl | 3 --- koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt | 2 +- 6 files changed, 5 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Feb 9 22:42:05 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Mon, 09 Feb 2015 21:42:05 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-23-g36da7ef Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 36da7efe95c2e1509aef76a13e3fc09f0d531db2 (commit) via 702b26488b582afffe9297274f5ee667d79cc0f6 (commit) via b839a1c4bf9ba0b4b5471ed901f9ead48a9eec08 (commit) from 6da3dff2b18247441c719aa2eb74c7fc417d09f3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 36da7efe95c2e1509aef76a13e3fc09f0d531db2 Author: Mark Tompsett Date: Fri Dec 19 12:28:19 2014 -0500 Bug 13457 - Followup for CPL and S codes Based on comment #3, this corrects CPL and S issues if they do not exist in the DB. TEST PLAN --------- 0) Backup your DB. 1) Clear CPL and S from your DB. - delete from borrowers where categorycode='S'; - delete from categories where categorycode='S'; - delete from borrowers where branchcode='CPL'; - delete from branch where branchcode='CPL'; 2) prove t/db_dependent/Suggestions.t -- This should fail. 3) Apply patch 4) prove t/db_dependent/Suggestions.t -- This should work. 5) Intentionally add categorycode 'S' and branchcode 'CPL' back into the database. 6) prove t/db_dependent/Suggestions.t -- This should work. 7) run koha qa test tools. 8) Restore your DB :) Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 01c7c2a12904fae5076914d839c5e829c54deb6f) Signed-off-by: Chris Cormack commit 702b26488b582afffe9297274f5ee667d79cc0f6 Author: Mark Tompsett Date: Fri Dec 12 17:03:17 2014 -0500 Bug 13457: Suggestions.t expects sample itemtypes TEST PLAN --------- 1) Make sure you have more than 8 item types, and preferably something with a non-sample default code for itemtypes. 2) prove t/db_dependent/Suggestions.t -- this will fail 3) Apply patch 4) prove t/db_dependent/Suggestions.t -- this will succeed 5) run koha qa test tools Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit bfb035511e8afd6716ea8d1b2de966f8950b74e6) Signed-off-by: Chris Cormack commit b839a1c4bf9ba0b4b5471ed901f9ead48a9eec08 Author: Thomas Date: Thu Jan 15 01:43:28 2015 +0000 Bug 10241 - Easy analyticals creates two 773 fields. Search/link from host to children is broken Hidden 'New child record' if 'EasyAnalytics' is set to display. Testing plan: -Turn on 'EasyAnalytics'. Check the drop down menu from the records page *The drop down menu should include 'Analyze items' and not include 'New child record' -Turn off 'EasyAnalytics'. Again check the drop down menu from the records page *The drop down menu should include 'New child record' and not inlucde 'Analyze items' Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 6f57a2e09b7e9a87270eba1b04f75ae22fbbc999) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: .../intranet-tmpl/prog/en/includes/cat-toolbar.inc | 2 +- t/db_dependent/Suggestions.t | 34 ++++++++++++++++++++ 2 files changed, 35 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 10 12:43:56 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Feb 2015 11:43:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-304-g2df5417 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 2df541712fd691ee817568ed9d14e94bba13424e (commit) from 8f690a135edf531ee3576bc1fb4fa81b0d954477 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2df541712fd691ee817568ed9d14e94bba13424e Author: Jonathan Druart Date: Fri Feb 6 16:19:14 2015 +0100 Bug 13675: Do not set aqorders.budget_id to NULL C4::Acquisition::ModReceiveOrder updates the aqorders with budget_id=NULL if no budget_id given in parameter. Actually the same budget_id should be used. In tests (especially t/db_dependent/Acquisition/TransferOrder.t), ModReceiveOrder is not called with a budget_id param and set to NULL the budget_id value. test plan: prove t/db_dependent/Acquisition/TransferOrder.t should return green Note that this bug should not appear using the interface. Signed-off-by: Tomas Cohen Arazi The fix makes sense, and running $ prove t/db_dependent/Acq* returns all green. koha-qa.pl also likes it. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 10 18:02:09 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Feb 2015 17:02:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-310-g155ce56 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 155ce56ad811954802090faf2994278f7c9dcbf2 (commit) via 18c28fe36cace2edcedcecad44b0637cc8a90625 (commit) via 5bd9482550cee62fde36c5a74d73714ec000dc0b (commit) via 87bcc8b303e506514318814f63c430a3a54f1181 (commit) via f19a1777a0847ce2dc10b7f259bf76fc2d382d19 (commit) via dc5b94486304fc5353640c0341cdfa11d3367fb2 (commit) from 2df541712fd691ee817568ed9d14e94bba13424e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 155ce56ad811954802090faf2994278f7c9dcbf2 Author: Kyle M Hall Date: Fri Feb 6 09:44:33 2015 -0500 Bug 13240 [QA Followup] Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 18c28fe36cace2edcedcecad44b0637cc8a90625 Author: Jonathan Druart Date: Wed Nov 12 12:24:10 2014 +0100 Bug 13240: Remove commented warns Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 5bd9482550cee62fde36c5a74d73714ec000dc0b Author: Jonathan Druart Date: Wed Nov 12 12:23:38 2014 +0100 Bug 13240: Remove some code obfuscation my $bar; my $foo = $bar->{borrowernumber} ||= {}; $foo->{one} ||= 'something'; $foo->{two}++; What does $bar contain? $VAR1 = { 'borrowernumber' => { 'two' => 1, 'bar' => 'something' } }; Not really obvious. Maybe something I did not see is hidden. Test plan: Verify the digest for DUE and PREDUE work as before. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 87bcc8b303e506514318814f63c430a3a54f1181 Author: Kyle M Hall Date: Thu Feb 5 09:21:12 2015 -0500 Bug 13670 - Patron holds table not loading when holds tab anchor is used If a link to a patron record ends with #reserves, the holds tab is selected on page load, but the holds table does not load. Test Plan: 1) Build your holds queue 2) From the holds queue report, open any patron link 3) Note the patron's reserves do not load 4) Apply this patch 5) Clear your browser cache 6) Repeat step 2 7) Note the holds table now loads Signed-off-by: Sean McGarvey Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit f19a1777a0847ce2dc10b7f259bf76fc2d382d19 Author: Jonathan Druart Date: Fri Nov 14 16:18:09 2014 +0100 Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber The tests highligh the problem: if the parent_ordernumber attribute is not set on inserting an order, the object returned by the method does not contain the value (undef). Test plan: Verify the tests are consistent and prove t/db_dependent/Acquisition/CancelReceipt.t should return green. You can also verify that receive partially an order and cancel the receipt work as expected. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit dc5b94486304fc5353640c0341cdfa11d3367fb2 Author: Kyle M Hall Date: Wed May 21 11:09:04 2014 -0700 Bug 12323 [SIGNED OFF] - Acquisitions search results fixed in order of biblionumber The acquisitions search is exhibiting the same behavior as bug 11410. Results are always fixed in order of biblionumber, among other possible issues ( including the ampersand issue ). Test Plan: 1) From an open basket, choose "Add to basket" 2) Run a search for "From an existing record" 3) Note the "View MARC" URLs are fixed in order of biblionumber 4) Apply this patch 5) Refresh the page 6) Note the results are no longer fixed in order of biblionumber Signed-off-by: David Cook Works as described. I think the code could be a bit tidier, but I think it makes sense to use buildQuery here. It'll detect CCL, CQL, and PQF queries, as well as parsing a regular keyword search as one would expect when searching the catalogue. It also has the added bonus of performing relevance searching, so long as QueryAutoTruncation is off, and so long as library staff avoid using the "*" truncation wildcard (see bug 12430). While there are simpler ways to fix this acq bug, I think this was probably the best move, as it adds a bit to the consistency of what librarians can expect from their search results. Signed-off-by: Jonathan Druart Same result with and without the patch but I agree with the changes. BuildQuery should be called before SimpleSearch if QP is not used. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: Koha/Acquisition/Order.pm | 3 +- acqui/neworderbiblio.pl | 13 ++++++-- koha-tmpl/intranet-tmpl/prog/en/js/holds.js | 13 +++++--- misc/cronjobs/advance_notices.pl | 16 +++------- t/db_dependent/Acquisition/CancelReceipt.t | 44 +++++++++++++++++++++++++-- 5 files changed, 68 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 10 22:44:07 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Feb 2015 21:44:07 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-26-g016b111 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 016b111d4e6281c5d8618acd8a5563f627957952 (commit) via 70282cf9a4edbd09f7482cefa5968d6149965e7b (commit) via 07a81a496d395c20e93e362305b28aa9e913c936 (commit) from 36da7efe95c2e1509aef76a13e3fc09f0d531db2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 016b111d4e6281c5d8618acd8a5563f627957952 Author: Kyle M Hall Date: Thu Jan 1 16:38:34 2015 -0500 Bug 13441 - Branchcodes should not be allowed to have spaces in them In multiple cases I've seen issues arise in Koha where a librarian accidentally puts a space at the end of a new branchcode. This of course causes endless confusion because the branchcode looks perfectly fine in every case unless you wrap the code with some characters to reveal the hidden space! Test Plan: 1) Try creating a new branch with one or more spaces in the branchcode 2) Note you are able to 3) Apply this patch 4) Repeat step 1 5) Note you are no longer able to Followed test plan with cache cleared. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit a7c41e6073a2719e21f86909a37daab6410b2b96) Signed-off-by: Chris Cormack commit 70282cf9a4edbd09f7482cefa5968d6149965e7b Author: Jonathan Druart Date: Mon Nov 10 10:45:25 2014 +0100 Bug 12905: funds with children could not be deleted The interface should prevent to delete funds with children. Otherwise the relationship is broken and problems occur: 1/ You don't see the orphan fund in the fund list 2/ You cannot edit the orphan fund amount ('Fund amount exceeds parent allocation'). This patch: - adds a JS check, template side - adds a check in the perl script (should never be true) - adds an updatedatabase check, in order to alert users with inconsistent data. Test plan: Verify you are not allow to delete a fund with children. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 522e9c5861854fad7c9b292f75ebd19968f5b11c) Signed-off-by: Chris Cormack commit 07a81a496d395c20e93e362305b28aa9e913c936 Author: Jonathan Druart Date: Tue Nov 25 12:23:45 2014 +0100 Bug 13333: Fix Display basket group for already received orders Bug 11111 adds a basket group column on the parcel page. But it seems that the already received orders never contain the value (always 'no basket group'). Test plan: Receive an order which is in a basket group and verify the basket group column is correctly filled. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 74640683f0d7f4b9734a69763424b33977f66cfd) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 14 ++++++++----- admin/aqbudgets.pl | 6 ++++++ installer/data/mysql/updatedatabase.pl | 22 ++++++++++++++++++++ .../prog/en/modules/admin/aqbudgets.tt | 11 +++++++++- .../prog/en/modules/admin/branches.tt | 20 ++++++++++++++---- t/db_dependent/Acquisition/Invoices.t | 9 ++++---- 6 files changed, 68 insertions(+), 14 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 10 22:56:55 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Feb 2015 21:56:55 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-28-gdbc39e4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via dbc39e40a49ee01f14bf92c251b4895575e90152 (commit) via d3de39d946f04b9923a5d9249728e5a4e8ff259b (commit) from 016b111d4e6281c5d8618acd8a5563f627957952 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dbc39e40a49ee01f14bf92c251b4895575e90152 Author: Jonathan Druart Date: Thu Jan 29 16:18:19 2015 +0100 Bug 12860: the export tools explodes if a field is not exported To reproduce: 1/ Go on tools/export.pl 2/ Export some records and specify you don't want the fields 245 (the whole field, do not specify a subfield). 3/ Export, BOOM Software error: Arguments must be MARC::Field object at /home/koha/src/tools/export.pl line 400. Test plan: Apply the patch and confirm the fields 245 are not exported and the export works as expected. Signed-off-by: Robin Sheat Export fails to asplode with this patch Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit e2968fe0812898d92ce8c63e9c7f0dedd244acc9) Signed-off-by: Chris Cormack commit d3de39d946f04b9923a5d9249728e5a4e8ff259b Author: Jonathan Druart Date: Mon Nov 17 17:17:49 2014 +0100 Bug 13270: Don't display "vendor note" label if nothing to display Bug 12111 removes the vendor note edition on receiving. The label should not be displayed when it's empty. Test plan: 1/ Receive an order without a vendor note and verify that the label is not displayed. 2/ Receive an order with a vendor note and verify that the note is displayed. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, small template change. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 1c62f1a9783bb8a171352e0b66d910056ccfe0d4) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 4 +++- tools/export.pl | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 10 23:08:44 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Feb 2015 22:08:44 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-29-g7ac6d73 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 7ac6d73301f864a69a1d8a5ca21ed8492e3e8800 (commit) from dbc39e40a49ee01f14bf92c251b4895575e90152 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7ac6d73301f864a69a1d8a5ca21ed8492e3e8800 Author: Chris Cormack Date: Wed Feb 11 11:15:02 2015 +1300 Bumping version number to 3.18.03.001 ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 2 +- kohaversion.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 10 23:22:29 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 10 Feb 2015 22:22:29 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-31-g8c59429 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 8c594291f3f35d6f21de48a9c261ee86cea3891e (commit) via 9abad2800c0dafb55a63f86a0fcb0883de33a3f3 (commit) from 7ac6d73301f864a69a1d8a5ca21ed8492e3e8800 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8c594291f3f35d6f21de48a9c261ee86cea3891e Author: Kyle M Hall Date: Fri Jan 30 07:10:29 2015 -0500 Bug 13450 [QA Followup] - Remove tab character from start of line Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit fe66114e210885324eb37773e2bd09e7e2190f59) Signed-off-by: Chris Cormack commit 9abad2800c0dafb55a63f86a0fcb0883de33a3f3 Author: Marc V?ron Date: Tue Dec 30 00:04:53 2014 +0100 Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) (Missing added) Signed-off-by: Aleisha Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit e2bbdc0b145fba30bd60110ad2d4fd8262107947) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/members/memberentrygen.tt | 23 +++++--------------- 1 file changed, 5 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 12 19:22:56 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 12 Feb 2015 18:22:56 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-321-ga23c551 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via a23c551f3012eb1413b25ac2ef867500d5eca9fb (commit) via d792583186d4942a8b80d0f281afd91b64f91a95 (commit) via 089c08ea6526158bcc7a1f770fec0db2e714c9c7 (commit) via 074428bb8a36788507f4282136a0eaf6aec92b54 (commit) via d562df4af2f9de0e0aa94d03b40b464e10cd8737 (commit) via 3107975ba95f5853ea1084afa01db598e4adeeea (commit) via 6f0316a8d298b023fb74351d9ffff51fdeb31119 (commit) via 295fb70f62069c0b1fbed2d9bbdf2650f58e488c (commit) via fcaa6f35c080c079ba422a70dec49ca327346c82 (commit) via dbf0b358b9362fdf634b47569b1777d7034b17a9 (commit) via 9e701294dd6ccf4fa5d8b24d1a7da15be353992e (commit) from 155ce56ad811954802090faf2994278f7c9dcbf2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a23c551f3012eb1413b25ac2ef867500d5eca9fb Author: Kyle M Hall Date: Tue Feb 10 14:01:51 2015 -0500 Bug 13019 [QA Followup] - Fix stale unit test Signed-off-by: Tomas Cohen Arazi commit d792583186d4942a8b80d0f281afd91b64f91a95 Author: Kyle M Hall Date: Tue Feb 10 13:30:32 2015 -0500 Bug 13019 [QA Followup] - Allow chaining By returning the object itself instead of a boolean, we can chain methods together while retaining the exact same functionality. Signed-off-by: Tomas Cohen Arazi commit 089c08ea6526158bcc7a1f770fec0db2e714c9c7 Author: Kyle M Hall Date: Mon Nov 24 06:09:54 2014 -0500 Bug 13019 [QA Followup] - Remove use of encode Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi commit 074428bb8a36788507f4282136a0eaf6aec92b54 Author: Marcel de Rooy Date: Mon Nov 24 12:46:43 2014 +0100 Bug 13019: [QA Follow-up] Rename new_from_dbic and few typos Since new_from_dbic is not meant as a public method, this patch adds a prefix to the name of this internal routine. For the same reason I removed it from t/Borrower.t. Removed one use overload-line in Objects (not used). Resolved a few typos. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit d562df4af2f9de0e0aa94d03b40b464e10cd8737 Author: Kyle M Hall Date: Fri Nov 21 11:40:48 2014 -0500 Bug 13019 [QA Followup] - Allow find() and search() to be called as static methods Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 3107975ba95f5853ea1084afa01db598e4adeeea Author: Jonathan Druart Date: Mon Nov 10 12:55:35 2014 +0100 Bug 13019: (follow-up) Remove smartmatch operator This patch also adds 1 test. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 6f0316a8d298b023fb74351d9ffff51fdeb31119 Author: Kyle M Hall Date: Tue Sep 30 15:05:30 2014 -0400 Bug 13019 - Add base classes on which to build Koha objects The idea behind this is to have a pair of base classes on which to build our new generation of Koha objects. Koha::Object is a base class, which in it's most basic form, is to represent a row in a table. For example, Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for example. Koha::Objects is to represent a way to fetch and manipulate sets of objects. For example, Koha::Borrowers has a method to get a Koha::Borrower object by id and a method to search for an get a list of Koha::Borrower objects. Right now Koha::Objects has only the essentials but can easily be extended and those enhancements will be passed down to all the child classes based on it. By using these classes as a base, we will add consistency to our code, allow us to keep our code DRY, reduce bugs, and encapsulate our database access among other benefits. Test Plan: 1) Apply this patch 2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 295fb70f62069c0b1fbed2d9bbdf2650f58e488c Author: Kyle M Hall Date: Tue Nov 25 10:16:47 2014 -0500 Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing No matter what the selection of OPACShowHoldQueueDetails is, if it is enabled it displays a line "Holds and priority:" even if you've opted to hide one of those! Test Plan: 1) Apply this patch 2) Test each setting of OPACShowHoldQueueDetails 3) Ensure each setting displays the correct fields ( or lack thereof ) Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit fcaa6f35c080c079ba422a70dec49ca327346c82 Author: Kyle M Hall Date: Wed Jan 28 08:31:30 2015 -0500 Bug 13636 - Staff search results item status incorrect for holds Imagine this scenario: we have one record with four items. Two of those items are checked out, one of those items is a waiting hold, and one of those items is available. We would expect to see this on the search results page. Instead, we will see both non-checked out items as unavailable due to waiting holds. This is due to a semantic issue GetReserveStatus. C4::Search::searchResults uses GetReserveStatus to get the reserve status of each item, but unlike all other calls to the sub, this one passes in not only itemnumber, but biblionumber. When no reserve is found for the available item, the subroutine uses the biblionumber to grab what is essentially an arbitrary reserve to use for the status. This makes no sense and this functionality should be entirely removed from the subroutine so regressions like this will be prevented in the future. Test Plan: 1) Create one record with 4 items a) check two of the items out to patrons b) set one of the items as a waiting hold c) leave the fourth item as available 2) Run a search where this record will be in the results list 3) Note that the results list 2 items on loan, two unavailable 4) Apply this patch, reload the search results 5) Note that the results list 1 available, 2 on loan, 1 unavailable Signed-off-by: John Andrews Signed-off-by: Sheila Kearns Signed-off-by: Katrin Fischer Note: This is for the staff search result list! Works as expected. Signed-off-by: Tomas Cohen Arazi commit dbf0b358b9362fdf634b47569b1777d7034b17a9 Author: Jacek Ablewicz Date: Tue Dec 30 10:30:30 2014 +0100 Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues 1) Removed 'use C4::Context;' because it can lead to introduction of circular reference in the near future 2) Put fastmmap initialization code into an eval {} block, to catch various kinds of errors which can still occur during it's init in some [less usual] Koha setups and/or more unusual circumstances 3) Do not include UID in the sharefile name (it will be constructed using namespace + database name + database host instead). Test plan addendum: s/and UID// Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 9e701294dd6ccf4fa5d8b24d1a7da15be353992e Author: Jacek Ablewicz Date: Tue Dec 16 12:48:09 2014 +0100 Bug 13431 - Shared FastMmap file causes issues Koha::Cache package does not take into account that, when using fastmmap caching variant, mmaped cache file created in /tmp (typically: /tmp/sharefile-koha-koha), would only be further accessible to the one given OS user - the one which created it. In many Koha setups, in the circumstances when various system scripts are executed by 2+ users with diffrent UIDs (like multi-tenant servers, for example) this may cause many kinds of issues. Observable symptom is usually the appearance of the below error when searching, or looking at MARC Framework pages and a few other places: Open of share file /tmp/sharefile-koha-koha failed: Permission denied at /usr/lib/perl5/Cache/FastMmap.pm line 640. This patch: - disables initialisation of fastmmap caching subsystem unless it is explicitly requested by the user (CACHING_SYSTEM=fastmmap) - disables fastmmap cache usage for command line scripts (i.e. when GATEWAY_INTERFACE environment variable is not defined) - adds the database name, host name and an ID of the OS user to the mmaped file name created in /tmp, to prevent various kinds of unintentional conflicts and/or permission problems from happening To test: 1) remove the /tmp/sharefile-koha-* file[s] (if any) 2) do something which would lead to its re-creation (e.g., performing any search in OPAC should be sufficient to cause that) 3) observe that /tmp/sharefile-koha-koha got created 4) remove it 5) apply patch 6) redo step 2) 7) observe that aforementioned file is no longer created in /tmp 8) set CACHING_SYSTEM environment variable to 'fastmmap' 9) redo step 2), observe that /tmp/sharefile-koha-* file got created and that it's name now contains hostname, database name and UID 10) ensure that everything still works like it should and that there are no regressions of any kinds anywhere in the system ;) Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 12 +- C4/Search.pm | 2 +- C4/Barcodes/incremental.pm => Koha/Borrower.pm | 43 ++- C4/Barcodes/incremental.pm => Koha/Borrowers.pm | 47 +++- Koha/Cache.pm | 35 ++- Koha/Object.pm | 286 ++++++++++++++++++++ Koha/Objects.pm | 245 +++++++++++++++++ .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 16 +- opac/opac-reserve.pl | 2 - t/Borrower.t | 56 ++++ t/db_dependent/Borrower.t | 74 +++++ t/db_dependent/Borrowers.t | 93 +++++++ 12 files changed, 856 insertions(+), 55 deletions(-) copy C4/Barcodes/incremental.pm => Koha/Borrower.pm (62%) copy C4/Barcodes/incremental.pm => Koha/Borrowers.pm (58%) create mode 100644 Koha/Object.pm create mode 100644 Koha/Objects.pm create mode 100755 t/Borrower.t create mode 100755 t/db_dependent/Borrower.t create mode 100755 t/db_dependent/Borrowers.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 12 19:31:12 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 12 Feb 2015 18:31:12 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-323-gb2ccd0f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b2ccd0f3a208f8920eda0552fb4f5fc773e23901 (commit) via a0e5d77a719443c6616194a898795f70d34d6ebc (commit) from a23c551f3012eb1413b25ac2ef867500d5eca9fb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b2ccd0f3a208f8920eda0552fb4f5fc773e23901 Author: Kyle M Hall Date: Mon Nov 3 09:31:27 2014 -0500 Bug 13189 - Patron card creator patron search browse by last name broken by extended attributes The browse by last name letters on the patron search for the patron card creator doesn't work quite right. If extended patron attributes are disabled, it works fine, but if they are enabled, they are searched even when using the browse last name. Thus, if a searchable attribute has a "D" in it, and one clicks the "D" link for the last name browser, that patron will show even if he or she has no "D" in his or her hame! Test Plan: 1) Enable extended patron attributes 2) Add a new searchable patron attribute 3) Create a new patron with the last name "Ace" 4) Add the value "D" to the attribute for this patron 5) Browse to the patron card maker, start a new patron batch 6) Click "Add item(s)" to bring up the patron search 7) Click the letter "D" in the patron search box 8) Note that "Ace" shows in the results list 9) Apply this patch 10) Repeat step 7 11) Note that "Ace" no longer shows in the results list 12) Perform a regular search by putting the letter "D" in the "Name:" field, and hit the "Search" button 13) Note this time the results *do* have Ace in them Signed-off-by: Frederic Demians Well described for a tricky bug. Reproducible. Fixed with this patch. Signed-off-by: Katrin Fischer This works as described, no problems or regressions found. commit a0e5d77a719443c6616194a898795f70d34d6ebc Author: Jonathan Druart Date: Wed Nov 26 15:14:59 2014 +0100 Bug 13343: Embed items when send a basket/shelf When a basket/shelf is downloaded, items are embedded, but not when sending it by email. We would expect to get the same file. Test plan: On Opac and intranet: 1/ Add records with items to your basket and send it by email. Verify the file contains items. 2/ Add records with items to a list and send it by email. Verify the file contains items. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Members.pm | 4 ++-- basket/sendbasket.pl | 2 +- .../intranet-tmpl/prog/en/modules/patroncards/members-search.tt | 2 +- opac/opac-sendbasket.pl | 2 +- opac/opac-sendshelf.pl | 2 +- patroncards/members-search.pl | 5 +++-- virtualshelves/sendshelf.pl | 2 +- 7 files changed, 10 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 12 22:35:54 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 12 Feb 2015 21:35:54 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-33-g6f51d3b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 6f51d3b31b690415f9fc9bff6477d93701628b83 (commit) via d31c4264552fd1fe94ca97737e0fe6365a09cf09 (commit) from 8c594291f3f35d6f21de48a9c261ee86cea3891e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6f51d3b31b690415f9fc9bff6477d93701628b83 Author: Olli-Antti Kivilahti Date: Tue Jan 20 16:48:13 2015 +0200 Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences When editing a Patron's messaging preferences or borrower attributes, one cannot save changes because 'userid' is not given as a parameter. It shouldn't, but the Check_Userid($newdata{'userid'},$borrowernumber) -check must have it. REPLICATE THE ISSUE: 1. Find a Borrower. 2. Go to the details-tab. 3. Under "Patron messaging preferences" click edit to edit just the messaging preferences. 4. Just save, no need to make any modifications. 5. Observe the error "Username/password already exists" This happens to all/most of the sub-forms in the Borrower's Details-view. AFTER THIS PATCH: Check_Userid() get the $userid from the new parameters, or if not present, from the koha.borrowers-table. TEST FOR REGRESSION: 1. Edit a borrower normally. Notice no errors. 2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no errors. DISCLAIMER: You are free to steal/rip/modify/hack this patch to your soul's extent without my permission. As long as it makes to Koha I am happy. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 58f7f56b8664810335f60f3fe5e43faa079f33bc) Signed-off-by: Chris Cormack commit d31c4264552fd1fe94ca97737e0fe6365a09cf09 Author: Owen Leonard Date: Wed Jan 28 12:24:45 2015 -0500 Bug 13638 - Batch patron modification tool missing option to switch language The batch patron modification tool's template was created without the footer include at the bottom. Without the footer include the language toolbar will not be displayed. All page templates should include the global footer include: [% INCLUDE 'intranet-bottom.inc' %] To test: - Install at least a second language - Enable at least 2 languages (language system preference) - Go to tools > Batch patron modification - Verify that at the bottom of the page the language chooser is shown Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 28af6c4d01e0b1a31dece34031b6379fb9befebc) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 5 +---- members/memberentry.pl | 6 ++++-- 2 files changed, 5 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 12 22:37:07 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 12 Feb 2015 21:37:07 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-35-g6e01fc7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 6e01fc7a5da9df8f645481048e023b46e378de3b (commit) via 98b6b33f6e499e728409dc8087bc459607da4d32 (commit) from 6f51d3b31b690415f9fc9bff6477d93701628b83 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6e01fc7a5da9df8f645481048e023b46e378de3b Author: Julian Maurice Date: Wed Jan 14 17:00:17 2015 +0100 Bug 13562: Fix item search on item MARC subfields Test plan: 1. Add 4 item search fields (in Administration ? Items search fields): a. 1 biblio field linked to a DB field b. 1 biblio field not linked to a DB field c. 1 item field linked to a DB field d. 1 item field not linked to a DB field 2. Make sure you have some data in those fields to search on. 3. Go to item search page and do a search using these new fields, make sure the result is correct. Signed-off-by: Nick Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit f70ad43f8fd49ad7fb43697c6953767e534f7368) Signed-off-by: Chris Cormack commit 98b6b33f6e499e728409dc8087bc459607da4d32 Author: Tomas Cohen Arazi Date: Mon Feb 9 13:32:50 2015 -0300 Bug 13602: (QA followup) take advantage of the defined-or operator Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 381de54ed1f56f61f22a682147b67d3902f43604) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 32 +++++++++++++++++++++++++++----- members/memberentry.pl | 7 ++++--- t/db_dependent/Items.t | 48 +++++++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 78 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 12 23:03:44 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 12 Feb 2015 22:03:44 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-36-gabc4665 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via abc46657e5039ba9d40637624390c0a28a664c8e (commit) from 6e01fc7a5da9df8f645481048e023b46e378de3b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit abc46657e5039ba9d40637624390c0a28a664c8e Author: Jonathan Druart Date: Mon Jan 26 10:28:27 2015 +0100 Bug 13352: On editing, prices should not be formatted Bug 12979 refactored the way to display prices. The price format configuration was duplicated everywhere it was used. All calls looks good except the one in admin/aqbudgetperiods.pl In this one, the prices are formatted for an edition field (input). This means the input is incorrectly filled even if the user does not update the field. At the end, maybe should we manage formatted prices everywhere, even in inputs, but it's not in the scope of this bug. Technically, a new subroutine format_for_editing is added to the Koha::Number::Price module. It should be called everywhere a price is displayed in an input field. At the moment, it only does a sprintf("%.2f"), but it is a first step to let the number of decimals to display configurable. To test: 1/ Verify the issue described is fixed (editing a budget with a total amount > 1000 (With CurrencyFormat is US or FR). 2/ Verify you can edit a fund with a total amount > 1000 Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 945a0f09e73606907d6df72b873e478cc6763c14) Signed-off-by: Chris Cormack Conflicts: admin/aqbudgetperiods.pl t/Prices.t ----------------------------------------------------------------------- Summary of changes: Koha/Number/Price.pm | 15 + Koha/Template/Plugin/Price.pm | 9 +- admin/aqbudgetperiods.pl | 47 +-- admin/aqbudgets.pl | 1 - .../prog/en/modules/admin/aqbudgetperiods.tt | 7 +- .../prog/en/modules/admin/aqbudgets.tt | 6 +- t/Prices.t | 412 ++++++++++++++++++++ 7 files changed, 461 insertions(+), 36 deletions(-) create mode 100644 t/Prices.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 12 23:04:11 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 12 Feb 2015 22:04:11 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-37-g1120246 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 1120246a818e16af04cf155984fec7c44b5ed47c (commit) from abc46657e5039ba9d40637624390c0a28a664c8e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1120246a818e16af04cf155984fec7c44b5ed47c Author: Katrin Fischer Date: Sun Feb 8 16:23:41 2015 +0100 Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)" Signed-off-by: Tomas Cohen Arazi (cherry picked from commit bc355fef2455b7b22c29a061db72d07046169738) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 12 23:33:35 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 12 Feb 2015 22:33:35 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-42-g073ac1a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 073ac1abd26cf877f5a383197b38254d1be30ca5 (commit) via 21d420b8810ac4ad3d33d0f678ea94109fa703e7 (commit) via eb1ca95054f8deb1268c8cc6ef798fed1929a710 (commit) via 74a5fb4fbdb96253605244707da462a11cae8f98 (commit) via fb2669673dab127e7ad1d191bc1f9d53bbb5ae7b (commit) from 1120246a818e16af04cf155984fec7c44b5ed47c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 073ac1abd26cf877f5a383197b38254d1be30ca5 Author: Jonathan Druart Date: Wed Nov 5 12:41:13 2014 +0100 Bug 13201: GetSuggestion takes suggestionid Having $ordernumber as the parameter in a function which is handling suggestions and it is used as a suggestion id is confusing to the coder and person trying to read the code. This patch corrects the confusion. REVISED TEST PLAN ----------------- 1) perldoc C4::Suggestions -- notice it says ordernumber for the GetSuggestions example. 2) Ensure you have CPL in your branches table. 3) prove -v t/db_dependent/Suggestions.t -- if you have more than 8 itemtypes in your database, two tests at the end will fail, but that is not relevant to the modified GetSuggestions code. 4) apply patch 5) perldoc C4::Suggestions -- notice it is corrected now. 6) prove -v t/db_dependent/Suggestions.t -- it should run with the same results as in step 3. That is, if you have 8 itemtypes, all pass, otherwise those two tests fail. 7) run koha qa test tool Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit ddf909ae24df5a3185370f5c4916135bb94b67ae) Signed-off-by: Chris Cormack commit 21d420b8810ac4ad3d33d0f678ea94109fa703e7 Author: Marcel de Rooy Date: Mon Feb 9 09:26:04 2015 +0100 Bug 13404: [QA Follow-up] Minor rewording of some warnings Changes are confirmed with author (Mirko Tietgen). See Bugzilla. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 09edfe8d53f91d150c39be9ec41bc24c82ce93dd) Signed-off-by: Chris Cormack commit eb1ca95054f8deb1268c8cc6ef798fed1929a710 Author: Kyle M Hall Date: Thu Jan 1 21:06:58 2015 -0500 Bug 13404 [QA Followup] Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 983f49d7b28e3bf65c799f7ff00d64bdb10429d0) Signed-off-by: Chris Cormack commit 74a5fb4fbdb96253605244707da462a11cae8f98 Author: Mirko Tietgen Date: Sun Dec 7 18:39:51 2014 +0100 Bug 13404 - More System information about GRS1 vs DOM settings System information indicates missing and entries in koha-conf.xml. This patch - adds warnings about a possible mismatch between these settings and the actual setup - adds info about the actual setup/what values to use for and if they are not set. The assumption is that a path including 'zebra-*-dom.cfg' in the respective section indicates a DOM setup. Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 6a68ac3e5ded2e56d9b9de8f6e1a6a9ed49ac327) Signed-off-by: Chris Cormack commit fb2669673dab127e7ad1d191bc1f9d53bbb5ae7b Author: Fridolin Somers Date: Fri Dec 5 15:50:05 2014 +0100 Bug 13401 - sort branches alphabetically in admin/authorised_values.pl This patch adds a sort of branches alphabetically by name in authorised values administration, like in many other pages. Also replaces var $branch (too ambigus) by $branchcode. Test plan : - Create 2 branches : code=AAA,name=Zbranch and code=ZZZ,name=Abranch - Create a new authorized value : admin/authorised_values.pl - Look at "Libraries limitation" : => Without patch branches are sorted by code : Zbranch then Abranch => Without patch branches are sorted by name : Abranch then Zbranch - Select a branch and save - Re-edit => Check the same branch is selected Followed test plan. Patch behaves as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit b6aae39c263eee482aaeb574c206fa0c2c69f120) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: C4/Suggestions.pm | 8 ++-- about.pl | 46 ++++++++++++++++++++++ admin/authorised_values.pl | 8 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 30 ++++++++++++++ 4 files changed, 84 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 13 02:13:33 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Feb 2015 01:13:33 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-44-g04bb67f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 04bb67fa41457be733d85d9820c84e8680a5a0a8 (commit) via 9ca213316c8f0c03fbedc26f9a75042cce37c550 (commit) from 073ac1abd26cf877f5a383197b38254d1be30ca5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 04bb67fa41457be733d85d9820c84e8680a5a0a8 Author: Chris Cormack Date: Fri Feb 13 14:19:58 2015 +1300 Revert "Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)"" This reverts commit 1120246a818e16af04cf155984fec7c44b5ed47c. commit 9ca213316c8f0c03fbedc26f9a75042cce37c550 Author: Chris Cormack Date: Fri Feb 13 14:19:54 2015 +1300 Revert "Bug 13352: On editing, prices should not be formatted" This reverts commit abc46657e5039ba9d40637624390c0a28a664c8e. ----------------------------------------------------------------------- Summary of changes: Koha/Number/Price.pm | 15 - Koha/Template/Plugin/Price.pm | 9 +- admin/aqbudgetperiods.pl | 47 ++- admin/aqbudgets.pl | 1 + .../prog/en/modules/admin/aqbudgetperiods.tt | 7 +- .../prog/en/modules/admin/aqbudgets.tt | 6 +- t/Prices.t | 412 -------------------- 7 files changed, 36 insertions(+), 461 deletions(-) delete mode 100644 t/Prices.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 13 02:14:54 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Feb 2015 01:14:54 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-45-g5a310c0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 5a310c03ddfff8880c7d607750bc8f52e1f3e5bc (commit) from 04bb67fa41457be733d85d9820c84e8680a5a0a8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5a310c03ddfff8880c7d607750bc8f52e1f3e5bc Author: Kyle M Hall Date: Wed Nov 19 08:16:17 2014 -0500 Bug 13298 - Holds ratios report ignores ordered items The holds ratio report ignores ordered items. This could cause a library to inadvertently order more copies of a title than they actually need. An option should be added to count ordered items ( i.e. any negative notforloan value ). Test Plan: 1) Apply this patch 2) Create a record with two items, one regular, one ordered. 3) Place 3 holds on the item 4) Run the reserve ratios report, by default you should see this record 5) Check the new 'include ordered' checkbox, rerun the report 6) Note that record is no longer displayed Signed-off-by: Heather Braum Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit d8e5f0cd9d5926fb3b72e47852eac6b6c4f59be9) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: circ/reserveratios.pl | 11 ++++-- .../prog/en/modules/circ/reserveratios.tt | 39 +++++++++++++------- 2 files changed, 32 insertions(+), 18 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 13 18:05:41 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 13 Feb 2015 17:05:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-334-gb280b48 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b280b4890c813b5535b6e98b27c390d9af10551a (commit) via 59cfca3464f195918baf5fd0c88e1bc442911fca (commit) via 020434f2754ced867f41f8d04776807a3143c54f (commit) via 5e688f5694570df1d6e08ef88386788b52d804b0 (commit) via 4149055445d921e7aec82d847e03e4c35841137b (commit) via 70586324c596a608da615de3fa4fb093348c73a7 (commit) via 9c65bd8124ad21a96672c76b0ef1e31f80d7f4f3 (commit) via a7da45099f49093cc950a1392d6488543af5ddd3 (commit) via 7dacb45ce5ae3579283b2449cf32c6656188ecb4 (commit) via 3c7375685624a818232fa387018436cf7c03d95d (commit) via ae592bd25a8b52591494f5a75f2db918c55e8617 (commit) from b2ccd0f3a208f8920eda0552fb4f5fc773e23901 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b280b4890c813b5535b6e98b27c390d9af10551a Author: Kyle M Hall Date: Tue Jan 20 10:11:24 2015 -0500 Bug 13603 - autoBarcode setting hbyymmincr not taking month into account when looking up next increment The hbyymmincr autoBarcode builder looks up all barcodes that begin with any number of letters ( the branchcode ) and a two-digit year directly afterward ( e.g. MPL15 ), then grabs the last four digits as the increment counter. The problem is, this does not take months into account, so unlike the description that says the system is limited to 10,000 items a month, it is limited to 10,000 items per *year*. This situation can easily be corrected my adding the month into the lookup ( e.g. MPL1501 ). Test Plan: 1) Enable autoBarcode, set to hbyymmincr 2) Catalog an item, let the barcode.pl plugin generate the next barcode. 3) Catalog an item with the barcode MPL15009999 4) Catalog another item, use the barcode.pl plugin to generate the next barcode. 5) Note the barcode is generated ends with '0001' instead of the correct increment 6) Apply this patch 7) Repeat step 4 8) Note the barcode now ends with the correct increment Signed-off-by: Kyle M Hall Signed-off-by: Jeanne Heicher Signed-off-by: Katrin Fischer Problem confirmed - the continuing number bit was not reset to start counting from 1 again on the beginning of a new month. Signed-off-by: Tomas Cohen Arazi commit 59cfca3464f195918baf5fd0c88e1bc442911fca Author: Tomas Cohen Arazi Date: Fri Feb 13 13:56:07 2015 -0300 Bug 13417: DBRev 3.19.00.011 Signed-off-by: Tomas Cohen Arazi commit 020434f2754ced867f41f8d04776807a3143c54f Author: Jonathan Druart Date: Fri Jan 9 16:10:11 2015 +0100 Bug 13417: Remove warnings Without this patch perl -wc C4/VirtualShelves.pm failed: Constant subroutine C4::VirtualShelves::SHELVES_MASTHEAD_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_COMBO_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_MGRPAGE_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHELVES_POPUP_MAX redefined at /usr/share/perl/5.20/constant.pm line 156. Constant subroutine C4::VirtualShelves::SHARE_INVITATION_EXPIRY_DAYS redefined at /usr/share/perl/5.20/constant.pm line 156. Subroutine GetShelves redefined at C4/VirtualShelves.pm line 103. Subroutine GetAllShelves redefined at C4/VirtualShelves.pm line 159. Subroutine GetSomeShelfNames redefined at C4/VirtualShelves.pm line 189. Subroutine GetShelf redefined at C4/VirtualShelves.pm line 230. Subroutine GetShelfContents redefined at C4/VirtualShelves.pm line 262. Subroutine AddShelf redefined at C4/VirtualShelves.pm line 315. Subroutine AddToShelf redefined at C4/VirtualShelves.pm line 353. Subroutine ModShelf redefined at C4/VirtualShelves.pm line 394. Subroutine ShelfPossibleAction redefined at C4/VirtualShelves.pm line 454. Subroutine DelFromShelf redefined at C4/VirtualShelves.pm line 545. Subroutine DelShelf redefined at C4/VirtualShelves.pm line 589. Subroutine GetBibliosShelves redefined at C4/VirtualShelves.pm line 603. Subroutine ShelvesMax redefined at C4/VirtualShelves.pm line 628. Subroutine HandleDelBorrower redefined at C4/VirtualShelves.pm line 648. Subroutine AddShare redefined at C4/VirtualShelves.pm line 683. Subroutine AcceptShare redefined at C4/VirtualShelves.pm line 703. Subroutine IsSharedList redefined at C4/VirtualShelves.pm line 731. Subroutine RemoveShare redefined at C4/VirtualShelves.pm line 750. Subroutine _shelf_count redefined at C4/VirtualShelves.pm line 764. Subroutine _CheckShelfName redefined at C4/VirtualShelves.pm line 788. C4/VirtualShelves.pm syntax OK Signed-off-by: Tomas Cohen Arazi commit 5e688f5694570df1d6e08ef88386788b52d804b0 Author: Jonathan Druart Date: Mon Jan 5 10:42:32 2015 +0100 Bug 13417: Add the permission for all languages Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 4149055445d921e7aec82d847e03e4c35841137b Author: Jonathan Druart Date: Mon Jan 5 10:36:33 2015 +0100 Bug 13417: (qa follow-up) Rename the permission to delete_public_lists Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 70586324c596a608da615de3fa4fb093348c73a7 Author: Jonathan Druart Date: Wed Dec 17 16:27:11 2014 +0100 Bug 13417: Limit the permission to delete It's preferable to limit the permission to delete shelves. Apply both patches before testing, then follow this test plan Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to delete all public lists Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 9c65bd8124ad21a96672c76b0ef1e31f80d7f4f3 Author: Jonathan Druart Date: Fri Dec 5 12:30:08 2014 +0100 Bug 13417: Allow staff members to manage public lists Currently a public list can only be deleted by its owner. This means lists can exist infinitely. This will introduce a new permission for list. With this permission, a staff member will be allow to delete any public lists. Test plan: 1/ Add the manage_shelves permission to a patron. 2/ Login with this patron 3/ Go on the public list view 4/ You should be able to edit all public lists Followed test plan. Works as expected. Signed-off-by: Marc Veron Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit a7da45099f49093cc950a1392d6488543af5ddd3 Author: Owen Leonard Date: Wed Nov 12 14:42:37 2014 -0500 Bug 13142 - Change "mobile phone" label back to "other phone" Labeling a phone number field "mobile phone" eliminates the usefulness of having the labels "primary" and "secondary." Generic labels let the user populate the fields according to their importance rather than their type. To test I recommend editing a patron record so that the values in the patron record contain a label matching the table column: borrowers.phone : 555-555-1234 (primary - phone) borrowers.phonepro : 555-555-5678 (secondary - phonepro) borrowers.mobile : 555-555-9012 (other - mobile) View this patron's information in the various affected templates and verify that the labels correctly match the data: - OPAC "your personal details" (opac-memberentry.pl) - Submit changes to primary, secondary, and other phone via the OPAC. In the staff client, view the confirmation for those changes. - Patron details in the staff client (moremember.pl) - Patron entry/edit in the staff client (memberentrygen.pl) - Patron duplicate confirmation in the staff client (you can navigate directly to /members/moremember.pl?borrowernumber=XXXX&print=brief) Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 7dacb45ce5ae3579283b2449cf32c6656188ecb4 Author: Kyle M Hall Date: Fri Feb 13 11:18:39 2015 -0500 Bug 13545 [QA Followup] - Complete POD documentation Signed-off-by: Tomas Cohen Arazi commit 3c7375685624a818232fa387018436cf7c03d95d Author: Tomas Cohen Arazi Date: Tue Feb 10 12:52:25 2015 -0300 Bug 13545: (followup) POD and error handling This patch adds POD to the new /svc/barcode service, and also implements some error handling. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit ae592bd25a8b52591494f5a75f2db918c55e8617 Author: Kyle M Hall Date: Thu Dec 4 07:48:35 2014 -0500 Bug 13545 - Add barcode image generator service If we add a script to Koha that can be passed a barcode, we will be able to easily embed item and patron barcodes into html printable slips and notices. This can be very helpful for librarians, as it means scanning an image instead of typing in the barcode manually. This patch adds a barcode image generator that can be passed a barcode and an optional type ( defaults to Code39, all GD::Barcode types should work ). This image can be embedded in html slips and notices. ( e.g. ) Test Plan: 1) Apply this patch 2) Browse to /cgi-bin/koha/svc/barcode?barcode=123456789 on your server 3) Note the barcode image Signed-off-by: Brandon Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Barcodes/ValueBuilder.pm | 9 +- C4/VirtualShelves.pm | 10 +- C4/VirtualShelves/Page.pm | 10 +- installer/data/mysql/de-DE/mandatory/userflags.sql | 1 + .../data/mysql/de-DE/mandatory/userpermissions.sql | 3 +- installer/data/mysql/en/mandatory/userflags.sql | 4 +- .../data/mysql/en/mandatory/userpermissions.sql | 3 +- installer/data/mysql/es-ES/mandatory/userflags.sql | 1 + .../data/mysql/es-ES/mandatory/userpermissions.sql | 3 +- .../data/mysql/fr-FR/1-Obligatoire/userflags.sql | 1 + .../mysql/fr-FR/1-Obligatoire/userpermissions.sql | 3 +- installer/data/mysql/it-IT/necessari/userflags.sql | 1 + .../data/mysql/it-IT/necessari/userpermissions.sql | 3 +- .../data/mysql/nb-NO/1-Obligatorisk/userflags.sql | 1 + .../mysql/nb-NO/1-Obligatorisk/userpermissions.sql | 3 +- installer/data/mysql/pl-PL/mandatory/userflags.sql | 3 +- .../data/mysql/pl-PL/mandatory/userpermissions.sql | 3 +- .../ru-RU/mandatory/permissions_and_user_flags.sql | 6 +- .../uk-UA/mandatory/permissions_and_user_flags.sql | 7 +- installer/data/mysql/updatedatabase.pl | 14 +++ koha-tmpl/intranet-tmpl/prog/en/columns.def | 2 +- .../prog/en/modules/members/memberentrygen.tt | 2 +- .../prog/en/modules/members/members-update.tt | 4 +- .../prog/en/modules/members/moremember-brief.tt | 4 +- .../prog/en/modules/members/moremember.tt | 4 +- .../prog/en/modules/virtualshelves/shelves.tt | 4 +- .../bootstrap/en/modules/opac-memberentry.tt | 2 +- kohaversion.pl | 2 +- svc/barcode | 109 ++++++++++++++++++++ 29 files changed, 190 insertions(+), 32 deletions(-) create mode 100755 svc/barcode hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 14 07:50:33 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 14 Feb 2015 06:50:33 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-46-gfe29603 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via fe29603318a559b90ba302437e92315a16a41042 (commit) from 5a310c03ddfff8880c7d607750bc8f52e1f3e5bc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fe29603318a559b90ba302437e92315a16a41042 Author: Mark Tompsett Date: Wed Nov 19 13:28:12 2014 -0500 Bug 11954 - Clean up currency default files It makes no sense to have TRUNCATE or foreign key checks. TEST PLAN --------- 1) Back up your database 2) in an mysql client: use kohadata; SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql SET FOREIGN_KEY_CHECKS=1; QUIT -- These should all work without problem. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 3cf719433597ad6bf558950270cd564a62164ab4) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/it-IT/necessari/parameters.sql | 4 ---- installer/data/mysql/ru-RU/optional/sample_currency.sql | 2 -- installer/data/mysql/uk-UA/optional/sample_currency.sql | 2 -- 3 files changed, 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 14 08:04:36 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 14 Feb 2015 07:04:36 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-52-g49cb53a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 49cb53a07d166cd641c35834d6ab4647ddaf462c (commit) via 1da75880252c7bd483872dc36ffaefce4dfbb6a3 (commit) via 7374934d0a4b5ba5606a1ade8beeb29531d0d6fc (commit) via 004e095d4c43d4fb2f37a2debe85d980f0b8c5b9 (commit) via 74f230a2551f987808cee53cdd2708468cc795dd (commit) via 5e3ef35343249575a679b4300696b83980e732a7 (commit) from fe29603318a559b90ba302437e92315a16a41042 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 49cb53a07d166cd641c35834d6ab4647ddaf462c Author: Chris Cormack Date: Sat Feb 14 20:11:00 2015 +1300 Bumping db version to 3.18.03.002 commit 1da75880252c7bd483872dc36ffaefce4dfbb6a3 Author: Katrin Fischer Date: Tue Dec 30 09:14:15 2014 +0000 Bug - 5511 [Followup]: QA Fixes - Move database update entry to correct spot - Fix version number in database update - Fix capitalization in sys pref description - Fix sequence in sysprefs.sql Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 57d411dcd6a60fa36033a92e6cd1901b0ec7c78d) Signed-off-by: Chris Cormack commit 7374934d0a4b5ba5606a1ade8beeb29531d0d6fc Author: Martin Renvoize Date: Thu Dec 11 13:39:24 2014 +0000 Bug - 5511 [Followup]: Missed Instance There was an instance of the pragma missed which meant the the original patch set didn't actually solve the problem in a large number of cases This patch adds in the relevant statement. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit d556f6a9f2ead235b9daf9df7217ebf2cd2b2b5c) Signed-off-by: Chris Cormack commit 004e095d4c43d4fb2f37a2debe85d980f0b8c5b9 Author: Martin Renvoize Date: Tue Dec 9 13:48:29 2014 +0000 Bug - 5511 [Followup]: Switched defults Agree with Chris that the defualt should maintain the higher security and not reduce it. Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 129fb1fbe211b136ccad4d214ee26b94e988e5e5) Signed-off-by: Chris Cormack commit 74f230a2551f987808cee53cdd2708468cc795dd Author: Amit Gupta Date: Tue Oct 8 09:36:59 2013 +0530 Bug - 5511: Added new system preference: SessionRestrictionByIP Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 2d4d65d526e6f54a40ddec87a6d3207722234fd3) Conflicts: installer/data/mysql/updatedatabase.pl commit 5e3ef35343249575a679b4300696b83980e732a7 Author: Amit Gupta Date: Tue Oct 8 09:33:54 2013 +0530 Bug - 5511: Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. To Test: 1) Enable the system preference SessionRestrictionByIP 2) Change your system IP. It will not checkout your system IP or signout. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit e3bb1390807578e2b9898723e2816a58f2c01e57) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: C4/Auth.pm | 9 +++++---- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl | 7 +++++++ .../prog/en/modules/admin/preferences/admin.pref | 7 +++++++ kohaversion.pl | 2 +- 5 files changed, 21 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 14 08:24:11 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 14 Feb 2015 07:24:11 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-55-gcb56583 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via cb565836b323be2525241759bfd3b45c691d7115 (commit) via 0ddc368620bbb5e4b5246f2e2b9f7aa07b2f0d1f (commit) via 7226f8ced30038d95d73e7389fedd6e76aff3c36 (commit) from 49cb53a07d166cd641c35834d6ab4647ddaf462c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cb565836b323be2525241759bfd3b45c691d7115 Author: Kyle M Hall Date: Thu Feb 5 09:21:12 2015 -0500 Bug 13670 - Patron holds table not loading when holds tab anchor is used If a link to a patron record ends with #reserves, the holds tab is selected on page load, but the holds table does not load. Test Plan: 1) Build your holds queue 2) From the holds queue report, open any patron link 3) Note the patron's reserves do not load 4) Apply this patch 5) Clear your browser cache 6) Repeat step 2 7) Note the holds table now loads Signed-off-by: Sean McGarvey Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 87bcc8b303e506514318814f63c430a3a54f1181) Signed-off-by: Chris Cormack commit 0ddc368620bbb5e4b5246f2e2b9f7aa07b2f0d1f Author: Jonathan Druart Date: Fri Nov 14 16:18:09 2014 +0100 Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber The tests highligh the problem: if the parent_ordernumber attribute is not set on inserting an order, the object returned by the method does not contain the value (undef). Test plan: Verify the tests are consistent and prove t/db_dependent/Acquisition/CancelReceipt.t should return green. You can also verify that receive partially an order and cancel the receipt work as expected. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit f19a1777a0847ce2dc10b7f259bf76fc2d382d19) Signed-off-by: Chris Cormack commit 7226f8ced30038d95d73e7389fedd6e76aff3c36 Author: Kyle M Hall Date: Wed May 21 11:09:04 2014 -0700 Bug 12323 [SIGNED OFF] - Acquisitions search results fixed in order of biblionumber The acquisitions search is exhibiting the same behavior as bug 11410. Results are always fixed in order of biblionumber, among other possible issues ( including the ampersand issue ). Test Plan: 1) From an open basket, choose "Add to basket" 2) Run a search for "From an existing record" 3) Note the "View MARC" URLs are fixed in order of biblionumber 4) Apply this patch 5) Refresh the page 6) Note the results are no longer fixed in order of biblionumber Signed-off-by: David Cook Works as described. I think the code could be a bit tidier, but I think it makes sense to use buildQuery here. It'll detect CCL, CQL, and PQF queries, as well as parsing a regular keyword search as one would expect when searching the catalogue. It also has the added bonus of performing relevance searching, so long as QueryAutoTruncation is off, and so long as library staff avoid using the "*" truncation wildcard (see bug 12430). While there are simpler ways to fix this acq bug, I think this was probably the best move, as it adds a bit to the consistency of what librarians can expect from their search results. Signed-off-by: Jonathan Druart Same result with and without the patch but I agree with the changes. BuildQuery should be called before SimpleSearch if QP is not used. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit dc5b94486304fc5353640c0341cdfa11d3367fb2) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: Koha/Acquisition/Order.pm | 3 +- acqui/neworderbiblio.pl | 13 ++++++-- koha-tmpl/intranet-tmpl/prog/en/js/holds.js | 13 +++++--- t/db_dependent/Acquisition/CancelReceipt.t | 44 +++++++++++++++++++++++++-- 4 files changed, 64 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 14 08:30:39 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 14 Feb 2015 07:30:39 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-57-gfa74808 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via fa74808736d9aea8df6fff1bf9e146c62d95046c (commit) via 38663a4af3e4bbb43a46d0f723cb243dc30eba5e (commit) from cb565836b323be2525241759bfd3b45c691d7115 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit fa74808736d9aea8df6fff1bf9e146c62d95046c Author: Jacek Ablewicz Date: Tue Dec 30 10:30:30 2014 +0100 Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues 1) Removed 'use C4::Context;' because it can lead to introduction of circular reference in the near future 2) Put fastmmap initialization code into an eval {} block, to catch various kinds of errors which can still occur during it's init in some [less usual] Koha setups and/or more unusual circumstances 3) Do not include UID in the sharefile name (it will be constructed using namespace + database name + database host instead). Test plan addendum: s/and UID// Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit dbf0b358b9362fdf634b47569b1777d7034b17a9) Signed-off-by: Chris Cormack commit 38663a4af3e4bbb43a46d0f723cb243dc30eba5e Author: Jacek Ablewicz Date: Tue Dec 16 12:48:09 2014 +0100 Bug 13431 - Shared FastMmap file causes issues Koha::Cache package does not take into account that, when using fastmmap caching variant, mmaped cache file created in /tmp (typically: /tmp/sharefile-koha-koha), would only be further accessible to the one given OS user - the one which created it. In many Koha setups, in the circumstances when various system scripts are executed by 2+ users with diffrent UIDs (like multi-tenant servers, for example) this may cause many kinds of issues. Observable symptom is usually the appearance of the below error when searching, or looking at MARC Framework pages and a few other places: Open of share file /tmp/sharefile-koha-koha failed: Permission denied at /usr/lib/perl5/Cache/FastMmap.pm line 640. This patch: - disables initialisation of fastmmap caching subsystem unless it is explicitly requested by the user (CACHING_SYSTEM=fastmmap) - disables fastmmap cache usage for command line scripts (i.e. when GATEWAY_INTERFACE environment variable is not defined) - adds the database name, host name and an ID of the OS user to the mmaped file name created in /tmp, to prevent various kinds of unintentional conflicts and/or permission problems from happening To test: 1) remove the /tmp/sharefile-koha-* file[s] (if any) 2) do something which would lead to its re-creation (e.g., performing any search in OPAC should be sufficient to cause that) 3) observe that /tmp/sharefile-koha-koha got created 4) remove it 5) apply patch 6) redo step 2) 7) observe that aforementioned file is no longer created in /tmp 8) set CACHING_SYSTEM environment variable to 'fastmmap' 9) redo step 2), observe that /tmp/sharefile-koha-* file got created and that it's name now contains hostname, database name and UID 10) ensure that everything still works like it should and that there are no regressions of any kinds anywhere in the system ;) Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 9e701294dd6ccf4fa5d8b24d1a7da15be353992e) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: Koha/Cache.pm | 35 ++++++++++++++++++++++++++--------- 1 file changed, 26 insertions(+), 9 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 14 09:08:17 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 14 Feb 2015 08:08:17 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-60-g544c59c Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 544c59cb22b12c914968fe9a69b49184be9fdcb7 (commit) via 41e419e3172497dd71b6de49d3996612d071191d (commit) via e8c4bd8ab4e8986bfe2cfae58e9b14ac666bfe3f (commit) from fa74808736d9aea8df6fff1bf9e146c62d95046c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 544c59cb22b12c914968fe9a69b49184be9fdcb7 Author: Jonathan Druart Date: Wed Nov 26 15:14:59 2014 +0100 Bug 13343: Embed items when send a basket/shelf When a basket/shelf is downloaded, items are embedded, but not when sending it by email. We would expect to get the same file. Test plan: On Opac and intranet: 1/ Add records with items to your basket and send it by email. Verify the file contains items. 2/ Add records with items to a list and send it by email. Verify the file contains items. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit a0e5d77a719443c6616194a898795f70d34d6ebc) Signed-off-by: Chris Cormack commit 41e419e3172497dd71b6de49d3996612d071191d Author: Kyle M Hall Date: Tue Nov 25 10:16:47 2014 -0500 Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing No matter what the selection of OPACShowHoldQueueDetails is, if it is enabled it displays a line "Holds and priority:" even if you've opted to hide one of those! Test Plan: 1) Apply this patch 2) Test each setting of OPACShowHoldQueueDetails 3) Ensure each setting displays the correct fields ( or lack thereof ) Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 295fb70f62069c0b1fbed2d9bbdf2650f58e488c) Signed-off-by: Chris Cormack commit e8c4bd8ab4e8986bfe2cfae58e9b14ac666bfe3f Author: Kyle M Hall Date: Wed Jan 28 08:31:30 2015 -0500 Bug 13636 - Staff search results item status incorrect for holds Imagine this scenario: we have one record with four items. Two of those items are checked out, one of those items is a waiting hold, and one of those items is available. We would expect to see this on the search results page. Instead, we will see both non-checked out items as unavailable due to waiting holds. This is due to a semantic issue GetReserveStatus. C4::Search::searchResults uses GetReserveStatus to get the reserve status of each item, but unlike all other calls to the sub, this one passes in not only itemnumber, but biblionumber. When no reserve is found for the available item, the subroutine uses the biblionumber to grab what is essentially an arbitrary reserve to use for the status. This makes no sense and this functionality should be entirely removed from the subroutine so regressions like this will be prevented in the future. Test Plan: 1) Create one record with 4 items a) check two of the items out to patrons b) set one of the items as a waiting hold c) leave the fourth item as available 2) Run a search where this record will be in the results list 3) Note that the results list 2 items on loan, two unavailable 4) Apply this patch, reload the search results 5) Note that the results list 1 available, 2 on loan, 1 unavailable Signed-off-by: John Andrews Signed-off-by: Sheila Kearns Signed-off-by: Katrin Fischer Note: This is for the staff search result list! Works as expected. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit fcaa6f35c080c079ba422a70dec49ca327346c82) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: C4/Reserves.pm | 12 +++--------- C4/Search.pm | 2 +- basket/sendbasket.pl | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 16 +++++++++++----- opac/opac-reserve.pl | 2 -- opac/opac-sendbasket.pl | 2 +- opac/opac-sendshelf.pl | 2 +- virtualshelves/sendshelf.pl | 2 +- 8 files changed, 19 insertions(+), 21 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sat Feb 14 09:21:56 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sat, 14 Feb 2015 08:21:56 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-62-ga3189a6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via a3189a6f68cf2812849573c8ec64ff76d9fa593d (commit) via f9a2751aaa94b6499d6ac14a92dab93a256f68d3 (commit) from 544c59cb22b12c914968fe9a69b49184be9fdcb7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a3189a6f68cf2812849573c8ec64ff76d9fa593d Author: Kyle M Hall Date: Tue Jan 20 10:11:24 2015 -0500 Bug 13603 - autoBarcode setting hbyymmincr not taking month into account when looking up next increment The hbyymmincr autoBarcode builder looks up all barcodes that begin with any number of letters ( the branchcode ) and a two-digit year directly afterward ( e.g. MPL15 ), then grabs the last four digits as the increment counter. The problem is, this does not take months into account, so unlike the description that says the system is limited to 10,000 items a month, it is limited to 10,000 items per *year*. This situation can easily be corrected my adding the month into the lookup ( e.g. MPL1501 ). Test Plan: 1) Enable autoBarcode, set to hbyymmincr 2) Catalog an item, let the barcode.pl plugin generate the next barcode. 3) Catalog an item with the barcode MPL15009999 4) Catalog another item, use the barcode.pl plugin to generate the next barcode. 5) Note the barcode is generated ends with '0001' instead of the correct increment 6) Apply this patch 7) Repeat step 4 8) Note the barcode now ends with the correct increment Signed-off-by: Kyle M Hall Signed-off-by: Jeanne Heicher Signed-off-by: Katrin Fischer Problem confirmed - the continuing number bit was not reset to start counting from 1 again on the beginning of a new month. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit b280b4890c813b5535b6e98b27c390d9af10551a) Signed-off-by: Chris Cormack commit f9a2751aaa94b6499d6ac14a92dab93a256f68d3 Author: Owen Leonard Date: Wed Nov 12 14:42:37 2014 -0500 Bug 13142 - Change "mobile phone" label back to "other phone" Labeling a phone number field "mobile phone" eliminates the usefulness of having the labels "primary" and "secondary." Generic labels let the user populate the fields according to their importance rather than their type. To test I recommend editing a patron record so that the values in the patron record contain a label matching the table column: borrowers.phone : 555-555-1234 (primary - phone) borrowers.phonepro : 555-555-5678 (secondary - phonepro) borrowers.mobile : 555-555-9012 (other - mobile) View this patron's information in the various affected templates and verify that the labels correctly match the data: - OPAC "your personal details" (opac-memberentry.pl) - Submit changes to primary, secondary, and other phone via the OPAC. In the staff client, view the confirmation for those changes. - Patron details in the staff client (moremember.pl) - Patron entry/edit in the staff client (memberentrygen.pl) - Patron duplicate confirmation in the staff client (you can navigate directly to /members/moremember.pl?borrowernumber=XXXX&print=brief) Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit a7da45099f49093cc950a1392d6488543af5ddd3) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: C4/Barcodes/ValueBuilder.pm | 9 +++++---- koha-tmpl/intranet-tmpl/prog/en/columns.def | 2 +- .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- .../intranet-tmpl/prog/en/modules/members/members-update.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/members/moremember-brief.tt | 4 ++-- koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 4 ++-- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- 7 files changed, 14 insertions(+), 13 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Feb 15 06:46:58 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 15 Feb 2015 05:46:58 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-64-g0085f89 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 0085f89df9ff2f8c5b3c364da6a7994376914a43 (commit) via d469db4b387cb9dd8111034ffa65fde58734d9e6 (commit) from a3189a6f68cf2812849573c8ec64ff76d9fa593d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0085f89df9ff2f8c5b3c364da6a7994376914a43 Author: Katrin Fischer Date: Sun Feb 8 16:23:41 2015 +0100 Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)" Signed-off-by: Chris Cormack commit d469db4b387cb9dd8111034ffa65fde58734d9e6 Author: Jonathan Druart Date: Mon Jan 26 10:28:27 2015 +0100 Bug 13352: On editing, prices should not be formatted Bug 12979 refactored the way to display prices. The price format configuration was duplicated everywhere it was used. All calls looks good except the one in admin/aqbudgetperiods.pl In this one, the prices are formatted for an edition field (input). This means the input is incorrectly filled even if the user does not update the field. At the end, maybe should we manage formatted prices everywhere, even in inputs, but it's not in the scope of this bug. Technically, a new subroutine format_for_editing is added to the Koha::Number::Price module. It should be called everywhere a price is displayed in an input field. At the moment, it only does a sprintf("%.2f"), but it is a first step to let the number of decimals to display configurable. To test: 1/ Verify the issue described is fixed (editing a budget with a total amount > 1000 (With CurrencyFormat is US or FR). 2/ Verify you can edit a fund with a total amount > 1000 Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: Koha/Number/Price.pm | 15 +++++++++++++++ Koha/Template/Plugin/Price.pm | 9 +++++++-- admin/aqbudgetperiods.pl | 5 ----- admin/aqbudgets.pl | 1 - .../prog/en/modules/admin/aqbudgetperiods.tt | 7 +++---- .../intranet-tmpl/prog/en/modules/admin/aqbudgets.tt | 6 +++--- 6 files changed, 28 insertions(+), 15 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 17 03:37:29 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 17 Feb 2015 02:37:29 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-339-g6b12857 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6b12857de2ee915b8d4cf1ef78e212ed9e1d53b1 (commit) via 82f62dc9c6d0a608c3667e67b935c9f1e8522042 (commit) via 957e65c748359e5dbbed176b564a578d84479821 (commit) via 39c22b1a6a744d6b4c50c3a4b62295ab3a601636 (commit) via b678301e46c92cb10a5813da013e25467738e363 (commit) from b280b4890c813b5535b6e98b27c390d9af10551a (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6b12857de2ee915b8d4cf1ef78e212ed9e1d53b1 Author: Owen Leonard Date: Tue Dec 9 13:00:02 2014 -0500 Bug 7741 [Follow-up] Clear search terms in Z3950 search page This patch makes a follow-up change and takes as its basis a dependency on Bug 13218 - usability enhancement for z39.50 search. If we have a one-column search form it's possible to put the "Clear search form" link at the bottom of the form rather than in the header, logically associating it with the grouping of form fields which will be affected. Doing so also allows us to eliminate all the custom styling which was an issue for QA. Other changes made by this patch: Fixing the indentation error, correcting the case of the link text ("Clear search form" instead of "Clear Search Form"), and adding "preventDefault()" to the click handler so that clicking the link doesn't scroll the user back to the top of the page. To test, apply the previous patch and this one on top of Bug 13218. Repeat the test plan. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 82f62dc9c6d0a608c3667e67b935c9f1e8522042 Author: Thomas Misilo Date: Tue Dec 2 20:15:07 2014 -0500 Bug 7741: Added Clearing Capability to the Z39.50 Search fields Tested in: /koha/cataloguing/z3950_auth_search.pl (Home:Authorities:New from Z39.50) /koha/cataloguing/z3950_search.pl (Home:Cataloging:New from Z39.50/SRU) /koha/acqui/z3950_search.pl (Home:Acquisitions:[Bookshop]:[Basket]:Order from external source) All three forms can now be cleared. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 957e65c748359e5dbbed176b564a578d84479821 Author: Kyle M Hall Date: Thu Feb 5 12:19:38 2015 -0500 Bug 13672 - OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords It appears that an empty string is sneaking into the list of words to highlight and that is causing the browser to freak out. Test Plan: 1) Enable NoveList 2) Enable OpacHighlightedItems 3) Search a title with a series (i.e. The Hunger Games) 4) Click into the record 5) Click on the series to search it 6) Click on a title in the search results 7) If Firefox doesn't crash, it gives the unresponsive script message 8) Apply this patch 9) Repeat steps 3-6 10) Browser doesn't freak our Signed-off-by: Jason Robb Signed-off-by: Katrin Fischer could not confirm the problem, but small change and highlighting terms on result list and couldn't find any regressions in highlighting. Signed-off-by: Tomas Cohen Arazi commit 39c22b1a6a744d6b4c50c3a4b62295ab3a601636 Author: Julian Maurice Date: Fri Feb 13 13:30:56 2015 +0100 Bug 13700: Fix item search templates for translation Since translator rebuild HTML tags with double quotes for attributes values, use double quotes in english template too and escape them with backslash. Signed-off-by: Bernardo Gonzalez Kriegel It works well!! Test: 1) Intall translation (de-DE, es-ES) 2) to Go to item search, in english, do a search that gives results 3) Switch language, repeat search, result's table does not render 4) Apply patch 5) Install translation again 6) Repeat 3, now results are displayed No koha-qa errors Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit b678301e46c92cb10a5813da013e25467738e363 Author: Jonathan Druart Date: Mon Feb 9 17:43:48 2015 +0100 Bug 13684: C4::Budgets should not be used in C4::Output Bug 12844 removed the call to C4::Budgets::GetCurrency. The use of this module can be completely removed from C4::Output. Signed-off-by: Tomas Cohen Arazi It makes sense and no runtime errors found. Signed-off-by: Katrin Fischer ----------------------------------------------------------------------- Summary of changes: C4/Output.pm | 1 - .../prog/en/includes/catalogue/itemsearch_item.json.inc | 12 +++++++++--- .../intranet-tmpl/prog/en/modules/acqui/z3950_search.tt | 5 +++++ .../prog/en/modules/cataloguing/z3950_auth_search.tt | 5 +++++ .../prog/en/modules/cataloguing/z3950_search.tt | 5 +++++ koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 1 + 6 files changed, 25 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 19 14:03:55 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 19 Feb 2015 13:03:55 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-348-gb5721e8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b5721e8758d8fa002a5006ef828cdbe48ce1ec64 (commit) via 82a100abb56a19d9eb6610ccf677759dd3a99376 (commit) via 7e94b04eabdbb4877bb53eddb4750fd9ba594d58 (commit) via 7a1d9250bb72aa3f2fc9744d2e7ff2bd106d456f (commit) via f1ea9624bd197b04f78750bcc4d8f07ef2f9675d (commit) via 407e9c163a2fe338c1b567f36511f363c7216490 (commit) via aed056a636dd8b5231b8484ba9a8531c5d84f740 (commit) via d374d87b417f77a22679571ee054a358a2438123 (commit) via 4318eeef5ffed524513b803855dd0afe565e320c (commit) from 6b12857de2ee915b8d4cf1ef78e212ed9e1d53b1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b5721e8758d8fa002a5006ef828cdbe48ce1ec64 Author: Jonathan Druart Date: Fri Nov 14 15:44:46 2014 +0100 Bug 12970: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 82a100abb56a19d9eb6610ccf677759dd3a99376 Author: Jonathan Druart Date: Thu Sep 25 16:39:11 2014 +0200 Bug 12970: Cancelled orders Previous patch does modify the code for cancelled orders. Test plan: Cancel 1+ orders and verify the prices are correct (i.e. the same as the non-cancelled orders) and that the prices are formated. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 7e94b04eabdbb4877bb53eddb4750fd9ba594d58 Author: Jonathan Druart Date: Thu Sep 25 16:32:01 2014 +0200 Bug 12970: Format totals The total values should be formated too. Test plan: 1/ Go on the basket page 2/ Using the CurrencyFormat, verify the totals are correctly formated. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 7a1d9250bb72aa3f2fc9744d2e7ff2bd106d456f Author: Jonathan Druart Date: Fri Sep 19 17:09:34 2014 +0200 Bug 12970: Use the centralize VAT and prices calculation - basket.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/basket.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Go on the basket page 4/ Apply the patch 5/ Verify you don't see any difference before and after applying the patch Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit f1ea9624bd197b04f78750bcc4d8f07ef2f9675d Author: Fr?d?ric Demians Date: Mon Jan 12 12:18:19 2015 +0100 Bug 13568 OAI Server doesn't handle properly resumption token When responding to ListRecords and ListIdentifiers verbs, OAI server doesn't return proper resumption token. At the end of a result set, OAI server generates a resumption token even if there isn't anymore records. Consequently, OAI harverster will send a new request, based on this invalid resumption, token. OAI Server responds with an empty resultset, which is considered as an invalid response by most of the harvesters. TO TEST: - Find in your DB, a day where a few biblio records have been created. The number of created biblios must inferior to OAI-PMH:MaxCount. - Let say this day is 2014-01-09. Send an OAI-PMH request to Koha OAI Server: /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2014-01-09&until=2014-01-09 - At the end of the result, you will see a resumption token which looks like that: marcxml/47/2014-01-09/2014-01-09/ This is wrong. No resumptiion token should be sent since there isn't anymore records to harvest. - Apply the patch. - Resend the OAI-PMH request. There is no resumption token at the end of the result. - You could test also with ListIdenfiers verb in place of ListRecord. Signed-off-by: Christophe Brocquet Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 407e9c163a2fe338c1b567f36511f363c7216490 Author: Magnus Enger Date: Mon Feb 16 10:50:17 2015 +0100 Bug 13712 - Missing newline in DB update 3.19.00.010 To test: - Make sure your database is pre 3.19.00.010 (for example by loading in an older backup) - Run through the web-based database update (web installer, step 3) - Verify that updates 3.19.00.010 and 3.19.00.011 are squashed together on one line - Apply the patch - Reset the database and run the web-based database upgrade again - Verify that the two uupdates are noe displayed on separate lines (as separate bullet points) Signed-off-by: Tomas Cohen Arazi commit aed056a636dd8b5231b8484ba9a8531c5d84f740 Author: Jonathan Druart Date: Mon Nov 17 12:45:22 2014 +0100 Bug 12976: Fix some comment in tests Previous comments were wrong. Actually the main part of price values is correct. Only some rounding and tax values are badly calculated. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit d374d87b417f77a22679571ee054a358a2438123 Author: Jonathan Druart Date: Fri Nov 14 15:51:24 2014 +0100 Bug 12976: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 4318eeef5ffed524513b803855dd0afe565e320c Author: Jonathan Druart Date: Mon Sep 22 17:10:10 2014 +0200 Bug 12976: Use the centralize VAT and prices calculation - invoice.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/invoice.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Receive the items and create an invoice 4/ Go on the invoice page acqui/invoice.pl?invoiceid=XXX 5/ Verify you don't see any difference before and after applying the patch on the invoice details table. Note: The only different you should see is the price formating for "Total tax exc.". Before this patch "432.10" was displayed "432.1". Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 35 ++-- acqui/basket.pl | 43 ++-- acqui/invoice.pl | 34 ++-- installer/data/mysql/updatedatabase.pl | 2 +- .../intranet-tmpl/prog/en/modules/acqui/basket.tt | 47 ++--- .../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 33 ++-- opac/oai.pl | 64 +++--- t/Prices.t | 208 +++++++++++++++++++- 8 files changed, 323 insertions(+), 143 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 19 15:09:41 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 19 Feb 2015 14:09:41 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-349-g6b26f88 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6b26f8858e5069a2fae21fb28692a8eeb37fa0a8 (commit) from b5721e8758d8fa002a5006ef828cdbe48ce1ec64 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6b26f8858e5069a2fae21fb28692a8eeb37fa0a8 Author: Tomas Cohen Arazi Date: Wed Feb 18 12:27:20 2015 -0300 Bug 13728: koha-translate -l -a shows po files instead of language codes This patch corrects the call to 'basename' inside the script so it correctly shows the language code when asked to list the available languages. To test: - On a packages install, run: $ koha-translate --list --available => FAIL: It shows: am-Ethi-opac-bootstrap.po ar-Arab-opac-bootstrap.po az-AZ-opac-bootstrap.po be-BY-opac-bootstrap.po ben-opac-bootstrap.po ... - Apply the patch - Copy the patched debian/scripts/koha-translate script to your packages setup. - Run: $ koha-translate --list --available => SUCCESS: It shows: am-Ethi ar-Arab az-AZ be-BY ben ... - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-translate | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 20 15:05:18 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 20 Feb 2015 14:05:18 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-358-g8770d37 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 8770d37de70ea935702139ca955b4dd9d4ff38fa (commit) via 9cc7ac68e1c2993b7780a6fe1c361ddd434a595b (commit) via 79e1008cef66345106328487c712ef6dde7f3507 (commit) via acc7da6a5f93e12704acdfd7981481c9ef07904b (commit) via a303cdec4871d3d3740d419c972eea7faf8e5a8a (commit) via 8804598f3dcff3ccacc34723939cf072d8451fac (commit) via f82064286d3bc97031ad784901716a7a327839bc (commit) via e8f9000fcca4fd542f7f82e2288d3a627053dd77 (commit) via 07f9dd9f8c2abb43a031c91449661a779ff53746 (commit) from 6b26f8858e5069a2fae21fb28692a8eeb37fa0a8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8770d37de70ea935702139ca955b4dd9d4ff38fa Author: Jonathan Druart Date: Thu Feb 19 15:50:37 2015 +0100 Bug 13593: (follow-up) 'stock number' should be 'inventory number' Add one more. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 9cc7ac68e1c2993b7780a6fe1c361ddd434a595b Author: Katrin Fischer Date: Sun Jan 18 20:04:15 2015 +0100 Bug 13593: 'stock number' should be 'inventory number' To make Koha easier to use, we should use terms consistently. This patch fixes some occurrences of 'stock number' to be 'inventory number' as this is also the term used in the frameworks. Item search, accessible via the link from staff's advanced search 1) Do a search for items, but choose CSV as output 2) Verify that the header row says 'inventory number' Acquisition 3) Set AcqCreateItem to 'order' 4) Create a new order, check the labels on the item table in the order 5) Receive the order, check the labels on the item table on receive 6) Set AcqCreateItem to 'receive' 7) Check the item table on receiving an order Followed test plan (including item search with JavaScipt disabled). Headers / labels display as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 79e1008cef66345106328487c712ef6dde7f3507 Author: Kyle M Hall Date: Fri Feb 20 07:23:15 2015 -0500 Bug 12858 [QA Followup] - Don't call webservice if we have no data Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit acc7da6a5f93e12704acdfd7981481c9ef07904b Author: Martin Renvoize Date: Tue Sep 2 09:14:03 2014 +0000 Bug 12858: Add error handling to Syndetics Index * Syndetics routines include a statement to check that the returned content from Syndetics is xml. The get_syndetics_index routine was missing this check and so when a 'not found' html page was returned the opac-detail page would take a long time to load whilst xml::simple attempted to parse the large html document. Test Plan 1. Enable Syndetics indexes on opac. 2. Head over to an opac-detail page on the opac. 3. Remove the ISBN from the same item in the staff client. 4. Reload the opac-detail page for the item noticeing a much slower page load. 5. Apply the patch 6. Reload the opac-detail page for the item and note that it now laods in a reasonable timescale again. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit a303cdec4871d3d3740d419c972eea7faf8e5a8a Author: Martin Renvoize Date: Mon Jan 19 13:48:42 2015 +0000 BUG 13596: Prevent utf8mb4 -> utf8 convertion utf8mb4 is a superset of utf8 and thus is compatible. We should not force an entire db change upon people who have proactively set utf8mb4 encoding before now. This patch also removed the deprecated use of ->tables stanza in favour of the table_info stanza. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 8804598f3dcff3ccacc34723939cf072d8451fac Author: Marc V?ron Date: Tue Feb 10 18:16:45 2015 +0100 Bug 13682 - Capitalization: Holds Queue This patch changes capitalization of Holds Queue to Holds queue in koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueu$ To test: Apply patch Go to Circulation > Holds queue page Verify that the capitalization is correct Signed-off-by: Magnus Enger Works as advertised. Signed-off-by: Tomas Cohen Arazi commit f82064286d3bc97031ad784901716a7a327839bc Author: Jonathan Druart Date: Tue Sep 16 13:15:57 2014 +0200 Bug 12669: Centralize the timezone handle into Koha::DateUtils This patch adds unit tests for the previous changes and centralize the timezone handle into the Koha::DateUtils module. Like that the behavior will affect all date manipulations using this module (should be all dates in Koha). Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit e8f9000fcca4fd542f7f82e2288d3a627053dd77 Author: Rolando Isidoro Date: Fri Aug 1 09:42:30 2014 +0100 Bug 12669: Use floating timezone when handling dates without hours, minutes and seconds. Test plan: 1. Create a new serial record or pick an existing one; 2. Add a "New subscription" and set the "First issue publication date" and "Frequency" values so that the "Planned date" for a given issue hits a day where a transition to Daylight Saving Time (DST) occurs ex:. 1979-04-01 in Europe/Lisbon (http://www.timeanddate.com/time/change/portugal/lisbon?year=1979) ... use this website page as a source http://www.timeanddate.com/time/dst/2014.html to find a suitable transition to DST in your timezone in the current year. 3. From the "Subscription detail" page in Koha for the given record click the "Serial collection" link on the left side context menu. Expected result: Prior to applying the patch the error described in this bug report should occur. After the patch is applied the "Serial collection" page should load correctly. Signed-off-by: Colin Campbell Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 07f9dd9f8c2abb43a031c91449661a779ff53746 Author: Chris Cormack Date: Sat Feb 7 17:04:40 2015 +1300 Bug 13679 : Bug in listing overdues To test 1/ Create some overdues and some issues due in the future 2/ Run the overdues script 3/ Notice item due in the future is in the list 4/ Apply patch 5/ Run script again 6/ Notice in the future not in the list Signed-off-by: Nick Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/External/Syndetics.pm | 9 ++++-- Koha/DateUtils.pm | 27 +++++++++++++----- Koha/Template/Plugin/KohaDates.pm | 2 ++ installer/data/mysql/updatedatabase.pl | 14 ++++++--- .../en/includes/catalogue/itemsearch_items.inc | 2 +- .../prog/en/modules/acqui/neworderempty.tt | 2 +- .../prog/en/modules/acqui/orderreceive.tt | 4 +-- .../prog/en/modules/catalogue/itemsearch.csv.tt | 2 +- .../prog/en/modules/circ/view_holdsqueue.tt | 2 +- misc/cronjobs/overdue_notices.pl | 2 ++ t/DateUtils.t | 22 +++++++++++++- t/db_dependent/Koha_template_plugin_KohaDates.t | 30 ++++++++++++++++---- 12 files changed, 93 insertions(+), 25 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 20 15:45:16 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 20 Feb 2015 14:45:16 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-361-gc29a53e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via c29a53ea20d668f135c62abbc7dda1bf282be8f0 (commit) via bf89e306a86c440a3296fc89436ad5e854ea4f34 (commit) via c52bc9756a5fa1e4f6bba7ce5c58124f150c5efc (commit) from 8770d37de70ea935702139ca955b4dd9d4ff38fa (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit c29a53ea20d668f135c62abbc7dda1bf282be8f0 Author: Zeno Tajoli Date: Sun Feb 15 17:40:06 2015 +0100 Bug 12948: Use word indexing for language (MARC21) This patch is for MARC21. To test: 1)Setup a site with MARC21 2)Insert 2 record, one lang A in 041 and 008 pos 35-37 an other with lang A in 041 and lang B in 008 pos 35-37 3)Index them 4)Search in advanced search with filter 'languare' for lan A. You will see 2 records 5)Search in advanced search with filter 'languare' for lan B. You will see 0 records 6)Apply the patch 7)Full reindex 8)Search in advanced search with filter 'languare' for lan B. You will see 1 records http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger I have *not* actually tested this, but the changes are identical to the ones done for NORMARC, which I have tested, so I think it is safe to sign off. If anyone disagrees, please reset the bug to "Needs signoff". Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit bf89e306a86c440a3296fc89436ad5e854ea4f34 Author: Zeno Tajoli Date: Sun Feb 15 17:54:48 2015 +0100 Bug 12948: Use word indexing for language (NORMARC) This patch is for Normarc Same test plan as patch for MARC21, except you need a setup with Normarc. http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger - Added a record with "bul" in 008pos35-37 - Verified that this did not turn up in an advanced search with language = Bulgarian - Applied the patch - I was testing on a gitified install, so I had to copy the patched index file to the right location with this command: sudo cp etc/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl - Did a full reindex - Verified that the record *did* turn up in an advanced search with language = Bulgarian - Signing off! Thanks Zeno! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit c52bc9756a5fa1e4f6bba7ce5c58124f150c5efc Author: Jonathan Druart Date: Tue Feb 10 11:34:10 2015 +0100 Bug 13690: use Koha::Schema only when it's needed This patch makes Koha::Database lazy-load the whole Koha::Schema libraries. It doesn't seem to have negative effects, and makes scripts not using DBIx::Class notably faster [1]. Regards [1] If you read the DBIx::Class::Schema docs, it explains that it it uses Module::Find to load all schema files... http://search.cpan.org/~ribasushi/DBIx-Class-0.082810/lib/DBIx/Class/Schema.pm#load_namespaces Signed-off-by: Tomas Cohen Arazi Happy to sign this one. The only extra comment would be that DBIx::Class performance issues remain after this patch, but is being handled in a different bug. Signed-off-by: Kyle M Hall ----------------------------------------------------------------------- Summary of changes: Koha/Database.pm | 2 +- etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml | 4 ++-- etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl | 2 +- etc/zebradb/marc_defs/normarc/biblios/biblio-koha-indexdefs.xml | 4 ++-- etc/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 20 19:41:31 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 20 Feb 2015 18:41:31 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-366-g00f27cb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 00f27cb0b9fb200a06da461371e04be1501ca107 (commit) via 4883835816ebce164ec336f9adcd4c925f9244b4 (commit) via 354ee6d427e3ec8fc926d7fb793141a127733258 (commit) via 5db89aa1e93b3156989e55179f8d7295833e3c12 (commit) via 5568f55a6ca4a0190c89f26d2bd8b2640115ec46 (commit) from c29a53ea20d668f135c62abbc7dda1bf282be8f0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 00f27cb0b9fb200a06da461371e04be1501ca107 Author: Kyle M Hall Date: Fri Feb 20 09:54:35 2015 -0500 Bug 13645 [QA Followup] - Add DBIx::Connector to the list of dependancies Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Nice catch Kyle, I changed it to require Ubuntu 12.04's commit 4883835816ebce164ec336f9adcd4c925f9244b4 Author: Jonathan Druart Date: Tue Feb 10 10:47:05 2015 +0100 Bug 13645: Use DBIx::Connector Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit 354ee6d427e3ec8fc926d7fb793141a127733258 Author: Jonathan Druart Date: Fri Jan 30 17:10:54 2015 +0100 Bug 13645: Cache the DBIx connection We don't want to recreate a new connection to the DB every time we want a new schema. This patch creates a $database package level variable on the same way it's done in C4::Context for $dbh. Signed-off-by: Jacek Ablewicz Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit 5db89aa1e93b3156989e55179f8d7295833e3c12 Author: Kyle M Hall Date: Fri Feb 20 08:52:07 2015 -0500 Bug 13506 [QA Follouwp] - Fix POD Signed-off-by: Tomas Cohen Arazi commit 5568f55a6ca4a0190c89f26d2bd8b2640115ec46 Author: Colin Campbell Date: Fri Jan 2 09:58:55 2015 +0000 Bug 13506: Remove unused Sip/Configuration Classes Sip::Configuration calls new on Account, Institution and Service classes but does not store or subsequently use the returned objects ( which immediately go out of scope ). Their existence just obscures the code and misleads the reader. Remobe them Removed redundant commented out code from Configyration module which was not serving any useful purpose Ran Configuration.pm through perltidy to make layout more consistent Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Context.pm | 11 +++-- C4/Installer/PerlDependencies.pm | 5 ++ C4/SIP/ILS.pod | 11 ++--- C4/SIP/Sip/Configuration.pm | 82 ++++++++++++------------------- C4/SIP/Sip/Configuration/Account.pm | 38 -------------- C4/SIP/Sip/Configuration/Institution.pm | 58 ---------------------- C4/SIP/Sip/Configuration/Service.pm | 23 --------- Koha/Database.pm | 20 ++++---- t/db_dependent/Koha_Database.t | 8 ++- 9 files changed, 66 insertions(+), 190 deletions(-) delete mode 100644 C4/SIP/Sip/Configuration/Account.pm delete mode 100644 C4/SIP/Sip/Configuration/Institution.pm delete mode 100644 C4/SIP/Sip/Configuration/Service.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Feb 22 23:43:19 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 22 Feb 2015 22:43:19 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-65-gcc5dfd1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via cc5dfd1039511e156af921bfa2ac6bdb7eb85677 (commit) from 0085f89df9ff2f8c5b3c364da6a7994376914a43 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cc5dfd1039511e156af921bfa2ac6bdb7eb85677 Author: Bernardo Gonzalez Kriegel Date: Sun Feb 22 19:13:10 2015 -0300 Translation updates for Koha 3.18.04 release ----------------------------------------------------------------------- Summary of changes: .../po/am-Ethi-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/am-Ethi-opac-bootstrap.po | 152 +- misc/translator/po/am-Ethi-pref.po | 12 + misc/translator/po/am-Ethi-staff-help.po | 2 +- .../po/ar-Arab-i-staff-t-prog-v-3006000.po | 2542 ++--- misc/translator/po/ar-Arab-opac-bootstrap.po | 163 +- misc/translator/po/ar-Arab-pref.po | 40 +- misc/translator/po/ar-Arab-staff-help.po | 2 +- .../po/az-AZ-i-staff-t-prog-v-3006000.po | 2443 ++--- misc/translator/po/az-AZ-opac-bootstrap.po | 154 +- misc/translator/po/az-AZ-pref.po | 12 + misc/translator/po/az-AZ-staff-help.po | 2 +- .../po/be-BY-i-staff-t-prog-v-3006000.po | 2467 ++--- misc/translator/po/be-BY-opac-bootstrap.po | 153 +- misc/translator/po/be-BY-pref.po | 12 + misc/translator/po/be-BY-staff-help.po | 2 +- misc/translator/po/ben-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/ben-opac-bootstrap.po | 152 +- misc/translator/po/ben-pref.po | 12 + misc/translator/po/ben-staff-help.po | 2 +- .../po/bg-Cyrl-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 152 +- misc/translator/po/bg-Cyrl-pref.po | 12 + misc/translator/po/bg-Cyrl-staff-help.po | 2 +- .../po/ca-ES-i-staff-t-prog-v-3006000.po | 2444 ++--- misc/translator/po/ca-ES-opac-bootstrap.po | 154 +- misc/translator/po/ca-ES-pref.po | 12 + misc/translator/po/ca-ES-staff-help.po | 2 +- .../po/cs-CZ-i-staff-t-prog-v-3006000.po | 2526 ++--- misc/translator/po/cs-CZ-opac-bootstrap.po | 158 +- misc/translator/po/cs-CZ-pref.po | 18 +- misc/translator/po/cs-CZ-staff-help.po | 19 +- .../po/da-DK-i-staff-t-prog-v-3006000.po | 3605 ++++--- misc/translator/po/da-DK-opac-bootstrap.po | 644 +- misc/translator/po/da-DK-pref.po | 202 +- misc/translator/po/da-DK-staff-help.po | 2 +- .../po/de-CH-i-staff-t-prog-v-3006000.po |11093 ++++++++++---------- misc/translator/po/de-CH-opac-bootstrap.po | 3163 +++--- misc/translator/po/de-CH-pref.po | 3424 ++++-- misc/translator/po/de-CH-staff-help.po | 27 +- .../po/de-DE-i-staff-t-prog-v-3006000.po | 2533 ++--- misc/translator/po/de-DE-opac-bootstrap.po | 184 +- misc/translator/po/de-DE-pref.po | 30 +- misc/translator/po/de-DE-staff-help.po | 14 +- .../po/el-GR-i-staff-t-prog-v-3006000.po | 2457 ++--- misc/translator/po/el-GR-opac-bootstrap.po | 158 +- misc/translator/po/el-GR-pref.po | 12 + misc/translator/po/el-GR-staff-help.po | 2 +- .../po/en-GB-i-staff-t-prog-v-3006000.po | 2443 ++--- misc/translator/po/en-GB-opac-bootstrap.po | 152 +- misc/translator/po/en-GB-pref.po | 12 + misc/translator/po/en-GB-staff-help.po | 2 +- .../po/en-NZ-i-staff-t-prog-v-3006000.po | 2487 ++--- misc/translator/po/en-NZ-opac-bootstrap.po | 171 +- misc/translator/po/en-NZ-pref.po | 47 +- misc/translator/po/en-NZ-staff-help.po | 2 +- misc/translator/po/eo-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/eo-opac-bootstrap.po | 152 +- misc/translator/po/eo-pref.po | 12 + misc/translator/po/eo-staff-help.po | 2 +- .../po/es-ES-i-staff-t-prog-v-3006000.po | 2479 ++--- misc/translator/po/es-ES-opac-bootstrap.po | 162 +- misc/translator/po/es-ES-pref.po | 38 +- misc/translator/po/es-ES-staff-help.po | 2 +- misc/translator/po/eu-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/eu-opac-bootstrap.po | 152 +- misc/translator/po/eu-pref.po | 12 + misc/translator/po/eu-staff-help.po | 2 +- .../po/fa-Arab-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/fa-Arab-opac-bootstrap.po | 152 +- misc/translator/po/fa-Arab-pref.po | 12 + misc/translator/po/fa-Arab-staff-help.po | 2 +- .../po/fi-FI-i-staff-t-prog-v-3006000.po | 2459 ++--- misc/translator/po/fi-FI-opac-bootstrap.po | 154 +- misc/translator/po/fi-FI-pref.po | 12 + misc/translator/po/fi-FI-staff-help.po | 2 +- .../po/fo-FO-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/fo-FO-opac-bootstrap.po | 153 +- misc/translator/po/fo-FO-pref.po | 12 + misc/translator/po/fo-FO-staff-help.po | 2 +- .../po/fr-CA-i-staff-t-prog-v-3006000.po | 2466 ++--- misc/translator/po/fr-CA-opac-bootstrap.po | 152 +- misc/translator/po/fr-CA-pref.po | 12 + misc/translator/po/fr-CA-staff-help.po | 2 +- .../po/fr-FR-i-staff-t-prog-v-3006000.po | 2466 ++--- misc/translator/po/fr-FR-opac-bootstrap.po | 154 +- misc/translator/po/fr-FR-pref.po | 12 + misc/translator/po/fr-FR-staff-help.po | 2 +- misc/translator/po/gl-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/gl-opac-bootstrap.po | 152 +- misc/translator/po/gl-pref.po | 12 + misc/translator/po/gl-staff-help.po | 2 +- .../po/he-Hebr-i-staff-t-prog-v-3006000.po | 2446 ++--- misc/translator/po/he-Hebr-opac-bootstrap.po | 156 +- misc/translator/po/he-Hebr-pref.po | 12 + misc/translator/po/he-Hebr-staff-help.po | 2 +- misc/translator/po/hi-i-staff-t-prog-v-3006000.po | 2443 ++--- misc/translator/po/hi-opac-bootstrap.po | 152 +- misc/translator/po/hi-pref.po | 12 + misc/translator/po/hi-staff-help.po | 2 +- .../po/hr-HR-i-staff-t-prog-v-3006000.po | 2451 ++--- misc/translator/po/hr-HR-opac-bootstrap.po | 152 +- misc/translator/po/hr-HR-pref.po | 12 + misc/translator/po/hr-HR-staff-help.po | 2 +- .../po/hu-HU-i-staff-t-prog-v-3006000.po | 2443 ++--- misc/translator/po/hu-HU-opac-bootstrap.po | 152 +- misc/translator/po/hu-HU-pref.po | 12 + misc/translator/po/hu-HU-staff-help.po | 2 +- .../po/hy-Armn-i-staff-t-prog-v-3006000.po | 2535 ++--- misc/translator/po/hy-Armn-opac-bootstrap.po | 165 +- misc/translator/po/hy-Armn-pref.po | 44 +- misc/translator/po/hy-Armn-staff-help.po | 2 +- .../po/id-ID-i-staff-t-prog-v-3006000.po | 2456 ++--- misc/translator/po/id-ID-opac-bootstrap.po | 152 +- misc/translator/po/id-ID-pref.po | 12 + misc/translator/po/id-ID-staff-help.po | 2 +- .../po/is-IS-i-staff-t-prog-v-3006000.po | 2443 ++--- misc/translator/po/is-IS-opac-bootstrap.po | 152 +- misc/translator/po/is-IS-pref.po | 12 + misc/translator/po/is-IS-staff-help.po | 2 +- .../po/it-IT-i-staff-t-prog-v-3006000.po | 2532 ++--- misc/translator/po/it-IT-opac-bootstrap.po | 3049 +++--- misc/translator/po/it-IT-pref.po | 46 +- misc/translator/po/it-IT-staff-help.po | 2 +- .../po/ja-Jpan-JP-i-staff-t-prog-v-3006000.po | 2446 ++--- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 161 +- misc/translator/po/ja-Jpan-JP-pref.po | 12 + misc/translator/po/ja-Jpan-JP-staff-help.po | 2 +- .../po/km-KH-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/km-KH-opac-bootstrap.po | 152 +- misc/translator/po/km-KH-pref.po | 12 + misc/translator/po/km-KH-staff-help.po | 2 +- .../po/kn-Knda-i-staff-t-prog-v-3006000.po | 2447 ++--- misc/translator/po/kn-Knda-opac-bootstrap.po | 152 +- misc/translator/po/kn-Knda-pref.po | 12 + misc/translator/po/kn-Knda-staff-help.po | 2 +- .../po/ko-Kore-KP-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 152 +- misc/translator/po/ko-Kore-KP-pref.po | 12 + misc/translator/po/ko-Kore-KP-staff-help.po | 2 +- .../po/ku-Arab-i-staff-t-prog-v-3006000.po | 2460 ++--- misc/translator/po/ku-Arab-opac-bootstrap.po | 152 +- misc/translator/po/ku-Arab-pref.po | 12 + misc/translator/po/ku-Arab-staff-help.po | 2 +- .../po/lo-Laoo-i-staff-t-prog-v-3006000.po | 2455 ++--- misc/translator/po/lo-Laoo-opac-bootstrap.po | 152 +- misc/translator/po/lo-Laoo-pref.po | 12 + misc/translator/po/lo-Laoo-staff-help.po | 2 +- .../po/mi-NZ-i-staff-t-prog-v-3006000.po | 2443 ++--- misc/translator/po/mi-NZ-opac-bootstrap.po | 152 +- misc/translator/po/mi-NZ-pref.po | 12 + misc/translator/po/mi-NZ-staff-help.po | 2 +- misc/translator/po/mon-i-staff-t-prog-v-3006000.po | 2443 ++--- misc/translator/po/mon-opac-bootstrap.po | 152 +- misc/translator/po/mon-pref.po | 12 + misc/translator/po/mon-staff-help.po | 2 +- misc/translator/po/mr-i-staff-t-prog-v-3006000.po | 2446 ++--- misc/translator/po/mr-opac-bootstrap.po | 152 +- misc/translator/po/mr-pref.po | 12 + misc/translator/po/mr-staff-help.po | 2 +- .../po/ms-MY-i-staff-t-prog-v-3006000.po | 2454 ++--- misc/translator/po/ms-MY-opac-bootstrap.po | 153 +- misc/translator/po/ms-MY-pref.po | 12 + misc/translator/po/ms-MY-staff-help.po | 2 +- .../po/nb-NO-i-staff-t-prog-v-3006000.po | 2592 ++--- misc/translator/po/nb-NO-opac-bootstrap.po | 163 +- misc/translator/po/nb-NO-pref.po | 196 +- misc/translator/po/nb-NO-staff-help.po | 2 +- .../po/ne-NE-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/ne-NE-opac-bootstrap.po | 152 +- misc/translator/po/ne-NE-pref.po | 12 + misc/translator/po/ne-NE-staff-help.po | 2 +- .../po/nl-BE-i-staff-t-prog-v-3006000.po | 2467 ++--- misc/translator/po/nl-BE-opac-bootstrap.po | 154 +- misc/translator/po/nl-BE-pref.po | 12 + misc/translator/po/nl-BE-staff-help.po | 2 +- .../po/nl-NL-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/nl-NL-opac-bootstrap.po | 154 +- misc/translator/po/nl-NL-pref.po | 12 + misc/translator/po/nl-NL-staff-help.po | 2 +- .../po/nn-NO-i-staff-t-prog-v-3006000.po | 2443 ++--- misc/translator/po/nn-NO-opac-bootstrap.po | 152 +- misc/translator/po/nn-NO-pref.po | 12 + misc/translator/po/nn-NO-staff-help.po | 2 +- misc/translator/po/pbr-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/pbr-opac-bootstrap.po | 152 +- misc/translator/po/pbr-pref.po | 12 + misc/translator/po/pbr-staff-help.po | 2 +- .../po/pl-PL-i-staff-t-prog-v-3006000.po | 2475 ++--- misc/translator/po/pl-PL-opac-bootstrap.po | 154 +- misc/translator/po/pl-PL-pref.po | 12 + misc/translator/po/pl-PL-staff-help.po | 2 +- misc/translator/po/prs-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/prs-opac-bootstrap.po | 156 +- misc/translator/po/prs-pref.po | 12 + misc/translator/po/prs-staff-help.po | 2 +- .../po/pt-BR-i-staff-t-prog-v-3006000.po | 2554 ++--- misc/translator/po/pt-BR-opac-bootstrap.po | 320 +- misc/translator/po/pt-BR-pref.po | 12 + misc/translator/po/pt-BR-staff-help.po | 2 +- .../po/pt-PT-i-staff-t-prog-v-3006000.po | 4108 ++++---- misc/translator/po/pt-PT-opac-bootstrap.po | 478 +- misc/translator/po/pt-PT-pref.po | 332 +- misc/translator/po/pt-PT-staff-help.po | 204 +- .../po/ro-RO-i-staff-t-prog-v-3006000.po | 2443 ++--- misc/translator/po/ro-RO-opac-bootstrap.po | 152 +- misc/translator/po/ro-RO-pref.po | 12 + misc/translator/po/ro-RO-staff-help.po | 2 +- .../po/ru-RU-i-staff-t-prog-v-3006000.po | 2467 ++--- misc/translator/po/ru-RU-opac-bootstrap.po | 153 +- misc/translator/po/ru-RU-pref.po | 12 + misc/translator/po/ru-RU-staff-help.po | 2 +- .../po/rw-RW-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/rw-RW-opac-bootstrap.po | 152 +- misc/translator/po/rw-RW-pref.po | 12 + misc/translator/po/rw-RW-staff-help.po | 2 +- .../po/sd-PK-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/sd-PK-opac-bootstrap.po | 152 +- misc/translator/po/sd-PK-pref.po | 12 + misc/translator/po/sd-PK-staff-help.po | 2 +- .../po/sk-SK-i-staff-t-prog-v-3006000.po | 2557 +++-- misc/translator/po/sk-SK-opac-bootstrap.po | 158 +- misc/translator/po/sk-SK-pref.po | 18 +- misc/translator/po/sk-SK-staff-help.po | 2 +- .../po/sl-SI-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/sl-SI-opac-bootstrap.po | 152 +- misc/translator/po/sl-SI-pref.po | 12 + misc/translator/po/sl-SI-staff-help.po | 2 +- .../po/sq-AL-i-staff-t-prog-v-3006000.po | 2458 ++--- misc/translator/po/sq-AL-opac-bootstrap.po | 152 +- misc/translator/po/sq-AL-pref.po | 12 + misc/translator/po/sq-AL-staff-help.po | 2 +- .../po/sr-Cyrl-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 152 +- misc/translator/po/sr-Cyrl-pref.po | 12 + misc/translator/po/sr-Cyrl-staff-help.po | 2 +- .../po/sv-SE-i-staff-t-prog-v-3006000.po | 2471 ++--- misc/translator/po/sv-SE-opac-bootstrap.po | 154 +- misc/translator/po/sv-SE-pref.po | 12 + misc/translator/po/sv-SE-staff-help.po | 2 +- .../po/sw-KE-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/sw-KE-opac-bootstrap.po | 152 +- misc/translator/po/sw-KE-pref.po | 12 + misc/translator/po/sw-KE-staff-help.po | 2 +- .../po/ta-LK-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/ta-LK-opac-bootstrap.po | 152 +- misc/translator/po/ta-LK-pref.po | 12 + misc/translator/po/ta-LK-staff-help.po | 2 +- misc/translator/po/ta-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/ta-opac-bootstrap.po | 152 +- misc/translator/po/ta-pref.po | 12 + misc/translator/po/ta-staff-help.po | 2 +- misc/translator/po/tet-i-staff-t-prog-v-3006000.po | 2469 ++--- misc/translator/po/tet-opac-bootstrap.po | 154 +- misc/translator/po/tet-pref.po | 12 + misc/translator/po/tet-staff-help.po | 2 +- .../po/th-TH-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/th-TH-opac-bootstrap.po | 152 +- misc/translator/po/th-TH-pref.po | 12 + misc/translator/po/th-TH-staff-help.po | 2 +- .../po/tl-PH-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/tl-PH-opac-bootstrap.po | 156 +- misc/translator/po/tl-PH-pref.po | 12 + misc/translator/po/tl-PH-staff-help.po | 2 +- .../po/tr-TR-i-staff-t-prog-v-3006000.po | 2516 ++--- misc/translator/po/tr-TR-opac-bootstrap.po | 160 +- misc/translator/po/tr-TR-pref.po | 18 +- misc/translator/po/tr-TR-staff-help.po | 15 +- .../po/uk-UA-i-staff-t-prog-v-3006000.po | 2465 ++--- misc/translator/po/uk-UA-opac-bootstrap.po | 155 +- misc/translator/po/uk-UA-pref.po | 12 + misc/translator/po/uk-UA-staff-help.po | 2 +- .../po/ur-Arab-i-staff-t-prog-v-3006000.po | 2442 ++--- misc/translator/po/ur-Arab-opac-bootstrap.po | 156 +- misc/translator/po/ur-Arab-pref.po | 12 + misc/translator/po/ur-Arab-staff-help.po | 2 +- .../po/vi-VN-i-staff-t-prog-v-3006000.po | 2462 ++--- misc/translator/po/vi-VN-opac-bootstrap.po | 152 +- misc/translator/po/vi-VN-pref.po | 12 + misc/translator/po/vi-VN-staff-help.po | 2 +- .../po/zh-Hans-CN-i-staff-t-prog-v-3006000.po | 2460 ++--- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 154 +- misc/translator/po/zh-Hans-CN-pref.po | 12 + misc/translator/po/zh-Hans-CN-staff-help.po | 2 +- .../po/zh-Hans-TW-i-staff-t-prog-v-3006000.po | 2532 ++--- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 163 +- misc/translator/po/zh-Hans-TW-pref.po | 12 + misc/translator/po/zh-Hans-TW-staff-help.po | 2 +- 288 files changed, 108285 insertions(+), 104112 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Feb 22 23:52:43 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 22 Feb 2015 22:52:43 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-66-gdd43df5 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via dd43df588e39b2d4b379d3ed11e5381bd8a881e0 (commit) from cc5dfd1039511e156af921bfa2ac6bdb7eb85677 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit dd43df588e39b2d4b379d3ed11e5381bd8a881e0 Author: Fr?d?ric Demians Date: Mon Jan 12 12:18:19 2015 +0100 Bug 13568 OAI Server doesn't handle properly resumption token When responding to ListRecords and ListIdentifiers verbs, OAI server doesn't return proper resumption token. At the end of a result set, OAI server generates a resumption token even if there isn't anymore records. Consequently, OAI harverster will send a new request, based on this invalid resumption, token. OAI Server responds with an empty resultset, which is considered as an invalid response by most of the harvesters. TO TEST: - Find in your DB, a day where a few biblio records have been created. The number of created biblios must inferior to OAI-PMH:MaxCount. - Let say this day is 2014-01-09. Send an OAI-PMH request to Koha OAI Server: /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2014-01-09&until=2014-01-09 - At the end of the result, you will see a resumption token which looks like that: marcxml/47/2014-01-09/2014-01-09/ This is wrong. No resumptiion token should be sent since there isn't anymore records to harvest. - Apply the patch. - Resend the OAI-PMH request. There is no resumption token at the end of the result. - You could test also with ListIdenfiers verb in place of ListRecord. Signed-off-by: Christophe Brocquet Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit f1ea9624bd197b04f78750bcc4d8f07ef2f9675d) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: opac/oai.pl | 64 +++++++++++++++++++++++++++++++++-------------------------- 1 file changed, 36 insertions(+), 28 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Sun Feb 22 23:56:33 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 22 Feb 2015 22:56:33 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-67-g1d9f869 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 1d9f869040bda7f626a3052451b84b4ade014e73 (commit) from dd43df588e39b2d4b379d3ed11e5381bd8a881e0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 1d9f869040bda7f626a3052451b84b4ade014e73 Author: Tomas Cohen Arazi Date: Wed Feb 18 12:27:20 2015 -0300 Bug 13728: koha-translate -l -a shows po files instead of language codes This patch corrects the call to 'basename' inside the script so it correctly shows the language code when asked to list the available languages. To test: - On a packages install, run: $ koha-translate --list --available => FAIL: It shows: am-Ethi-opac-bootstrap.po ar-Arab-opac-bootstrap.po az-AZ-opac-bootstrap.po be-BY-opac-bootstrap.po ben-opac-bootstrap.po ... - Apply the patch - Copy the patched debian/scripts/koha-translate script to your packages setup. - Run: $ koha-translate --list --available => SUCCESS: It shows: am-Ethi ar-Arab az-AZ be-BY ben ... - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 6b26f8858e5069a2fae21fb28692a8eeb37fa0a8) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-translate | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Feb 23 00:07:19 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 22 Feb 2015 23:07:19 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-73-g11287e0 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 11287e0ad19d69175026b507ac8796988cfd0ab9 (commit) via 01dc4bc0ced9e705b1e5c0d008b78770a1eef9a5 (commit) via 012d960b359795ed347de8c32f0bf73d21911fd4 (commit) via eef770cf2fa3842e2ba1863b4c1966bb125e2d4e (commit) via c6c653b4d4f1ea293fc2b197250b67093eabf781 (commit) via dd91aec752cee7dd963a888da164c533e11979fa (commit) from 1d9f869040bda7f626a3052451b84b4ade014e73 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 11287e0ad19d69175026b507ac8796988cfd0ab9 Author: Jonathan Druart Date: Tue Feb 10 11:34:10 2015 +0100 Bug 13690: use Koha::Schema only when it's needed This patch makes Koha::Database lazy-load the whole Koha::Schema libraries. It doesn't seem to have negative effects, and makes scripts not using DBIx::Class notably faster [1]. Regards [1] If you read the DBIx::Class::Schema docs, it explains that it it uses Module::Find to load all schema files... http://search.cpan.org/~ribasushi/DBIx-Class-0.082810/lib/DBIx/Class/Schema.pm#load_namespaces Signed-off-by: Tomas Cohen Arazi Happy to sign this one. The only extra comment would be that DBIx::Class performance issues remain after this patch, but is being handled in a different bug. Signed-off-by: Kyle M Hall (cherry picked from commit c52bc9756a5fa1e4f6bba7ce5c58124f150c5efc) Signed-off-by: Chris Cormack commit 01dc4bc0ced9e705b1e5c0d008b78770a1eef9a5 Author: Kyle M Hall Date: Fri Feb 20 07:23:15 2015 -0500 Bug 12858 [QA Followup] - Don't call webservice if we have no data Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 79e1008cef66345106328487c712ef6dde7f3507) Signed-off-by: Chris Cormack commit 012d960b359795ed347de8c32f0bf73d21911fd4 Author: Martin Renvoize Date: Tue Sep 2 09:14:03 2014 +0000 Bug 12858: Add error handling to Syndetics Index * Syndetics routines include a statement to check that the returned content from Syndetics is xml. The get_syndetics_index routine was missing this check and so when a 'not found' html page was returned the opac-detail page would take a long time to load whilst xml::simple attempted to parse the large html document. Test Plan 1. Enable Syndetics indexes on opac. 2. Head over to an opac-detail page on the opac. 3. Remove the ISBN from the same item in the staff client. 4. Reload the opac-detail page for the item noticeing a much slower page load. 5. Apply the patch 6. Reload the opac-detail page for the item and note that it now laods in a reasonable timescale again. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit acc7da6a5f93e12704acdfd7981481c9ef07904b) Signed-off-by: Chris Cormack commit eef770cf2fa3842e2ba1863b4c1966bb125e2d4e Author: Jonathan Druart Date: Tue Sep 16 13:15:57 2014 +0200 Bug 12669: Centralize the timezone handle into Koha::DateUtils This patch adds unit tests for the previous changes and centralize the timezone handle into the Koha::DateUtils module. Like that the behavior will affect all date manipulations using this module (should be all dates in Koha). Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit f82064286d3bc97031ad784901716a7a327839bc) Signed-off-by: Chris Cormack commit c6c653b4d4f1ea293fc2b197250b67093eabf781 Author: Rolando Isidoro Date: Fri Aug 1 09:42:30 2014 +0100 Bug 12669: Use floating timezone when handling dates without hours, minutes and seconds. Test plan: 1. Create a new serial record or pick an existing one; 2. Add a "New subscription" and set the "First issue publication date" and "Frequency" values so that the "Planned date" for a given issue hits a day where a transition to Daylight Saving Time (DST) occurs ex:. 1979-04-01 in Europe/Lisbon (http://www.timeanddate.com/time/change/portugal/lisbon?year=1979) ... use this website page as a source http://www.timeanddate.com/time/dst/2014.html to find a suitable transition to DST in your timezone in the current year. 3. From the "Subscription detail" page in Koha for the given record click the "Serial collection" link on the left side context menu. Expected result: Prior to applying the patch the error described in this bug report should occur. After the patch is applied the "Serial collection" page should load correctly. Signed-off-by: Colin Campbell Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit e8f9000fcca4fd542f7f82e2288d3a627053dd77) Signed-off-by: Chris Cormack commit dd91aec752cee7dd963a888da164c533e11979fa Author: Chris Cormack Date: Sat Feb 7 17:04:40 2015 +1300 Bug 13679 : Bug in listing overdues To test 1/ Create some overdues and some issues due in the future 2/ Run the overdues script 3/ Notice item due in the future is in the list 4/ Apply patch 5/ Run script again 6/ Notice in the future not in the list Signed-off-by: Nick Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 07f9dd9f8c2abb43a031c91449661a779ff53746) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: C4/External/Syndetics.pm | 9 +++++-- Koha/Database.pm | 2 +- Koha/DateUtils.pm | 27 ++++++++++++++------ Koha/Template/Plugin/KohaDates.pm | 2 ++ misc/cronjobs/overdue_notices.pl | 2 ++ t/DateUtils.t | 22 ++++++++++++++++- t/db_dependent/Koha_template_plugin_KohaDates.t | 30 +++++++++++++++++++---- 7 files changed, 78 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Feb 23 00:13:05 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 22 Feb 2015 23:13:05 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-75-g2ec870a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 2ec870a2c2825984220d8445a36617582fc2cf67 (commit) via e5073e1235162e395ca39edff93bfca643b3f1b9 (commit) from 11287e0ad19d69175026b507ac8796988cfd0ab9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 2ec870a2c2825984220d8445a36617582fc2cf67 Author: Zeno Tajoli Date: Sun Feb 15 17:40:06 2015 +0100 Bug 12948: Use word indexing for language (MARC21) This patch is for MARC21. To test: 1)Setup a site with MARC21 2)Insert 2 record, one lang A in 041 and 008 pos 35-37 an other with lang A in 041 and lang B in 008 pos 35-37 3)Index them 4)Search in advanced search with filter 'languare' for lan A. You will see 2 records 5)Search in advanced search with filter 'languare' for lan B. You will see 0 records 6)Apply the patch 7)Full reindex 8)Search in advanced search with filter 'languare' for lan B. You will see 1 records http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger I have *not* actually tested this, but the changes are identical to the ones done for NORMARC, which I have tested, so I think it is safe to sign off. If anyone disagrees, please reset the bug to "Needs signoff". Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit c29a53ea20d668f135c62abbc7dda1bf282be8f0) Signed-off-by: Chris Cormack commit e5073e1235162e395ca39edff93bfca643b3f1b9 Author: Zeno Tajoli Date: Sun Feb 15 17:54:48 2015 +0100 Bug 12948: Use word indexing for language (NORMARC) This patch is for Normarc Same test plan as patch for MARC21, except you need a setup with Normarc. http://bugs.koha-community.org/show_bug.cgi?id=12948 Signed-off-by: Magnus Enger - Added a record with "bul" in 008pos35-37 - Verified that this did not turn up in an advanced search with language = Bulgarian - Applied the patch - I was testing on a gitified install, so I had to copy the patched index file to the right location with this command: sudo cp etc/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl - Did a full reindex - Verified that the record *did* turn up in an advanced search with language = Bulgarian - Signing off! Thanks Zeno! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit bf89e306a86c440a3296fc89436ad5e854ea4f34) Signed-off-by: Chris Cormack ----------------------------------------------------------------------- Summary of changes: etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml | 4 ++-- etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl | 2 +- etc/zebradb/marc_defs/normarc/biblios/biblio-koha-indexdefs.xml | 4 ++-- etc/zebradb/marc_defs/normarc/biblios/biblio-zebra-indexdefs.xsl | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Feb 23 00:14:22 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 22 Feb 2015 23:14:22 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-76-g5584b2d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 5584b2d9680db4eaf30a2bddd3ec0bb78ab7afee (commit) from 2ec870a2c2825984220d8445a36617582fc2cf67 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5584b2d9680db4eaf30a2bddd3ec0bb78ab7afee Author: Chris Cormack Date: Mon Feb 23 12:21:17 2015 +1300 Bumping version number for release ----------------------------------------------------------------------- Summary of changes: installer/data/mysql/updatedatabase.pl | 6 ++++++ kohaversion.pl | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Feb 23 00:48:51 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 22 Feb 2015 23:48:51 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.04 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 24f4bdab3175e2abbb77cf472795de8d1473a2ae (commit) from 5584b2d9680db4eaf30a2bddd3ec0bb78ab7afee (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 24f4bdab3175e2abbb77cf472795de8d1473a2ae Author: Chris Cormack Date: Mon Feb 23 12:42:26 2015 +1300 Adding release notes ----------------------------------------------------------------------- Summary of changes: misc/release_notes/release_notes_3_18_4.html | 451 ++++++++++++++++++++++++++ 1 file changed, 451 insertions(+) create mode 100644 misc/release_notes/release_notes_3_18_4.html hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Mon Feb 23 00:48:52 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Sun, 22 Feb 2015 23:48:52 +0000 Subject: [koha-commits] main Koha release repository annotated tag v3.18.04 created. v3.18.04 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v3.18.04 has been created at 6a6f32362aa1018bee7d178bcecf00199e2f038a (tag) tagging 24f4bdab3175e2abbb77cf472795de8d1473a2ae (commit) replaces v3.18.03 tagged by Chris Cormack on Mon Feb 23 12:55:48 2015 +1300 - Log ----------------------------------------------------------------- Koha Release 3.18.04 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABCAAGBQJU6myEAAoJEG5T+NVYEYs1I6sQAKLaXgrLw874JGB79TXQnfvj FTYhizk3C4WE75dCyBsmHHRK0gmtSaLe2znbC62+FWw6874j86zEqffeJL7CbVTu pYYk90DMafqK8IvNM9EK5asgwL4yPIj1HzN485fJJmvhBuM/U+ZT6ljFLUv8FD/J W28iYmsh/Mv9wGvctOuxO5K7a+VKoWI/6/V5Bh23DPgjFzFJapPIoIpc7N0RKKu7 20hXhlVdhGaxcDW0t3fucu94vN8gDP95DNgXUdLTXs6dnZymYRmpCmp8gxX/Q7eQ eI/NkHGd1xoAKbfFe1iJuoqUoJL40smsQAcIAlbjeGKBN0SrOGQWLZgxIrSp6LVg RuGJQU9CAItFg7AWn8H9aLoyC0JC857KXVntbDnpSwf6mvLsAF7FxEEJn6oeC1U0 Jp63qZZVH4TAYmR5xLE5uQFFViCOPU7RV0Y/MJ1qSEe0zqbdRsldUp96G4NaQqwR ODIl0Nl8naQbJ0Hd7Yi1/1XBpDHpAbgXvVwMjijF3v5LC99IUMddZBWNtY9+Omw7 O6MoicHbI4qqy/YpQxOgx+Nvd1oSk6ohcJv/37PRM6e/PomBjvaP1/GG4KewwaXd M3V5O4I6vyEmOgOCFGZ3q9QVeVxZUUgg5kYimwMklDHrSZyIIaJNnfp1Qfxry6Hl 0nccZsqXsYFBzpocC6Vj =HYoH -----END PGP SIGNATURE----- Abby (1): Bug 13587: Fix Authorised Values Toolbar Amit Gupta (2): Bug - 5511: Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. Bug - 5511: Added new system preference: SessionRestrictionByIP Bernardo Gonzalez Kriegel (1): Translation updates for Koha 3.18.04 release Chris Cormack (9): Updating release notes Bug 12861 : Noisy warn in the error logs Bumping version number to 3.18.03.001 Revert "Bug 13352: On editing, prices should not be formatted" Revert "Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)"" Bumping db version to 3.18.03.002 Bug 13679 : Bug in listing overdues Bumping version number for release Adding release notes Fridolin Somers (2): Bug 13268 - biblioitems.size value not correctly displayed (more) Bug 13401 - sort branches alphabetically in admin/authorised_values.pl Fr?d?ric Demians (1): Bug 13568 OAI Server doesn't handle properly resumption token Jacek Ablewicz (2): Bug 13431 - Shared FastMmap file causes issues Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues Jonathan Druart (14): Bug 12861: (follow-up) Noisy warn in error logs Bug 13544: Make it explicit that getauthtypes returns a hash ref Bug 13268: the size should not be emptied in pl script Bug 13333: Fix Display basket group for already received orders Bug 12905: funds with children could not be deleted Bug 13270: Don't display "vendor note" label if nothing to display Bug 12860: the export tools explodes if a field is not exported Bug 13352: On editing, prices should not be formatted Bug 13201: GetSuggestion takes suggestionid Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber Bug 13343: Embed items when send a basket/shelf Bug 13352: On editing, prices should not be formatted Bug 12669: Centralize the timezone handle into Koha::DateUtils Bug 13690: use Koha::Schema only when it's needed Julian Maurice (1): Bug 13562: Fix item search on item MARC subfields Justin (1): Bug - 11345 - Self registration captcha Katrin Fischer (3): Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)" Bug - 5511 [Followup]: QA Fixes Bug 13352: QA Follow-up: Remove Price filter from "Warning at (%)" Kyle M Hall (12): Bug 13599 - Add patron cardnumber to self registration confirmation Bug 13432 - SIP Server does not respect timeout setting Bug 13441 - Branchcodes should not be allowed to have spaces in them Bug 13450 [QA Followup] - Remove tab character from start of line Bug 13404 [QA Followup] Bug 13298 - Holds ratios report ignores ordered items Bug 12323 [SIGNED OFF] - Acquisitions search results fixed in order of biblionumber Bug 13670 - Patron holds table not loading when holds tab anchor is used Bug 13636 - Staff search results item status incorrect for holds Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing Bug 13603 - autoBarcode setting hbyymmincr not taking month into account when looking up next increment Bug 12858 [QA Followup] - Don't call webservice if we have no data Marc V?ron (1): Bug 13450 - Title and breadcrumb of Patron form can look weird in translations Marcel de Rooy (1): Bug 13404: [QA Follow-up] Minor rewording of some warnings Mark Tompsett (3): Bug 13457: Suggestions.t expects sample itemtypes Bug 13457 - Followup for CPL and S codes Bug 11954 - Clean up currency default files Martin Renvoize (7): Bug 13499: Tidy of Auth.pm Bug 13521: Removed superflous semicolon Bug 13521: Add missing semicolon Bug 12954: Failed login should retain anonymous session Bug - 5511 [Followup]: Switched defults Bug - 5511 [Followup]: Missed Instance Bug 12858: Add error handling to Syndetics Index Mirko Tietgen (1): Bug 13404 - More System information about GRS1 vs DOM settings Olli-Antti Kivilahti (2): Bug 13025 - Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences Owen Leonard (4): Bug 13525 - Date sorting on accounts (fines) tab doesn't work correctly Bug 13339 - Cart button doesn't open the cart Bug 13638 - Batch patron modification tool missing option to switch language Bug 13142 - Change "mobile phone" label back to "other phone" Rafal Kopaczka (3): Bug 13373 [1/2] - Update Polish web installer sample data files. Bug 13373 [2/2] - Update Polish web installer sample data files. Bug 13373 - [QA Followup] - Update Polish web installer sample data files Rolando Isidoro (1): Bug 12669: Use floating timezone when handling dates without hours, minutes and seconds. Thomas (1): Bug 10241 - Easy analyticals creates two 773 fields. Search/link from host to children is broken Tomas Cohen Arazi (2): Bug 13602: (QA followup) take advantage of the defined-or operator Bug 13728: koha-translate -l -a shows po files instead of language codes Zeno Tajoli (2): Bug 12948: Use word indexing for language (NORMARC) Bug 12948: Use word indexing for language (MARC21) ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Tue Feb 24 18:17:09 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Tue, 24 Feb 2015 17:17:09 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.18.00-374-g003993d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 003993d547a98a3b1e085058b96aecd318ece036 (commit) via 7272426d0d6985e1e7f35d4a55d5fb6444b1ffba (commit) via 06608a24408c74d0975665b24c1e80fec5669385 (commit) via 4b59bc4e2b591b32ff28eccda0baf8d131544736 (commit) via 13a16343fa21e87b9c4723fdf4d02ae6eb46d495 (commit) via 0a91c48edbd4eb8d4080fbca6fb2bc3af9ca9f92 (commit) via 459b082f3512d22856429183840a90117970b59e (commit) via 103811a13d349d8a83801eef1b6b43891aa72ac5 (commit) from 00f27cb0b9fb200a06da461371e04be1501ca107 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 003993d547a98a3b1e085058b96aecd318ece036 Author: Kyle M Hall Date: Tue Feb 17 06:23:35 2015 -0500 Bug 13473 - Plugins fail When trying to execute or configure the plugin on 3.18 I got: Template process failed: file error - doc-head-open.inc: not found at /usr/share/koha/lib/C4/Templates.pm line 129. Test Plan: 1) Install the Kitchen Sink plugin 2) Go to the configuration page of the plugin 3) Note the template processing error 4) Apply this patch 5) Refresh the page 6) Note the page now loads Signed-off-by: Nick Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 7272426d0d6985e1e7f35d4a55d5fb6444b1ffba Author: Tomas Cohen Arazi Date: Tue Feb 24 14:20:31 2015 -0300 Bug 13523: DBIC updates Signed-off-by: Tomas Cohen Arazi commit 06608a24408c74d0975665b24c1e80fec5669385 Author: Tomas Cohen Arazi Date: Tue Feb 24 11:27:03 2015 -0300 Bug 13523: DBRev 3.19.00.012 Signed-off-by: Tomas Cohen Arazi commit 4b59bc4e2b591b32ff28eccda0baf8d131544736 Author: Benjamin Rokseth Date: Thu Jan 22 12:21:47 2015 +0100 Bug 13523 - AddBiblio fails on mysql with STRICT_TRANS_TABLES This patch removes the NOT NULL restriction on biblioitems.marcxml and deletedbiblioitems.marcxml due to STRICT_TRANS_TABLES default in Mysql 5.6.22 and onwards. Test: 1. check mysql global settings: mysql > SELECT @@GLOBAL.sql_mode; verify that STRICT_TRANS_TABLES is not set 2. set STRICT_TRANS_TABLES (or upgrade mysql to > 5.6.21) mysql > SET @@GLOBAL.sql_mode = 'STRICT_TRANS_TABLES'; 3. try to add biblio in Cataloguing module verify that it fails with a "software error" 4. apply patch 5. repeat 3 and verify that there is no "software error" any more Signed-off-by: Jonathan Druart I confirm with the problem with mariadb and STRICT_TRANS_TABLES enabled. On adding a biblio (C4::Biblio::AddBiblio), biblioitems is populate in _koha_add_biblioitem but marxcml is not generated yet. It's in ModBiblioMarc, few lines later. The NOT NULL condition is not valid here. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 13a16343fa21e87b9c4723fdf4d02ae6eb46d495 Author: Viktor Sarge Date: Wed Feb 18 21:02:09 2015 +0000 Bug 13729 - Give news in Opac a unique anchor This patch introduces the use of the idnew-value from the opac_news table as a base for a unique anchor on each newsitem in Opac. The anchor can be used for linking to specific newsitems and also for improving bug 7843 (RSS stream for news) with a unique link to each item in the RSS stream. Test plan: * Make shure you have a few news in the opac. Best is if it's enough to hide a few beneath the bottom of the window. * Install the patch. * Verify that you can access newitems with links like mykoha/cgi-bin/koha/opac-main.pl#newsitem4 * Experiment with removing newsitems and verify that that the newsitem-id stay unique to each newsitem. Signed-off-by: Magnus Enger Works as advertised. Nice enhancement! Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 0a91c48edbd4eb8d4080fbca6fb2bc3af9ca9f92 Author: Robin Sheat Date: Tue Feb 24 18:32:30 2015 +1300 Bug 13645: dependencies for libdbix-connector-perl Signed-off-by: Tomas Cohen Arazi commit 459b082f3512d22856429183840a90117970b59e Author: Owen Leonard Date: Thu Jan 22 11:28:35 2015 -0500 Bug 13612 - Remove old YUI javacript libraries from opac-tmpl YUI files were left behind in opac-tmpl/lib/yui after the removal of the prog theme. These files are unused and can be safely removed. To test, apply the patch and search for references to any of the YUI files. You should find none in the OPAC templates. No references found. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 103811a13d349d8a83801eef1b6b43891aa72ac5 Author: Marc V?ron Date: Tue Feb 10 15:57:01 2015 +0100 Bug 13689 - Remove opac-old.css and sco-old.css The following files are obsolete and should be removed: koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css To test: Apply patch. Search for the files; they should no longer exist. Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Templates.pm | 4 + Koha/Schema/Result/Biblioitem.pm | 8 +- Koha/Schema/Result/Deletedbiblioitem.pm | 8 +- debian/control | 2 + installer/data/mysql/kohastructure.sql | 4 +- installer/data/mysql/updatedatabase.pl | 14 + koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css | 2862 -------------------- koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css | 333 --- .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 2 +- koha-tmpl/opac-tmpl/lib/yui/button.css | 7 - koha-tmpl/opac-tmpl/lib/yui/container.css | 318 --- .../opac-tmpl/lib/yui/container/container-min.js | 17 - .../lib/yui/container/container_core-min.js | 12 - koha-tmpl/opac-tmpl/lib/yui/menu.css | 7 - koha-tmpl/opac-tmpl/lib/yui/menu/menu-min.js | 16 - koha-tmpl/opac-tmpl/lib/yui/reset-fonts-grids.css | 9 - koha-tmpl/opac-tmpl/lib/yui/skin.css | 23 - koha-tmpl/opac-tmpl/lib/yui/utilities/utilities.js | 36 - koha-tmpl/opac-tmpl/lib/yui/yui-sprite.png | Bin 3123 -> 0 bytes kohaversion.pl | 2 +- 20 files changed, 32 insertions(+), 3652 deletions(-) delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css delete mode 100644 koha-tmpl/opac-tmpl/lib/yui/button.css delete mode 100644 koha-tmpl/opac-tmpl/lib/yui/container.css delete mode 100644 koha-tmpl/opac-tmpl/lib/yui/container/container-min.js delete mode 100644 koha-tmpl/opac-tmpl/lib/yui/container/container_core-min.js delete mode 100644 koha-tmpl/opac-tmpl/lib/yui/menu.css delete mode 100644 koha-tmpl/opac-tmpl/lib/yui/menu/menu-min.js delete mode 100644 koha-tmpl/opac-tmpl/lib/yui/reset-fonts-grids.css delete mode 100644 koha-tmpl/opac-tmpl/lib/yui/skin.css delete mode 100644 koha-tmpl/opac-tmpl/lib/yui/utilities/utilities.js delete mode 100644 koha-tmpl/opac-tmpl/lib/yui/yui-sprite.png hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 25 11:30:46 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 25 Feb 2015 10:30:46 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-3-ga2dc1e4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via a2dc1e4ecaadb0676b4da54745c6bc7e53cc68d6 (commit) from 74b78a40818e762375830f6a5c92fc8f9dbbc0bb (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a2dc1e4ecaadb0676b4da54745c6bc7e53cc68d6 Author: Marc V?ron Date: Sun Jul 27 08:03:23 2014 +0200 Bug 12705 - News not possible for one sublanguage if two sublanguages are installed To test: - Install two language variants (e.g. de-DE and de-CH) - Create OPAC news for each of them - Verify that they are displayed in OPAC as appropriate Signed-off-by: Bernardo Gonzalez Kriegel Works Ok, no koha-qa errors Signed-off-by: Katrin Fischer Works ok, all installed languages now show up in the pull downs and display for the selected language in the OPAC. Passes tests and QA script. Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: tools/koha-news.pl | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 25 11:48:44 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 25 Feb 2015 10:48:44 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-4-gb7a1353 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via b7a1353cfe918d2bbdd4ca96c29b252849fb61a8 (commit) from a2dc1e4ecaadb0676b4da54745c6bc7e53cc68d6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b7a1353cfe918d2bbdd4ca96c29b252849fb61a8 Author: Liz Rea Date: Tue Oct 7 09:35:19 2014 +1300 Bug 12856: koha-disable fails without disabling site To test: Package up a branch with this patch install that package create a site - sudo koha-create --create-db testdisable enable a site - sudo koha-enable testdisable check it's enabled - sudo koha-list --enabled * it should show up disable a site - sudo koha-disable testdisable Do this for both debian squeeze/wheezy and ubuntu 12.04 and 14.04, if you can. I'd like to see a sign off from a debian (sq/wh)eez(e/y) or ubuntu 12 user, because I could only test reliably on ubuntu 14.04. * make sure apache restarts and no errors are produced check it's disabled - sudo koha-list --enabled * it should not show up check the site is still there - sudo koha-list * it should still be there check that the config file has the Include for disabling uncommented * the line Include /etc/koha/apache-shared-disable.conf should not have a # in front. Re-enable the site - sudo koha-enable testdisable * the line Include /etc/koha/apache-shared-disable.conf should have a # in front. And the final question - does the site work? All other functions unchanged? Signed-off-by: Mason James Signed-off-by: Tomas Cohen Arazi Works as expected. code reads better too. Edit: I added a missing space in one line. Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: debian/scripts/koha-disable | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 25 11:57:57 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 25 Feb 2015 10:57:57 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-5-gab5115d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via ab5115db7823ed7df117d1c8f33028e486e2eff9 (commit) from b7a1353cfe918d2bbdd4ca96c29b252849fb61a8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ab5115db7823ed7df117d1c8f33028e486e2eff9 Author: Jonathan Druart Date: Tue Jan 27 15:59:49 2015 +0100 Bug 13458: specific followup for 3.16.x members/member.tt uses patron-toolbar.inc which calls the Koha TT Plugin (for Preference). But this plugin is not loaded in the member.tt. It works on master and 3.18.x Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 1 + 1 file changed, 1 insertion(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 25 12:11:49 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 25 Feb 2015 11:11:49 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-7-ga914ca4 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via a914ca478bfb50d628e40632f6bfe21a4578d960 (commit) via 9401c5bf7ca5d1c1765cdf12a0d9bba1c323f08a (commit) from ab5115db7823ed7df117d1c8f33028e486e2eff9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a914ca478bfb50d628e40632f6bfe21a4578d960 Author: Mason James Date: Thu Feb 26 00:08:51 2015 +1300 Revert "Bug 12823: Alert about defining the SRU search field mappings" This reverts commit ca7c1b6ff1d79cbc222669d8d13a646879698c17. commit 9401c5bf7ca5d1c1765cdf12a0d9bba1c323f08a Author: Mason James Date: Thu Feb 26 00:08:29 2015 +1300 Revert "Bug 12823: Add some hints for Host and Database" This reverts commit 779ef3bc7731e1eca3a77a25084f11e9b01e880e. ----------------------------------------------------------------------- Summary of changes: .../prog/en/modules/admin/z3950servers.tt | 63 ++------------------ 1 file changed, 4 insertions(+), 59 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Wed Feb 25 12:46:54 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 25 Feb 2015 11:46:54 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-9-g3d11d64 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 3d11d64d86a01472092aa62585d763ebeb789601 (commit) via 21e9e1ec7d90ddab19886bd8014bf9ab87e72c22 (commit) from a914ca478bfb50d628e40632f6bfe21a4578d960 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 3d11d64d86a01472092aa62585d763ebeb789601 Author: Kyle M Hall Date: Fri Aug 29 10:38:31 2014 -0400 Bug 3186 [QA Followup] - Don't return undef, just return Signed-off-by: Kyle M Hall Signed-off-by: Mason James commit 21e9e1ec7d90ddab19886bd8014bf9ab87e72c22 Author: Olli-Antti Kivilahti Date: Wed Aug 27 15:43:59 2014 +0300 Bug 3186 - invalid or uninstalled SMSSendDriver (or bad number format) causes process_message_queue to fail This patch wraps the SMS::Send Driver initialization and sending process into an eval block and gracefully causes the sending to fail, instead of crashing the process and preventing emails and good sms' from being sent. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: C4/SMS.pm | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 03:07:20 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 02:07:20 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-11-gb827560 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via b82756048119415dd1a4d48babebe5a7f29c1216 (commit) via ead74ef0596b25ea6da6c786be1cfe46e732eb62 (commit) from 3d11d64d86a01472092aa62585d763ebeb789601 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b82756048119415dd1a4d48babebe5a7f29c1216 Author: Jonathan Druart Date: Thu Jan 15 15:20:02 2015 +0100 Bug 12861: (follow-up) Noisy warn in error logs Completely get rid of warns. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Mason James commit ead74ef0596b25ea6da6c786be1cfe46e732eb62 Author: Chris Cormack Date: Wed Sep 3 09:49:41 2014 +1200 Bug 12861 : Noisy warn in the error logs To test Hit a url like cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY Notice the warns in the error log Apply patch Reload the url Still works but no warns (cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d) Signed-off-by: Chris Cormack Reformatted to fix error M Tompsett spotted Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy Instead of 10 warnings, I now have only 4 warnings. We're going in the right direction. Signed-off-by: Jonathan Druart Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: C4/AuthoritiesMarc.pm | 79 +++++++++++++++++++++++++++---------------------- 1 file changed, 43 insertions(+), 36 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 03:32:42 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 02:32:42 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-12-g0c8defb Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 0c8defb752d65a3562f35ace90780d075043b21f (commit) from b82756048119415dd1a4d48babebe5a7f29c1216 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0c8defb752d65a3562f35ace90780d075043b21f Author: Olli-Antti Kivilahti Date: Thu Jan 8 14:50:52 2015 +0200 Bug 13025 - Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 This error only appears when using the SIPServer, it doesn't manifest when using the SIP unit tests or when using the staff client. -------------------- ------------------ PREPARE THE TEST ------------------ -------------------- 0a. Find a borrower. 0b. Find an Item (cardnumber 'debar123') and check-out to the borrower 0c. Find a borrower and add a manual debarrment to it, indefinetely in effect. This is the default behaviour. 0d. Configure and start a SIP-server which you can access with telnet. See http://wiki.koha-community.org/wiki/Koha_SIP2_server_setup In this example, the Borrower defined as the Check-out/in machine has the following credentials: username: herkules password: palautathan branchcode: JOE_JOE but you are free to use your own, it doesn't affect this test plan. 0e. access your server with telnet ----------------------- --------------------- REPLICATE THE ISSUE --------------------- ----------------------- 1. Paste the following SIP-command to login: 9300CNherkules|COpalautathan|CPJOE_JOE| 2. Paste the following SIP-command to check-in the Item of the debarred Borrower: 09N20140721 07501620140721 075016AP|AO|ABdebar123|AC|BIN| 3. The connection should die and in the SIP Server's error log you can find the following error: Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925 -------------------- ------------------ AFTER THIS PATCH ------------------ -------------------- Redo steps 1-2. 3. No error is given and the connection doesn't die. No unit tests included and never will, because setting up the test environment would be very tedious. It is entirely possible but the scaffolding required is beyond the scope of this patch. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Note: I did not test this patch with SIP, but I did not find any regression on checking or renewing an item. Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 03:46:40 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 02:46:40 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-14-g7d13c57 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 7d13c576791bbf7b4d4c3ad4036d59f01c923164 (commit) via 7bc0ddcc15e904f2500126daf08e7924e728ff3f (commit) from 0c8defb752d65a3562f35ace90780d075043b21f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 7d13c576791bbf7b4d4c3ad4036d59f01c923164 Author: Kyle M Hall Date: Wed Dec 10 12:27:59 2014 -0500 Bug 13432 - SIP Server does not respect timeout setting Koha's SIP server accepts timeout parameters, but those parameters are only used for the login portion of a telnet transport session. Other than that, they are ignored, and as long as whatever opened the connection keeps it open, it will stay open indefinitely. Test Plan: 1) Set the timeout setting on your SIP server to 10 seconds 2) Modify misc/sip_cli_emulator.pl, add "sleep 100;" directly after line 91 3) Start your SIP server 4) Run the modified sip script with valid parameters 5) Watch the SIP server stderr 6) Note that even though the script waits far too long before continuing, the SIP server never kills the connection, and the requests the cli script makes come back with valid data. 7) Apply this patch 8) Restart your SIP server 9) Repeat step 4 10) Note that this time you see "SIP Timed Out!" in the SIP server stderr and when the script finally makes it's request, it doesn't come back with valid data. Signed-off-by: Colin Campbell Signed-off-by: Jonathan Druart Signed-off-by: Mason James commit 7bc0ddcc15e904f2500126daf08e7924e728ff3f Author: Justin Date: Wed Jan 14 23:16:29 2015 +0000 Bug - 11345 - Self registration captcha Test Plan - Open the opac site - Navigate to the self registration page (Home -> Register here) - Notice that there is no note stating that the verification box is case-sensitive - Apply patch - Refresh page - Notice that there is now an extra note stating that the verification box is case-sensitive. Followed test plan. Hint displays as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: C4/SIP/SIPServer.pm | 4 ++++ koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 1 + 2 files changed, 5 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 03:47:53 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 02:47:53 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-15-ge0d6aff Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via e0d6aff8fbe62603c368ade2502d062f173beee1 (commit) from 7d13c576791bbf7b4d4c3ad4036d59f01c923164 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e0d6aff8fbe62603c368ade2502d062f173beee1 Author: Mason James Date: Thu Feb 26 15:54:38 2015 +1300 Revert "Bug - 11345 - Self registration captcha" This reverts commit 7bc0ddcc15e904f2500126daf08e7924e728ff3f. ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 1 - 1 file changed, 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 04:07:28 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 03:07:28 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-16-g8726956 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 87269562468b683d501e482b7bed5f601f204b35 (commit) from e0d6aff8fbe62603c368ade2502d062f173beee1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 87269562468b683d501e482b7bed5f601f204b35 Author: Owen Leonard Date: Thu Jan 22 14:25:29 2015 -0500 Bug 13339 - Cart button doesn't open the cart The link to open the cart no longer triggers the cart popup. Instead, in order to make it more usable with mobile devices, it triggers a menu which displays the count of items in the cart -- something which previously was done with a hover action (something touch-screen devices don't have). Clicking/tapping this menu item is what opens the cart window. Since the cart link is really now a menu trigger rather than just a link, it seems logical to add the small arrow which the lists link has indicating that the link triggers a menu. To test, apply the patch and view any page in a Cart-enabled OPAC. Confirm that the "caret" icon displays correctly when the cart is both empty and when it has contents. Followed test plan. Icon displays as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Works as described, good idea. Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 04:15:27 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 03:15:27 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-18-ge706d0d Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via e706d0d66f76866080aeadf2248a522802cc47d1 (commit) via 62abe24f89bf6d1e61cb45061ccccd73139301ac (commit) from 87269562468b683d501e482b7bed5f601f204b35 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit e706d0d66f76866080aeadf2248a522802cc47d1 Author: Jonathan Druart Date: Tue Nov 25 12:23:45 2014 +0100 Bug 13333: Fix Display basket group for already received orders Bug 11111 adds a basket group column on the parcel page. But it seems that the already received orders never contain the value (always 'no basket group'). Test plan: Receive an order which is in a basket group and verify the basket group column is correctly filled. Signed-off-by: Paola Rossi Signed-off-by: Kyle M Hall Signed-off-by: Mason James commit 62abe24f89bf6d1e61cb45061ccccd73139301ac Author: Thomas Date: Thu Jan 15 01:43:28 2015 +0000 Bug 10241 - Easy analyticals creates two 773 fields. Search/link from host to children is broken Hidden 'New child record' if 'EasyAnalytics' is set to display. Testing plan: -Turn on 'EasyAnalytics'. Check the drop down menu from the records page *The drop down menu should include 'Analyze items' and not include 'New child record' -Turn off 'EasyAnalytics'. Again check the drop down menu from the records page *The drop down menu should include 'New child record' and not inlucde 'Analyze items' Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: C4/Acquisition.pm | 14 +++++++++----- koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc | 2 +- t/db_dependent/Acquisition/Invoices.t | 9 +++++---- 3 files changed, 15 insertions(+), 10 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 04:26:45 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 03:26:45 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-19-g5ba9be9 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 5ba9be9026f4a071d98b4c7ab4da5ad09db5eb63 (commit) from e706d0d66f76866080aeadf2248a522802cc47d1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5ba9be9026f4a071d98b4c7ab4da5ad09db5eb63 Author: Jonathan Druart Date: Thu Jan 29 16:18:19 2015 +0100 Bug 12860: the export tools explodes if a field is not exported To reproduce: 1/ Go on tools/export.pl 2/ Export some records and specify you don't want the fields 245 (the whole field, do not specify a subfield). 3/ Export, BOOM Software error: Arguments must be MARC::Field object at /home/koha/src/tools/export.pl line 400. Test plan: Apply the patch and confirm the fields 245 are not exported and the export works as expected. Signed-off-by: Robin Sheat Export fails to asplode with this patch Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: tools/export.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 04:34:33 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 03:34:33 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-20-gbc5ad96 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via bc5ad9604518c0ac9514154269333d16f8b59590 (commit) from 5ba9be9026f4a071d98b4c7ab4da5ad09db5eb63 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit bc5ad9604518c0ac9514154269333d16f8b59590 Author: Owen Leonard Date: Wed Jan 28 12:24:45 2015 -0500 Bug 13638 - Batch patron modification tool missing option to switch language The batch patron modification tool's template was created without the footer include at the bottom. Without the footer include the language toolbar will not be displayed. All page templates should include the global footer include: [% INCLUDE 'intranet-bottom.inc' %] To test: - Install at least a second language - Enable at least 2 languages (language system preference) - Go to tools > Batch patron modification - Verify that at the bottom of the page the language chooser is shown Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 05:19:27 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 04:19:27 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-21-g595c8df Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 595c8df72d2f2f0ef2837f3b9368d75c55d597af (commit) from bc5ad9604518c0ac9514154269333d16f8b59590 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 595c8df72d2f2f0ef2837f3b9368d75c55d597af Author: Olli-Antti Kivilahti Date: Tue Jan 20 16:48:13 2015 +0200 Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences When editing a Patron's messaging preferences or borrower attributes, one cannot save changes because 'userid' is not given as a parameter. It shouldn't, but the Check_Userid($newdata{'userid'},$borrowernumber) -check must have it. REPLICATE THE ISSUE: 1. Find a Borrower. 2. Go to the details-tab. 3. Under "Patron messaging preferences" click edit to edit just the messaging preferences. 4. Just save, no need to make any modifications. 5. Observe the error "Username/password already exists" This happens to all/most of the sub-forms in the Borrower's Details-view. AFTER THIS PATCH: Check_Userid() get the $userid from the new parameters, or if not present, from the koha.borrowers-table. TEST FOR REGRESSION: 1. Edit a borrower normally. Notice no errors. 2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no errors. DISCLAIMER: You are free to steal/rip/modify/hack this patch to your soul's extent without my permission. As long as it makes to Koha I am happy. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: members/memberentry.pl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 05:28:51 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 04:28:51 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-24-g06c173e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 06c173efd58ea46da21a7e4a68247704e42b3733 (commit) via 53098ad2efa15c5113a17d810318af8deb98c4f8 (commit) via 771c294c7419818e47009e0af1335ba0410ad80a (commit) from 595c8df72d2f2f0ef2837f3b9368d75c55d597af (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 06c173efd58ea46da21a7e4a68247704e42b3733 Author: Mark Tompsett Date: Wed Nov 19 13:28:12 2014 -0500 Bug 11954 - Clean up currency default files It makes no sense to have TRUNCATE or foreign key checks. TEST PLAN --------- 1) Back up your database 2) in an mysql client: use kohadata; SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/ru-RU/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/uk-UA/optional/sample_currency.sql SET FOREIGN_KEY_CHECKS=0; TRUNCATE currency; source /home/mtompset/kohaclone/installer/data/mysql/it-IT/necessari/parameters.sql SET FOREIGN_KEY_CHECKS=1; QUIT -- These should all work without problem. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Mason James commit 53098ad2efa15c5113a17d810318af8deb98c4f8 Author: Jonathan Druart Date: Wed Nov 5 12:41:13 2014 +0100 Bug 13201: GetSuggestion takes suggestionid Having $ordernumber as the parameter in a function which is handling suggestions and it is used as a suggestion id is confusing to the coder and person trying to read the code. This patch corrects the confusion. REVISED TEST PLAN ----------------- 1) perldoc C4::Suggestions -- notice it says ordernumber for the GetSuggestions example. 2) Ensure you have CPL in your branches table. 3) prove -v t/db_dependent/Suggestions.t -- if you have more than 8 itemtypes in your database, two tests at the end will fail, but that is not relevant to the modified GetSuggestions code. 4) apply patch 5) perldoc C4::Suggestions -- notice it is corrected now. 6) prove -v t/db_dependent/Suggestions.t -- it should run with the same results as in step 3. That is, if you have 8 itemtypes, all pass, otherwise those two tests fail. 7) run koha qa test tool Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Mason James commit 771c294c7419818e47009e0af1335ba0410ad80a Author: Fridolin Somers Date: Fri Dec 5 15:50:05 2014 +0100 Bug 13401 - sort branches alphabetically in admin/authorised_values.pl This patch adds a sort of branches alphabetically by name in authorised values administration, like in many other pages. Also replaces var $branch (too ambigus) by $branchcode. Test plan : - Create 2 branches : code=AAA,name=Zbranch and code=ZZZ,name=Abranch - Create a new authorized value : admin/authorised_values.pl - Look at "Libraries limitation" : => Without patch branches are sorted by code : Zbranch then Abranch => Without patch branches are sorted by name : Abranch then Zbranch - Select a branch and save - Re-edit => Check the same branch is selected Followed test plan. Patch behaves as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: C4/Suggestions.pm | 8 ++++---- admin/authorised_values.pl | 8 ++++---- installer/data/mysql/it-IT/necessari/parameters.sql | 4 ---- installer/data/mysql/ru-RU/optional/sample_currency.sql | 2 -- installer/data/mysql/uk-UA/optional/sample_currency.sql | 2 -- 5 files changed, 8 insertions(+), 16 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 05:35:22 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 04:35:22 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-25-gff8bcdc Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via ff8bcdc2e203f66a2dc4f2e5182428fcc07ff7c8 (commit) from 06c173efd58ea46da21a7e4a68247704e42b3733 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ff8bcdc2e203f66a2dc4f2e5182428fcc07ff7c8 Author: Kyle M Hall Date: Wed May 21 11:09:04 2014 -0700 Bug 12323 [SIGNED OFF] - Acquisitions search results fixed in order of biblionumber The acquisitions search is exhibiting the same behavior as bug 11410. Results are always fixed in order of biblionumber, among other possible issues ( including the ampersand issue ). Test Plan: 1) From an open basket, choose "Add to basket" 2) Run a search for "From an existing record" 3) Note the "View MARC" URLs are fixed in order of biblionumber 4) Apply this patch 5) Refresh the page 6) Note the results are no longer fixed in order of biblionumber Signed-off-by: David Cook Works as described. I think the code could be a bit tidier, but I think it makes sense to use buildQuery here. It'll detect CCL, CQL, and PQF queries, as well as parsing a regular keyword search as one would expect when searching the catalogue. It also has the added bonus of performing relevance searching, so long as QueryAutoTruncation is off, and so long as library staff avoid using the "*" truncation wildcard (see bug 12430). While there are simpler ways to fix this acq bug, I think this was probably the best move, as it adds a bit to the consistency of what librarians can expect from their search results. Signed-off-by: Jonathan Druart Same result with and without the patch but I agree with the changes. BuildQuery should be called before SimpleSearch if QP is not used. Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: acqui/neworderbiblio.pl | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 05:47:49 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 04:47:49 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-26-g8705cb8 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 8705cb845ef78c5e941a7a1ee8765fdd8cc40e8b (commit) from ff8bcdc2e203f66a2dc4f2e5182428fcc07ff7c8 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8705cb845ef78c5e941a7a1ee8765fdd8cc40e8b Author: Jacek Ablewicz Date: Tue Dec 16 12:48:09 2014 +0100 Bug 13431 - Shared FastMmap file causes issues Koha::Cache package does not take into account that, when using fastmmap caching variant, mmaped cache file created in /tmp (typically: /tmp/sharefile-koha-koha), would only be further accessible to the one given OS user - the one which created it. In many Koha setups, in the circumstances when various system scripts are executed by 2+ users with diffrent UIDs (like multi-tenant servers, for example) this may cause many kinds of issues. Observable symptom is usually the appearance of the below error when searching, or looking at MARC Framework pages and a few other places: Open of share file /tmp/sharefile-koha-koha failed: Permission denied at /usr/lib/perl5/Cache/FastMmap.pm line 640. This patch: - disables initialisation of fastmmap caching subsystem unless it is explicitly requested by the user (CACHING_SYSTEM=fastmmap) - disables fastmmap cache usage for command line scripts (i.e. when GATEWAY_INTERFACE environment variable is not defined) - adds the database name, host name and an ID of the OS user to the mmaped file name created in /tmp, to prevent various kinds of unintentional conflicts and/or permission problems from happening To test: 1) remove the /tmp/sharefile-koha-* file[s] (if any) 2) do something which would lead to its re-creation (e.g., performing any search in OPAC should be sufficient to cause that) 3) observe that /tmp/sharefile-koha-koha got created 4) remove it 5) apply patch 6) redo step 2) 7) observe that aforementioned file is no longer created in /tmp 8) set CACHING_SYSTEM environment variable to 'fastmmap' 9) redo step 2), observe that /tmp/sharefile-koha-* file got created and that it's name now contains hostname, database name and UID 10) ensure that everything still works like it should and that there are no regressions of any kinds anywhere in the system ;) Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: Koha/Cache.pm | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 05:50:39 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 04:50:39 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-27-g081ce4b Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 081ce4ba27ec032e70a57d7f056e8aaa23490542 (commit) from 8705cb845ef78c5e941a7a1ee8765fdd8cc40e8b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 081ce4ba27ec032e70a57d7f056e8aaa23490542 Author: Jacek Ablewicz Date: Tue Dec 30 10:30:30 2014 +0100 Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues 1) Removed 'use C4::Context;' because it can lead to introduction of circular reference in the near future 2) Put fastmmap initialization code into an eval {} block, to catch various kinds of errors which can still occur during it's init in some [less usual] Koha setups and/or more unusual circumstances 3) Do not include UID in the sharefile name (it will be constructed using namespace + database name + database host instead). Test plan addendum: s/and UID// Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: Koha/Cache.pm | 33 ++++++++++++++++++++++----------- 1 file changed, 22 insertions(+), 11 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 06:01:08 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 05:01:08 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-29-g94a4c5f Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 94a4c5fd95c8a79b9c03fc9700eb9e74b1265379 (commit) via 542b6770c606d6e42b4020d1bf4a19f43a6548a9 (commit) from 081ce4ba27ec032e70a57d7f056e8aaa23490542 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 94a4c5fd95c8a79b9c03fc9700eb9e74b1265379 Author: Kyle M Hall Date: Tue Jan 20 10:11:24 2015 -0500 Bug 13603 - autoBarcode setting hbyymmincr not taking month into account when looking up next increment The hbyymmincr autoBarcode builder looks up all barcodes that begin with any number of letters ( the branchcode ) and a two-digit year directly afterward ( e.g. MPL15 ), then grabs the last four digits as the increment counter. The problem is, this does not take months into account, so unlike the description that says the system is limited to 10,000 items a month, it is limited to 10,000 items per *year*. This situation can easily be corrected my adding the month into the lookup ( e.g. MPL1501 ). Test Plan: 1) Enable autoBarcode, set to hbyymmincr 2) Catalog an item, let the barcode.pl plugin generate the next barcode. 3) Catalog an item with the barcode MPL15009999 4) Catalog another item, use the barcode.pl plugin to generate the next barcode. 5) Note the barcode is generated ends with '0001' instead of the correct increment 6) Apply this patch 7) Repeat step 4 8) Note the barcode now ends with the correct increment Signed-off-by: Kyle M Hall Signed-off-by: Jeanne Heicher Signed-off-by: Katrin Fischer Problem confirmed - the continuing number bit was not reset to start counting from 1 again on the beginning of a new month. Signed-off-by: Mason James commit 542b6770c606d6e42b4020d1bf4a19f43a6548a9 Author: Jonathan Druart Date: Wed Nov 26 15:14:59 2014 +0100 Bug 13343: Embed items when send a basket/shelf When a basket/shelf is downloaded, items are embedded, but not when sending it by email. We would expect to get the same file. Test plan: On Opac and intranet: 1/ Add records with items to your basket and send it by email. Verify the file contains items. 2/ Add records with items to a list and send it by email. Verify the file contains items. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: C4/Barcodes/ValueBuilder.pm | 9 +++++---- basket/sendbasket.pl | 2 +- opac/opac-sendbasket.pl | 2 +- opac/opac-sendshelf.pl | 2 +- virtualshelves/sendshelf.pl | 2 +- 5 files changed, 9 insertions(+), 8 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 06:06:15 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 05:06:15 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-30-g8ac1c24 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 8ac1c243fe86fc9a77f54f1d21d3448491d27da0 (commit) from 94a4c5fd95c8a79b9c03fc9700eb9e74b1265379 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8ac1c243fe86fc9a77f54f1d21d3448491d27da0 Author: Martin Renvoize Date: Tue Sep 2 09:14:03 2014 +0000 Bug 12858: Add error handling to Syndetics Index * Syndetics routines include a statement to check that the returned content from Syndetics is xml. The get_syndetics_index routine was missing this check and so when a 'not found' html page was returned the opac-detail page would take a long time to load whilst xml::simple attempted to parse the large html document. Test Plan 1. Enable Syndetics indexes on opac. 2. Head over to an opac-detail page on the opac. 3. Remove the ISBN from the same item in the staff client. 4. Reload the opac-detail page for the item noticeing a much slower page load. 5. Apply the patch 6. Reload the opac-detail page for the item and note that it now laods in a reasonable timescale again. Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: C4/External/Syndetics.pm | 3 +++ 1 file changed, 3 insertions(+) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 06:07:07 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 05:07:07 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-31-g4c8c1e1 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 4c8c1e1cd0b2894404d3147e1f480dcdb6def330 (commit) from 8ac1c243fe86fc9a77f54f1d21d3448491d27da0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4c8c1e1cd0b2894404d3147e1f480dcdb6def330 Author: Kyle M Hall Date: Fri Feb 20 07:23:15 2015 -0500 Bug 12858 [QA Followup] - Don't call webservice if we have no data Signed-off-by: Kyle M Hall Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: C4/External/Syndetics.pm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Feb 26 06:23:02 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Thu, 26 Feb 2015 05:23:02 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-32-g5766392 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 576639251ce56385b90ebc96bd9327260723927b (commit) from 4c8c1e1cd0b2894404d3147e1f480dcdb6def330 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 576639251ce56385b90ebc96bd9327260723927b Author: Bernardo Gonzalez Kriegel Date: Sun Feb 22 20:06:34 2015 -0300 Translation updates for Koha 3.16.08 release Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: .../po/am-Ethi-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/am-Ethi-opac-bootstrap.po | 4 +- .../po/ar-Arab-i-opac-t-prog-v-3006000.po | 8 +- .../po/ar-Arab-i-staff-t-prog-v-3006000.po | 778 +- misc/translator/po/ar-Arab-opac-bootstrap.po | 33 +- misc/translator/po/ar-Arab-pref.po | 13 +- .../po/az-AZ-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/az-AZ-opac-bootstrap.po | 4 +- .../po/be-BY-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/be-BY-opac-bootstrap.po | 4 +- misc/translator/po/ben-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/ben-opac-bootstrap.po | 4 +- .../po/bg-Cyrl-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/bg-Cyrl-opac-bootstrap.po | 4 +- .../po/ca-ES-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/ca-ES-opac-bootstrap.po | 4 +- .../po/cs-CZ-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/cs-CZ-opac-bootstrap.po | 4 +- .../po/da-DK-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/da-DK-opac-bootstrap.po | 4 +- .../po/de-CH-i-staff-t-prog-v-3006000.po | 6645 +++------- misc/translator/po/de-CH-opac-bootstrap.po | 2008 +-- misc/translator/po/de-CH-pref.po | 30 +- misc/translator/po/de-CH-staff-help.po |12861 +++++-------------- .../translator/po/de-DE-i-opac-t-prog-v-3006000.po | 12 +- .../po/de-DE-i-staff-t-prog-v-3006000.po | 6625 +++------- misc/translator/po/de-DE-opac-bootstrap.po | 2016 +-- misc/translator/po/de-DE-pref.po | 30 +- misc/translator/po/de-DE-staff-help.po |12867 +++++--------------- .../po/el-GR-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/el-GR-opac-bootstrap.po | 4 +- .../po/en-GB-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/en-GB-opac-bootstrap.po | 4 +- .../po/en-NZ-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/en-NZ-opac-bootstrap.po | 4 +- misc/translator/po/eo-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/eo-opac-bootstrap.po | 4 +- .../po/es-ES-i-staff-t-prog-v-3006000.po | 665 +- misc/translator/po/es-ES-opac-bootstrap.po | 8 +- misc/translator/po/es-ES-pref.po | 7 +- misc/translator/po/eu-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/eu-opac-bootstrap.po | 4 +- .../po/fa-Arab-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/fa-Arab-opac-bootstrap.po | 4 +- .../po/fi-FI-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/fi-FI-opac-bootstrap.po | 4 +- .../po/fo-FO-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/fo-FO-opac-bootstrap.po | 4 +- .../po/fr-CA-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/fr-CA-opac-bootstrap.po | 4 +- .../po/fr-FR-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/fr-FR-opac-bootstrap.po | 4 +- misc/translator/po/gl-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/gl-opac-bootstrap.po | 4 +- .../po/he-Hebr-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/he-Hebr-opac-bootstrap.po | 4 +- misc/translator/po/hi-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/hi-opac-bootstrap.po | 4 +- .../po/hr-HR-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/hr-HR-opac-bootstrap.po | 4 +- .../po/hu-HU-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/hu-HU-opac-bootstrap.po | 4 +- .../po/hy-Armn-i-opac-t-prog-v-3006000.po | 6 +- .../po/hy-Armn-i-staff-t-prog-v-3006000.po | 665 +- misc/translator/po/hy-Armn-opac-bootstrap.po | 10 +- misc/translator/po/hy-Armn-pref.po | 5 +- .../po/id-ID-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/id-ID-opac-bootstrap.po | 4 +- .../po/is-IS-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/is-IS-opac-bootstrap.po | 4 +- .../po/it-IT-i-staff-t-prog-v-3006000.po | 6349 +++------- misc/translator/po/it-IT-opac-bootstrap.po | 1966 +-- misc/translator/po/it-IT-pref.po | 12 +- misc/translator/po/it-IT-staff-help.po |12293 +++++-------------- .../po/ja-Jpan-JP-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/ja-Jpan-JP-opac-bootstrap.po | 4 +- .../po/km-KH-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/km-KH-opac-bootstrap.po | 4 +- .../po/kn-Knda-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/kn-Knda-opac-bootstrap.po | 4 +- .../po/ko-Kore-KP-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/ko-Kore-KP-opac-bootstrap.po | 4 +- .../po/ku-Arab-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/ku-Arab-opac-bootstrap.po | 4 +- .../po/lo-Laoo-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/lo-Laoo-opac-bootstrap.po | 4 +- .../po/mi-NZ-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/mi-NZ-opac-bootstrap.po | 4 +- misc/translator/po/mon-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/mon-opac-bootstrap.po | 4 +- misc/translator/po/mr-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/mr-opac-bootstrap.po | 4 +- .../po/ms-MY-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/ms-MY-opac-bootstrap.po | 4 +- .../po/nb-NO-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/nb-NO-opac-bootstrap.po | 4 +- .../po/ne-NE-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/ne-NE-opac-bootstrap.po | 4 +- .../po/nl-BE-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/nl-BE-opac-bootstrap.po | 4 +- .../po/nl-NL-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/nl-NL-opac-bootstrap.po | 4 +- .../po/nn-NO-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/nn-NO-opac-bootstrap.po | 4 +- misc/translator/po/pbr-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/pbr-opac-bootstrap.po | 4 +- .../po/pl-PL-i-staff-t-prog-v-3006000.po | 738 +- misc/translator/po/pl-PL-opac-bootstrap.po | 15 +- misc/translator/po/pl-PL-pref.po | 22 +- misc/translator/po/pl-PL-staff-help.po | 927 +- misc/translator/po/prs-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/prs-opac-bootstrap.po | 4 +- .../po/pt-BR-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/pt-BR-opac-bootstrap.po | 4 +- .../po/pt-PT-i-staff-t-prog-v-3006000.po | 685 +- misc/translator/po/pt-PT-opac-bootstrap.po | 24 +- misc/translator/po/pt-PT-pref.po | 4 +- .../po/ro-RO-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/ro-RO-opac-bootstrap.po | 4 +- .../po/ru-RU-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/ru-RU-opac-bootstrap.po | 4 +- .../po/rw-RW-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/rw-RW-opac-bootstrap.po | 4 +- .../po/sd-PK-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/sd-PK-opac-bootstrap.po | 4 +- .../po/sk-SK-i-staff-t-prog-v-3006000.po | 665 +- misc/translator/po/sk-SK-opac-bootstrap.po | 4 +- misc/translator/po/sk-SK-pref.po | 2 +- .../po/sl-SI-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/sl-SI-opac-bootstrap.po | 4 +- .../po/sq-AL-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/sq-AL-opac-bootstrap.po | 4 +- .../po/sr-Cyrl-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/sr-Cyrl-opac-bootstrap.po | 4 +- .../po/sv-SE-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/sv-SE-opac-bootstrap.po | 4 +- .../po/sw-KE-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/sw-KE-opac-bootstrap.po | 4 +- .../po/ta-LK-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/ta-LK-opac-bootstrap.po | 4 +- misc/translator/po/ta-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/ta-opac-bootstrap.po | 4 +- misc/translator/po/tet-i-staff-t-prog-v-3006000.po | 2886 +++-- misc/translator/po/tet-opac-bootstrap.po | 10 +- .../po/th-TH-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/th-TH-opac-bootstrap.po | 4 +- .../po/tl-PH-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/tl-PH-opac-bootstrap.po | 4 +- .../po/tr-TR-i-staff-t-prog-v-3006000.po | 673 +- misc/translator/po/tr-TR-opac-bootstrap.po | 4 +- misc/translator/po/tr-TR-pref.po | 1 + .../po/uk-UA-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/uk-UA-opac-bootstrap.po | 4 +- .../po/ur-Arab-i-staff-t-prog-v-3006000.po | 655 +- misc/translator/po/ur-Arab-opac-bootstrap.po | 4 +- .../po/vi-VN-i-staff-t-prog-v-3006000.po | 663 +- misc/translator/po/vi-VN-opac-bootstrap.po | 4 +- .../po/zh-Hans-CN-i-staff-t-prog-v-3006000.po | 659 +- misc/translator/po/zh-Hans-CN-opac-bootstrap.po | 4 +- .../po/zh-Hans-TW-i-opac-t-prog-v-3006000.po | 16 +- .../po/zh-Hans-TW-i-staff-t-prog-v-3006000.po | 675 +- misc/translator/po/zh-Hans-TW-opac-bootstrap.po | 19 +- misc/translator/po/zh-Hans-TW-pref.po | 1 + 163 files changed, 40311 insertions(+), 72680 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Feb 27 15:14:33 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 27 Feb 2015 14:14:33 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-35-g97b7968 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 97b79687b35b6620365cc5d5f2bf991ea7ac3d7b (commit) via 42f92b49b3d714d4509ea24a81cd9b10870b485a (commit) via 9751fdf9701f4e9e725138c1524865d35b894ce3 (commit) from 576639251ce56385b90ebc96bd9327260723927b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 97b79687b35b6620365cc5d5f2bf991ea7ac3d7b Author: Mason James Date: Thu Feb 26 18:33:18 2015 +1300 Bumping version number for 3.16.8 release commit 42f92b49b3d714d4509ea24a81cd9b10870b485a Author: Mason James Date: Sat Feb 28 03:17:59 2015 +1300 Revert "Bug 13431 - Shared FastMmap file causes issues" This reverts commit 8705cb845ef78c5e941a7a1ee8765fdd8cc40e8b. commit 9751fdf9701f4e9e725138c1524865d35b894ce3 Author: Mason James Date: Sat Feb 28 03:17:49 2015 +1300 Revert "Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues" This reverts commit 081ce4ba27ec032e70a57d7f056e8aaa23490542. ----------------------------------------------------------------------- Summary of changes: Koha/Cache.pm | 35 ++++++++------------------------ installer/data/mysql/updatedatabase.pl | 7 +++++++ kohaversion.pl | 2 +- 3 files changed, 17 insertions(+), 27 deletions(-) hooks/post-receive -- main Koha release repository