[koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-11-gf3b90f7

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.18.x has been updated
       via  f3b90f78f5010aaa9e705026e3db556a40fccaa1 (commit)
       via  c619aa9f7fd3363975d6d2743fb024279aec85be (commit)
       via  754c44183f908647b8fa66b56aa4715709ee71e5 (commit)
       via  d059d907e1d4bffa173c9b0a5d3a187d546df09d (commit)
      from  46de4d267ade7cfc9a4302e522a040a6feb6cad1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f3b90f78f5010aaa9e705026e3db556a40fccaa1
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Dec 30 13:54:50 2014 +0000

    Bug 12954: Failed login should retain anonymous session
    
    A failed login should not leave the user in a half logged authenticated
    state, but rather return them to an anonymouse session as per the
    pre-login attempt state.
    
    To replicate error:
    1. Try to log in with some nonexisting user id or wrong password in the
       OPAC
    2. Go directly to /opac-user.pl (e.g., enter it in the browser address
       bar, or just click on the "Log in" link)
    3. Observe a DBI error displayed on the screen
    4. You are now in the "deadloop" of sorts (opac/opac-user.pl refuses to
       display the login screen, no matter how many times you try to reload
       it); to break the deadloop, one needs to:
       - remove session cookie from the browser (or cause the session to
         expire in some other way - closing browser window would be probably
         enough for that)
       - remove offending session on the server (from mysql sessions table,
        ..)
       - log in with proper credentials using some other page (like
         opac/opac-main.pl right-side panel), which does not involve
         opac/opac-user.pl being called without "userid" CGI parameter.
    
    To test:
    1. Test as above, the DBI error should no longer be present
    2. Check that search history works across failed and sucessful login
       attempts
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 229a3b329c9fbe1567a9cd0796dce7ddf1aca781)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit c619aa9f7fd3363975d6d2743fb024279aec85be
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Jan 6 06:54:00 2015 +0000

    Bug 13521: Add missing semicolon
    
    Add a missing semicolon to the end of a template variable assignment
    line. This patch should not affect operation.
    
    Note: With Bug 13499 we did a non-destructive perltidy, as such we only
    affected indenting and whitespace to maintain blame history. However, a
    number of minor code issues were also highlighted, in this series of
    patches I hope to correct other minor style issues.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit f73dc51a88e63a7ef7cf30d3d88c09b30bb2c177)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit 754c44183f908647b8fa66b56aa4715709ee71e5
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Tue Jan 6 06:48:29 2015 +0000

    Bug 13521: Removed superflous semicolon
    
    Removed an uneeded semicolon from the end of an 'if' block. This should
    not affect operation of the script.
    
    Note: With Bug 13499 we did a non-destructive perltidy, as such we only
    affected indenting and whitespace to maintain blame history. However, a
    number of minor code issues were also highlighted, in this series of
    patches I hope to correct other minor style issues.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit a36c7435f23b7d69e8286370774fbb8554e7f98f)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit d059d907e1d4bffa173c9b0a5d3a187d546df09d
Author: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Date:   Mon Jan 5 22:45:44 2015 +0000

    Bug 13499: Tidy of Auth.pm
    
    This tidy should only change whitespace and not line breaks, thus
    retaining history.
    
    There are no code changes, and thus there should be no regressions to
    test for koha wise.
    
    To test the non-destrcutive nature of the patch, run a 'git blame -w' on
    the file before and after the patch. The resulting blame should include
    a comparabile history of the file, with only some additional blank
    lines being attributed to this commit.
    
    A 'git blame -wM' may also be useful for comparison purposes.
    
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 1926bf9d0180315f6e51431e3d514a8d53ce3b9c)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm | 1236 ++++++++++++++++++++++++++++++++----------------------------
 1 file changed, 652 insertions(+), 584 deletions(-)


hooks/post-receive
-- 
main Koha release repository