[koha-commits] main Koha release repository branch master updated. v3.18.00-260-g42c3429
Git repo owner
gitmaster at git.koha-community.org
Thu Feb 5 19:21:50 CET 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 42c342972ab9aed7f3674be4fc226a4806cb5ffc (commit)
via d3c128af9d4e3890cf6cf84fc4bf2c1fc4f9d24c (commit)
via 41181b27087b1b547e8a487afc3207e9677fab6d (commit)
via 10280c091ce8d7cd6fca3d648b145713bb837157 (commit)
via 135f98ee620cff5eb76d7fff64c767b0cb49cef1 (commit)
via 6fd9c909014b488bb383e0488a539512fae39bc2 (commit)
via e2968fe0812898d92ce8c63e9c7f0dedd244acc9 (commit)
via 1c62f1a9783bb8a171352e0b66d910056ccfe0d4 (commit)
via a7c41e6073a2719e21f86909a37daab6410b2b96 (commit)
from 522e9c5861854fad7c9b292f75ebd19968f5b11c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 42c342972ab9aed7f3674be4fc226a4806cb5ffc
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Thu Feb 5 15:25:50 2015 -0300
Bug 13262: (QA followup) fix duplicate variable definition
Running
$ prove t/db_dependent/XSLT_Handler.t
raises a couple warnings because of variable redefinitions. This small patch fixes that.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit d3c128af9d4e3890cf6cf84fc4bf2c1fc4f9d24c
Author: David Cook <dcook at prosentient.com.au>
Date: Mon Nov 17 13:59:49 2014 +1100
Bug 13262 - Add parameters to XSLT Handler transform method
This patch adds an optional hashref argument to the XSLT_Handler
transform() method. It allows you to send key => value pairs
parameters to the XML::LibXSLT object, which you can reference
in a XSLT via <xsl:param name="XXX" />.
The parameter value is evaluated as an XPath query, so you can only
pass quoted strings (i.e. "'test'") or numbers. Otherwise, the
XSLT engine will interpret it as a Xpath query and will run it
on the XML that you're transforming.
The most common use case is sending strings to a XSLT. In my case,
this is an OAI-PMH identifier that comes in a OAI response but not
the actual metadata. See the following link from the official POD:
http://search.cpan.org/~shlomif/XML-LibXSLT-1.92/LibXSLT.pm#Parameters
_TEST PLAN_
1) Run "perl t/db_dependent/XSLT_Handler.t". If all tests pass,
you should be free to sign off. Feel free to inspect the last
test in XSLT_Handler.t and the XSL in test04.xsl to see how it
works.
If you really want to be thorough, you could write your own test
cases using mine as an example.
Alternatively, you could go into C4::XSLT, and try to pass a
value to a parameter in the search results or the detail page,
but that might be a bit over the top.
It's a pretty simple patch.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 41181b27087b1b547e8a487afc3207e9677fab6d
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Thu Feb 5 15:21:51 2015 -0300
Bug 12601: (RM followup) DBIx updates
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 10280c091ce8d7cd6fca3d648b145713bb837157
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Thu Feb 5 15:17:47 2015 -0300
Bug 12601: DBRev 3.19.00.008
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 135f98ee620cff5eb76d7fff64c767b0cb49cef1
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Jul 18 12:34:07 2014 +0200
Bug 12601: Add a foreign key for aqorders.budget_id
When creating an order, the fund value is mandatory but the DB structure
does not show this constraint.
The aqorders.budget_id field should be linked to aqbudgets.budget_id.
The updatedatabase.pl (entry 3.01.00.077) commented this constraint,
certainly for a retro compatibility reason.
Actually I found some cases (in production) where aqorders.budget_id is
set to "0". To add this constraint, we should add a temporary fund to
linked orphan orders.
Test plan:
0/ Verify it is not possible to create an order not linked to a fund via
the Koha interface.
1/ Using your SQL CLI (or equivalent), create or update 1+ orders and set
"0" in the budget_id field.
2/ Execute the updatedabase script.
3/ Verify that your order is linked to a new fund (which is linked to a
new budget).
4/ Verify the constraint has correctly been added (show create table
aqorders).
Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 6fd9c909014b488bb383e0488a539512fae39bc2
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Thu Feb 5 15:15:22 2015 -0300
Bug 12905: DBRev 3.19.00.007
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit e2968fe0812898d92ce8c63e9c7f0dedd244acc9
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Jan 29 16:18:19 2015 +0100
Bug 12860: the export tools explodes if a field is not exported
To reproduce:
1/ Go on tools/export.pl
2/ Export some records and specify you don't want the fields 245 (the
whole field, do not specify a subfield).
3/ Export, BOOM
Software error:
Arguments must be MARC::Field object at /home/koha/src/tools/export.pl line 400.
Test plan:
Apply the patch and confirm the fields 245 are not exported and the
export works as expected.
Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
Export fails to asplode with this patch
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 1c62f1a9783bb8a171352e0b66d910056ccfe0d4
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Nov 17 17:17:49 2014 +0100
Bug 13270: Don't display "vendor note" label if nothing to display
Bug 12111 removes the vendor note edition on receiving.
The label should not be displayed when it's empty.
Test plan:
1/ Receive an order without a vendor note and verify that the label is not
displayed.
2/ Receive an order with a vendor note and verify that the note is
displayed.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Works as described, small template change.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit a7c41e6073a2719e21f86909a37daab6410b2b96
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Jan 1 16:38:34 2015 -0500
Bug 13441 - Branchcodes should not be allowed to have spaces in them
In multiple cases I've seen issues arise in Koha where a librarian
accidentally puts a space at the end of a new branchcode. This of course
causes endless confusion because the branchcode looks perfectly fine in
every case unless you wrap the code with some characters to reveal the
hidden space!
Test Plan:
1) Try creating a new branch with one or more spaces in the branchcode
2) Note you are able to
3) Apply this patch
4) Repeat step 1
5) Note you are no longer able to
Followed test plan with cache cleared. Works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described, passes tests and QA script.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
Koha/Schema/Result/Aqbudget.pm | 19 ++++++++-
Koha/Schema/Result/Aqorder.pm | 22 ++++++++--
Koha/Schema/Result/AuthorisedValue.pm | 19 ++++++++-
Koha/Schema/Result/ItemsSearchField.pm | 8 ++--
Koha/XSLT_Handler.pm | 16 ++++++--
installer/data/mysql/kohastructure.sql | 1 +
installer/data/mysql/updatedatabase.pl | 43 +++++++++++++++++++-
.../prog/en/modules/acqui/orderreceive.tt | 4 +-
.../prog/en/modules/admin/aqbudgets.tt | 1 +
.../prog/en/modules/admin/branches.tt | 20 +++++++--
kohaversion.pl | 2 +-
t/db_dependent/XSLT_Handler.t | 25 +++++++++++-
.../XSLT_Handler/{test03.xsl => test04.xsl} | 7 ++--
tools/export.pl | 2 +-
14 files changed, 163 insertions(+), 26 deletions(-)
copy t/db_dependent/XSLT_Handler/{test03.xsl => test04.xsl} (77%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list