[koha-commits] main Koha release repository branch master updated. v3.18.00-321-ga23c551
Git repo owner
gitmaster at git.koha-community.org
Thu Feb 12 19:22:56 CET 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via a23c551f3012eb1413b25ac2ef867500d5eca9fb (commit)
via d792583186d4942a8b80d0f281afd91b64f91a95 (commit)
via 089c08ea6526158bcc7a1f770fec0db2e714c9c7 (commit)
via 074428bb8a36788507f4282136a0eaf6aec92b54 (commit)
via d562df4af2f9de0e0aa94d03b40b464e10cd8737 (commit)
via 3107975ba95f5853ea1084afa01db598e4adeeea (commit)
via 6f0316a8d298b023fb74351d9ffff51fdeb31119 (commit)
via 295fb70f62069c0b1fbed2d9bbdf2650f58e488c (commit)
via fcaa6f35c080c079ba422a70dec49ca327346c82 (commit)
via dbf0b358b9362fdf634b47569b1777d7034b17a9 (commit)
via 9e701294dd6ccf4fa5d8b24d1a7da15be353992e (commit)
from 155ce56ad811954802090faf2994278f7c9dcbf2 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a23c551f3012eb1413b25ac2ef867500d5eca9fb
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Feb 10 14:01:51 2015 -0500
Bug 13019 [QA Followup] - Fix stale unit test
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit d792583186d4942a8b80d0f281afd91b64f91a95
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Feb 10 13:30:32 2015 -0500
Bug 13019 [QA Followup] - Allow chaining
By returning the object itself instead of a boolean, we can chain
methods together while retaining the exact same functionality.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 089c08ea6526158bcc7a1f770fec0db2e714c9c7
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Nov 24 06:09:54 2014 -0500
Bug 13019 [QA Followup] - Remove use of encode
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 074428bb8a36788507f4282136a0eaf6aec92b54
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Nov 24 12:46:43 2014 +0100
Bug 13019: [QA Follow-up] Rename new_from_dbic and few typos
Since new_from_dbic is not meant as a public method, this patch adds
a prefix to the name of this internal routine. For the same reason I
removed it from t/Borrower.t.
Removed one use overload-line in Objects (not used).
Resolved a few typos.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit d562df4af2f9de0e0aa94d03b40b464e10cd8737
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Nov 21 11:40:48 2014 -0500
Bug 13019 [QA Followup] - Allow find() and search() to be called as static methods
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 3107975ba95f5853ea1084afa01db598e4adeeea
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Nov 10 12:55:35 2014 +0100
Bug 13019: (follow-up) Remove smartmatch operator
This patch also adds 1 test.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 6f0316a8d298b023fb74351d9ffff51fdeb31119
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Sep 30 15:05:30 2014 -0400
Bug 13019 - Add base classes on which to build Koha objects
The idea behind this is to have a pair of base classes on which to build
our new generation of Koha objects. Koha::Object is a base class, which
in it's most basic form, is to represent a row in a table. For example,
Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio
and Koha::Item for example.
Koha::Objects is to represent a way to fetch and manipulate sets of
objects. For example, Koha::Borrowers has a method to get a
Koha::Borrower object by id and a method to search for an get a list
of Koha::Borrower objects. Right now Koha::Objects has only the
essentials but can easily be extended and those enhancements will be
passed down to all the child classes based on it.
By using these classes as a base, we will add consistency to our
code, allow us to keep our code DRY, reduce bugs, and encapsulate our
database access among other benefits.
Test Plan:
1) Apply this patch
2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 295fb70f62069c0b1fbed2d9bbdf2650f58e488c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Nov 25 10:16:47 2014 -0500
Bug 13335 - Holds and priority display via OPACShowHoldQueueDetails confusing
No matter what the selection of OPACShowHoldQueueDetails is, if it is
enabled it displays a line "Holds and priority:" even if you've opted to
hide one of those!
Test Plan:
1) Apply this patch
2) Test each setting of OPACShowHoldQueueDetails
3) Ensure each setting displays the correct fields ( or lack thereof )
Signed-off-by: Christopher Brannon <cbrannon at debian.localdomain>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit fcaa6f35c080c079ba422a70dec49ca327346c82
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Wed Jan 28 08:31:30 2015 -0500
Bug 13636 - Staff search results item status incorrect for holds
Imagine this scenario: we have one record with four items. Two of those
items are checked out, one of those items is a waiting hold, and one of
those items is available. We would expect to see this on the search
results page. Instead, we will see both non-checked out items as
unavailable due to waiting holds.
This is due to a semantic issue GetReserveStatus.
C4::Search::searchResults uses GetReserveStatus to get the reserve
status of each item, but unlike all other calls to the sub, this one
passes in not only itemnumber, but biblionumber.
When no reserve is found for the available item, the subroutine uses the
biblionumber to grab what is essentially an arbitrary reserve to use for
the status. This makes no sense and this functionality should be
entirely removed from the subroutine so regressions like this will be
prevented in the future.
Test Plan:
1) Create one record with 4 items
a) check two of the items out to patrons
b) set one of the items as a waiting hold
c) leave the fourth item as available
2) Run a search where this record will be in the results list
3) Note that the results list 2 items on loan, two unavailable
4) Apply this patch, reload the search results
5) Note that the results list 1 available, 2 on loan, 1 unavailable
Signed-off-by: John Andrews <jandrews at washoecounty.us>
Signed-off-by: Sheila Kearns <sheila.kearns at state.vt.us>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Note: This is for the staff search result list!
Works as expected.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit dbf0b358b9362fdf634b47569b1777d7034b17a9
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date: Tue Dec 30 10:30:30 2014 +0100
Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues
1) Removed 'use C4::Context;' because it can lead to introduction
of circular reference in the near future
2) Put fastmmap initialization code into an eval {} block, to catch
various kinds of errors which can still occur during it's init in
some [less usual] Koha setups and/or more unusual circumstances
3) Do not include UID in the sharefile name (it will be constructed
using namespace + database name + database host instead).
Test plan addendum:
s/and UID//
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 9e701294dd6ccf4fa5d8b24d1a7da15be353992e
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date: Tue Dec 16 12:48:09 2014 +0100
Bug 13431 - Shared FastMmap file causes issues
Koha::Cache package does not take into account that, when using
fastmmap caching variant, mmaped cache file created in /tmp
(typically: /tmp/sharefile-koha-koha), would only be further
accessible to the one given OS user - the one which created it.
In many Koha setups, in the circumstances when various system scripts
are executed by 2+ users with diffrent UIDs (like multi-tenant servers,
for example) this may cause many kinds of issues. Observable symptom
is usually the appearance of the below error when searching, or looking
at MARC Framework pages and a few other places:
Open of share file /tmp/sharefile-koha-koha failed: Permission denied
at /usr/lib/perl5/Cache/FastMmap.pm line 640.
This patch:
- disables initialisation of fastmmap caching subsystem unless it is
explicitly requested by the user (CACHING_SYSTEM=fastmmap)
- disables fastmmap cache usage for command line scripts
(i.e. when GATEWAY_INTERFACE environment variable is not defined)
- adds the database name, host name and an ID of the OS user to the
mmaped file name created in /tmp, to prevent various kinds of
unintentional conflicts and/or permission problems from happening
To test:
1) remove the /tmp/sharefile-koha-* file[s] (if any)
2) do something which would lead to its re-creation (e.g., performing
any search in OPAC should be sufficient to cause that)
3) observe that /tmp/sharefile-koha-koha got created
4) remove it
5) apply patch
6) redo step 2)
7) observe that aforementioned file is no longer created in /tmp
8) set CACHING_SYSTEM environment variable to 'fastmmap'
9) redo step 2), observe that /tmp/sharefile-koha-* file got created
and that it's name now contains hostname, database name and UID
10) ensure that everything still works like it should and that there
are no regressions of any kinds anywhere in the system ;)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Reserves.pm | 12 +-
C4/Search.pm | 2 +-
C4/Barcodes/incremental.pm => Koha/Borrower.pm | 43 ++-
C4/Barcodes/incremental.pm => Koha/Borrowers.pm | 47 +++-
Koha/Cache.pm | 35 ++-
Koha/Object.pm | 286 ++++++++++++++++++++
Koha/Objects.pm | 245 +++++++++++++++++
.../opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 16 +-
opac/opac-reserve.pl | 2 -
t/Borrower.t | 56 ++++
t/db_dependent/Borrower.t | 74 +++++
t/db_dependent/Borrowers.t | 93 +++++++
12 files changed, 856 insertions(+), 55 deletions(-)
copy C4/Barcodes/incremental.pm => Koha/Borrower.pm (62%)
copy C4/Barcodes/incremental.pm => Koha/Borrowers.pm (58%)
create mode 100644 Koha/Object.pm
create mode 100644 Koha/Objects.pm
create mode 100755 t/Borrower.t
create mode 100755 t/db_dependent/Borrower.t
create mode 100755 t/db_dependent/Borrowers.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list