[koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-33-g6f51d3b

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.18.x has been updated
       via  6f51d3b31b690415f9fc9bff6477d93701628b83 (commit)
       via  d31c4264552fd1fe94ca97737e0fe6365a09cf09 (commit)
      from  8c594291f3f35d6f21de48a9c261ee86cea3891e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6f51d3b31b690415f9fc9bff6477d93701628b83
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date:   Tue Jan 20 16:48:13 2015 +0200

    Bug 13602 - Username/password already exists when editing borrower attributes and messaging preferences
    
    When editing a Patron's messaging preferences or borrower attributes, one cannot
    save changes because 'userid' is not given as a parameter.
    
    It shouldn't, but the
    Check_Userid($newdata{'userid'},$borrowernumber) -check must have it.
    
    REPLICATE THE ISSUE:
    1. Find a Borrower.
    2. Go to the details-tab.
    3. Under "Patron messaging preferences" click edit to edit just the messaging
       preferences.
    4. Just save, no need to make any modifications.
    5. Observe the error "Username/password already exists"
       This happens to all/most of the sub-forms in the Borrower's Details-view.
    
    AFTER THIS PATCH:
    Check_Userid() get the $userid from the new parameters, or if not present, from
    the koha.borrowers-table.
    
    TEST FOR REGRESSION:
    1. Edit a borrower normally. Notice no errors.
    2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no
       errors.
    
    DISCLAIMER: You are free to steal/rip/modify/hack this patch to your soul's
    extent without my permission. As long as it makes to Koha I am happy.
    
    Works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 58f7f56b8664810335f60f3fe5e43faa079f33bc)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit d31c4264552fd1fe94ca97737e0fe6365a09cf09
Author: Owen Leonard <oleonard at myacpl.org>
Date:   Wed Jan 28 12:24:45 2015 -0500

    Bug 13638 - Batch patron modification tool missing option to switch language
    
    The batch patron modification tool's template was created without the
    footer include at the bottom. Without the footer include the language
    toolbar will not be displayed.
    
    All page templates should include the global footer include:
    
    [% INCLUDE 'intranet-bottom.inc' %]
    
    To test:
     - Install at least a second language
     - Enable at least 2 languages (language system preference)
     - Go to tools > Batch patron modification
     - Verify that at the bottom of the page the language chooser is shown
    
    Followed test plan. Works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 28af6c4d01e0b1a31dece34031b6379fb9befebc)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt |    5 +----
 members/memberentry.pl                                        |    6 ++++--
 2 files changed, 5 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
main Koha release repository