[koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-36-gabc4665

Git repo owner gitmaster at git.koha-community.org
Thu Feb 12 23:03:44 CET 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.18.x has been updated
       via  abc46657e5039ba9d40637624390c0a28a664c8e (commit)
      from  6e01fc7a5da9df8f645481048e023b46e378de3b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit abc46657e5039ba9d40637624390c0a28a664c8e
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Mon Jan 26 10:28:27 2015 +0100

    Bug 13352: On editing, prices should not be formatted
    
    Bug 12979 refactored the way to display prices.
    The price format configuration was duplicated everywhere it was used.
    
    All calls looks good except the one in admin/aqbudgetperiods.pl
    In this one, the prices are formatted for an edition field (input).
    This means the input is incorrectly filled even if the user does not
    update the field.
    
    At the end, maybe should we manage formatted prices everywhere, even in
    inputs, but it's not in the scope of this bug.
    
    Technically, a new subroutine format_for_editing is added to the
    Koha::Number::Price module.
    It should be called everywhere a price is displayed in an input field.
    At the moment, it only does a sprintf("%.2f"), but it is a first step to
    let the number of decimals to display configurable.
    
    To test:
    1/ Verify the issue described is fixed (editing a budget with a total
    amount > 1000 (With CurrencyFormat is US or FR).
    2/ Verify you can edit a fund with a total amount > 1000
    
    Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 945a0f09e73606907d6df72b873e478cc6763c14)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    
    Conflicts:
    	admin/aqbudgetperiods.pl
    	t/Prices.t

-----------------------------------------------------------------------

Summary of changes:
 Koha/Number/Price.pm                               |   15 +
 Koha/Template/Plugin/Price.pm                      |    9 +-
 admin/aqbudgetperiods.pl                           |   47 +--
 admin/aqbudgets.pl                                 |    1 -
 .../prog/en/modules/admin/aqbudgetperiods.tt       |    7 +-
 .../prog/en/modules/admin/aqbudgets.tt             |    6 +-
 t/Prices.t                                         |  412 ++++++++++++++++++++
 7 files changed, 461 insertions(+), 36 deletions(-)
 create mode 100644 t/Prices.t


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list