[koha-commits] main Koha release repository branch 3.18.x updated. v3.18.03-57-gfa74808

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.18.x has been updated
       via  fa74808736d9aea8df6fff1bf9e146c62d95046c (commit)
       via  38663a4af3e4bbb43a46d0f723cb243dc30eba5e (commit)
      from  cb565836b323be2525241759bfd3b45c691d7115 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fa74808736d9aea8df6fff1bf9e146c62d95046c
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date:   Tue Dec 30 10:30:30 2014 +0100

    Bug 13431 [QA Follow-up]: Shared FastMmap file causes issues
    
    1) Removed 'use C4::Context;' because it can lead to introduction
    of circular reference in the near future
    2) Put fastmmap initialization code into an eval {} block, to catch
    various kinds of errors which can still occur during it's init in
    some [less usual] Koha setups and/or more unusual circumstances
    3) Do not include UID in the sharefile name (it will be constructed
    using namespace + database name + database host instead).
    
    Test plan addendum:
    
       s/and UID//
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit dbf0b358b9362fdf634b47569b1777d7034b17a9)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit 38663a4af3e4bbb43a46d0f723cb243dc30eba5e
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date:   Tue Dec 16 12:48:09 2014 +0100

    Bug 13431 - Shared FastMmap file causes issues
    
    Koha::Cache package does not take into account that, when using
    fastmmap caching variant, mmaped cache file created in /tmp
    (typically: /tmp/sharefile-koha-koha), would only be further
    accessible to the one given OS user - the one which created it.
    In many Koha setups, in the circumstances when various system scripts
    are executed by 2+ users with diffrent UIDs (like multi-tenant servers,
    for example) this may cause many kinds of issues. Observable symptom
    is usually the appearance of the below error when searching, or looking
    at MARC Framework pages and a few other places:
    
    Open of share file /tmp/sharefile-koha-koha failed: Permission denied
    at /usr/lib/perl5/Cache/FastMmap.pm line 640.
    
    This patch:
    - disables initialisation of fastmmap caching subsystem unless it is
    explicitly requested by the user (CACHING_SYSTEM=fastmmap)
    - disables fastmmap cache usage for command line scripts
    (i.e. when GATEWAY_INTERFACE environment variable is not defined)
    - adds the database name, host name and an ID of the OS user to the
    mmaped file name created in /tmp, to prevent various kinds of
    unintentional conflicts and/or permission problems from happening
    
    To test:
    
    1) remove the /tmp/sharefile-koha-* file[s] (if any)
    2) do something which would lead to its re-creation (e.g., performing
    any search in OPAC should be sufficient to cause that)
    3) observe that /tmp/sharefile-koha-koha got created
    4) remove it
    5) apply patch
    6) redo step 2)
    7) observe that aforementioned file is no longer created in /tmp
    8) set CACHING_SYSTEM environment variable to 'fastmmap'
    9) redo step 2), observe that /tmp/sharefile-koha-* file got created
    and that it's name now contains hostname, database name and UID
    10) ensure that everything still works like it should and that there
    are no regressions of any kinds anywhere in the system ;)
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 9e701294dd6ccf4fa5d8b24d1a7da15be353992e)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Cache.pm |   35 ++++++++++++++++++++++++++---------
 1 file changed, 26 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository