[koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-12-g0c8defb

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.16.x has been updated
       via  0c8defb752d65a3562f35ace90780d075043b21f (commit)
      from  b82756048119415dd1a4d48babebe5a7f29c1216 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0c8defb752d65a3562f35ace90780d075043b21f
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date:   Thu Jan 8 14:50:52 2015 +0200

    Bug 13025 - Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925
    
    This error only appears when using the SIPServer, it doesn't manifest when using the SIP unit tests
    or when using the staff client.
    
    --------------------
     ------------------
      PREPARE THE TEST
     ------------------
    --------------------
    
    0a. Find a borrower.
    0b. Find an Item (cardnumber 'debar123') and check-out to the borrower
    0c. Find a borrower and add a manual debarrment to it, indefinetely in effect.
        This is the default behaviour.
    0d. Configure and start a SIP-server which you can access with telnet.
        See http://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
        In this example, the Borrower defined as the Check-out/in machine has the following credentials:
        username: herkules password: palautathan branchcode: JOE_JOE
        but you are free to use your own, it doesn't affect this test plan.
    0e. access your server with telnet
    
    -----------------------
     ---------------------
      REPLICATE THE ISSUE
     ---------------------
    -----------------------
    1. Paste the following SIP-command to login:
    9300CNherkules|COpalautathan|CPJOE_JOE|
    2. Paste the following SIP-command to check-in the Item of the debarred Borrower:
    09N20140721    07501620140721    075016AP|AO|ABdebar123|AC|BIN|
    3. The connection should die and in the SIP Server's error log you can find the following error:
    Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925
    
    --------------------
     ------------------
      AFTER THIS PATCH
     ------------------
    --------------------
    
    Redo steps 1-2.
    3. No error is given and the connection doesn't die.
    
    No unit tests included and never will, because setting up the test environment would be very tedious.
    It is entirely possible but the scaffolding required is beyond the scope of this patch.
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Note: I did not test this patch with SIP, but I did not find any
    regression on checking or renewing an item.
    Signed-off-by: Mason James <mtj at kohaaloha.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Circulation.pm |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository