[koha-commits] main Koha release repository branch 3.16.x updated. v3.16.07-26-g8705cb8

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.16.x has been updated
       via  8705cb845ef78c5e941a7a1ee8765fdd8cc40e8b (commit)
      from  ff8bcdc2e203f66a2dc4f2e5182428fcc07ff7c8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8705cb845ef78c5e941a7a1ee8765fdd8cc40e8b
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date:   Tue Dec 16 12:48:09 2014 +0100

    Bug 13431 - Shared FastMmap file causes issues
    
    Koha::Cache package does not take into account that, when using
    fastmmap caching variant, mmaped cache file created in /tmp
    (typically: /tmp/sharefile-koha-koha), would only be further
    accessible to the one given OS user - the one which created it.
    In many Koha setups, in the circumstances when various system scripts
    are executed by 2+ users with diffrent UIDs (like multi-tenant servers,
    for example) this may cause many kinds of issues. Observable symptom
    is usually the appearance of the below error when searching, or looking
    at MARC Framework pages and a few other places:
    
    Open of share file /tmp/sharefile-koha-koha failed: Permission denied
    at /usr/lib/perl5/Cache/FastMmap.pm line 640.
    
    This patch:
    - disables initialisation of fastmmap caching subsystem unless it is
    explicitly requested by the user (CACHING_SYSTEM=fastmmap)
    - disables fastmmap cache usage for command line scripts
    (i.e. when GATEWAY_INTERFACE environment variable is not defined)
    - adds the database name, host name and an ID of the OS user to the
    mmaped file name created in /tmp, to prevent various kinds of
    unintentional conflicts and/or permission problems from happening
    
    To test:
    
    1) remove the /tmp/sharefile-koha-* file[s] (if any)
    2) do something which would lead to its re-creation (e.g., performing
    any search in OPAC should be sufficient to cause that)
    3) observe that /tmp/sharefile-koha-koha got created
    4) remove it
    5) apply patch
    6) redo step 2)
    7) observe that aforementioned file is no longer created in /tmp
    8) set CACHING_SYSTEM environment variable to 'fastmmap'
    9) redo step 2), observe that /tmp/sharefile-koha-* file got created
    and that it's name now contains hostname, database name and UID
    10) ensure that everything still works like it should and that there
    are no regressions of any kinds anywhere in the system ;)
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Mason James <mtj at kohaaloha.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Cache.pm |   14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository