[koha-commits] main Koha release repository branch master updated. v3.18.00-117-g483ad2a

Git repo owner gitmaster at git.koha-community.org
Sat Jan 10 20:12:27 CET 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  483ad2aee510cb23f2bae61883d6b90de262d13d (commit)
       via  e6dbae9dbf8ce506d6692cb7abace9c9b3175e3e (commit)
       via  9d53118f55f0f278a22f846af510edb7fa4477be (commit)
       via  b454e1a8947fe399879a928a7b05c62d993f1800 (commit)
       via  bdf8627e640827c303259da73e6a1e82f6836fcb (commit)
       via  fbfc109777338fce515ae544e9537d5a9a8a7947 (commit)
       via  57ac4a126b3e929ab750519e7e521f9e98a80490 (commit)
      from  4958a8a0f67d04c41eb300d9247c915f2346acf0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 483ad2aee510cb23f2bae61883d6b90de262d13d
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed Sep 3 19:15:12 2014 -0400

    Bug 12868: Wrong variable used for borrower number
    
    When only the card number is passed to GetMemberDetail, the
    value of $borrowernumber is undefined. Even after finding the
    correct borrower and providing a nice hash ($borrower), the
    GetMemberAccountRecords is called with the wrong borrower number,
    even though it is in the hash ($borrower).
    
    This was fixed by changing $borrowernumber to
    $borrower->{borrowernumber}, so that the hash's value will always
    be used, since it is correct regardless of whether borrowernumber
    or cardnumber were used to find the borrower.
    
    TEST PLAN
    ---------
    1) Apply both patches
    2) prove -v t/db_dependent/Member.t
       -- This time the previously failing test will pass.
    3) run koha QA test tools.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit e6dbae9dbf8ce506d6692cb7abace9c9b3175e3e
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed Sep 3 19:09:46 2014 -0400

    Bug 12868: Improving t/db_dependent/Member.t
    
    The mock function of GetMemberAccountRecord did not properly
    account for the undef case. This was corrected.
    
    Then all 4 combinations of borrower number and card number being
    defined or not were called to GetMemberDetail.
    
    The problematic test case is where the borrower number is
    undefined and the cardnumber is defined.
    
    TEST PLAN
    ---------
    1) Apply just this first patch.
    2) prove -v t/db_dependent/Member.t
       -- This should fail!
    3) Run koha QA test tools.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 9d53118f55f0f278a22f846af510edb7fa4477be
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date:   Mon Sep 15 11:38:32 2014 +0300

    Bug 12922 - Do not DIE the advance_notices.pl -cronjob if no letter of type is found!!
    
    We failed to deliver advance_notices because a template for sms's is undefined, because we don't support
    sending sms' as advance_notice.
    This crashed the cronjob because digests are set to die instead of the warn used in non-digest.
    And we get angry customers asking for compensation!
    
    This patch replaces the die with warn.
    
    TEST PREPARATION:
    
    0. Edit the ODUEDGST letter, find an undefined letter for any trasport type.
    
    TEST PLAN:
    
    1. Find a borrower and from the messaging preferences set the "Advance notice" transport type to
       the undefined digest. Set the "Days in Advance" to 1.
    2. Check-out something for that borrower and set the due date for tomorrow.
    3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal.
    4. BEFORE THIS PATCH: You get an error
       "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609."
       and the script dies.
    4. AFTER THIS PATCH: You get an error
       "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609."
       but the script keep on going!
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit b454e1a8947fe399879a928a7b05c62d993f1800
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Fri Nov 14 11:15:08 2014 +0100

    Bug 13318: Delete C4::Acq::GetParcel
    
    Test plan:
      git grep GetParcel
    should not return use of this subroutine.
    
    Signed-off-by: wajasu <matted at 34813.mypacks.net>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit bdf8627e640827c303259da73e6a1e82f6836fcb
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Tue Jan 6 11:40:46 2015 +0000

    Bug 13522: Make it explicit that scalar containd a hash ref
    
    Prior to perl 5.12 keys can only operate on a hash. So although
    $data[0] ( thats an abysmal variable name! ) will contain a hash ref
    the perl compiler cannot deduce that from the context and gives
    a syntax error. Add the hash sigil to make the context explicit and
    the compiler can generate the correct code.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit fbfc109777338fce515ae544e9537d5a9a8a7947
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Dec 3 11:35:36 2014 +0100

    Bug 13378: Add a filter to search suggestions not linked to a fund
    
    This patch adds a "None" option for the fund filter.
    
    Test plan:
    1/ Go on the suggestion search page
    2/ Search suggestions not linked to a fund using the "None" option.
    3/ Search all suggestions (linked or not to a fund) using the "Any" option.
    
    Works as expected.
    Signed-off-by: Marc Veron <veron at veron.ch>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 57ac4a126b3e929ab750519e7e521f9e98a80490
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue Dec 2 10:51:08 2014 +0100

    Bug 13369: table should been highlighted correctly when row are grouped
    
    The css used to highlight the rows comes from staff-global.css
    We need a more specific rule to be used.
    
    Test plan:
    Go on the fund list view and confirm that the rows are correctly
    highlighted.
    
    Signed-off-by: Owen Leonard <oleonard at myacpl.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm                                  |   73 +-------------------
 C4/Members.pm                                      |    2 +-
 C4/Suggestions.pm                                  |   17 ++---
 koha-tmpl/intranet-tmpl/prog/en/css/datatables.css |   14 +++-
 .../prog/en/modules/admin/aqbudgets.tt             |    2 +-
 .../prog/en/modules/suggestion/suggestion.tt       |    9 ++-
 misc/cronjobs/advance_notices.pl                   |   12 ++--
 t/db_dependent/Members.t                           |   26 ++++++-
 t/db_dependent/Suggestions.t                       |   56 +++++++++++++--
 tools/viewlog.pl                                   |    2 +-
 10 files changed, 114 insertions(+), 99 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list