[koha-commits] main Koha release repository branch 3.18.x updated. v3.18.02-59-g30c5d74

Git repo owner gitmaster at git.koha-community.org
Thu Jan 15 02:41:24 CET 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.18.x has been updated
       via  30c5d74805a3e587aa372f7c0b429e2c1e7e4300 (commit)
       via  278e76fb8a651d518833ed2b34fad7f1d3f7f5dd (commit)
      from  23e2ded850175bedb89da06159a465f8928ce588 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 30c5d74805a3e587aa372f7c0b429e2c1e7e4300
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed Sep 3 19:09:46 2014 -0400

    Bug 12868: Improving t/db_dependent/Member.t
    
    The mock function of GetMemberAccountRecord did not properly
    account for the undef case. This was corrected.
    
    Then all 4 combinations of borrower number and card number being
    defined or not were called to GetMemberDetail.
    
    The problematic test case is where the borrower number is
    undefined and the cardnumber is defined.
    
    TEST PLAN
    ---------
    1) Apply just this first patch.
    2) prove -v t/db_dependent/Member.t
       -- This should fail!
    3) Run koha QA test tools.
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit e6dbae9dbf8ce506d6692cb7abace9c9b3175e3e)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit 278e76fb8a651d518833ed2b34fad7f1d3f7f5dd
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date:   Mon Sep 15 11:38:32 2014 +0300

    Bug 12922 - Do not DIE the advance_notices.pl -cronjob if no letter of type is found!!
    
    We failed to deliver advance_notices because a template for sms's is undefined, because we don't support
    sending sms' as advance_notice.
    This crashed the cronjob because digests are set to die instead of the warn used in non-digest.
    And we get angry customers asking for compensation!
    
    This patch replaces the die with warn.
    
    TEST PREPARATION:
    
    0. Edit the ODUEDGST letter, find an undefined letter for any trasport type.
    
    TEST PLAN:
    
    1. Find a borrower and from the messaging preferences set the "Advance notice" transport type to
       the undefined digest. Set the "Days in Advance" to 1.
    2. Check-out something for that borrower and set the due date for tomorrow.
    3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal.
    4. BEFORE THIS PATCH: You get an error
       "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609."
       and the script dies.
    4. AFTER THIS PATCH: You get an error
       "No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609."
       but the script keep on going!
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 9d53118f55f0f278a22f846af510edb7fa4477be)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 misc/cronjobs/advance_notices.pl |   12 ++++++------
 t/db_dependent/Members.t         |   26 +++++++++++++++++++++++---
 2 files changed, 29 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list