[koha-commits] main Koha release repository branch 3.16.x updated. v3.16.06-27-g05a9dea
Git repo owner
gitmaster at git.koha-community.org
Sat Jan 17 00:36:28 CET 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, 3.16.x has been updated
via 05a9deaacd381a3be18690762ed6d547b6819b22 (commit)
via b8ef9e288548ea5247c120df4c8012f0df7a7be4 (commit)
via c5d177b82e94ed36c25fb51110ca1e10ce1d5b29 (commit)
via 1b48202e28b5000e1a9904cef82bc436b3628c94 (commit)
via 10ee2cd2f1d5e50a566542638acfa3fc5aaca22a (commit)
via d21856d2ad8b63c863bfdd3f39c06e7feafd6f2b (commit)
via b2d7832aab960e6df2239568cd62eb1e9a7a431b (commit)
via 5ab7aa964aa5051c9938a1fb0d01df67ea0cc789 (commit)
via 878e044963543fa919f887e6ed653eeb7de8d768 (commit)
via 4350573fedd03a909991247a9fffae0c32c48f39 (commit)
via 70cc27c7847c0c0e72d3c85c32efa99ad9157bdb (commit)
via a6ba8507e5385d3974abdb162a81058ae7fef90a (commit)
from 5c71f8ed5a8d250c638703022bb5cb007f7ca095 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 05a9deaacd381a3be18690762ed6d547b6819b22
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Sep 3 19:15:12 2014 -0400
Bug 12868: Wrong variable used for borrower number
When only the card number is passed to GetMemberDetail, the
value of $borrowernumber is undefined. Even after finding the
correct borrower and providing a nice hash ($borrower), the
GetMemberAccountRecords is called with the wrong borrower number,
even though it is in the hash ($borrower).
This was fixed by changing $borrowernumber to
$borrower->{borrowernumber}, so that the hash's value will always
be used, since it is correct regardless of whether borrowernumber
or cardnumber were used to find the borrower.
TEST PLAN
---------
1) Apply both patches
2) prove -v t/db_dependent/Member.t
-- This time the previously failing test will pass.
3) run koha QA test tools.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
commit b8ef9e288548ea5247c120df4c8012f0df7a7be4
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Sep 3 19:09:46 2014 -0400
Bug 12868: Improving t/db_dependent/Member.t
The mock function of GetMemberAccountRecord did not properly
account for the undef case. This was corrected.
Then all 4 combinations of borrower number and card number being
defined or not were called to GetMemberDetail.
The problematic test case is where the borrower number is
undefined and the cardnumber is defined.
TEST PLAN
---------
1) Apply just this first patch.
2) prove -v t/db_dependent/Member.t
-- This should fail!
3) Run koha QA test tools.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit c5d177b82e94ed36c25fb51110ca1e10ce1d5b29
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Mon Sep 15 11:38:32 2014 +0300
Bug 12922 - Do not DIE the advance_notices.pl -cronjob if no letter of type is found!!
We failed to deliver advance_notices because a template for sms's is undefined, because we don't support
sending sms' as advance_notice.
This crashed the cronjob because digests are set to die instead of the warn used in non-digest.
And we get angry customers asking for compensation!
This patch replaces the die with warn.
TEST PREPARATION:
0. Edit the ODUEDGST letter, find an undefined letter for any trasport type.
TEST PLAN:
1. Find a borrower and from the messaging preferences set the "Advance notice" transport type to
the undefined digest. Set the "Days in Advance" to 1.
2. Check-out something for that borrower and set the due date for tomorrow.
3. Run "misc/cronjobs/advance_notices.pl -c -n -v" from the terminal.
4. BEFORE THIS PATCH: You get an error
"No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609."
and the script dies.
4. AFTER THIS PATCH: You get an error
"No circulation PREDUEDGST letter transported by sms at /home/koha/kohaclone/C4/Letters.pm line 609."
but the script keep on going!
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 1b48202e28b5000e1a9904cef82bc436b3628c94
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date: Tue Jan 6 11:40:46 2015 +0000
Bug 13522: Make it explicit that scalar containd a hash ref
Prior to perl 5.12 keys can only operate on a hash. So although
$data[0] ( thats an abysmal variable name! ) will contain a hash ref
the perl compiler cannot deduce that from the context and gives
a syntax error. Add the hash sigil to make the context explicit and
the compiler can generate the correct code.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 10ee2cd2f1d5e50a566542638acfa3fc5aaca22a
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Dec 3 11:35:36 2014 +0100
Bug 13378: Add a filter to search suggestions not linked to a fund
This patch adds a "None" option for the fund filter.
Test plan:
1/ Go on the suggestion search page
2/ Search suggestions not linked to a fund using the "None" option.
3/ Search all suggestions (linked or not to a fund) using the "Any" option.
Works as expected.
Signed-off-by: Marc Veron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit d21856d2ad8b63c863bfdd3f39c06e7feafd6f2b
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Dec 2 10:51:08 2014 +0100
Bug 13369: table should been highlighted correctly when row are grouped
The css used to highlight the rows comes from staff-global.css
We need a more specific rule to be used.
Test plan:
Go on the fund list view and confirm that the rows are correctly
highlighted.
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit b2d7832aab960e6df2239568cd62eb1e9a7a431b
Author: Chris Nighswonger <chris.nighswonger at gmail.com>
Date: Fri Dec 19 07:47:40 2014 -0500
Bug 13407 Bumping required version of PDF::Reuse
Signed-off-by: Chris <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 5ab7aa964aa5051c9938a1fb0d01df67ea0cc789
Author: Chris Nighswonger <cnighswonger at foundations.edu>
Date: Tue Dec 2 12:08:04 2014 -0500
Bug 13406: Removing depricated code included in PDF::Reuse
1. Upgrade PDF::Reuse to 0.35_04. [1]
2. Run Koha's non-DB dependent test suite. You should notice some non-fatal warnings about
the redefinition of one or two subs in PDF::Reuse. This should not affect the
functionality of the tools for the end user.
3. Verify the functionality of the related tools.
4. Apply the attached patch.
5. Re-run Koha's non-DB dependent test suite. You should note no warnings related to PDF::Reuse.
6. Re-verify the functionality of the related tools.
[1] http://search.cpan.org/CPAN/authors/id/C/CN/CNIGHS/PDF-Reuse-0.35_04.tar.gz
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Chris <chris at bigballofwax.co.nz>
http://bugs.koha-community.org/show_bug.cgi?id=13407
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 878e044963543fa919f887e6ed653eeb7de8d768
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Jul 29 12:39:15 2014 -0400
Bug 11872 - Lost overdue items should not generate fines
An item can be marked as lost by longoverdue.pl, but left checked out to
the patron. In this case, the item will continue to accrue fines.
Test Plan:
1) Check out an item and back date it so it is overdue and should
generate fines.
2) Mark the item as lost by either using longoverdue.pl, or just
by setting itemlost to 1 by directly accessing the database
3) Run fines.pl
4) Note the overdue generated a fine
5) Repeat steps 1-2
6) Apply this patch
7) Run fines.pl
8) Note a fine was not generated
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 4350573fedd03a909991247a9fffae0c32c48f39
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Sat Dec 27 12:58:52 2014 +0100
Bug 13459: Fix datatables paging for admin > itemtypes
To test:
- Go to administration > itemtypes
- Verify the display of the paging options is broken
- Apply patch
- Verify the display is now correct and works nicely
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit 70cc27c7847c0c0e72d3c85c32efa99ad9157bdb
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Sat Dec 27 21:13:58 2014 +0100
Bug 13459: Fix datatables paging for patron lists
The display of the datatables paging options for the
patron list feature is broken.
To test:
- Go to tools > patron lists
- The paging for the 'list of lists' is broken
- Select a patron list 'Add more patrons'
- Notice the paging on this page is also broken
- Apply patch
- Verify both pages now display the paging correctly
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
commit a6ba8507e5385d3974abdb162a81058ae7fef90a
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Dec 31 13:23:06 2014 +0100
Bug 13504: Remove the '----' marker for CHECKIN and CHECKOUT notices
If only 1 item exist in the message, the marker is not removed.
This marker is removed by render_metadata, but this method is only
called on appending.
Test plan:
1/ Enable the CHECKIN and/or CHECKOUT notices for a patron
2/ check and item in or out and verify that the marker is no longer
displayed in the generated notices.
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Creators/PDF.pm | 92 +------
C4/Installer/PerlDependencies.pm | 2 +-
C4/Members.pm | 2 +-
C4/Message.pm | 7 +-
C4/Overdues.pm | 4 +-
C4/Suggestions.pm | 17 +-
koha-tmpl/intranet-tmpl/prog/en/css/datatables.css | 14 +-
.../prog/en/modules/admin/aqbudgets.tt | 2 +-
.../prog/en/modules/admin/itemtypes.tt | 3 +-
.../prog/en/modules/patron_lists/list.tt | 3 +-
.../prog/en/modules/patron_lists/lists.tt | 3 +-
.../prog/en/modules/suggestion/suggestion.tt | 9 +-
misc/cronjobs/advance_notices.pl | 12 +-
misc/cronjobs/fines.pl | 2 +
misc/cronjobs/staticfines.pl | 1 +
t/db_dependent/Members.t | 54 +++-
t/db_dependent/Suggestions.t | 286 +++++++++++++++++++-
tools/viewlog.pl | 23 ++
18 files changed, 405 insertions(+), 131 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list