[koha-commits] main Koha release repository branch master updated. v3.18.00-193-gfd6176d

Sun Jan 18 14:45:35 CET 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  fd6176d0a58e5e5016d5db002578b7a7dee9531c (commit)
       via  bcbcad897a3f383b38851f8d0fb27017170d181f (commit)
       via  b8989510ec8b6b58249707bf2ddc6cf80fbfef4d (commit)
       via  cb2f8f663571a12e1e45819964735d6a910ce7dd (commit)
       via  97acd9511e5a3abb22dac02fd0014c44295a4313 (commit)
       via  64aeb864561418ba1937f8933e8def6b008c5bf9 (commit)
      from  9db34fe8758e6303246a3347d19f05edc2653a42 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fd6176d0a58e5e5016d5db002578b7a7dee9531c
Author: David Cook <dcook at prosentient.com.au>
Date:   Wed Jan 7 17:32:06 2015 +1100

    Bug 13526 - Mandatory fields should not be able to be hidden in borrower self-registration

    Currently, mandatory fields in the borrower self-registration can be hidden.
    This causes problems since the validator rejects the registration,
    even though all required fields on the screen have been filled out.

    This is especially a problem when using the system preference
    "PatronSelfRegistrationVerifyByEmail", since it automatically makes
    "email" a mandatory field.

    This patch makes it so that a mandatory field cannot be hidden on
    the self-registration page.

    _TEST PLAN_

    Before applying
    1) Hide the "email" and the "emailpro" fields using the
    "PatronSelfRegistrationBorrowerUnwantedField" system preference.

    2) Make the "email" and the "emailpro" fields mandatory using the
    "PatronSelfRegistrationBorrowerMandatoryField" system preference.

    3) Note that you cannot see "Primary email" or "Secondary email"
    on the self registration page.
    (The registration page which can be found by turning
    on "PatronSelfRegistration" and filling in
    "PatronSelfRegistrationDefaultCategory". The link will be on
    opac-main.pl on the right side of the screen under the login box.)

    4) Note that you cannot submit a self-registration request as
    the system tells you that you have not filled in all the mandatory
    fields.

    5) Apply the patch && refresh the self registration page

    6) Note that you can now see "Primary email" and "Secondary email"
    on the self-registration screen".

    Signed-off-by: Abby <abbyrobnz at gmail.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit bcbcad897a3f383b38851f8d0fb27017170d181f
Author: Thomas <tomsStudy at gmail.com>
Date:   Tue Jan 13 23:25:49 2015 +0000

    Bug 12702 - Suggestions still accessible in OPAC when deactivated

    Added check for suggestions turned off. If off user is redirected to 404 error. If patron suggestions are off guest sugestions will also redirect to 404

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit b8989510ec8b6b58249707bf2ddc6cf80fbfef4d
Author: Marc Véron <veron at veron.ch>
Date:   Sun Nov 16 22:52:31 2014 +0100

    Bug 8096 - card number twice on patron search

    This patch removes double patron card numbers from patron search results.

    To test:

    Search patrons
    See card number 12345 in first column and in second column like Testman, John (12345)
    Apply patch
    Patron card number no longer dispays in second colum

    Further testing:
    Search for other places in intranet where patron-title.inc is used (git grep 'patron-title.inc')
    The card number still should display at the other places.

    Signed-off-by: Chris <chris at bigballofwax.co.nz>

    http://bugs.koha-community.org/show_bug.cgi?id=8096
    Signed-off-by: Chris <chris at bigballofwax.co.nz>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit cb2f8f663571a12e1e45819964735d6a910ce7dd
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Sat Jan 17 23:23:47 2015 -0300

    Bug 12973: (QA followup) warnings are features, test them

    This patch makes the test look for the warnings Koha::XSLT_Handler raises
    instead of just throwing them to STDERR.

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 97acd9511e5a3abb22dac02fd0014c44295a4313
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Sep 25 11:22:40 2014 +0200

    Bug 12973: Additional unit tests for XSLT_Handler.t

    The additional way of parameter passing is tested in three additional
    tests.

    Test plan:
    Verify if XSLT_Handler.t passes.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 64aeb864561418ba1937f8933e8def6b008c5bf9
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Fri Sep 19 22:36:46 2014 +0200

    Bug 12973: Allow passing code to XSLT_Handler instead of filename

    This patch adds the option to pass a code string to the XSLT handler object
    instead of passing a filename.
    This is achieved by a change to parameter hashref. The old style parameters
    are also allowed.
    Note that this patch should not change behavior but will be used in future
    development: see bug 12758 or bug 12754.

    Test plan:
    Verify that behavior did not change in the following steps.
    [1] Edit OPACXSLTResultsDisplay in order to use XSLT.
    [2] Check search results page in OPAC.
    [3] Edit OPACXSLTDetailsDisplay in order to use XSLT.
    [4] Check detail page in OPAC.

    Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/XSLT_Handler.pm                               |   86 +++++++++++++++-----
 .../prog/en/includes/patron-title.inc              |    8 +-
 .../en/modules/members/tables/members_results.tt   |    2 +-
 opac/opac-memberentry.pl                           |   10 ++-
 opac/opac-suggestions.pl                           |    6 ++
 t/db_dependent/XSLT_Handler.t                      |   66 ++++++++++++---
 6 files changed, 138 insertions(+), 40 deletions(-)

hooks/post-receive
-- 
main Koha release repository