[koha-commits] main Koha release repository branch master updated. v3.18.00-208-g580ed63
Git repo owner
gitmaster at git.koha-community.org
Wed Jan 21 15:03:56 CET 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 580ed6360ddf0eac902fe807bc76abddec86529a (commit)
via 5ee0293ed6207a801df234b09f33bebb84e65e05 (commit)
via 2246feaf5b17bbac722add6209ddfe79fbd0f5d2 (commit)
via c8f3f9f57484f43779fadae8939c214e3691d4d8 (commit)
via 82c78355c79c960853a413419f6f5873826317b6 (commit)
via 84064ae4e4b07d1fa07e9be01546e104e4e70a01 (commit)
via 6f5f8b112f3ac5fc841b527cb0d92a82768d2346 (commit)
via 5ac46633ef1cf24e83ba65aaf684867a2a394ef6 (commit)
via d0d150a0c5e65a2070bf8a21ab66ed9cdb4bddf8 (commit)
via 89fb9c4a42e000144f38a3c596c0aaa80e0856e6 (commit)
via 752d627266455d787ba5ce1d88ed0f98d1282b4a (commit)
via e8d283172bcce2782e4d839922e7bc2538726c71 (commit)
via 4c68cebdef064a59cdd690f7492884c6d48dd765 (commit)
via acff2645584043c8f34515e3326973f149dcf913 (commit)
via b2ce6347e55c92c9974f64d272dedffda41e3b44 (commit)
from fd6176d0a58e5e5016d5db002578b7a7dee9531c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 580ed6360ddf0eac902fe807bc76abddec86529a
Author: Justin <justinvos at live.com>
Date: Wed Jan 14 23:16:29 2015 +0000
Bug - 11345 - Self registration captcha
Test Plan
- Open the opac site
- Navigate to the self registration page (Home -> Register here)
- Notice that there is no note stating that the verification box is case-sensitive
- Apply patch
- Refresh page
- Notice that there is now an extra note stating that the verification box is case-sensitive.
Followed test plan. Hint displays as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 5ee0293ed6207a801df234b09f33bebb84e65e05
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Tue Aug 13 10:56:15 2013 -0300
Bug 10606: Remove MySQLism in GetUpcomingDueIssues
To test:
[1] Arrange to have at least one loan in your test database due
one day from now.
[2] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2
and note the number of loans reported.
[3] Apply the patch.
[4] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 again
and verify that the number of loans reported remains the same.
Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
All tests and QA script pass.
Also tested with unit tests from bug 10719.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 2246feaf5b17bbac722add6209ddfe79fbd0f5d2
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Jan 19 14:15:29 2015 +0100
Bug 13582: (follow-up) Able to view menu for Circulation History even when user does not have permission
Same changes as the previous patch, for the .tt file.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit c8f3f9f57484f43779fadae8939c214e3691d4d8
Author: Thomas <tomsStudy at gmail.com>
Date: Wed Jan 14 22:03:40 2015 +0000
Bug 13582 - Able to view menu for Circulation History even when user does not have permission
Added check for borrowers that stops the Circulation History link being shown.
This could be done through the css but that function currently appears to be broken.
Testing Plan:
-Search for a patron with an account that does not have the 'borrowers' permission
*Circulation history should not be seen in the menu.
-Change the accounts permissions so they have the 'borrowers' permission
*Circulation history should be present in the menu.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 82c78355c79c960853a413419f6f5873826317b6
Author: Abby <abbyrobnz at gmail.com>
Date: Tue Jan 13 20:29:48 2015 +0000
Bug 7143: Adding releases to history file
To test, verify that the latest releases appear in docs/history.txt
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Verified some release dates and still added a few missing.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Thx Abby!
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 84064ae4e4b07d1fa07e9be01546e104e4e70a01
Author: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi>
Date: Thu Jan 8 14:50:52 2015 +0200
Bug 13025 - Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925
This error only appears when using the SIPServer, it doesn't manifest when using the SIP unit tests
or when using the staff client.
--------------------
------------------
PREPARE THE TEST
------------------
--------------------
0a. Find a borrower.
0b. Find an Item (cardnumber 'debar123') and check-out to the borrower
0c. Find a borrower and add a manual debarrment to it, indefinetely in effect.
This is the default behaviour.
0d. Configure and start a SIP-server which you can access with telnet.
See http://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
In this example, the Borrower defined as the Check-out/in machine has the following credentials:
username: herkules password: palautathan branchcode: JOE_JOE
but you are free to use your own, it doesn't affect this test plan.
0e. access your server with telnet
-----------------------
---------------------
REPLICATE THE ISSUE
---------------------
-----------------------
1. Paste the following SIP-command to login:
9300CNherkules|COpalautathan|CPJOE_JOE|
2. Paste the following SIP-command to check-in the Item of the debarred Borrower:
09N20140721 07501620140721 075016AP|AO|ABdebar123|AC|BIN|
3. The connection should die and in the SIP Server's error log you can find the following error:
Software error: Undefined subroutine &C4::Circulation::HasOverdues called at /home/koha/kohaclone/C4/Circulation.pm line 1925
--------------------
------------------
AFTER THIS PATCH
------------------
--------------------
Redo steps 1-2.
3. No error is given and the connection doesn't die.
No unit tests included and never will, because setting up the test environment would be very tedious.
It is entirely possible but the scaffolding required is beyond the scope of this patch.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Note: I did not test this patch with SIP, but I did not find any
regression on checking or renewing an item.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 6f5f8b112f3ac5fc841b527cb0d92a82768d2346
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Dec 4 15:21:25 2014 +0100
Bug 11927 - Small corrections on word-phrase-utf.chr
Small fixes :
more space characters : ¡¿
uppercase AE missing in equivalent
some trailling spaces
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 5ac46633ef1cf24e83ba65aaf684867a2a394ef6
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Dec 4 15:20:29 2014 +0100
Bug 11927 - Add greek to word-phrase-utf.chr
Add greek support in word-phrase-utf.chr for searching in a Greek catalog (it can also contain latin records).
Developped in collaboration with Giannis Kourmoulis <ikourmou at lib.auth.gr>
Test plan :
- Install using CHR zebra indexing
- Index a greek catalog
- Look for results with mixed uppercase, lowercase and diacritics in title
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit d0d150a0c5e65a2070bf8a21ab66ed9cdb4bddf8
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Dec 4 14:16:58 2014 +0100
Bug 11927 - Add greek chr lang_def file
Add the sort-string-utf.chr for sorting Greek catalog (it can also contain latin records).
Developped in collaboration with Giannis Kourmoulis <ikourmou at lib.auth.gr>
Test plan :
- Install using "gr" in "Primary language for Zebra indexing"
- Index a greek catalog
- Sort by title and check sorting is correct
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 89fb9c4a42e000144f38a3c596c0aaa80e0856e6
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Wed Mar 12 12:53:20 2014 +0100
Bug 11927 - Add gr install option
Add greek as lang definition in installer.
Developed in collaboration with Giannis Kourmoulis <ikourmou at lib.auth.gr>
Test plan :
- Install using "gr" in "Primary language for Zebra indexing"
- check gr is used in etc/zebradb/zebra-*.cfg
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 752d627266455d787ba5ce1d88ed0f98d1282b4a
Author: Abby <abbyrobnz at gmail.com>
Date: Thu Jan 15 20:28:54 2015 +0000
Bug 13587: Fix Authorised Values Toolbar
To test:
1. Go to Home > Administration > Authorised Values
2. Notice no plus icons are appearing infront "New Authorised Value..." and "New Category" in the toolbar.
3. Apply the patch.
4. Check that the plus icons infront of "New Authorised Value..." and "New Category" in the toolbar are appearing as they should.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Nice addition! I added spaces to match the formatting on the other pages a bit more closely.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit e8d283172bcce2782e4d839922e7bc2538726c71
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Jan 15 12:07:01 2015 +0100
Bug 13584: (follow-up) Able to view menu for Purchase Suggestions even when user does not have permission
Same changes as the previous patch, for the .tt file.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 4c68cebdef064a59cdd690f7492884c6d48dd765
Author: Thomas <tomsStudy at gmail.com>
Date: Wed Jan 14 23:26:36 2015 +0000
Bug 13584 - Able to view menu for Purchase Suggestions even when user does not have permission
Added check for borrowers that stops the Purchase Suggestions link being shown. This could be done through the css but that function currently appears to be broken
Testing Plan:
-Search for a patron with an account that does not have the 'borrowers' permission
*Purchase suggestions item should not be seen in the menu.
-Change the accounts permissions so they have the 'borrowers' permission
*Purchase suggestions item should be present in the menu.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
The page requires borrowers permission, so the link should act accordingly.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Same problem for Fines, Circulation history, Notices and Statistics
tabs.
circ-menu.tt is only used from the Fines tab (which is not accessible),
to it's not useful to add this check to it. But for the consistency, it
makes sense. follow-up coming.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit acff2645584043c8f34515e3326973f149dcf913
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Jan 15 15:20:02 2015 +0100
Bug 12861: (follow-up) Noisy warn in error logs
Completely get rid of warns.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit b2ce6347e55c92c9974f64d272dedffda41e3b44
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date: Wed Sep 3 09:49:41 2014 +1200
Bug 12861 : Noisy warn in the error logs
To test
Hit a url like
cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY
Notice the warns in the error log
Apply patch
Reload the url
Still works but no warns
(cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d)
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Reformatted to fix error M Tompsett spotted
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Instead of 10 warnings, I now have only 4 warnings.
We're going in the right direction.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/AuthoritiesMarc.pm | 79 ++++++------
C4/Circulation.pm | 9 +-
Makefile.PL | 2 +-
debian/docs/koha-create.xml | 2 +-
debian/scripts/koha-create | 2 +-
docs/history.txt | 10 +-
etc/zebradb/etc/word-phrase-utf.chr | 91 +++++++++-----
.../gr/sort-string-utf.chr} | 129 ++++++++++----------
.../intranet-tmpl/prog/en/includes/circ-menu.inc | 8 +-
.../intranet-tmpl/prog/en/includes/circ-menu.tt | 9 +-
.../prog/en/modules/admin/authorised_values.tt | 4 +-
.../bootstrap/en/modules/opac-memberentry.tt | 1 +
12 files changed, 200 insertions(+), 146 deletions(-)
copy etc/zebradb/{etc/word-phrase-utf.chr => lang_defs/gr/sort-string-utf.chr} (72%)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list