[koha-commits] main Koha release repository branch master updated. v3.20.00-270-g52814a9
Git repo owner
gitmaster at git.koha-community.org
Tue Jul 7 20:27:31 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 52814a9fa0e061e5d8a669ea1895474e01216cfd (commit)
via 9f008a102415c8b71a1f4a976bc15691c2663b5c (commit)
via bfea40b6e8161629c11d97be5eeba56fb6d59ba3 (commit)
via c3fea53039a6c53c766b0403eedd57f644c6f772 (commit)
via 5f3ec7109321f8e928371880e473e84d8db39f8d (commit)
via ee30fb90048358829dc39906ef033f7dd74207e5 (commit)
via efedadebf233cf7f2b8c1eb64d1687b282d94474 (commit)
via 94315f663b8a582fb7ef68de2bd9c3933901cd7f (commit)
via ffedc98577f4967181e9a17886483c6ac5a1d140 (commit)
via e0d2bc669e385cfd1c42c1e83aaff3495a75a822 (commit)
via c95e794bd458377d742280ae8fff281ddf395e04 (commit)
from d12b4e0b19d43e10a06a934689b9001bdd9049f4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 52814a9fa0e061e5d8a669ea1895474e01216cfd
Author: Julian FIOL <julian.fiol at biblibre.com>
Date: Tue May 26 14:49:20 2015 +0200
Bug 14207: Improving circulation performance
by caching yaml file This patch improve circulation performance by caching yaml file With this patch we saved between 300ms and 500ms on circulation page.
Following Comment #3 :
No useless warn
No tidy
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Less lines, same result.
Comments were useful on testing :)
No errors
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 9f008a102415c8b71a1f4a976bc15691c2663b5c
Author: Indranil Das Gupta <indradg at l2c2.co.in>
Date: Mon May 4 18:55:15 2015 +0530
Bug 14135: Adds 'Free' to variabletypes in systempreferences.tt
The 'Local Use' system preference addition/modification template provides the following options against "Variable Type" - Choice, YesNo, Integer, Textarea, Float, Themes, Languages, Upload or ClassSource.
There is no option presented for "Free" which seems to be the most
used variable type out-of-the-box (i.e. INTRAdidyoumean,
OPACdidyoumean, UsageStatsID and UsageStatsLastUpdateTime)
This trivial patch proposes to modify the systempreferences.tt
and add the option 'Free' to the list offered to users.
Test Plan
=========
1/ Go to Home > Administration > System preferences > Local use
2/ Click on 'New preference'.
3/ In the fieldset 'Koha Internal', the variable types offered
are Choice, YesNo, Integer, Textarea, Float, Themes,
Languages, Upload or ClassSources.
4/ Clicking on 'Choice' should set the 'preftype' field as
'Choice'.
5/ Apply this patch.
6/ Refresh the page.
7/ The variable types list should read - "Free, Choice, YesNo,
Integer, Textarea, Float, Themes, Languages, Upload or
ClassSources".
8/ Clicking on 'Free' should set the 'preftype' field as 'Free'.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
NOTE: Discovered that there is no validation on the type field.
However, that is beyond the scope of this bug.
Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit bfea40b6e8161629c11d97be5eeba56fb6d59ba3
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jul 3 11:02:22 2015 +0200
Bug 14382: [QA Follow-up] Bad regex alarm
The regex /|date>>/ will match much more than you like :)
The unescaped pipe is bad, but you also need to remove the >> because
the split a few lines above it removes them already.
This allows you to recover from an error like this one, running another
report with a string parameter:
The given date (india%) does not match the date format (us) at
Koha/DateUtils.pm line 144.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended for possible spaces around the word date.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit c3fea53039a6c53c766b0403eedd57f644c6f772
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Jun 24 12:13:46 2015 -0400
Bug 14382: Non-ISO Date parameters generate empty reports.
The issue is that SQL expects ISO dates, but the user may wish to view dates according to the dateformat system preference.
By detecting a date preference, the non-ISO dates can be converted to ISO dates before being stuffed back into the SQL query to be executed.
TEST PLAN
---------
1) Add a report with date parameters.
-- I used 'Holds placed in date range' from
http://wiki.koha-community.org/wiki/SQL_Reports_Library
2) Set your dateformat to YYYY-MM-DD
3) Run the report
-- Note the SQL reads
"... BETWEEN '{date formatted in YYYY-MM-DD}'..."
-- If there is supposed to be data, there is some.
4) Set your dateformat to MM/DD/YYYY
5) Run the report
-- Note the SQL reads
"... BETWEEN '{date formatted in MM/DD/YYYY}'..."
-- If there is supposed to be data, there is none.
6) Apply patch
7) Repeat steps 2-5
-- The SQL will always read YYYY-MM-DD (ISO) format.
-- The report will have data, if there is some.
8) koha qa test tools.
Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Adding a QA follow-up.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 5f3ec7109321f8e928371880e473e84d8db39f8d
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Jun 19 14:00:13 2015 -0400
Bug 14427: Use Koha::version instead of C4::Context->KOHAVERSION
While testing bug 9006, I discovered this gem in
installer/install.pl
TEST PLAN
---------
1) back up DB
2) drop db and create db
3) git reset --hard origin/3.20.x
4) run web installer and all sample data
5) git reset --hard origin/master
6) empty your koha intranet error log
7) run web installer to upgrade
-- there will be warnings regarding regex around
installer/install.pl line 328 or so.
grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log
8) repeat steps 2-6
9) apply this patch
10) run web installer to upgrade
-- no regex warnings.
grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log
11) koha qa test tools
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit ee30fb90048358829dc39906ef033f7dd74207e5
Author: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Date: Tue Jul 7 15:15:01 2015 -0300
Bug 9942: DBRev 3.21.00.013
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit efedadebf233cf7f2b8c1eb64d1687b282d94474
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Jun 25 17:22:25 2015 -0400
Bug 9942: [QA Followup] - Add test and alert to returns.pl
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 94315f663b8a582fb7ef68de2bd9c3933901cd7f
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Thu Apr 9 13:07:05 2015 +0200
Bug 9942: Make Koha fails if privacy is not respected
If a patron has requested anonymity on returning items and the system is
not correctly configured (AnonymousPatron no set or set to an inexistent
patron), the application should take it into account and not fail
quietly.
This patch is quite radical: the script will die loudly if the privacy
is not respected.
To be care of the bad "Software error", some checks are done in the
updatedatabase to be sure the admin will be warned is something is wrong
in the configuration.
Test plan:
1/ Test the updatedatabase entry:
a. Turn on OPACPrivacy and set AnonymousPatron to an existing patron
=> You will get a warning
b. Turn on OPACPrivacy and set AnonymousPatron to 0 or ''
=> You will get a warning
c. Turn on OPACPrivacy and set the privacy to 2 (Never) for at least 1 patron
Turn off OPACPrivacy
=> You will get a warning
d. In all other cases you will get no error
2/ Test the interface
a. Turn on OPACPrivacy and set the privacy to 2 (Never) for a patron
b. Now you can turn off OPACPrivacy or keep it on, behavior should be
the same
c. check an item out the patron
d. Check the item in using the check out table
=> fail
e. Check the item in using the Check in tab
=> fail (not gracefully).
Note that the software error could appear on other pages too.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Updatedatabase works as described
On staff, if don't have correct settings for anonymity it's
impossible to check-in (with OPACPrivacy on)
No errors
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit ffedc98577f4967181e9a17886483c6ac5a1d140
Author: Jonathan Druart <jonathan.druart at koha-community.org>
Date: Mon Jun 22 12:45:50 2015 +0200
Bug 14431: FIX encoding issues in search (staff client)
Note that this does not appears at the OPAC.
We will need 2 different testers here, the results seem to depend on the
Encode version.
0/ Determine your Encode version (`pmvers Encode`).
If you have 2.60:
1) /cgi-bin/koha/catalogue/search.pl?q=ééé&op=Submit
You should get
" No results match your search for 'kw,wrdl: ���' in my library Catalog."
2) /cgi-bin/koha/catalogue/search.pl?q=ກ
You should get
Cannot decode string with wide characters at
/usr/lib/i386-linux-gnu/perl/5.20/Encode.pm line 215.
If you have <2.60 (? not sure here):
1) /cgi-bin/koha/catalogue/search.pl?q=ééé&op=Submit
You should not get encoding problems.
2) /cgi-bin/koha/catalogue/search.pl?q=ກ
You should not get encoding problems.
Apply this patch, try again 1 and 2.
If the Encode version is >=2.60, the encoding issues should be fixed.
If not, please detail if there are any regression.
NOTE: Tested on Ubuntu 14.04, Debian 8, and Debian 7. See comment #3.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit e0d2bc669e385cfd1c42c1e83aaff3495a75a822
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Jun 25 16:41:23 2015 -0400
Bug 14467: Security updates break some Koha plugins
The new security updates break previously functioning plugins, most
notably the cover flow plugin and the Ebsco EDS plugin.
Test Plan:
1) Install and configure the cover flow plugin ( http://bywatersolutions.com/koha-plugins/ )
2) Note that attempting to access coverflow.pl from the OPAC results in an error
3) Apply this patch
4) Note that coverflow.pl now output html again
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit c95e794bd458377d742280ae8fff281ddf395e04
Author: Liz Rea <liz at catalyst.net.nz>
Date: Tue Jun 16 16:12:57 2015 +1200
Bug 14389: Editing a syspref in a textarea does not enable the Save button
Test plan:
1. Navigate to the "opaccredits" syspref (or any other textarea, i.e.,
"Click to Edit", syspref) in the system preferences editor.
2. Change its contents, by either pasting or typing. The field may not
be marked as modified, even after you click outside the box.
3. Apply the patch.
4. Reload the page and try again; either pasting or typing should mark
the field as changed and allow you to save.
Signed-off-by: Jesse Weaver <pianohacker at gmail.com>
Confirmed working for normal input, paste and middle-click paste in
Chrome and Firefox in Linux.
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
-----------------------------------------------------------------------
Summary of changes:
C4/Circulation.pm | 28 +++++++---
C4/Utils/DataTables/ColumnsSettings.pm | 18 ++++---
Koha.pm | 2 +-
Koha/Plugins/Base.pm | 3 +-
catalogue/search.pl | 2 +-
installer/data/mysql/updatedatabase.pl | 33 ++++++++++++
installer/install.pl | 2 +-
.../intranet-tmpl/prog/en/js/pages/preferences.js | 2 +-
.../prog/en/modules/admin/systempreferences.tt | 2 +-
.../intranet-tmpl/prog/en/modules/circ/returns.tt | 5 ++
reports/guided_reports.pl | 7 ++-
t/db_dependent/Circulation/MarkIssueReturned.t | 55 ++++++++++++++++++++
12 files changed, 140 insertions(+), 19 deletions(-)
create mode 100644 t/db_dependent/Circulation/MarkIssueReturned.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list