[koha-commits] main Koha release repository branch master updated. v3.20.00-325-g2331a21
Git repo owner
gitmaster at git.koha-community.org
Tue Jul 21 16:56:18 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 2331a21cc8901ee69a57a7ade472b4b21c29e5b6 (commit)
via b69beb2499f1f8da4c02a5a593fbeb3221d5ef8b (commit)
via e32d731238ed8f2c1e77d2a9c82050b1f97d4998 (commit)
via c339b5e4ccf86575c9fa9d6a184db9cd05a9c56f (commit)
via 347d12c41f9ebe638a844b059df5523975e1867d (commit)
via 25df3abb22e6f36ed80e8510f1e3b9f2150f1b2c (commit)
via 1044e620ca3bb24a96947b58857b30775341b856 (commit)
via 02821d52e3406cadc96fda362abfb11e91cd6784 (commit)
via a269e8ec4480732ade4f0cbcda0e1560c4c257d3 (commit)
from ee6dced5617acb6132299f8de521c4bb38b501ea (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 2331a21cc8901ee69a57a7ade472b4b21c29e5b6
Author: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Date: Tue Jul 21 11:54:17 2015 -0300
Bug 14167: (QA followup) new entries in koha-conf.xml should be tested in about.pl
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit b69beb2499f1f8da4c02a5a593fbeb3221d5ef8b
Author: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Date: Tue Jul 21 10:50:17 2015 -0300
Bug 14167: (QA followup) use warn instead of just STDERR
This patch makes Koha::Logger use 'warn' instead of just printing
to STDERR. It introduces tests for this warnings too.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit e32d731238ed8f2c1e77d2a9c82050b1f97d4998
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Jun 25 14:23:48 2015 -0400
Bug 14167: (QA followup) Tidy Koha/Logger.pm
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit c339b5e4ccf86575c9fa9d6a184db9cd05a9c56f
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jun 26 14:22:04 2015 +0200
Bug 14167: Add a unit test for Koha::Logger
Test plan:
Run the test.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 347d12c41f9ebe638a844b059df5523975e1867d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jun 26 14:12:20 2015 +0200
Bug 14167: (QA followup) Making Koha::Logger bit more crash resistant
Moving the BEGIN block to _init for the most part. We only need to
initialize when we actually start using the logger.
Removed the third init part. If we do not have a log4perl_conf in the
koha config, we are not using it yet.
Method get uses hash parameters now. It calls init. If we do not have a
config or the logfile is not writable, we will not use log4perl.
Using AUTOLOAD as a wrapper around Log4perl in order to add some checks
that log4perl does not have.
If a logrotate would change file permissions on a default logfile, we
should catch that now too (see recheck).
Test plan:
Run the previous tests again.
Will still add a unit test.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 25df3abb22e6f36ed80e8510f1e3b9f2150f1b2c
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue Jun 16 13:32:53 2015 -0400
Bug 14167: (QA followup) Embed default config into Koha::Logger
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 1044e620ca3bb24a96947b58857b30775341b856
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu May 14 07:04:19 2015 -0400
Bug 14167: (QA followup) Add template and changes needed for packages
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: upgraded DEBUG level to WARN in config file.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 02821d52e3406cadc96fda362abfb11e91cd6784
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Jun 5 10:08:22 2015 +0200
Bug 14167: (QA followup) Adjust category handling in Koha::Logger
The first patch makes the category parameter mandatory.
This patch makes it optional, falling back to the current package. This is
the expected log4perl model. It would not be necessary to pass the class
name everywhere (check subclasses..)
It also adds a delimiter between the interface and the class name.
This allows you to add config lines like:
log4perl.logger.opac.C4.Auth = DEBUG, OPAC
log4perl.logger.intranet.C4.Circulation = TRACE, INTRANET
The first line would make the logger more sensitive to C4::Auth log
messages while staying at the WARN level for other messages, etc. The
second line makes the trace visible from the renewal example.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit a269e8ec4480732ade4f0cbcda0e1560c4c257d3
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu May 7 11:20:50 2015 -0400
Bug 14167: Add Koha::Logger based on Log4perl
Koha needs a better logger, and it seems like the best solution would be
to take advantage of Log4perl which is already a fully featured logger.
We use Log4perl to selectively decide what statements should be logged,
and where they should go!
Test plan:
0) Install Log::Log4perl via packages or cpan
1) Apply this patch and the example renewal patch
2) Copy etc/log4perl.conf to your koha conf directory, edit the paths
to match your current error logs
3) Edit your koha-conf file and add the
<log4perl_conf>/path/to/log4perl.conf</log4perl_conf> line
4) Watch your intranet and opac error logs
5) Perform a renewal via the staff interface, note there is nothing new
in the log file
7) Update the log4perl.conf, change the log level from WARN to TRACE
for both the staff and opac sides
8) Perform a renewal via the staff interface, note the logged lines
9) Perform a renewal via the opac, note the logged lines
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended this patch: Moved the renewal stuff to a separate example patch.
And upgraded the DEBUG level to WARN in the log4perl config file.
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
-----------------------------------------------------------------------
Summary of changes:
C4/Installer/PerlDependencies.pm | 5 +
Koha/Logger.pm | 189 ++++++++++++++++++++++
about.pl | 6 +
debian/scripts/koha-create | 4 +
debian/templates/koha-conf-site.xml.in | 1 +
debian/templates/log4perl-site.conf.in | 13 ++
etc/koha-conf.xml | 1 +
etc/log4perl.conf | 13 ++
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 7 +
t/Logger.t | 77 +++++++++
10 files changed, 316 insertions(+)
create mode 100644 Koha/Logger.pm
create mode 100644 debian/templates/log4perl-site.conf.in
create mode 100644 etc/log4perl.conf
create mode 100644 t/Logger.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list