[koha-commits] main Koha release repository branch master updated. v3.20.00-344-g3b23fb8
Git repo owner
gitmaster at git.koha-community.org
Fri Jul 24 19:07:01 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 3b23fb8b211c3fbedadc8b67bf294b65ed2ddf2d (commit)
via b6c8de6503c41996c37cff79665bd4c7498a9e55 (commit)
via 6e3bcc387e8d0d2d6bf638fdb6b7171a03facfb0 (commit)
via ff89e6234ae0427b8a76ee8d6e758fff1bda179e (commit)
via d4bbb08eef5471eb1c5ac70ec66ddac5ac24598a (commit)
via b1d05cb44d85667f2e479e35aaf1578783380f20 (commit)
via cf5df6590d16e5d78f031fa276d888c91e5367e6 (commit)
via 342a7a120593092ca33d15dfe07c9e5d06d8f0a5 (commit)
via ab1fd8a55691254702460b6710de254444349cf7 (commit)
via ee7666a5fdd1b04f1bf50aa89900488e1a01402b (commit)
via f7ed250d618c57a3fc00728bbb93460b25ceda52 (commit)
via 2eded5f165eb1cc175bc61a93c1b5b7c8f5ac02f (commit)
via fa5104a6a1c7e3b0bcb232e4d888066dd20eebe8 (commit)
via f3a8b7a0e1e1bf112628c6215105ab80f25ed94f (commit)
via 5e1474836024a9ccd1a9fb4eef91641fba6f8598 (commit)
via fa54a6f04d5e84f8747d268efc2e0e1d175a1ecb (commit)
via 7d4e7e4e525fc99cb4452de135e161a0e0866753 (commit)
via 224d4d4dec19b50f39127de643eb78b0d1704ca2 (commit)
via 53c75d3523e45045be0cb01aa12a1ab3eed045ac (commit)
from 2331a21cc8901ee69a57a7ade472b4b21c29e5b6 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3b23fb8b211c3fbedadc8b67bf294b65ed2ddf2d
Author: Marc Véron <veron at veron.ch>
Date: Sat May 2 07:20:22 2015 +0200
Bug 14107: Patron cards: Make barcode width and height scaling editable
The size of the barcode in patron card creator was hardcoded to 1% of the card height and 80% of the card width.
This patch exposes both values in the layout editor. If no values are given, the previousely hard coded values (0.01 / 0.8) are used in order to work with existing card definitions.
To test:
- Go to Home > Tools > Patron card creator
- Export a patron card (PDF) from en existing definition
- Apply patch
- Export patron card again, compare results (should be the same)
- Go to Home > Tools > Patron card creator > Manage card layouts
- Edit the layout you use for testing and set barcode scaling values e.g. to 0.03 for height and 0.4 for widht
- Export patron card again, verify that barcode size changed
Signed-off-by: Chris Nighswonger <cnighswonger at foundations.edu>
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit b6c8de6503c41996c37cff79665bd4c7498a9e55
Author: Indranil Das Gupta <indradg at gmail.com>
Date: Tue May 26 02:47:00 2015 +0530
Bug 14268: Followup - instruction for preftype selection
removes the now redundant instruction "Note: you should have no
reasons to modify the following default values" and replaces it
with "Note: change the variable type to one of the dropdown values
as needed"
Signed-off-by: Tadeasm <tadeas.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 6e3bcc387e8d0d2d6bf638fdb6b7171a03facfb0
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Mon May 25 15:38:36 2015 -0400
Bug 14268: Use dropdown for variable types
The information needed to build the dropdown is already passed.
This patch uses it to build the variable type dropdown correctly.
TEST PLAN
---------
1) Apply 14135
2) In the staff client:
Home -> Global system preferences -> Local use
3) Click 'Edit' on any system preference.
4) Note all the types listed.
5) Click 'Cancel'
6) Apply this patch
7) Click '+New Preference'
8) Enter data to have a decent 'Free' type preference.
9) Click 'Save'
10) For each type noted in step 4 (do 'Free' again last)
a) Click 'Edit' for the added system preference
-- it should be the last saved variable type.
b) Change the variable type to the next type.
c) Click 'Save'
d) Repeat steps (a) through (c) until all the types have
been done.
-- NOTE: Yes, there are other strange things here, but
those are beyond the scope of this bug.
11) Run koha qa test tools
Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>
Signed-off-by: Tadeasm <tadeas.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit ff89e6234ae0427b8a76ee8d6e758fff1bda179e
Author: Jonathan Druart <jonathan.druart at koha-community.org>
Date: Tue Jun 16 18:46:54 2015 +0200
Bug 12906: DataTables: Use -1 to specify the last column
It will avoid further changes.
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit d4bbb08eef5471eb1c5ac70ec66ddac5ac24598a
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Mon Jun 8 04:28:50 2015 +0200
Bug 12906: Show shipment date in invoice search result list
Patch adds the shipment as a new separate column to the
search results of the invoices search.
To test:
- Search for invoices in the acquisition module
- Verify the results table shows the shipment date
- Verify that sorting works correctly
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit b1d05cb44d85667f2e479e35aaf1578783380f20
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Wed Apr 29 20:52:43 2015 -0400
Bug 5685: Add missing about information
In comment #20, Katrin requested the about page be updated
to reflect the addition of a jquery plugin.
TEST PLAN
---------
1) Apply all patches
2) Log in to Staff Client
3) Home -> About Koha -> Licenses
-- jQuery Validation Plugin is now listed nicely.
4) Run koha qa test tools
License appears as expected, qa OK
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit cf5df6590d16e5d78f031fa276d888c91e5367e6
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Oct 23 09:50:38 2014 -0400
Bug 5685: [OPAC follow-up] Validation of email address field
This patch makes a few changes to the way errors are handled in the
OPAC:
- The validation plugin has been moved from the global include file to
the template itself. Since we aren't doing form validation on any
other page yet it doesn't make sense to include it globally at this
time.
- The error message which appears if you have JavaScript disabled and
have submitted invalid emails was styled in a non-standard way.
- I have added in-page links to the error message which appears if you
have JavaScript disabled so that you can click to jump to the field
which contains the error.
- I have modified the error message language slightly to make it (I
hope) read better.
Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 342a7a120593092ca33d15dfe07c9e5d06d8f0a5
Author: Owen Leonard <oleonard at myacpl.org>
Date: Thu Oct 23 09:16:08 2014 -0400
Bug 5685: [Compiled CSS] Validation of email address field
This patch contains the recompiled opac.css file based on changes made
to opac.less in the previous patch.
Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>
FIXED the compress. - mtompset
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit ab1fd8a55691254702460b6710de254444349cf7
Author: Juhani Seppälä <jseppal at student.uef.fi>
Date: Fri Aug 15 12:11:17 2014 +0300
Bug 5685: Validation of email address field
This patch adds server-side & client-side validation for email
form fields in the members/memberentry -view and in the
opac/memberentry-view (bootstrap).
I recently added simple validation for phone number and email address fields
for our in-house koha and saw this old bug: I'm open to any ideas on how
to do this better. Validation for phone numbers would be easy to add on
top of this but I left it out since this bug is only about the email
fields.
To test:
1) Select a member and go to any of the edit forms with email fields
(Primary info, "Library use", "Alternate address", "Alternative
contact").
2) Disable javascript in the browser in order to test server-side
validation and try to input invalid emails in each of the email form
fields.
3) Confirm that an invalid address is catched from any of the email
fields, an alert shown for each invalid address and that the member's
information was not updated with invalid data.
4) Enable javascript in the browser.
5) Confirm that the jquery validation plugin caches invalid addresses
from any of the email fields and that you cannot send the form before
correcting the problem.
6) Perform the same tests for the opac-memberentry-view.
Note: as the jQuery validation plugin doesn't exist in the bootstrap
folder, I just copied it over from the staff-client folder -how to deal
with this?
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
I have undone the changes to opac.css so that they can be submitted as a
separate patch. I have some other follow-ups to make as well.
Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit ee7666a5fdd1b04f1bf50aa89900488e1a01402b
Author: mxbeaulieu <maxime.beaulieu at inlibro.com>
Date: Mon Jun 15 11:05:51 2015 -0400
Bug 14387: Merge reference selection has no effect when merging authorities.
This patch swaps the authority records according to the refenrece record selection.
To TEST:
Merge two authority records, select the second as merge reference.
The reference authority is always the first.
Apply the patch.
Repeat previous steps, the authority is now merged using the selected reference record.
modified: authorities/merge.pl
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit f7ed250d618c57a3fc00728bbb93460b25ceda52
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Sun Jul 5 13:17:02 2015 +0200
Bug 11693: Default emailing preferences not loaded for self registering patron
The call to AddMember_Opac does not take care of the messaging prefs
when enhanced messaging is enabled.
This patch adds the call to handle_form_action to do that.
Test plan:
Enable self registering patrons and enhanced messaging.
Check the (default) message prefs for the relevant patron category. At least
enable email for one notice.
Self-register a user with and without verification email enabled.
Check in both cases that the message prefs of the user conform to
those in the patron category. (So at least one enabled.)
Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 2eded5f165eb1cc175bc61a93c1b5b7c8f5ac02f
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Apr 13 10:12:03 2015 +0200
Bug 8684: Add regression tests for SearchItemsByField
Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit fa5104a6a1c7e3b0bcb232e4d888066dd20eebe8
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Apr 7 14:14:18 2015 +0200
Bug 8684: Fix duplicate check on creating items in the acquisition module
The script acqui/check_uniqueness.pl has been introduced by bug 7178.
But bug 11425 added a call to a new subroutine SearchItemsByField in
order to refactore some code. This subroutine calls SearchItems with an
arrayref, which is not what SearchItems is expecting.
This broke the duplicate check done on creating items in the acquisition
module.
To reproduce the issue:
1/ Fill the pref UniqueItemFields with "barcode" and AcqCreateItem with
"placing an order"
2/ Create a new basket
3/ Create a new order
4/ Close the basket
5/ Receive items and set barcode with one already in your DB
6/ Save
7/ Nothing happen on the interface, but an error should have been added
in your Koha log file:
Can't use an undefined value as an ARRAY reference at
/home/koha/src/acqui/check_uniqueness.pl line 48.
Test plan:
1/ Repeat steps 1-6
2/ You should see a warning on the interface
Note that this should also happen with AcqCreateItem set to "creating an
order".
Works well, no errors.
Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit f3a8b7a0e1e1bf112628c6215105ab80f25ed94f
Author: Jacek Ablewicz <abl at biblos.pk.edu.pl>
Date: Wed Jun 24 19:43:05 2015 +0200
Bug 14456: EmbedSeeFromHeadings record filter shouldn't process MARC holding fields
If the system preference IncludeSeeFromInSearches is enabled, records
exported for zebra indexing are being additionally processed by
EmbedSeeFromHeadings record filter (right now used only in rebuild_zebra.pl
script). This filter embeds 'see from' fields (extracted from authority
records linked with the given biblio via $9 subfields) into target MARC
record, which is then subsequently indexed in zebra.
Currently all fields containing $9 are getting the same exact treatment
by this filter. But on the export stage when the filter is applied, MARC
record being processed already does have holdings data fields added in
the previous stage (usually 952 / 995, depending on the MARC format).
Problem is that holdings data fields use to have $9 subfields in them
as well (mapped to item.itemnumber by default). As a consequence, some
(great many in the typical setup) records exported for zebra indexing
may have surplus "see from" fields added erroneously in semi-random
fashion, so biblio searches would often return some completely
unexpected additional results.
EmbedSeeFromHeadings record filter should not process holdings fields
when dealing with MARC records intended for zebra indexing.
To reproduce:
1) database with as many sample or real-world biblio, item and authority
records as possible is recommended for testing purposes
2) enable IncludeSeeFromInSearches
3) export a bunch of biblio records for zebra (e.g.:
misc/migration_tools/rebuild_zebra.pl -I -b -x -k -length=1000),
inspect the result xml records in /tmp/<whatever> file; observe that at
the end of many records, here and there some extra "see from" (= 1st
indicator: 'z') fields tend to appear, which shouldn't be there ;)
To test:
4) apply patch
5) redo 3)
6) compare results from 3) and 5) with diff
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
I introduced a regression test for this. You should run the tests
without/with the patch and verify that the patch actually fixes the problem.
Good job Jacek! I'm sure writing the regression test would take less time
than such a detailed commit message!
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 5e1474836024a9ccd1a9fb4eef91641fba6f8598
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Wed Jul 22 11:22:20 2015 -0300
Bug 14456: (regression test) Holdings fields should be skipped by EmbedSeeFromHeadings
This patch introduces a regression test for the situation in which
an itemnumber on a record matches the authid of an authority record
and the current implementation of the EmbedSeeFromHeadings filter
wrongly includes new holding fields with authority data...
To test:
- Apply the patch
- Run:
$ prove t/db_dependent/RecordProcessor_EmbedSeeFromHeadings.t
=> FAIL: The test 'Holdings fields not processed to introduce See-from heading'
fails.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit fa54a6f04d5e84f8747d268efc2e0e1d175a1ecb
Author: Hector Castro <hector.hecaxmmx at gmail.com>
Date: Fri Jul 17 13:42:38 2015 -0600
Bug 14545: Typo in help file (stage-marc-import.tt)
Typo found in stage-marc-import.tt file for Koha help in 3.20
Test plan:
1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/stage-marc-import.tt:28' and check the typo "precendence" or go to Tools > Stage MARC records for import and open up the help
2) Apply the patch
3) Repeat step 1 and check if the typo is fixed.
Sponsored-by: Universidad de El Salvador
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 7d4e7e4e525fc99cb4452de135e161a0e0866753
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Mon Jul 20 11:38:56 2015 +0200
Bug 14569: Typo borroewr|borow
Trivial correction. Only touches comments.
Test plan:
Run git grep -E "borroewr|borow". You should not find anything now.
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Typos in comments corrected.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 224d4d4dec19b50f39127de643eb78b0d1704ca2
Author: Robin Sheat <robin at catalyst.net.nz>
Date: Fri Jul 24 11:36:38 2015 +1200
Bug 14167: remove the log4perl.conf file from /etc for packages
We don't need that file in the package build because it's generated on a
per-site basis from a template.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 53c75d3523e45045be0cb01aa12a1ab3eed045ac
Author: Robin Sheat <robin at catalyst.net.nz>
Date: Fri Jul 24 11:14:25 2015 +1200
Bug 14167: package dependencies for Log::Log4perl
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
-----------------------------------------------------------------------
Summary of changes:
C4/Items.pm | 8 +--
C4/Members/Attributes.pm | 2 +-
C4/Patroncards/Patroncard.pm | 13 +++--
Koha/Filter/MARC/EmbedSeeFromHeadings.pm | 5 ++
authorities/merge.pl | 11 ++--
debian/control | 2 +
debian/rules | 1 +
installer/data/mysql/kohastructure.sql | 4 +-
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 3 ++
.../prog/en/modules/acqui/invoices.tt | 10 +++-
.../prog/en/modules/admin/systempreferences.tt | 56 ++++++++++++++++++--
.../en/modules/help/tools/stage-marc-import.tt | 5 +-
.../prog/en/modules/members/memberentrygen.tt | 20 +++++++
.../prog/en/modules/patroncards/edit-layout.tt | 8 +++
koha-tmpl/opac-tmpl/bootstrap/css/opac.css | 2 +-
.../bootstrap/en/modules/opac-memberentry.tt | 45 ++++++++++++++++
koha-tmpl/opac-tmpl/bootstrap/less/opac.less | 17 ++++++
.../lib/jquery/plugins/jquery.validate.min.js | 4 ++
members/memberentry.pl | 16 ++++++
opac/opac-memberentry.pl | 26 ++++++++-
opac/opac-registration-verify.pl | 2 +
patroncards/create-pdf.pl | 3 +-
patroncards/edit-layout.pl | 2 +
t/db_dependent/Items.t | 5 +-
.../RecordProcessor_EmbedSeeFromHeadings.t | 48 +++++++++++++++++
25 files changed, 291 insertions(+), 27 deletions(-)
create mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.validate.min.js
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list