[koha-commits] main Koha release repository branch master updated. v3.20.00-355-gaac6c26
Git repo owner
gitmaster at git.koha-community.org
Tue Jul 28 15:36:02 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via aac6c2687155e61f78f34767c2b2e45160658c90 (commit)
via c0a52bb1981cea372033ccac02430cba761d3def (commit)
via daab662c7cf8f91ef5e431393da86a985eb309c3 (commit)
via aa356f47ea5a00fdc8800ae6c35890524b8c1dfb (commit)
via e12127127f779bae509966f7101810d343b85b53 (commit)
via 5c3c67972841f7ec99638a9387bd53d62ce9ef7d (commit)
via 41f3cab1f53b4fddb382a9d4ebd1afa01293baea (commit)
via 62dc6b0ca15a9de99a1cb41809e6c9c016e6b0d0 (commit)
via 298c4c76a5f231d9cc0935b6f14a5f191b727804 (commit)
via beef8534724900e5777fc7b6d163763712decb1f (commit)
via 0d632a606f499c31afb8a08f81625c4dfbddb445 (commit)
from 3b23fb8b211c3fbedadc8b67bf294b65ed2ddf2d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit aac6c2687155e61f78f34767c2b2e45160658c90
Author: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
Date: Tue Jul 28 10:32:31 2015 -0300
Bug 13948: DBRev 3.21.00.016
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit c0a52bb1981cea372033ccac02430cba761d3def
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri May 15 00:49:18 2015 -0400
Bug 13948: Prevent explosion when Template::Plugin::Stash not installed
TEST PLAN
---------
1) Install first two patches
2) do not install, or uninstall Template::Plugin::Stash
3) Upgrade to make sure system preference is added.
4) Set the system preference to turn it on for Staff and OPAC
5) Refresh staff -- kaboom
6) Load OPAC -- kaboom
7) Apply this patch
8) Reload staff and OPAC
-- nice HTML comment about what is wrong.
9) run koha qa test tools.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Neat, runs well. Tested with/without sysprefs and Template::Plugin::Stash
No koha-qa errors
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
commit daab662c7cf8f91ef5e431393da86a985eb309c3
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Tue May 12 12:42:07 2015 -0400
Bug 13948: (QA followup) Make dependency optional
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
commit aa356f47ea5a00fdc8800ae6c35890524b8c1dfb
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Thu Apr 2 11:14:45 2015 -0400
Bug 13948: Add ability to dump template toolkit variables to html comment
It would be incredibly helpful if we could easily enable Koha to dump
all Template Toolkit variables to a comment for debugging purposes.
Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Enable the new system preferences DumpTemplateVarsIntranet and
DumpTemplateVarsOpac
4) Load a page in the staff intranet, view the html source
5) Note the template toolkit variables are embedded in an html comment
6) Load a page in the opac, view the html source
7) Note the template toolkit variable are embedded in an html comment
NOTE: I had to cpan2deb Template::Plugin::Stash to test.
This is not optimal. Additionally:
http://www.template-toolkit.org/docs/modules/Template/Plugin/index.html
does not contain Stash. I suspect this was how it was
introduced initially by TT.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit e12127127f779bae509966f7101810d343b85b53
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed May 20 13:42:37 2015 +0200
Bug 13049: [QA Follow-up] Remove unneeded module
The call to cronlogaction is done in cleanup_database. So there is no use
in keeping the module here.
Test plan:
Run or compile (perl -c) script delete_expired_opac_registrations.pl.
Run or compile (perl -c) script delete_unverified_opac_registrations.pl.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 5c3c67972841f7ec99638a9387bd53d62ce9ef7d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Thu Oct 9 09:52:44 2014 +0200
Bug 13049: Merge selfreg cron jobs into cleanup_database
This patch moves the core code of two selfreg cron jobs into the Members
module. The new routines are called from cleanup_database with two new
parameters. The old cron jobs are now wrappers to cleanup_database.
As a bonus, we can add a unit test now.
In time, we can obsolete the selfreg cron jobs. For now, the code is in one
place and behavior does not change.
A next step (as described on the Bugzilla report) would be: remove the Delay
pref for self regs.
Test plan:
Run the unit test t/db_dependent/Members.t.
Test the two new parameters of cleanup_database.pl.
Verify if delete_expired_opac_registrations.pl still works.
Same for delete_unverified_opac_registrations.pl.
Signed-off-by: Frederic Demians <f.demians at tamil.fr>
. Fixed minor merge confict on UT & cleanup_database.pl
. UT ok
. The two deprecated scripts still work as before, with a warning
message.
. cleanup_database.pl do the deletion job, calling new C4::Members
function rather that doing it directly.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 41f3cab1f53b4fddb382a9d4ebd1afa01293baea
Author: Indranil Das Gupta <indradg at gmail.com>
Date: Thu May 21 07:24:28 2015 +0530
Bug 14240: Add '(All libraries)' to notice deletion form
Trivial patch that shows (All libraries) instead of an empty cell
for notices that are applicable across all libraries.
Test plan
=========
1) Log in to staff client
2) Tools->Notices & slips
3) Add a dummy notice for all libraries
-- test code, test description, email - test subject, test content
Click Submit
4) Click Delete
-- note that the Library column value is blank.
5) Click the no option
6) Apply this patch
7) Click Delete
-- note that the Library column value is (All Libraries).
8) run koha qa test tools.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 62dc6b0ca15a9de99a1cb41809e6c9c016e6b0d0
Author: Stéphane Delaune <stephane.delaune at biblibre.com>
Date: Thu Jul 23 16:28:57 2015 +0200
Bug 10961: (followup) Make query fields explicit and add regression tests
add correct frameworkcode to _koha_marc_update_bib_ids parameters
add test, prove with : prove t/db_dependent/Biblio.t
TEST PLAN
---------
1) git checkout -b bug_10961 origin/master
2) git bz apply 10961
3) git checkout origin/master -- C4/Biblio.pm
4) prove t/db_dependent/Biblio.t
-- was expecting failure, got failure.
5) git reset --hard origin/master
6) git bz apply 10961
7) prove t/db_dependent/Biblio.t
-- success as expected.
8) Read over code.
-- Noted it also grabs the framework code for the biblio, rather than uses default.
And it also corrects an indentation issue.
Test case looks like it attempts to cover the biblionumber!=biblioitemnumber case
by adding 1.
9) run koha qa test tools.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 298c4c76a5f231d9cc0935b6f14a5f191b727804
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Fri Sep 27 12:53:39 2013 -0400
Bug 10961: Error in GetMarcBiblio can cause severe data loss
A bug in GetMarcBiblio can cause severe data loss if your database has
records where the biblionumber and biblioitemnumber do not match and the
script misc/batchRebuildBiblioTables.pl is run.
The Biblio::GetMarcBiblio makes a kall to
C4::Biblio::_koha_marc_update_bib_ids which passes the biblionumber as
both the biblionumber *and the biblioitemnumber*.
Thus, if your biblio and biblioitem numbers are not always equal, you
will end up with a record where the biblioitemnumber is incorrect in the
record!
This is usually not a severe issue, but since batchRebuildBiblioTables
uses that record to update the database tables, it ends up updating the
wrong biblioitem row!
NOTE: What a horrible, horrible typo that was. Tested this with the
second patch.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit beef8534724900e5777fc7b6d163763712decb1f
Author: Mark Tompsett <mtompset at hotmail.com>
Date: Fri Jul 3 18:04:04 2015 -0400
Bug 14487: Noise best detected under Debian 8
The first error is caused by the fact that
$messages->{'IsPermanent'} is undefined.
The second error is caused by querying the CGI
parameter 'barcode' inside a function call. This is not required.
There is a variable $barcode set with the parameter. Changed to
use the variable.
TEST PLAN
----------
1) Test first patch.
2) Clear the log
3) Put in a barcode which is not checked out.
4) Check the log.
-- should be two errors. One about a hash,
the other will only be detectable under Debian 8.
5) Apply this second patch
6) Clear the log
7) Put in a barcode which is not checked out.
8) Check the log.
-- should be empty.
9) run koha qa test tools
Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 0d632a606f499c31afb8a08f81625c4dfbddb445
Author: Indranil Das Gupta <indradg at gmail.com>
Date: Fri Jul 3 13:33:06 2015 +0530
Bug 14487: silence warns during checkin
Test plan
=========
1/ check out an item and then check it back in.
1/ check the logs after the check-in to see the warns from
returns.pl line 623 of :
(a) Use of uninitialized value $holdingBranch
(b) Use of uninitialized value $collectionBranch
2/ apply patch
3/ check out and check-in again. no warns are recorded this time.
NOTE: Under Debian Jessie, there are other messages.
Additionally, this only corrects the line 623 ones.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
-----------------------------------------------------------------------
Summary of changes:
C4/Biblio.pm | 8 +-
C4/Installer/PerlDependencies.pm | 13 +-
C4/Members.pm | 55 ++++++++
Koha.pm | 2 +-
circ/returns.pl | 7 +-
installer/data/mysql/sysprefs.sql | 2 +
installer/data/mysql/updatedatabase.pl | 24 +++-
.../prog/en/includes/doc-head-open.inc | 21 +++
.../prog/en/modules/admin/preferences/logs.pref | 134 +++++++++++---------
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 2 +-
.../bootstrap/en/includes/doc-head-open.inc | 21 +++
misc/cronjobs/cleanup_database.pl | 46 ++++++-
misc/cronjobs/delete_expired_opac_registrations.pl | 37 +-----
.../delete_unverified_opac_registrations.pl | 18 +--
t/db_dependent/Biblio.t | 19 ++-
t/db_dependent/Members.t | 24 +++-
16 files changed, 309 insertions(+), 124 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list