[koha-commits] main Koha release repository branch master updated. v3.20.00-52-g06ef680

Mon Jun 1 19:15:25 CEST 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  06ef68046e52a56f690e656f30592ff46b21a383 (commit)
       via  c7a8e4dd25768870de74a5a96c63a92ff1c7fcc8 (commit)
       via  e1ac8b431002ad15ba8bc19a61f2daf0424552e2 (commit)
       via  9c37d43102d7e6224e9207b4ed02cb7d7eca9291 (commit)
       via  174b425c36416a2725da81345ccaf162c4f7f873 (commit)
       via  9878663731c4e31daf45ac8ce86e4bfa169d9689 (commit)
       via  a4b7df44901311f3a96b4e8f828e105845763dac (commit)
       via  4b9f4e1749b3de782068dbe658a04d8ce059e292 (commit)
       via  d78f832cb026ace04ff3e6d2c3765b39656e0e11 (commit)
      from  480ac8667971a638b4b27d0dc8e5bb29f9f2a372 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 06ef68046e52a56f690e656f30592ff46b21a383
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon May 25 14:01:09 2015 +1000

    Bug 14265 - Use $.trim instead of trim() in admin/categorie.tt

    This patch replaces trim() with $.trim() in admin/categorie.tt, as
    $.trim() is more cross-platform (ie it is supported in "< IE9").

    _TEST PLAN_

    Before applying patch:

    0) Use IE 8 or use Document Mode 8 in a newer IE using F12 Developer Tools
    1) Go to Administration > Patron categories
    2) Click "Edit" next to a category
    3) Click "Save" at the bottom
    4) Note the form doesn't submit (you can also notice the error in the
    console log)

    Apply the patch:

    5) Hold down shift + refresh the page
    6) Click "Save" at the bottom"
    7) Note that the form does submit and there are no errors reported

    Signed-off-by: Indranil Das Gupta <indradg at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
    No regression found using iceweasel.
    I did not know the staff interface was IE compatible.
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit c7a8e4dd25768870de74a5a96c63a92ff1c7fcc8
Author: Jonathan Druart <jonathan.druart at koha-community.org>
Date:   Tue May 26 13:05:51 2015 +0200

    Bug 14266: Trim the email address in the pl script

    The original concern of bug 14266 was to provide a compatibility for
    <IE9.
    But actually we don't need to trim the email address template side.
    It will even better to trim it in the perl script, so that the email
    will be trimed even if JS is disabled.

    Test plan:
    1/ Share a list and does not provide any email address
    2/ Submit
    => The form is not submited, no alert/message is displayed (same as
    before this patch).
    3/ Share a list and provide an email address with spaces before and
    after
    4/ Submit
    => You should receive the email

    Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>
    Test output compliant with expected test plan outcome.

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit e1ac8b431002ad15ba8bc19a61f2daf0424552e2
Author: David Cook <dcook at prosentient.com.au>
Date:   Mon May 25 14:07:27 2015 +1000

    Bug 14266: Replace trim() with $.trim() in opac-shareshelf.tt

    This patch replaces trim() with $.trim() which is supported
    in versions of IE older than IE9.

    Revised test plan
    =================

    Before applying patch:

    0) Use IE 8 or Document Mode 8 in a newer IE using F12 Developer Tools
    1) Set OpacAllowSharingPrivateLists to "Allow" in Global System Preferences
    2) Create a private list in the OPAC
    3) Add a record to the private list
    4) Click "Share" or "Share list" on one of the list screens
    5) Type in an email address and click "Send"
    6) Note the error in the console log
    7) The page should submit

    Apply the patch:

    7) Hold shift + refresh the browser to update any Javascript cache
    8) Try to "Share" the list again
    9) Note that the form submit after clicking "Send" and
    that there are no errors in the console log

    http://bugs.koha-community.org/show_bug.cgi?id=14266

    Signed-off-by: Indranil Das Gupta <indradg at gmail.com>
    Remarks: Works as per revised test plan
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 9c37d43102d7e6224e9207b4ed02cb7d7eca9291
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Fri May 1 16:31:47 2015 -0400

    Bug 14113: Silence t/Dates.t warnings and cleanup output.

    The expectation of a user not freaking out over 'Illegal date'
    messages is not sensible. Catch the messages, give a nicer
    message.

    Also, compress the veritical spacing on the output.

    TEST PLAN
    ---------
    1) $ prove t/Dates.t
       -- notice Illegal date messages, and extra lines between
          some sectional messages.
    2) Apply patch
    3) $ prove t/Dates.t
       -- Notice how nice and clean it is?
          Try it with -v to see all the output, including the
          expected warning type messages.
    4) run koha qa test tools.

    Test Remarks : complies with test plan.
    Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>a

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 174b425c36416a2725da81345ccaf162c4f7f873
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Fri May 1 17:56:07 2015 -0400

    Bug 14115: Silence warnings in t/Label*

    Two functions were triggering noisy warnings while testing:
    _get_text_fields and _split_lccn.

    TEST PLAN
    ----------
    1) $ prove t/Label*
       -- several warnings
    2) apply patch
    3) $ prove t/Label*
       -- no warnings
    4) koha qa test tools.

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Nicer, no koha-qa errors

    Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 9878663731c4e31daf45ac8ce86e4bfa169d9689
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Fri May 1 21:16:56 2015 -0400

    Bug 14116: Silence noisy output for t/Scrubber.

    Why diag or print out things, unless it is -v?
    And why print anything except success or failure type messages?
    This cleans up the output.

    TEST PLAN
    ---------
    1) $ prove t/Scrubber.t
       -- there's some noise.
    2) apply patch
    3) $ prove t/Scrubber.t
       -- noise issue resolved.
          Output is still reasonable for -v.
    4) koha qa test tools

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit a4b7df44901311f3a96b4e8f828e105845763dac
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Fri May 1 21:36:23 2015 -0400

    Bug 14117: Silence warnings t/SearchPazPar2.t

    The use of relative URLS (null actually), triggers warnings.
    Catch them, instead of letting them loose.

    TEST PLAN
    ---------
    1) $ prove t/Search_PazPar2.t
       -- noise for each test currently.
    2) apply patch
    3) $ prove t/Search_PazPar2.t
       -- No noise, and extra tests added.
          -v shows caught warning tests.
    4) koha qa test tools.

    Signed-off-by: Indranil Das Gupta <indradg at gmail.com>

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 4b9f4e1749b3de782068dbe658a04d8ce059e292
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Sat May 2 00:02:04 2015 -0400

    Bug 14120: Fixing t/db_dependent/Auth.t noise

    TEST PLAN
    ---------
    1) $ prove t/db_dependent/Auth.t
       -- warnings
    2) Apply this patch
    3) $ prove t/db_dependent/Auth.t
       -- only one specific type of warning
    4) Apply bug 5010 patch
    5) $ prove t/db_dependent/Auth.t
       -- noisy is eliminated
    6) koha qa test tools.

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    With patch only one warn
    With 5010 no more warns
    No errors

    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit d78f832cb026ace04ff3e6d2c3765b39656e0e11
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Wed May 20 11:31:18 2015 -0400

    Bug 12066: New renew page in staff client doesn't record branch in statistics

    Test Plan:
    1) Apply this patch
    2) Renew an item via circ/renew.pl
    3) Note the branch code of your logged in library is set as the
       branch in the generated statistic line

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Tested pre and post patch, now branch is saved
    No errors

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm                                         |    2 +-
 C4/Labels/Label.pm                                 |    7 +-
 C4/Templates.pm                                    |    1 +
 circ/renew.pl                                      |    3 +-
 .../prog/en/modules/admin/categorie.tt             |    2 +-
 .../bootstrap/en/modules/opac-shareshelf.tt        |   17 ++++-
 opac/opac-shareshelf.pl                            |    6 ++
 t/Dates.t                                          |   74 ++++++++++++++------
 t/Scrubber.t                                       |   46 ++++++------
 t/Search_PazPar2.t                                 |   43 +++++++++---
 10 files changed, 139 insertions(+), 62 deletions(-)

hooks/post-receive
-- 
main Koha release repository