[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.00-12-g21d4ea5

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  21d4ea5ccc6313fe59ef535555da8874c34ffd5a (commit)
       via  adf816c8c902940597b65e462cae3a99075509c1 (commit)
       via  b85094aa10c9c6c3bc9d5bc83d9bfd04af4c7c0d (commit)
       via  2b9ef94685ea014a014fdc994f8def827040e6f2 (commit)
      from  9c3ebb73c8ad33673b8e697e76b7c87ff6eb9035 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 21d4ea5ccc6313fe59ef535555da8874c34ffd5a
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Sat May 23 14:01:57 2015 +0200

    Bug 12176: Fix for missing field_value in select
    
    As Jonathan Druart discovered, we were still missing an important attribute
    in the selects. Var mv.name was not filled, so the name was empty with nice
    side-effects :)
    While fixing this, it was also possible to delete some unused vars that Bernardo
    already mentioned before: $attributes and $attributes_no_value.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    
    For me the simptom was different, when saving an edited item
    fields were mangled beyond repear :(
    No alert for empty mandatory fields.
    
    But this last patch fix the problem.
    Tested add/edit items
    Cleaner pl file :)
    No errors
    
    Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit e021b512e34d0521803fa5f32dd67f1532ddb73d)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit adf816c8c902940597b65e462cae3a99075509c1
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed May 20 16:42:34 2015 +0200

    Bug 12176: [QA Follow-up] Capitalization typo after eleventh hour
    
    While cleaning up, still found this super tiny string typo :)
    Yes, Tag Editor should now be Tag editor.
    
    Test plan :)
    Git grep on Tag editor and Tag Editor
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 351b2f753f7b30665dc22be595af4a00589424e7)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit b85094aa10c9c6c3bc9d5bc83d9bfd04af4c7c0d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed May 20 14:56:48 2015 +0200

    Bug 12176: [QA Follow-up] Small additem adjustments
    
    Adjusting a few small things and making qa tools happy:
    
    [1] Remove .hidden after [% avalue %] in additem.tt. (Typo)
    [2] A closer look revealed that mv.avalue is useless too. An input element
        does not contain any content. Putting it after the hidden element
        in a non-visible context has no meaning.
    [3] Change handling of select attributes readonly and disabled.
    [4] Remove unused variable $attributes_no_value_textarea
    [5] Removed a comment with TODO referring to this report.
    [6] Moving a duplicated TT variable (mv.javascript) outside IF statement.
    [7] And finally could not resist this one: Moving strings Tag editor and
        No popup from script to template.  Plugins++
        NOTE: Most item plugins redirect click to focus. In that case there is
        no popup, but unfortunately the text Tag editor comes up.
        When you remove or rename function Click, No popup comes up. So it works.
    
    Sorry that this small list kept growing :)
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 50d2b712883808a36b1d03ac770aed470c8d19d1)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit 2b9ef94685ea014a014fdc994f8def827040e6f2
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date:   Tue May 19 13:06:34 2015 -0300

    Bug 12176: Remove HTML from additem.pl
    
    This patch removes HTML code from additem.pl.
    
    To test:
    1. Check no regressions on Add/Edit/Save items
    2. Update translation files for a language,
       check new strings "Tag editor" & "No popup" on staff PO file
    3. Check it passes xt/tt_valid.t
    
    Patch partially rebased, part rewritten.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 47d2de9c024bfb93d56184f298f334b20685cd86)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 cataloguing/additem.pl                             |  128 ++++++++++++--------
 .../prog/en/modules/cataloguing/additem.tt         |   37 +++++-
 2 files changed, 111 insertions(+), 54 deletions(-)


hooks/post-receive
-- 
main Koha release repository