[koha-commits] main Koha release repository branch master updated. v3.20.00-119-ga215c79

Mon Jun 8 16:06:45 CEST 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  a215c79cc9ce512eb2994ebfe4bdd07c79fef871 (commit)
       via  a6017d87f16266e8947b046427537bdcae5a0699 (commit)
       via  9ce2cd7082a2577278c3a7078f9e277cfa683ae9 (commit)
       via  d763d7cf3c28149b5d7f82de8a98789ee97814d6 (commit)
       via  0114465ced0d87aed51e8632e0ec1c005ae4fce3 (commit)
       via  34fe5c24167f6bc27cff519d4a26c347d06341b3 (commit)
       via  4fd923e12eea70b7e871f0068471ff5ef91dda01 (commit)
      from  717fa8440dad2f67043641db31a5b5ad2b361bb1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a215c79cc9ce512eb2994ebfe4bdd07c79fef871
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Mon Jun 8 10:48:23 2015 -0300

    Bug 14053: DBRev 3.21.00.007

    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit a6017d87f16266e8947b046427537bdcae5a0699
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Thu Apr 23 17:38:03 2015 +0200

    Bug 14053: Acquisition db tables are missing indexes

    Acquisition db tables are missing some indexes to have
    performance queries.

    This patch adds an index on some columns very often
    used in search queries, such as aqbooksellers.name and
    aqbudgets.budget_code.

    Also adds an index on aqorders.orderstatus, very often used
    with hardcoded value like 'cancelled', in various queries.

    Test plan :
    1) Back up database
    2) $ git reset --hard origin/master
    3) $ git bz apply 14053
    4) In your mysql client
       > DROP DATABASE koha_library;
       > CREATE DATABASE koha_library;
       > QUIT;
       -- Obviously you may need to vary koha_library :)
    5) Navigate to staff client
       -- should be able to set up the DB just fine.
       -- this will catch the comma bug that keeps coming in.
    6) $ git reset --hard origin/master
    7) Repeat step 4
    8) Navigate to staff client
       -- nothing tested, but we need the DB set up.
    9) $ ./installer/data/mysql/updatedatabase.pl
       -- atomic updates run without issue.
    10) run koha qa test tools
    11) Restore DB
    12) Try to compare performance after and before
        database update. I think query contained in
        C4::Acquistion::GetInvoices could be a good example

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 9ce2cd7082a2577278c3a7078f9e277cfa683ae9
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Apr 27 17:01:37 2015 +0200

    Bug 14053: Acquisition db tables are missing indexes - atomicupdates

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit d763d7cf3c28149b5d7f82de8a98789ee97814d6
Author: Marc Véron <veron at veron.ch>
Date:   Tue Jun 2 11:39:17 2015 +0200

    Bug 14314: System Preferences: Better explanation for syspref 'ShowReviewerPhoto'

    [PASSED QA] If syspref ShowReviewerPhoto is enabled, the reviewer's avatar is displayed beside comments in OPAC. The avatar will be searched on www.libravatar.org using the patron's email address.

    This patch changes the text for 'ShowReviewerPhoto'.

    To test:
    Apply patch
    Go to Home > Administration > System preferences
    Search for ShowReviewerPhoto
    Verify that the new explanation makes sense.

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Better explanation, no errors.

    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Changed mail to e-mail.
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 0114465ced0d87aed51e8632e0ec1c005ae4fce3
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Jun 4 12:47:13 2015 +0200

    Bug 14330: Remove unused email_sender from sendbasket/sendshelf

    The sendbasket/sendshelf scripts and templates do not use email_sender
    as a cgi parameter or as a template var. Probably a leftover from previous
    changes.
    Let's make Koha cleaner :)

    Test plan:
    [1] Send your cart from opac or staff.
    [2] Send a shelf from opac or staff.
    [3] Git grep email_sender. No results.

    Followed test plan. Works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 34fe5c24167f6bc27cff519d4a26c347d06341b3
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Fri Apr 24 17:03:09 2015 +0200

    Bug 11790: Remove dependency C4::Context from C4::Charset

    C4::Context is only used to retrieve a syspref value.
    This patch moves the use of C4::Context to a require.

    Test plan:
    Try to reach the SetMarcUnicodeFlag subroutine (batchmod, add/update a biblio, etc.)

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Tested on French UNIMARC install
    No errors adding/editing biblios
    No koha-qa errors

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 4fd923e12eea70b7e871f0068471ff5ef91dda01
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu Jun 4 12:03:42 2015 +0200

    Bug 14329: Useless copy/pasta from Template::Plugin::HtmlToText

    The synopsis of this TT plugin contains two example lines:
    [% myhtml FILTER html2text(leftmargin => 0, rightmargin => 0) %]
    [% myhtmltext | html2text %]

    These lines have been copied (without too much thought :) to a few templates. Since we do no use the variables myhtml or myhtmltext in these templates, these lines are useless.

    Test plan:
    [1] Put some items in your cart. And send it.
    [2] Send a shelf.
    [3] Git grep on myhtml. Should not have results.

    NOTE: Sent carts and lists in Intranet and OPAC successfully.
          Though, this does bring into question why the letters
          have HTML formatting if it is getting removed. That,
          however, is beyond the scope of this bug.

    Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/Charset.pm                                      |    2 +-
 Koha.pm                                            |    2 +-
 basket/sendbasket.pl                               |    2 --
 installer/data/mysql/kohastructure.sql             |   12 +++++++-
 installer/data/mysql/updatedatabase.pl             |   31 ++++++++++++++++++++
 .../prog/en/modules/admin/preferences/opac.pref    |    2 +-
 .../prog/en/modules/basket/sendbasket.tt           |    2 --
 .../prog/en/modules/virtualshelves/sendshelf.tt    |    2 --
 .../bootstrap/en/modules/opac-sendbasket.tt        |    2 --
 .../bootstrap/en/modules/opac-sendshelf.tt         |    2 --
 opac/opac-sendbasket.pl                            |    2 --
 opac/opac-sendshelf.pl                             |    1 -
 virtualshelves/sendshelf.pl                        |    1 -
 13 files changed, 45 insertions(+), 18 deletions(-)

hooks/post-receive
-- 
main Koha release repository