[koha-commits] main Koha release repository branch master updated. v3.20.00-128-g39a598c

Git repo owner gitmaster at git.koha-community.org
Wed Jun 10 21:01:59 CEST 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  39a598c987f875c4f4033844f7b8c7e7ba588132 (commit)
       via  964fae60eebd4141ce49c3cff46881d3b2896e49 (commit)
       via  51197e9f1824890b6db66f0c9f90034482932a03 (commit)
       via  efe52666259d533d2c0a375cb7c764dbff3a58d3 (commit)
       via  db4dcb2c72398cd894e582ddd77bb330e242a09e (commit)
       via  c5bc51d7d1b6c98e9d897022f91d8e0806cf4524 (commit)
       via  395304d3b58d79bb1306c4e6f799548e2d875356 (commit)
      from  0002126a2ab0ac38a8d3f144f446dc3ba69dab59 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 39a598c987f875c4f4033844f7b8c7e7ba588132
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu May 14 15:09:40 2015 +0200

    Bug 13437: Replace javascript function parameter in builder
    
    The builder contains js functions with a parameter like subfield_managed
    or i or something similar. This parameter contains the html id of the
    field corresponding with the plugin.
    With the functionality of Koha::FrameworkPlugin in place, we can eliminate
    one js function call and get the same id via the event passed in. Note
    that this actually makes the function a 'real' event handler.
    
    Also note that in many cases this parameter was not used but the id
    was borrowed from a perl variable like $params->{id}. If the field is not
    cloned, this is not a problem. But some fields can be cloned and should
    not use the static perl value but should get it from the event.
    
    Test plan:
    Look for js errors when loading the marc editor.
    Since the Focus or Click event code has been touched for most marc21
    plugins, move your cursor into the field or click on the tag editor
    button. Verify that the focus event updates the correct field or the
    click event correctly launches the plugin AND the value comes back into
    the right field.
    Bonus: Attach a plugin with popup (like leader) to 040$d. Clone this field.
    Verify that the two launch buttons operate on the correct value.
    (This resolves a current bug.)
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Checked all 15 plugins.
    Plugin marc21_linking_section seems to work, but I could not get it to pass
    back something useful into my field. (Same without this patch.)
    Tested the clone button with leader on 040d.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    All seems to work, no errors
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 964fae60eebd4141ce49c3cff46881d3b2896e49
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Thu May 14 10:20:15 2015 +0200

    Bug 13437: Conversion of marc21 cataloguing plugins to new style
    
    This patch converts marc21 plugins to new style by making the following
    modifications:
    
    [1] Replace use strict with use Modern::Perl. This implies that we now
    re-enabled warnings. There are no redefine warnings anymore, but note that
    we need to silence some warnings from individual plugins that were covered
    by disabling the warnings pragma until now. Silencing these individual
    warnings is outside the scope of this report.
    [2] Sub plugin_javascript is replaced by an anonymous subroutine $builder.
    [3] The parameters of $builder are combined in a params hashref. In most
    cases we only need $params->{id} for the function name.
    [4] Javascript function Clicxxx is renamed to Clickxxx.
    [5] The builder does no longer return function_name.
    [6] Sub plugin is replaced by subroutine $launcher.
    [7] The parameters of $launcher are combined in a params hashref. We only
    use $params->{cgi}. Mostly we save that to $input. One exception: $query.
    [8] The plugins returns a hash with $builder and/or $launcher.
    
    Test plan:
    [1] Run t/db_dependent/FrameworkPlugin.t -incl cataloguing/value_builder/
    marc21*.pl. This should catch compile errors and general problems when
    building or launching these plugins.
    NOTE: You will see several initialize warnings from individual plugins that
    were hidden until now by disabling warnings. This is fine; we will be
    able to address these warnings now on new reports.
    [2] Check behavior of several plugins in the marc editor.
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Checked all marc21 plugins. Attached unused plugins to some field.
    Some plugins (unused by default) may need some further attention, but
    also outside the scope of this report.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    New warnigs, but all seems to work.
    No errors.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 51197e9f1824890b6db66f0c9f90034482932a03
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Wed May 13 13:47:38 2015 +0200

    Bug 13437: Trivial edits on marc21 plugins before conversion
    
    marc21_field_003.pl: copy-pasta comment about date removed
    marc21_field_005.pl: commented use removed
    marc21_field_006.pl: old/irrelevant pod lines
    marc21_field_007.pl: old/irrelevant pod lines
    marc21_field_008.pl: old/irrelevant pod lines, move sub par line twice
    marc21_field_008_authorities.pl: whitespace, old/irrelevant pod lines
    marc21_field_040c.pl: two commented lines removed
    marc21_field_040d.pl: whitespace, commented lines, old/irrelevant pod
    marc21_field_245h.pl: whitespace
    
    marc21_linking_section.pl: relocated some comment lines, and replaced a new
    CGI object by the one passed in via the plugin launcher (agreed, this may
    not be so trivial as the other changes)
    
    Test plan:
    These (trivial) changes are hard to test.
    Pick a few plugins and verify that behavior is not changed in the marc
    editor.
    For the brave: Try marc21_linking_section.pl.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Tried marc21_linking_section.pl :)
    (ling plugin to 773$9, create new record, search for parent and check values inserted)
    No errors
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit efe52666259d533d2c0a375cb7c764dbff3a58d3
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Tue May 12 17:49:04 2015 +0200

    Bug 13437: Preliminary changes for marc21 plugins field 008
    
    Preliminary work on marc21_field_008.pl and 008_authorities.pl.
    Moving $dateentered en $defaultval to lower scope level.
    date_entered is a new sub (in a module); sub Field008 has been reduced to
    one line.
    Added a trivial unit test for date_entered.
    Note: the format used in date_entered could be added in DateUtils, moving
    this logic to a better place.
    
    Test plan:
    Use both plugins in the marc21 editor (biblios/authorities).
    Run the adjusted unit test.
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Both plugins works, no errors
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit db4dcb2c72398cd894e582ddd77bb330e242a09e
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date:   Tue May 12 17:31:29 2015 +0200

    Bug 13437: Perltidy some plugin files before conversion
    
    Preliminary work before converting to new plugin style. Several files still
    contained tabs or had strange indentation.
    
    Perltidied: marc21_linking_section.pl
    Perltidied: marc21_field_007.pl
    Perltidied: marc21_leader_authorities.pl
    Perltidied: marc21_leader.pl
    Perltidied: marc21_leader_book.pl
    Perltidied: marc21_leader_computerfile.pl
    Perltidied: marc21_leader_video.pl
    
    Test plan:
    Run perltidy -pro=xt/perltidyrc on marc21_linking_section and compare.
    Try another one too :)
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Minor differences on comparison :)
    No errors
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit c5bc51d7d1b6c98e9d897022f91d8e0806cf4524
Author: Jonathan Druart <jonathan.druart at koha-community.org>
Date:   Thu Jun 4 11:35:15 2015 +0200

    Bug 14256: (follow-up) Check for unique constraint to regenerate random data
    
    There were some issues in the previous patch. This patch fixes the
    following:
    - rename $value with $original_value
    - remove $at_least_one_constraint_failed and $values_ok which make the
      code unnecessarily complicated
    - the constraints have to be checked only if no original value is passed
    - _buildColumnValue created a key to the default value hashref, it broke
      the test:
        last BUILD_VALUE if exists( $default_value->{$source} );
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 395304d3b58d79bb1306c4e6f799548e2d875356
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Wed Jun 3 15:54:57 2015 -0300

    Bug 14256: Check for unique constraint to regenerate random data
    
    Unique constraints should be checked when creating random data. Otherwise
    we get failures when the generated data already exists on the DB.
    
    This patch takes advantage of ->unique_constraints() to do the job,
    looping through all the unique constraints defined for the source.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Util/FrameworkPlugin.pm                       |   16 +-
 cataloguing/value_builder/marc21_field_003.pl      |   22 +-
 cataloguing/value_builder/marc21_field_005.pl      |   22 +-
 cataloguing/value_builder/marc21_field_006.pl      |   36 +-
 cataloguing/value_builder/marc21_field_007.pl      |  222 ++++----
 cataloguing/value_builder/marc21_field_008.pl      |   51 +-
 .../value_builder/marc21_field_008_authorities.pl  |   65 +--
 cataloguing/value_builder/marc21_field_040c.pl     |   23 +-
 cataloguing/value_builder/marc21_field_040d.pl     |   28 +-
 cataloguing/value_builder/marc21_field_245h.pl     |   22 +-
 cataloguing/value_builder/marc21_leader.pl         |  102 ++--
 .../value_builder/marc21_leader_authorities.pl     |   98 ++--
 cataloguing/value_builder/marc21_leader_book.pl    |   96 ++--
 .../value_builder/marc21_leader_computerfile.pl    |   96 ++--
 cataloguing/value_builder/marc21_leader_video.pl   |   96 ++--
 .../value_builder/marc21_linking_section.pl        |  556 ++++++++++----------
 t/Koha_Util_FrameworkPlugin.t                      |    7 +-
 t/lib/TestBuilder.pm                               |   62 ++-
 18 files changed, 837 insertions(+), 783 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list