[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.00-60-gbb86b74

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  bb86b74d186d7ea9652527f7c7db24f96b08878f (commit)
       via  5bd077b94701434a6f6a1ae8eb8b492ad3cd0d80 (commit)
      from  175cc45fcb26dba704d20ad1ac5b82c65cd2046e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bb86b74d186d7ea9652527f7c7db24f96b08878f
Author: Indranil Das Gupta <indradg at gmail.com>
Date:   Mon May 25 05:25:04 2015 +0530

    Bug 14206: Adds test for getletter() call from overdue_notices.pl
    
    Adds missing test for getletter() when called from overdue_notices.pl
    
    Test plan
    =========
    
    1/ apply this patch
    2/ run prove -v t/db_dependent/Letters.t
       all tests should pass, especially test #40 which tests call from
       overdue_notices.pl
    
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit c07f83f643e6b8820d90487a23e91e9b062a5cd6)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit 5bd077b94701434a6f6a1ae8eb8b492ad3cd0d80
Author: Indranil Das Gupta <indradg at gmail.com>
Date:   Fri May 22 03:49:10 2015 +0530

    Bug 14206: Adds delete function for non email templates
    
    C4::Letters::getletter() is called in tools/letter.pl by the function
    delete_confirm() to display the selected notice for deletion. Due to
    current implementation of getletter(), a notice that does not use
    the 'email' template (but uses any/all of the other templates - sms,
    print or phone) can't be deleted from the staff client.
    
    This patch adds deletion capability for notices that do not use email
    template, but uses any/all of the other templates i.e. sms, print or
    phone. This also adds 2 tests to t/db_dependent/Letters.t for testing
    both conditions - a) when message_transport_type is specified b) when
    it is not.
    
    Test plan
    =========
    
    1/ Go to Tools -> Notices & Slips. Add a new notice only for print,
       leave 'Library' and 'Koha module' options as default selections.
       Enter 'KOHA_14206' and 'Koha Test 14206' against Code and Name
       respectively, and 'Test' and 'Test Message' for subject and body.
       Leave the Email, Phone and SMS tabs blank. Save the notice.
    2/ On the notices listing page the new notice will be listed. Try to
       delete it. It will load the 'Delete notice' dialog form, but the
       table will not show any data under <th>s - 'Library', 'Module',
       'Code' or 'Name'.
    3/ Click the "Yes, delete" button. The page will be submitted and the
       Notices listing reloaded. The print-only KOHA_14206 notice should
       continue to exist. This is *wrong*.
    4/ Apply this patch
    5/ Reload the listings page and click on the 'Delete' link for Notice
       KOHA_14206. This time, it should show the data under 'Module',
       'Code' or 'Name' at least.
    6/ Click on 'Yes, delete'. The page should submit and the listing page
       reload. This time KOHA_14206 will be gone.
    7/ Run prove -v t/db_dependent/Letters.t
       All tests should PASS without any error.
    
    Followed test plan. Works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 8895caa33985bbb0cad9b011c4706d4591d2869b)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/Letters.pm            |    7 ++++---
 t/db_dependent/Letters.t |   17 ++++++++++++++++-
 2 files changed, 20 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
main Koha release repository