[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.01-14-gf7dd4d6

Git repo owner gitmaster at git.koha-community.org
Mon Jun 29 11:37:25 CEST 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  f7dd4d6aef41de85deebe2fac014c18ab1e0d0b7 (commit)
       via  c8e48b280a46f90f5d8cc004ba1222db5f69e076 (commit)
       via  114e3cae1a9a4613894492960eb5268c29c1999f (commit)
      from  bfc381f1e275275a2c3e38015e29befe1bad65f2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f7dd4d6aef41de85deebe2fac014c18ab1e0d0b7
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Tue Mar 24 17:01:30 2015 +0100

    Bug 4137: Fix the OPACViewOthersSuggestions behavior
    
    This pref does not work at all, the interface let the user choose to
    list all suggestions, but whatever he chooses the suggestion list is the
    same.
    
    This patch cleans a bit the suggestedby management.
    
    There are a lot of cases to test, because linked to 2 prefs:
     AnonSuggestions and OPACViewOthersSuggestions.
    1/ AnonSuggestions = 0 and OPACViewOthersSuggestions = 0
      - A non logged in user is not able to make a suggestion.
      - A logged in user is not able to see suggestions made by someone else.
    2/ AnonSuggestions = 0 and OPACViewOthersSuggestions = 1
      - A non logged in user is not able to make a suggestion.
      - A logged in user is able to see suggestions made by someone else.
    3/ AnonSuggestions = 1 and OPACViewOthersSuggestions = 0
      - A non logged in user is able to make a suggestion.
      The suggestedby field will be filled with the AnonymousPatron pref value.
      He is not able to see suggestions, even the ones made by AnonymousPatron.
      - A logged in user is not able to see suggestions made by someone else.
    4/ AnonSuggestions = 1 and OPACViewOthersSuggestions = 1
      - A non logged in user is able to make a suggestion.
      He is able to see all suggestions.
      - A logged in user is able to see suggestions made by someone else.
    
    In all cases a logged in user should be able to search for suggestions
    (except if he is not able to see them).
    
    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    All use cases tested, work as expected
    No errors
    
    Only comment is perhaps (in the future) a gracefull failure
    when AnonymousPatron is not set, or has '0' value
    
    Message is DBIx::Class::ResultSet::create(): Column 'suggestedby' cannot be null at ...
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    (cherry picked from commit be35039b55a351c97f2c1f9a5b373cb26ac5e0b0)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit c8e48b280a46f90f5d8cc004ba1222db5f69e076
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Apr 22 12:14:24 2015 +0200

    Bug 10866: Hide patron's history if intranetreadinghistory is set to not allow
    
    If set to "not allow", the intranetreadinghistory pref prevent staff
    members to access patron's checkout history.
    But:
    1/ The page is still accessible if you know the url
    2/ The history can be consulted on the item history page
    
    Test plan:
    0/ Don't apply this patch
    1/ Set the intranetreadinghistory to allow
    2/ Go on a patron's checkout history page
    3/ Open a new tab and go on a item's checkout history page
    4/ Set the intranetreadinghistory to not allow
    5/ Refresh both pages => no change
    6/ Apply this patch
    7/ Refresh both page.
    On the first page, you should see a warning
    On the other one, you should see that the patron column is not displayed
    anymore.
    
    Followed test plan, results were as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    http://bugs.koha-community.org/show_bug.cgi?id=10886
    Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
    Nice addition!
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    
    (cherry picked from commit d847b1d92a9df6db2bb5321f032f3ec13d6ba55d)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit 114e3cae1a9a4613894492960eb5268c29c1999f
Author: Magnus Enger <magnus at libriotech.no>
Date:   Wed Jun 17 14:36:44 2015 +0200

    Bug 14403: Remove warn in Koha::NorwegianPatronDB
    
    Line 99 has an unconditional warn, left over from development:
    
    warn "$combined_username => $combined_password";
    
    This patch deletes the line i question.
    
    To test:
    No testing needed, just have a look at the diff and see that
    it makes sense to delete the warn.
    
    Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    (cherry picked from commit b740b1b412e11b1d540b243e7b1767cc0c1cb962)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 C4/Auth.pm                                         |    1 -
 Koha/NorwegianPatronDB.pm                          |    1 -
 .../prog/en/modules/catalogue/issuehistory.tt      |   26 +++++----
 .../prog/en/modules/members/readingrec.tt          |    4 +-
 .../opac-tmpl/bootstrap/en/includes/usermenu.inc   |   12 ++---
 .../bootstrap/en/modules/opac-suggestions.tt       |   57 ++++++++++++--------
 opac/opac-suggestions.pl                           |   46 +++++++++++-----
 7 files changed, 90 insertions(+), 57 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list