[koha-commits] main Koha release repository branch master updated. v3.18.00-939-g20b842e

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  20b842e7b0ae1d0378c37ad854532cd1294c574f (commit)
       via  c8d364ae727053e40926772ca43c1cb6ff9dc176 (commit)
       via  0b24910100fbbe098acd2c8e4b961d0caa896e9e (commit)
      from  52c4161c83c9456836a8bfb4b0e1c1ab95896acc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 20b842e7b0ae1d0378c37ad854532cd1294c574f
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Thu May 7 14:12:14 2015 -0300

    Bug 13758: (QA followup) revert case change that broke the tests
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit c8d364ae727053e40926772ca43c1cb6ff9dc176
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed May 6 13:56:30 2015 -0400

    Bug 14103: Improved testing coverage
    
    As per Chris' comment #17, this improves the testing coverage.
    
    Same test plan as comment #16, but add:
    
    TEST PLAN SUPPLEMENT
    --------------------
    1) $ prove -v t/db_dependent/Borrower_Discharge.t
       -- notice only 5 tests, and generate_as_pdf not tested.
    2) Apply this patch.
    3) Retest as per comment #16
       -- this will test the error and no error cases
          tweaked in Koha/Borrower/Discharge.pm
    4) remove PDF::HTML
       $ sudo apt-get purge libpdf-fromhtml-perl
    5) $ prove -v t/db_dependent/Borrower_Discharge.t
       -- 7 tests, all successful
    6) add PDF::HTML
       $ sudo dpkg -i /path/to/libpdf-fromhtml-perl...
       -- depends on how you get it. vary accordingly.
    7) $ prove -v t/db_dependent/Borrower_Discharge.t
       -- 7 tests, all successful
       -- Note that is was a different 7th test. :)
    8) koha qa test tools
    
    Signed-off-by: Chris Nighswonger <cnighswonger at foundations.edu>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit 0b24910100fbbe098acd2c8e4b961d0caa896e9e
Author: Mark Tompsett <mtompset at hotmail.com>
Date:   Wed May 6 01:08:04 2015 -0400

    Bug 14103: PDF::FromHTML is conditionally required on UseDischarge systempreference
    
    Since this is only in generate_as_pdf of Koha::Borrowers::Discharge, it made
    sense to change it from a use to a require (avoiding a compile time error),
    and placing it inside the eval where the PDF is generated, thus capturing the
    problem in the koha error log.
    
    TEST PLAN
    ---------
    1) Log in to staff client
    2) Koha Administration -> Global system preferences -> Local Use
    3) Lower the Version number by 1, but DO NOT CLICK SAVE.
    4) At the command line, sudo apt-get purge libpdf-fromhtml-perl
    5) Back in the staff client, click save.
    6) Every looks great until you attempt to log in. KABOOM!
    7) Apply patch
    8) Log in to staff client
       -- YAY!
    9) Koha Administration -> Global system preferences -> Patrons
    10) Make use the useDischarge is set to Allow
    11) Find a patron with nothing checked out.
    12) There is now a Discharge tab on the left at the bottom.
    13) Click the 'Generate Discharge' button.
        -- nice error message
        -- check koha error log file for the ugly @INC missing message
    14) At the command line, reinstall PDF::FromHTML
        (I built my own with cpan2deb: sudo dpkg -i /path/to/libpdf-fromhtml-perl_...)
    15) In the staff client, click the 'Generate Discharge' button again.
        -- PDF is created as expected. All is well.
    16) run koha qa test tools.
    
    Signed-off-by: Chris Nighswonger <cnighswonger at foundations.edu>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

-----------------------------------------------------------------------

Summary of changes:
 Koha/Borrower/Discharge.pm          |   21 ++++++++++++++++-----
 t/Koha_Template_Plugin_Koha.t       |    8 ++++----
 t/db_dependent/Borrower_Discharge.t |   17 +++++++++++++++++
 3 files changed, 37 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository