[koha-commits] main Koha release repository branch master updated. v3.20.00-beta-22-ga072260
Git repo owner
gitmaster at git.koha-community.org
Thu May 14 16:51:44 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via a072260bf64f46e922bdb6a05b2f6dac605d3c60 (commit)
via 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7 (commit)
via 9bfa7f9e29c78ca39c3dd97a798e293c41fc2a81 (commit)
via c7a4b7e51b29a98c0b126504e0ff60a010ad7081 (commit)
via eb80bedc29a0aad74a89c1dff9dffc9c40720793 (commit)
via 1a54f0916ed96ae717cdca8ece53cf5998bafec3 (commit)
via b678c7359e2e7fe33d58d936f3227990911d43b6 (commit)
via 1d403fa465ca998c820f3de2cc162a7b6ba65351 (commit)
via 27b4db696f4b7a30b6dfdd96937839628c341335 (commit)
via 220315b9e5f2cf45282bf7296ffa5f7d356aec79 (commit)
via 95ce9492b9bc2aba5539eaf0efabdb3a4e56178d (commit)
from ae5d6d46dedd2b375a18b1a18850493420a3080a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a072260bf64f46e922bdb6a05b2f6dac605d3c60
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Apr 29 10:56:42 2015 +0200
Bug 13423: Fix number of tests in Serials.t
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 65b7ad030cd5cd0e3148fbbd1496d31b5cf149f7
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Sat Apr 25 09:01:44 2015 -0300
Bug 13423: Remove unused serials-recieve
This patch removes two files, serials-recieve.pl and serial-recieve.tt
serials-recieve.pl is not called anyware
(it's recieve!)
Also removes the sub removeMissingIssue called only from serials-recieve.pl
git grep serials-recieve.pl .
C4/Serials.pm:called when a missing issue is found from the serials-recieve.pl file
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt: <form method="post" name="f" action="serials-recieve.pl" onsubmit="return barcode_check()">
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt: <form method="post" name="f2" action="serials-recieve.pl">
serials/serials-recieve.pl:serials-recieve.pl
Just a POD entry and self reference.
After removing of files
git grep removeMissingIssue .
C4/Serials.pm: &check_routing &updateClaim &removeMissingIssue
C4/Serials.pm:=head2 removeMissingIssue
C4/Serials.pm:removeMissingIssue($subscriptionid)
C4/Serials.pm:sub removeMissingIssue {
t/db_dependent/Serials.t:is(C4::Serials::removeMissingIssue(), undef, 'test removing a missing issue');
Not used anymore
To test:
1) Apply the patch
2) Check serials workflow, no changes must be noted
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 9bfa7f9e29c78ca39c3dd97a798e293c41fc2a81
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Tue Mar 24 14:54:57 2015 -0300
Bug 13423: Remove unused JS function in serials-edit.tt
This patch removes unused code:
* barcode_check() function, with untranslatable strings
* commented call to this function
To test:
1. Apply the patch
2. Check serials receive, no changes shall be detected
NOTE: I did not run this test plan.
Verification steps
------------------
1. Find out where barcode_check is used.
$ git grep barcode_check
-- This is only in serials-edit.tt and serials-receive.tt
2. This patch only affects serials-edit.tt, so
check who put the <!--onsubmit="return barcode_check()">-->
$ git blame -L130 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
-- note the commit related number.
3. Check out the commit.
$ git show 77b64098
-- should show bug 5917, but the patches on bugzilla don't
have the change nicely, so...
4. Hunt through the pages to find the change.
-- Note: it is part of a "new file" diff!
5. Since this code hasn't been running since it was added...
6. apply the patch
7. run koha-qa test tools
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit c7a4b7e51b29a98c0b126504e0ff60a010ad7081
Author: Marc Véron <veron at veron.ch>
Date: Wed Apr 29 11:34:40 2015 +0200
Bug 14077: Remove unused AUTH_UPDATE_FAILED from moremember.tt
'AUTH_UPDATE_FAILED' in moremember.tt is never set and should be removed (see comment #6 on Bug 13910).
To verify: git grep 'AUTH_UPDATE_FAILED'
Result: Only one occurence (in moremember.tt)
Test plan:
- Apply patch (on top of Bug 13910)
- Verify that the part with AUTH_UPDATE_FAILED is removed from moremember.tt
- Go to a patron's detail page and verify that nothing is broken (Home > Patrons > Patrons details for...)
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
This has been introduced by
commit 1a91801b06607ee9e5f8c21d531a7b7a3ca3b683
Date: Sat Dec 1 20:56:27 2007 -0600
Add Staff member type. Add permissions checks for bug# 1269
and related permissions on memberentry and mods.
But was already not used...
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit eb80bedc29a0aad74a89c1dff9dffc9c40720793
Author: Marc Véron <veron at veron.ch>
Date: Wed Apr 29 11:18:08 2015 +0200
Bug 13910: Line with AUTH_UPDATE_FAILED restored
As of comment #6
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
This should be fixed in a separate patch, this error is not sent to the
template and the related code could be removed.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 1a54f0916ed96ae717cdca8ece53cf5998bafec3
Author: Marc Véron <veron at veron.ch>
Date: Thu Apr 23 22:50:17 2015 +0200
Bug 13910: Prevent delete of one's own patron account
This patch adds a check to prevent deleting the user's own account.
Additionali it fixes a "missing link" in moremember.pl and wrong comparisions in moremember.tt regarding other forbidden deleting.
To test:
- Apply patch
- Create a user with sufficient privileges to delete users
- Log in as this new user
- Try to delete this user. Confirm message box "Are you sure..."
- Confirm that you get a message "Not allowed to delete own account" and that the user still exists.
Bonus test:
Try to trigger other forbidden deletions (see members/deletemem.pl): 'CANT_DELETE_STAFF', 'CANT_DELETE_OTHERLIBRARY', 'CANT_DELETE'
(You can fake it by using an URL like: /cgi-bin/koha/members/moremember.pl?borrowernumber=115&error=CANT_DELETE_STAFF etc.)
Without patch, no message appears. With patch, messages appear as appropriate.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
NOTE: Attempted all CANT combinations. From reading the code,
this is kind of an important patch, because I'm not sure
deleting error messages work at all right now based on what
I read.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit b678c7359e2e7fe33d58d936f3227990911d43b6
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Apr 8 16:21:15 2015 +0200
Bug 9139: New subscription form - Does not check form on the first page
The vendor and Record input try to sent the form if the focus is on the
inputs (normal behavior).
But the form is on 2 pages, and the popup message ask you to fill info
on the second page when you are on the first one. This does not make
sense.
This patch suggests to launch search when the enter key is press on
these inputs.
Test plan:
1/ Create a new subscription
2/ Put the focus in the Vendor input and press enter: the vendor search
popup should appear
3/ Put the focus in the Record input and press enter: the record search
popup should appear
Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace at sub.su.se>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 1d403fa465ca998c820f3de2cc162a7b6ba65351
Author: Katrin Fischer <Katrin.Fischer.83 at web.de>
Date: Tue Apr 28 22:49:33 2015 +0200
Bug 14074: Format 'suggested on' date in suggestion list correctly
One of the dates (suggested on) in the list of
suggestions in staff is not correctly formatted.
To test:
- Create one or many suggestions
- Check the list of suggestion, especially in the
'Suggested by - on' column
- Verify the date is not displayed according to
the dateformat preference
- Apply patch
- Verify the problem is fixed
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 27b4db696f4b7a30b6dfdd96937839628c341335
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Apr 27 13:03:22 2015 +0200
Bug 11576: Make "manage" translatable - serials-collection
If a subscription is irregular, a tab with "manage" is displayed on the
serial collection page.
But this string is not translatable.
Test plan:
1/ Go on the serial collection page of an irregular subscription (or
create one).
2/ Note that the first tab was named "managed", it's now "Manage".
3/ Update a po lang file and confirm you see the string and you are able
to translate it.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described, no koha-qa errors
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 220315b9e5f2cf45282bf7296ffa5f7d356aec79
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Thu May 14 11:30:00 2015 -0300
Bug 11006: (RM followup) DBIx updates
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 95ce9492b9bc2aba5539eaf0efabdb3a4e56178d
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Thu May 14 11:29:29 2015 -0300
Bug 13421: (RM followup) DBIx updates
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Serials.pm | 43 +--
Koha/Schema/Result/Aqorder.pm | 12 +-
Koha/Schema/Result/Virtualshelve.pm | 18 +-
.../prog/en/modules/members/moremember.tt | 16 +-
.../prog/en/modules/serials/serials-collection.tt | 6 +-
.../prog/en/modules/serials/serials-edit.tt | 31 --
.../prog/en/modules/serials/serials-recieve.tt | 363 --------------------
.../prog/en/modules/serials/subscription-add.tt | 14 +-
.../prog/en/modules/suggestion/suggestion.tt | 2 +-
members/deletemem.pl | 6 +
members/moremember.pl | 2 +
serials/serials-recieve.pl | 278 ---------------
t/db_dependent/Serials.t | 4 +-
13 files changed, 55 insertions(+), 740 deletions(-)
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt
delete mode 100755 serials/serials-recieve.pl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list