[koha-commits] main Koha release repository branch master updated. v3.20.00-beta-35-g77930a5
Git repo owner
gitmaster at git.koha-community.org
Fri May 15 20:42:14 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 77930a5945c915e88b25fbac9d1432522b61b3cd (commit)
via 69e4b9b69b81dc35636cacad1f4dfb7042636cfc (commit)
via e196f19e2d7d6825e71306f45bcda0f3903a7a7f (commit)
via 52ee96316f95efbc653d3c4f45d438f1e392679b (commit)
via a1b7f1506245576e0167b35ae91cfc080917554c (commit)
via ad3b05996bb5c9c67fc419911fbe460fb3e523b7 (commit)
from fd8ac6f3cde3fa3b1e4ccf566334220c8cf39ce1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 77930a5945c915e88b25fbac9d1432522b61b3cd
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Apr 13 16:27:39 2015 +0200
Bug 11385: Remove SQL::Helper
At this point, no occurrence of SQL::Helper should exist.
Let's remove the package and tests.
Test plan:
git grep SQLHelper
and
git grep InTable
Should not return anything in the Koha code.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 69e4b9b69b81dc35636cacad1f4dfb7042636cfc
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Tue Apr 21 16:50:12 2015 +0200
Bug 12633: Fix specific default values
The dates should be set to undef if defined but empty, otherwise with an
empty string, '0000-00-00' will be inserted into the DB.
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit e196f19e2d7d6825e71306f45bcda0f3903a7a7f
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Mon Apr 13 16:21:50 2015 +0200
Bug 12633: Remove SQLHelper in C4::Members
This is the only places where SQLHelper is still called.
The C4::Members::Search is not used anymore, but ModMember and
AddMember.
This patch replaced the calls to SQLHelper to use DBIX::Class.
TODO: Move them to Koha::Borrower.
Test plan:
1/ Make sure the patron search still works (no changes expected since the
code was not in used).
2/ Add a patron with all fields filled
3/ Add another patron with some fields filled
4/ Update them with other values
5/ Delete them
You should not get any errors.
Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 52ee96316f95efbc653d3c4f45d438f1e392679b
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Wed Apr 22 10:19:33 2015 +0200
Bug 14038: Make nl-search.pl not using C4::Members::Search
To get rid of SQLHelper, we should not use this C4::Members::Search anymore.
Test plan for Magnus :)
0/ Enable the pref you need to use the Norwegian national library card ft
1/ Go on the members/nl-search.pl page and search for patrons.
2/ Make sure you search by card number and by "social security number"
Signed-off-by: Magnus Enger <magnus at enger.priv.no>
Searching works the same with and without the patch. Thanks Jonathan!
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit a1b7f1506245576e0167b35ae91cfc080917554c
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Fri May 15 15:28:56 2015 -0300
Bug 14204: (QA followup) remove unneeded messages
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit ad3b05996bb5c9c67fc419911fbe460fb3e523b7
Author: Nick Clemens <nick at quecheelibrary.org>
Date: Thu May 14 19:56:43 2015 +0000
Bug 14204: Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991
This patch updaes the batch_id variable after items are added to test batch
To test:
1. prove t/db_dependent/Labels/t_Batch.t and see two tests fail
2. apply patch
3. prove again, tests pass!
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
NOTE: The $batch->add_item() call to C4::Creators::Batch::add_item
triggers the change of the batch_id so this line is necessary!
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Members.pm | 168 +++----------
C4/SQLHelper.pm | 506 ---------------------------------------
members/nl-search.pl | 8 +-
t/db_dependent/Labels/t_Batch.t | 38 +--
t/db_dependent/Members.t | 66 +----
t/db_dependent/SQLHelper.t | 66 -----
6 files changed, 57 insertions(+), 795 deletions(-)
delete mode 100644 C4/SQLHelper.pm
delete mode 100755 t/db_dependent/SQLHelper.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list