[koha-commits] main Koha release repository branch master updated. v3.20.00-39-ge021b51
Git repo owner
gitmaster at git.koha-community.org
Tue May 26 19:37:15 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via e021b512e34d0521803fa5f32dd67f1532ddb73d (commit)
via 351b2f753f7b30665dc22be595af4a00589424e7 (commit)
via 50d2b712883808a36b1d03ac770aed470c8d19d1 (commit)
via 47d2de9c024bfb93d56184f298f334b20685cd86 (commit)
via cee05ed04efd8c4f273de395906d6d17c72dc768 (commit)
via 00393b73e4e2fa8ea806803dbe101d8d23b53cd4 (commit)
via 99f74da95196efd5fd6d3eb668b01a7604346a07 (commit)
via 54312cb5956edf299e19e9000a25c19d25879ba5 (commit)
via 8d58036b49821ea2d74a2b9cdac5b83b33e435b4 (commit)
via a95b385e31eef138b412a33b1902614b598aa19c (commit)
via 0ee7615036d372729054828c4ff5aa2ea8be91f0 (commit)
via e52e9fb7a205bd96750e0b48544c516fdb0deebf (commit)
via 109c610e99e1efcef970ae3bea3c1dc33fd2e198 (commit)
via f55c1032b757458815f6e7106605ddfbc5ba3d77 (commit)
via 5bb7ffa02685c60be44512510b53710a8e43c892 (commit)
from 73d9706667c3e1574c0b19009f4dc4e02c4c65e2 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit e021b512e34d0521803fa5f32dd67f1532ddb73d
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Sat May 23 14:01:57 2015 +0200
Bug 12176: Fix for missing field_value in select
As Jonathan Druart discovered, we were still missing an important attribute
in the selects. Var mv.name was not filled, so the name was empty with nice
side-effects :)
While fixing this, it was also possible to delete some unused vars that Bernardo
already mentioned before: $attributes and $attributes_no_value.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
For me the simptom was different, when saving an edited item
fields were mangled beyond repear :(
No alert for empty mandatory fields.
But this last patch fix the problem.
Tested add/edit items
Cleaner pl file :)
No errors
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 351b2f753f7b30665dc22be595af4a00589424e7
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed May 20 16:42:34 2015 +0200
Bug 12176: [QA Follow-up] Capitalization typo after eleventh hour
While cleaning up, still found this super tiny string typo :)
Yes, Tag Editor should now be Tag editor.
Test plan :)
Git grep on Tag editor and Tag Editor
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 50d2b712883808a36b1d03ac770aed470c8d19d1
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed May 20 14:56:48 2015 +0200
Bug 12176: [QA Follow-up] Small additem adjustments
Adjusting a few small things and making qa tools happy:
[1] Remove .hidden after [% avalue %] in additem.tt. (Typo)
[2] A closer look revealed that mv.avalue is useless too. An input element
does not contain any content. Putting it after the hidden element
in a non-visible context has no meaning.
[3] Change handling of select attributes readonly and disabled.
[4] Remove unused variable $attributes_no_value_textarea
[5] Removed a comment with TODO referring to this report.
[6] Moving a duplicated TT variable (mv.javascript) outside IF statement.
[7] And finally could not resist this one: Moving strings Tag editor and
No popup from script to template. Plugins++
NOTE: Most item plugins redirect click to focus. In that case there is
no popup, but unfortunately the text Tag editor comes up.
When you remove or rename function Click, No popup comes up. So it works.
Sorry that this small list kept growing :)
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 47d2de9c024bfb93d56184f298f334b20685cd86
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date: Tue May 19 13:06:34 2015 -0300
Bug 12176: Remove HTML from additem.pl
This patch removes HTML code from additem.pl.
To test:
1. Check no regressions on Add/Edit/Save items
2. Update translation files for a language,
check new strings "Tag editor" & "No popup" on staff PO file
3. Check it passes xt/tt_valid.t
Patch partially rebased, part rewritten.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit cee05ed04efd8c4f273de395906d6d17c72dc768
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Tue May 26 11:42:48 2015 -0300
Bug 13899: (QA followup) POD and usage message fixes
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
asd
commit 00393b73e4e2fa8ea806803dbe101d8d23b53cd4
Author: Julian FIOL <julian.fiol at biblibre.com>
Date: Mon Apr 27 09:21:26 2015 +0200
Bug 13899: Changing license to GPLv3
koha-qa should be good :
OK misc/devel/coverage.pl
OK critic
OK forbidden patterns
OK pod
OK valid
OK C4/Installer/PerlDependencies.pm
OK critic
OK forbidden patterns
OK pod
OK valid
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No koha-qa errors.
Test plan not explicitly stated,
script run and generates a lot of data :)
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 99f74da95196efd5fd6d3eb668b01a7604346a07
Author: Julian FIOL <julian.fiol at biblibre.com>
Date: Wed Apr 15 10:51:16 2015 +0200
Bug 13899: Add changes as asked in Comment 5
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Fixed a small conflict on PerlDependencies.pm
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 54312cb5956edf299e19e9000a25c19d25879ba5
Author: Julian FIOL <julian.fiol at biblibre.com>
Date: Tue Mar 24 11:46:10 2015 +0100
Bug 13899: Adding misc/devel/coverage.pl
It's a script making a cover on all modules to see
which ones are not tested yet. It uses Devel::Cover
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 8d58036b49821ea2d74a2b9cdac5b83b33e435b4
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Tue May 26 14:17:08 2015 -0300
Revert "Bug 6679: Fix 11 perlcritic violations in C4/Dates.pm"
This reverts commit 2ee1a35dfa91892474a7d10f8783dd95edbe7696.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit a95b385e31eef138b412a33b1902614b598aa19c
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Tue May 26 14:16:58 2015 -0300
Revert "Bug 6679: Fix 9 perlcritic violations in C4/TmplTokenType.pm"
This reverts commit 09787ec8b09cf3cf90cb5d6ff96c77dc0d314c58.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 0ee7615036d372729054828c4ff5aa2ea8be91f0
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Tue May 26 14:16:50 2015 -0300
Revert "Bug 6679: Fix 6 perlcritic violations in C4/Reports/Guided.pm"
This reverts commit e592536d97483b88dceabedfaec9fefcefbcda2f.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit e52e9fb7a205bd96750e0b48544c516fdb0deebf
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Tue May 26 14:16:41 2015 -0300
Revert "Bug 6679: Fix 2 perlcritic violations in C4/Installer/PerlModules.pm"
This reverts commit 7fbc7467b53784b41e1ef2db7a95ed69235c9c5e.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 109c610e99e1efcef970ae3bea3c1dc33fd2e198
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Tue May 26 14:16:31 2015 -0300
Revert "Bug 6679: Fixing code so it passes basic Perl:::Critic tests"
This reverts commit 8b9a555cc9391b841472ca11a0f48edcd4819a2f.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit f55c1032b757458815f6e7106605ddfbc5ba3d77
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Tue May 26 14:16:21 2015 -0300
Revert "Bug 6679: (follow-up) fix 9 perlcritic violations in C4/TmplTokenType.pm"
This reverts commit 8554ce273cd24bcef738ebf76aeaa79db87403e1.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
commit 5bb7ffa02685c60be44512510b53710a8e43c892
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date: Tue May 26 14:16:06 2015 -0300
Revert "Bug 6679: Fix 3 perlcritic violations in C4/Record.pm"
This reverts commit a04e8a8bfcff1d6c8e09a98086f108fac76d6e2d.
Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
-----------------------------------------------------------------------
Summary of changes:
C4/Dates.pm | 24 ++--
C4/Installer/PerlDependencies.pm | 5 +
C4/Installer/PerlModules.pm | 4 +-
C4/Record.pm | 6 +-
C4/Reports/Guided.pm | 2 +-
C4/TmplToken.pm | 2 +-
C4/TmplTokenType.pm | 18 +--
cataloguing/additem.pl | 128 ++++++++++++--------
.../prog/en/modules/cataloguing/additem.tt | 37 +++++-
misc/devel/coverage.pl | 79 ++++++++++++
opac/ilsdi.pl | 9 +-
11 files changed, 227 insertions(+), 87 deletions(-)
create mode 100755 misc/devel/coverage.pl
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list