[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.00-4-g4a9c83d

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  4a9c83d8508110f9d4e5a9dea5a34332831d85f3 (commit)
       via  f501d51807c3d9b7d2eea3402ec95b0a7d01f400 (commit)
      from  bade83ae7bc38b83620e95507501ba997fc70fae (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4a9c83d8508110f9d4e5a9dea5a34332831d85f3
Author: Indranil Das Gupta <indradg at gmail.com>
Date:   Thu May 14 07:23:16 2015 +0530

    Bug 14186 [QA Followup]: Undefined $reservedfor causes warn in opac-reserve.pl
    
    This is a followup for Bug 14186 that removes the extraneous tab
    char on line 470, so that the patch can clear QA tools.
    
    This patch sets $reservedfor to an empty string.
    
    Test plan
    =========
    
    1/ in a terminal, run `tail -f ` on your instance's opac-error.log
    2/ go to the opac and search from an item that exists on the Koha
       instance.
    3/ Select the title (if more than one title is returned) and click on
       'Place hold' link to go to opac-reserve.pl
    4/ notice the warning - "opac-reserve.pl: Use of uninitialized value
       $reservedfor" appear in the `tail`ed opac-error.log
    5/ apply the patch
    6/ reload the page (opac-reserve.pl)
    7/ page works but the warning in step #4 is no longer thrown up
    8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error
    
    Remarks: Testing result match expected test plan output. The QA tests
             pass with "OK" for the commit.
    
    Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 642e6012cd125cbc3aeaca83e1fd2430ce43fdb0)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit f501d51807c3d9b7d2eea3402ec95b0a7d01f400
Author: Aleisha <aleishaamohia at hotmail.com>
Date:   Tue May 12 03:30:46 2015 +0000

    Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl
    
    This patch sets $reservedfor to an empty string.
    
    Test plan
    =========
    
    1/ in a terminal, run `tail -f ` on your instance's opac-error.log
    2/ go to the opac and search from an item that exists on the Koha
       instance.
    3/ Select the title (if more than one title is returned) and click on
       'Place hold' link to go to opac-reserve.pl
    4/ notice the warning - "opac-reserve.pl: Use of uninitialized value
       $reservedfor" appear in the `tail`ed opac-error.log
    5/ apply the patch
    6/ reload the page (opac-reserve.pl)
    7/ page works but the warning in step #4 is no longer thrown up
    8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error
    
    Remarks: The QA test failed - "forbidden pattern: tab char (line 470)".
    
             Marking this as 'FAILED QA'
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 8fdd352bc9bb4d0dd84ca0df33b51558ee765ea1)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 opac/opac-reserve.pl |    1 +
 1 file changed, 1 insertion(+)


hooks/post-receive
-- 
main Koha release repository