[koha-commits] main Koha release repository branch 3.16.x updated. v3.16.10-4-g5e7ebdc

Git repo owner gitmaster at git.koha-community.org
Fri May 29 06:45:39 CEST 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.16.x has been updated
       via  5e7ebdca9dcd606e213cb4435bb734fff6e1394e (commit)
       via  eba22a082eeb3a277033d11ca59717169f0e0cba (commit)
       via  7160db430f7e32902eefacc3e50feab682dc0829 (commit)
      from  907d1615d4b13c812808dd1dcf3848b46140f281 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5e7ebdca9dcd606e213cb4435bb734fff6e1394e
Author: Tomas Cohen Arazi <tomascohen at gmail.com>
Date:   Thu Feb 5 15:50:30 2015 -0300

    Bug 7904: (QA followup) fix tests
    
    The package name for SIP wasn't fixed in the tests by the original patches.
    
    This patch fixes it.
    
    To test:
    - Run
      $ prove t/db_dependent/SIP_ILS.t
    - Tests should pass with the patch.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>

commit eba22a082eeb3a277033d11ca59717169f0e0cba
Author: Colin Campbell <colin.campbell at ptfs-europe.com>
Date:   Thu Oct 30 15:36:09 2014 +0000

    Bug 7904 Change SIP modules to use standard LIB path
    
    For historical reasons the SIPServer and SIP modules
    have used an extra module path in addition to the
    standard Koha one. This has caused numerous irritants
    in attempting to set up scripts and basic tests. It
    does not help in attempting to modify or debug
    this code
    
    This patch changes the package value in the modules
    under the C4/SIP directory and makes calls to
    them use the full package name.
    
    Where the export mechanism was being short circuited
    routines have been explicitly exported and imported
    declarations of 'use ILS' when that module was
    not being used and which only generated warnings
    have been removed.
    
    As a lot of the changes affect lines where
    an object is instantiated with new. The opportunity
    has been taken to replace the ambiguous indirect
    syntax with the preferred direct call
    
    In intializing ILS the full path is added as this
    will not require any changes to existing configs.
    I suspect this feature is unused, and adds
    obfuscation rather than flexibility but have kept
    the feature as we need this change in order to
    rationalize and extend the testing of the server.
    
    The visible difference is that with the normal Koha
    PERL5LIB setting. Compilation of Modules under C4/SIP
    should be successful and not fail with unlocated modules,
    allowing developers to see any perl warnings
    
    All the SIP modules can now be run through the tests
    in t/00-load.t now except for SIPServer itself
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Mason James <mtj at kohaaloha.com>

commit 7160db430f7e32902eefacc3e50feab682dc0829
Author: Robin Sheat <robin at catalyst.net.nz>
Date:   Mon Nov 10 11:38:29 2014 +1300

    Bug 7904 - remove unnecessary path from SIP script
    
    With the fixing of the namespace in the SIP code, we don't need to
    modify the PERL5LIB to have the old one.
    
    To test:
    * do a package install using this and the other patches on bug 7904
    * enable SIP
    * make sure koha-start-sip and koha-stop-sip work
    
    Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
    Signed-off-by: Mason James <mtj at kohaaloha.com>

-----------------------------------------------------------------------

Summary of changes:
 C4/SIP/ILS.pm                               |   68 +++++++++++------------
 C4/SIP/ILS/Item.pm                          |    6 +--
 C4/SIP/ILS/Patron.pm                        |    2 +-
 C4/SIP/ILS/Transaction.pm                   |    2 +-
 C4/SIP/ILS/Transaction/Checkin.pm           |    7 ++-
 C4/SIP/ILS/Transaction/Checkout.pm          |    7 ++-
 C4/SIP/ILS/Transaction/FeePayment.pm        |    5 +-
 C4/SIP/ILS/Transaction/Hold.pm              |    7 ++-
 C4/SIP/ILS/Transaction/Renew.pm             |    6 +--
 C4/SIP/ILS/Transaction/RenewAll.pm          |    8 +--
 C4/SIP/SIPServer.pm                         |   28 +++++-----
 C4/SIP/Sip.pm                               |    6 +--
 C4/SIP/Sip/Checksum.pm                      |    2 +-
 C4/SIP/Sip/Configuration.pm                 |   14 ++---
 C4/SIP/Sip/Configuration/Account.pm         |    2 +-
 C4/SIP/Sip/Configuration/Institution.pm     |    2 +-
 C4/SIP/Sip/Configuration/Service.pm         |    2 +-
 C4/SIP/Sip/Constants.pm                     |    2 +-
 C4/SIP/Sip/MsgType.pm                       |   78 ++++++++++++++-------------
 C4/SIP/example_institution_dump.sh          |    8 +--
 C4/SIP/interactive_item_dump.pl             |    4 +-
 C4/SIP/interactive_patron_check_password.pl |    6 +--
 C4/SIP/interactive_patron_dump.pl           |    4 +-
 C4/SIP/interactive_renew_all_dump.pl        |    4 +-
 C4/SIP/t/000_sc_config_auth.t               |    4 +-
 C4/SIP/t/00sc_status.t                      |    2 +
 C4/SIP/t/01patron_status.t                  |    6 ++-
 C4/SIP/t/02patron_info.t                    |    4 +-
 C4/SIP/t/03checkout.t                       |    4 +-
 C4/SIP/t/04patron_status.t                  |    4 +-
 C4/SIP/t/05block_patron.t                   |    6 ++-
 C4/SIP/t/06patron_enable.t                  |    4 +-
 C4/SIP/t/07hold.t                           |    4 +-
 C4/SIP/t/08checkin.t                        |    4 +-
 C4/SIP/t/09renew.t                          |    4 +-
 C4/SIP/t/10renew_all.t                      |    4 +-
 C4/SIP/t/11item_info.t                      |    4 +-
 C4/SIP/t/SIPtest.pm                         |    6 +--
 C4/SIP/xmlparse.pl                          |    2 +-
 debian/scripts/koha-start-sip               |    2 +-
 t/00-load.t                                 |   16 +-----
 t/SIP_Sip.t                                 |   21 ++++----
 t/db_dependent/SIP_ILS.t                    |   10 ++--
 43 files changed, 202 insertions(+), 189 deletions(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list