[koha-commits] main Koha release repository branch master updated. v3.20.00-1015-g3e0b35c

Wed Nov 4 15:00:13 CET 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  3e0b35c15db408593b0d1a1a4c381750f8d3bec8 (commit)
       via  6b31947c3bb6517ecdc7d21440ba79895c270749 (commit)
       via  fff73a73837d577214fa3a9198fa97f8a50471f3 (commit)
       via  c292dde75b5e206045cef47d0be51235159a4b6d (commit)
      from  8122df1f8788cbd695e06aa4c1acfa345da8cadc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3e0b35c15db408593b0d1a1a4c381750f8d3bec8
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date:   Mon Oct 26 08:44:17 2015 +0100

    Bug 15059: Line break in html attribute in branchoverdues.tt

    In circ/branchoverdues.tt, there is a line break inside href attribute.
    This generates an attribute with a lot of spaces %20.

    Test plan :
    - at intranet go to ciculation module
    - click on "Overdues with fines"
    - look at links "Phone", "Notice" and "Considered lost"
    => Without patch the URL contains a lot of spaces
    => With patch the URL is correct

    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 6b31947c3bb6517ecdc7d21440ba79895c270749
Author: Mason James <mtj at kohaaloha.com>
Date:   Wed Sep 16 13:56:23 2015 +1200

    Bug 15035: Anti-spam for opac-suggestions - FOLLOW-UP

    to test this patch...

    1/ enable 'suggestion' and 'AnonSuggestions' sysprefs

    2/ edit the koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt file,
        to reveal the hidden 'negcap' field

       replace line 87 opac-suggestions.tt, from...
         <li id="negcap" style="position: absolute; left: -2000px;">
       to ...
         <li id="negcap">

    3/ attempt to add another suggestion, and populate the 'negcap' field
       adding the suggestion is supposed to fail, but actually succeeds!?  :/

    4/ apply patch

    5/ repeat step 3, suggestion attempt should fail as expected

    	modified:   opac-suggestions.pl

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    Confirmed insertion with negcap before patch.
    With negcap value suggestion fails silently
    Without negcap suggestion is inserted
    No errors

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit fff73a73837d577214fa3a9198fa97f8a50471f3
Author: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Date:   Tue Nov 3 12:16:08 2015 -0300

    Bug 15061: Can't add item to rotating collection

    This patch prevents adding items to invalid (empty)
    rotating collection id

    To test:
    1) Go to /cgi-bin/koha/rotating_collections/addItems.pl
    2) Try to add an item, you get error show in attached pictures
    3) Apply the patch
    4) Go again to /cgi-bin/koha/rotating_collections/addItems.pl
    5) Can't add any items

    I don't know if this is a real problem

    Followed test plan, works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit c292dde75b5e206045cef47d0be51235159a4b6d
Author: Marc Véron <veron at veron.ch>
Date:   Tue Oct 27 12:38:32 2015 +0100

    Bug 15068: Get rid of warnings in members/summary-print.pl

    This patch removes warnings when printing a summary from a member's
    detail page, like:

    - use of uninitialized value in sprintf
      at /usr/share/kohaclone/members/summary-print.pl line 47

    - Use of uninitialized value $roadtype in concatenation (.) or string
      at /usr/share/kohaclone/members/summary-print.pl line 61

    - Use of uninitialized value in addition (+)
      at /usr/share/kohaclone/members/summary-print.pl line 87

    - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison
      (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103

    To test:
    - Apply patch
    - Go to a detail page with a member who has a lot of fines
    - Print summary
    - Verify that warnings like the ones above do no longer appear.

    Signed-off-by: Frederic Demians <f.demians at tamil.fr>
      Have been able to see those warnings in Apache log file, and notice
      their disappearance after applying this patch.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/circ/branchoverdues.tt           |    9 +++------
 .../prog/en/modules/rotating_collections/addItems.tt |   11 ++++++++---
 members/summary-print.pl                             |   18 ++++++++++++------
 opac/opac-suggestions.pl                             |    5 ++++-
 4 files changed, 27 insertions(+), 16 deletions(-)

hooks/post-receive
-- 
main Koha release repository