[koha-commits] main Koha release repository branch master updated. v3.20.00-1174-ga0460ec

Tue Nov 10 13:47:52 CET 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  a0460ecc0abbe5f69554ab3885775e55b6a25fe0 (commit)
       via  004fa5ac4448fc1dedf9a74774b2ee0b1ec67f77 (commit)
       via  e815d1e010a20b73327cba1eaa78d08f06ec50a8 (commit)
       via  237c1483ddf22babb4f1bfd4dfa3e7120c2d8cd9 (commit)
       via  9c20a3f7976ce1ff41c18113cb5a8f0c7a3a80e7 (commit)
      from  4a4dbbf1237c93e0233eef0600015c9be3320bf0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a0460ecc0abbe5f69554ab3885775e55b6a25fe0
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Nov 10 09:06:32 2015 +0000

    Bug 14575: Fix typo in opac-basket.tt

    No more typo in the codebase.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 004fa5ac4448fc1dedf9a74774b2ee0b1ec67f77
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Nov 9 11:01:02 2015 +0000

    Bug 14575: Fix typo OPACurlOpenInNewWindow vs OPACURLOpenInNewWindow

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit e815d1e010a20b73327cba1eaa78d08f06ec50a8
Author: David Cook <dcook at prosentient.com.au>
Date:   Tue Jul 21 13:09:39 2015 +1000

    Bug 14575: OPACURLOpenInNewWindow should apply to item-level urls too

    This patch applies the OPACURLOpenInNewWindow system preference
    to item-level urls (in addition to the pre-existing bib-level url
    handling).

    _TEST PLAN_

    Before applying:

    1) Set OPACURLOpenInNewWindow to "don't" and click on an item-level url
    2) Note that the current tab changes to that url
    3) Set OPACURLOpenInNewWindow to "do" and click on an item-level url
    4) Note that the current tab changes to that url

    Apply the patch.

    After applying:

    5) Click on an item-level url
    6) Note that the url opens in a new tab (as OPACURLOpenInNewWindow
    should be set to "do")
    7) Set OPACURLOpenInNewWindow to "don't" and click on an item-level
    url
    8) Note that the url opens in the current tab

    9) Repeat the above steps 5-8 alternating
    "TrackClicks" between "Don't track" and either "Track" or
    "Track anonymously".

    Followed test plan. Works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 237c1483ddf22babb4f1bfd4dfa3e7120c2d8cd9
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Nov 5 13:24:51 2015 +0000

    Bug 14743: addorder.pl redirect problems under plack behind apache 2.4.10

    I can't quite figure this out. When I run CGI version of Koha, I see following response (recorded using tcpdump):

    HTTP/1.1 302 Found
    Date: Thu, 27 Aug 2015 13:28:41 GMT
    Server: Apache/2.4.10 (Debian)
    Location: /cgi-bin/koha/acqui/basket.pl?basketno=5610
    Vary: User-Agent
    Content-Length: 0
    Keep-Alive: timeout=5, max=98
    Connection: Keep-Alive
    Content-Type: text/x-perl

    However, when running behind apache 2.4.10 on Debian wheezy I see chunked response:

    HTTP/1.1 302 Found
    Date: Thu, 27 Aug 2015 13:21:28 GMT
    Server: Apache/2.4.10 (Debian)
    Vary: User-Agent
    Keep-Alive: timeout=5, max=100
    Connection: Keep-Alive
    Transfer-Encoding: chunked
    Content-Type: text/x-perl

    60
    Transfer-Encoding: chunked
    Date: Thu, 27 Aug 2015 13:21:28 GMT
    Connection: keep-alive

    0

    0

    This response doesn't work in firefox (where it reports page not found) nor in chrome (where it returns lines below 60 on screen).

    In the template the hidden input 'basketno' is listed twice. What the cgi script reads in the parameter, what is does is concat the values of the multiple basketno instances together createing what is likely an invalid basketno. For reasons beyond my understanding this is what triggers this error!

    Test Plan:
    1) Using plack, add an order to a basket from an external source
    2) Note the error
    3) Apply this patch
    4) Add an order to a basket from an external source
    5) Note you get no error!

    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 9c20a3f7976ce1ff41c18113cb5a8f0c7a3a80e7
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Nov 9 11:35:03 2015 -0300

    Bug 15160: GetTopIssues.t should create random data

    This patch refactors t/db_dependent/Circulation/GetTopIssues.t so it
    creates its own data with random values. It does so by replacing (legacy)
    SQL inserts and fixed value data inserting by TestBuilder generated data.

    There is no expected behaviour change.

    To test:
    - Create an itemtyp directly on your DB with GTI_I_TEST as its itemtype
      > INSERT INTO itemtypes (itemtype) VALUES ('GTI_I_TEST');
    - Run:
      $ prove t/db_dependent/Circulation/GetTopIssues.t
    => FAIL: The insert line fails
    - Apply the patch
    - Run:
      $ prove t/db_dependent/Circulation/GetTopIssues.t
    => SUCCESS: tests pass due to random data usage.
    - Sign off

    Signed-off-by: Frederic Demians <f.demians at tamil.fr>
      Test plan produces the expected result, failing, then OK.

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-----------------------------------------------------------------------

Summary of changes:
 .../prog/en/modules/acqui/neworderempty.tt         |    1 -
 .../opac-tmpl/bootstrap/en/modules/opac-basket.tt  |    2 +-
 .../opac-tmpl/bootstrap/en/modules/opac-detail.tt  |   16 ++++--
 t/db_dependent/Circulation/GetTopIssues.t          |   56 +++++++++++++-------
 4 files changed, 50 insertions(+), 25 deletions(-)

hooks/post-receive
-- 
main Koha release repository