[koha-commits] main Koha release repository branch master updated. v3.22.00-beta-8-g706a31b

Fri Nov 13 15:31:33 CET 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  706a31b50d52ef1ba48c568d7e60c376cfe87983 (commit)
       via  918038904553ecd8572006abcb91f00bd92b4be4 (commit)
       via  7aabe91749936aa5cffacbf2da385ac2762f80fc (commit)
       via  2e74c8f15b7db2d973d9dcd4c2f6ea4ed12ce709 (commit)
       via  b8b0b1370f98f88efe933cca5e6c186b7b7e513f (commit)
       via  4b1818f0f2a65ae30f225b776c5ea5873ad2ccda (commit)
       via  320d2c586a51d6b6acce3576c4c89b0b36959bbc (commit)
      from  0c33f1d1e6481562c5898afb1289fe8a946e4d7a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 706a31b50d52ef1ba48c568d7e60c376cfe87983
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Oct 29 07:48:02 2015 -0400

    Bug 15079: Batch Delete Records Error

    When using the batch deletion tool, if the script attempts to delete an
    undeletable item, the script will die with the error:

    Label not found for "next BIBLIONUMBER" at
    /usr/share/koha/intranet/cgi-bin/tools/batch_delete_records.pl line 172.

    Test Plan:
    1) Attempt to batch delete a record with an item that cannot be deleted
    2) Note error
    3) Apply this patch
    4) Repeat step 1
    5) Note the error no longer occurs

    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    Works as advertised. Follow comment 5 to reproduce the issue

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    I have not tested this patch, but looking at the code it is obviously a mistake.
    If an error occured, we rollback and skip this record.
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 918038904553ecd8572006abcb91f00bd92b4be4
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 11 14:26:51 2015 +0000

    Bug 14985: dbms expects a iso formatted date

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 7aabe91749936aa5cffacbf2da385ac2762f80fc
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 11 12:07:05 2015 +0000

    Bug 14985: Simplify the date management in AddReserve

    The code is much more readable using the str param of output_pref

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 2e74c8f15b7db2d973d9dcd4c2f6ea4ed12ce709
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 11 12:03:51 2015 +0000

    Bug 14985: Fix regression on patron search

    This patch fixes 2 major errors introduced by last patch:
    1/ Undefined subroutine &C4::Utils::DataTables::Members::dt_from_string
    called
    when searching for patrons
    2/ Display the dates on the patron search in the pref format, not iso

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit b8b0b1370f98f88efe933cca5e6c186b7b7e513f
Author: Marc Véron <veron at veron.ch>
Date:   Thu Oct 8 23:02:30 2015 +0200

    Bug 14985: Remove C4::Dates from files in folder C4/*.pm (part one)

    This patch removes C4::Dates from following files in folder C4:

    - C4/Members.pm
    - C4/Reserves.pm
    - C4/Search.pm
    - C4/Utils/DataTables.pm
    - C4/Utils/DataTables/Members.pm
    - C4/VirtualShelves/Page.pm

    To test:
     -run tests as appropriate,
    - have a close look at the code changes
    - try to find regressions

    http://bugs.koha-community.org/show_bug.cgi?id=14985

    Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

    Bug 14985: (followup) Remove eval if dates come from database

    This patch removes some evals from date-formatting where the dates come
    from the database.

    See comments #7 - #9

    Additionaly, C4/VirtualShelves/Page.pm is removed from the patches (obsolete).

    Bug 14985: (followup) Remove C4::Dates from C4/Overdues.pm

    Ths patch removes a stray C4::Dates from C4/Overdues.pm

    - To test got to a patron who has overdues
      (Home > Circulation > Checkouts > [Patron])
    - Print overdues

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 4b1818f0f2a65ae30f225b776c5ea5873ad2ccda
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Nov 11 11:55:05 2015 +0000

    Bug 15166: Carp if an invalid date is passed

    Sign-off on second patch.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 320d2c586a51d6b6acce3576c4c89b0b36959bbc
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Nov 10 16:38:51 2015 +0000

    Bug 15166: Make output_pref takes a string in parameter

    To simplify the management of dates, it would be great that output_pref takes a string in parameter.

      my $date = $input->param('my_date');
      $date = eval { dt_from_string( $date ) } if $date;
      $date = output_pref({dt => $date}) if $date;

    Could be replace with:

      my $date = output_pref({ str => $input->param('my_date') });

    Tested with t/DateUtils.t, passed OK.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-----------------------------------------------------------------------

Summary of changes:
 C4/Members.pm                  |   13 ++++++-------
 C4/Overdues.pm                 |    3 ++-
 C4/Reserves.pm                 |   18 +++++++-----------
 C4/Search.pm                   |    4 ++--
 C4/Utils/DataTables.pm         |    4 ++--
 C4/Utils/DataTables/Members.pm |    5 +++--
 Koha/DateUtils.pm              |   15 +++++++++++----
 t/DateUtils.t                  |   14 +++++++++++++-
 t/db_dependent/Holds.t         |    2 +-
 tools/batch_delete_records.pl  |    2 +-
 10 files changed, 48 insertions(+), 32 deletions(-)

hooks/post-receive
-- 
main Koha release repository