[koha-commits] main Koha release repository branch master updated. v3.22.00-beta-23-gc0adb88
Git repo owner
gitmaster at git.koha-community.org
Mon Nov 16 19:56:04 CET 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via c0adb88d0a55ac5625bd5973bb7053b14769bd41 (commit)
via 9515db57bdd13cdff33d9056963455fb850ad877 (commit)
via 4f8476e09c2de223f73692521b8f8e533ef8400f (commit)
via b11eb03a4c9674f4f4dedadaa8790257e30fb1d0 (commit)
via f2c6bd2c616383018cfd098214c207efa90aa5ef (commit)
from 528e9963ee80f3abb6f70ecdaa616b6511bdbb3f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c0adb88d0a55ac5625bd5973bb7053b14769bd41
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Mon Nov 16 15:25:26 2015 -0300
Bug 15152: t/db_dependent/Reports_Guided.t should not depend on existing data
The current implementation relies on existing borrowers on the DB.
Even when the DB itself doesn't have a FK constraint, the function
that retrieves the reports from the DB relies on get_saved_reports_base_query
which creates a query that JOINs the full query with the 'borrowers' table, on
the borrowernumber. So it is doomed to fail on some scenarios.
Specially because the current tests expect specific borrowernumber values
to be present (1, 2 and 3).
To test:
[To set the failure scenario]
$ vagrant up jessie
$ vagrant ssh jessie
$ wget https://theke.io/static/reports_guided_sequence.txt -O /vagrant/reports_guided_sequence.txt
$ wget https://theke.io/static/koha_3_20_00.sql.gz -O /vagrant/koha_3_20_00.sql.gz
$ sudo -s
$ mysql
> DROP DATABASE koha_kohadev; CREATE DATABASE koha_kohadev; \q
$ zcat /vagrant/koha_3_20_00.sql.gz | mysql koha_kohadev
$ exit
$ sudo koha-shell kohadev
$ cd kohaclone
$ cat /vagrant/reports_guided_sequence.txt | xargs prove
- now run the tests:
$ prove t/db_dependent/Reports_Guided.t
=> FAIL: The tests fail
- Apply the patch
- [re create the scenario]
- Run the test:
$ prove t/db_dependent/Reports_Guided.t
=> SUCCESS: Tests now pass
- Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 9515db57bdd13cdff33d9056963455fb850ad877
Author: Frédéric Demians <f.demians at tamil.fr>
Date: Thu Nov 5 08:45:25 2015 +0100
Bug 15133: encode correctly email generated by runreport.pl
/misc/cronjobs/runreport.pl send badly encoded email in text/csv
(partially ok in HTML).
TEST:
1. Send by email a report containing a subject with accented characters
and resultset with accented characters. For example:
./runreport.pl --subject="éèà" --to=me at home.org 1
./runreport.pl --format=html --subject="éèà" --to=me at home.org 1
The first email contains badly encoded subject & message. The second email
contains badly encoded subject, but correct message.
2. Apply the patch
3. Repeat 1 => No more strange characters.
Signed-off-by: Liz Rea <liz at catalyst.net.nz>
Characters are correctly encoded now, thanks for that good spot.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 4f8476e09c2de223f73692521b8f8e533ef8400f
Author: Liz Rea <liz at catalyst.net.nz>
Date: Wed Nov 4 15:33:40 2015 +1300
Bug 15120: runreport.pl cronjob doesn't allow custom subjects anymore
To test, well do something like
misc/cronjobs/runreport.pl --subject="My fancy subject!" --to=you at youraddress.com 1
where 1 is the number of your favourite saved report.
Success is your email arrives with the subject "My fancy subject!" Failure is
(with --subject defined) you get either the description of the report, or "Koha
saved report" as the subject. This is success without --subject defined.
Signed-off-by: Frederic Demians <f.demians at tamil.fr>
Bug repeatable and fixed by this patch.
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit b11eb03a4c9674f4f4dedadaa8790257e30fb1d0
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Jul 16 17:48:14 2015 +0200
Bug 14542: Transliterate rule for all single quote forms
Single quotes in common language (not in programming) are usually ', but
there is also the form known as ’ in HTML. See
https://fr.wikipedia.org/wiki/Apostrophe_%28typographie%29
This bug proposes to transliterate all forms into a space.
Test plan :
(I'll use the code ’ instead of the unicode character)
- Without the patch
- Create a record with title : L’avion d’argile
- Index this record
- Search for "L’avion d’argile" => You find the record
- Search for "L'avion d'argile" => You do not find the record
- Apply patch
- Search for "L’avion d’argile" => You find the record
- Search for "L'avion d'argile" => You find the record
- Search for "L avion d argile" => You find the record
Signed-off-by: Frederic Demians <f.demians at tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit f2c6bd2c616383018cfd098214c207efa90aa5ef
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Nov 13 16:49:53 2015 +0000
Bug 14544: Fix regression on sending an email from staff
The shelfnumber was not filled and result in a software error
Can't call method "get_contents" on an undefined value at
/home/koha/src/virtualshelves/sendshelf.pl line 74.
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Whith patch mail is sent.
No errors
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
-----------------------------------------------------------------------
Summary of changes:
etc/zebradb/etc/words-icu.xml | 2 +
.../prog/en/includes/virtualshelves-toolbar.inc | 2 +-
misc/cronjobs/runreport.pl | 42 ++++++++------------
t/db_dependent/Reports_Guided.t | 5 ++-
4 files changed, 23 insertions(+), 28 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list