[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.05-29-gd4870cb

Git repo owner gitmaster at git.koha-community.org
Sun Nov 29 21:46:43 CET 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  d4870cbf99c7f7633314c5f6d2411a40e9898a4a (commit)
      from  9dace4e21e33f1b92e1e2db7ef72435539895794 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d4870cbf99c7f7633314c5f6d2411a40e9898a4a
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Nov 5 13:24:51 2015 +0000

    Bug 14743: addorder.pl redirect problems under plack behind apache 2.4.10
    
    I can't quite figure this out. When I run CGI version of Koha, I see following response (recorded using tcpdump):
    
    HTTP/1.1 302 Found
    Date: Thu, 27 Aug 2015 13:28:41 GMT
    Server: Apache/2.4.10 (Debian)
    Location: /cgi-bin/koha/acqui/basket.pl?basketno=5610
    Vary: User-Agent
    Content-Length: 0
    Keep-Alive: timeout=5, max=98
    Connection: Keep-Alive
    Content-Type: text/x-perl
    
    However, when running behind apache 2.4.10 on Debian wheezy I see chunked response:
    
    HTTP/1.1 302 Found
    Date: Thu, 27 Aug 2015 13:21:28 GMT
    Server: Apache/2.4.10 (Debian)
    Vary: User-Agent
    Keep-Alive: timeout=5, max=100
    Connection: Keep-Alive
    Transfer-Encoding: chunked
    Content-Type: text/x-perl
    
    60
    Transfer-Encoding: chunked
    Date: Thu, 27 Aug 2015 13:21:28 GMT
    Connection: keep-alive
    
    0
    
    0
    
    This response doesn't work in firefox (where it reports page not found) nor in chrome (where it returns lines below 60 on screen).
    
    In the template the hidden input 'basketno' is listed twice. What the cgi script reads in the parameter, what is does is concat the values of the multiple basketno instances together createing what is likely an invalid basketno. For reasons beyond my understanding this is what triggers this error!
    
    Test Plan:
    1) Using plack, add an order to a basket from an external source
    2) Note the error
    3) Apply this patch
    4) Add an order to a basket from an external source
    5) Note you get no error!
    
    Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
    
    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    (cherry picked from commit 237c1483ddf22babb4f1bfd4dfa3e7120c2d8cd9)

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt |    1 -
 1 file changed, 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list