[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.05-54-gfc5804e

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  fc5804e6f1c175e40708b0a7604c4bf7ba5344bd (commit)
       via  c87520d90a99c06a7f6194643ead55c1ebd3a867 (commit)
      from  c9d030f75f338fea183895010e8787ae1fe48c67 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fc5804e6f1c175e40708b0a7604c4bf7ba5344bd
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Mon Mar 2 06:06:58 2015 -0800

    Bug 13411: (QA followup) Add logging
    
    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    (cherry picked from commit feafa273e443e56021959153e91bd999a68daf29)
    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>

commit c87520d90a99c06a7f6194643ead55c1ebd3a867
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date:   Thu Aug 27 10:56:22 2015 -0400

    Bug 13411: Koha's SIP server returns not ok for checking in items that are not checked out
    
    If an item is not checked out when a checkin via SIP2 is attempted,
    Koha's SIP server sends back an "ok" of 0, and the AF message "Item
    not checked out". I am not entirely sure this is good and correct
    behavior by the SIP2 protocol.
    
    In particular, this will cause SIP2 book sorting devices to fail on
    all items that are not checked out, causing them all to be put into
    the "special handling" been that should be reserved for things like
    items checked in at the wrong library and items on hold.
    
    Test Plan:
    1) Apply the patch for bug 13159 so you can use the new enhanced
       SIP2 command line emulator
    2) Use a command similar to the following to check in an item:
       sip_cli_emulator.pl -a localhost -su <sip user> -sp <sip password> -l <instituation id> --item <barcode> -m checkin
    3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out
    4) Apply this patch
    5) Restart the SIP server
    6) Repeat steps 2-3, note that nothing has changed
    7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using.
    8) Restart the SIP server
    9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do not recieve the item not checked out message.
    
    Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no>
    
    Signed-off-by: Brendan A Gallagher <brendan at bywatersolutions.com>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    (cherry picked from commit 181d3aa56de8377c67247db26932c4e5a7cb83d9)
    Signed-off-by: Frédéric Demians <f.demians at tamil.fr>

-----------------------------------------------------------------------

Summary of changes:
 C4/SIP/ILS.pm         |   45 ++++++++++++++++++++++++++-------------------
 C4/SIP/Sip/MsgType.pm |    2 +-
 etc/SIPconfig.xml     |    2 +-
 3 files changed, 28 insertions(+), 21 deletions(-)


hooks/post-receive
-- 
main Koha release repository