From gitmaster at git.koha-community.org Thu Oct 1 00:36:54 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 30 Sep 2015 22:36:54 +0000 Subject: [koha-commits] main Koha release repository annotated tag v3.18.11 created. v3.18.11 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The annotated tag, v3.18.11 has been created at 01a14b49dc4fcf701e6985ea8a672a0cc3a89965 (tag) tagging 743095cc829e26044fbb12b8a2400a3754691abd (commit) replaces v3.18.10 tagged by Liz Rea on Thu Oct 1 11:34:02 2015 +1300 - Log ----------------------------------------------------------------- Koha release 3.18.11 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAABAgAGBQJWDGNaAAoJEBuNTiU1Z9kHp2cQAIS3H1i85eNlTBfwUqSQ8DcI d7kTARXUrL0xVDTp37Xx07kp5tDdI5WRWWMKwXnvOuvWmNL224hjTxW+XojIudKj F5EMo2Ft1I8zCjV7TLyd2rJewD4LxNaySOm4niq5fJAIaolbOufh/e0R1pNDQAQr Lixc0M6RgM5P19NhUzcXjWumxzhXVNOjbGjfgW33hl07k6yw7j2iiE5HNLchL4pm TpFZpNgDm/cbbfPQUr/FDSK0TMi8i5BcEPDk68tnFaOOnuAbInJM8WQEDRuCO9/0 zx8yzLUghw7+8uMa8oOsm5lbdbUS0k5F3DcapzWkwlPYRPx0kkrdTjT0sTCzIcBi 397N9/s/bFUmwL4u0vd4dm4c+RmgORDBM0euogbZJAF8UMD2OrzYrL8LjSZ69TZg KO9mzPLkgtyMFEPDWzzmv4ajjUPw2STEOpR6DRp5EiuVJYWJEBq8kzAgKRvIKkNS betIg571z467yOFH9pm4IsoEd9b2Bd0NHhGqkByZ+JafBpPcbuCTmkRZ/Oz5wyEh QV5MkwqgD8nj7P+wbjKvL+VzAErmz2sbhnoLbO0sk+q7BVKHSaL2xxKyauVfIj5o uD4tSTf9uCD71JrEZvQbblKhNGGW1v8D7qtyZP8OLozKstTwF+HZzYLCrU2N3opH AFNg9ff2d5Aos7uU1Vc1 =sbaO -----END PGP SIGNATURE----- Aleisha (2): Bug 14634: Warns when placing hold on record with no items Bug 14585: Fixing up online help on main page Benjamin Rokseth (1): Bug 14361: koha-restart-zebra fails and probably breaks upgrade Bernardo Gonzalez Kriegel (1): Bug 14245: Problems with RIS export in unimarc Blou (1): Bug 14726: Checkout summary doesn't show title Fridolin Somers (1): Bug 14721: OAI-PMH must return error when no results Fr?d?rick (1): Bug 11880: Select the barcode index by default then searching for label items. Genevieve Plantin (1): Bug 13781: Fix missing heading columns for relative's checkouts table in check out patron page Jonathan Druart (25): Bug 14205: Deleting an Item/Record does not remove link to course reserve Bug 11880: Select what has been selected before Bug 14696: useless use of String::Random in catalogue/search.pl Bug 13943: Prevent the deletion of items if the user cancels Bug 12885: Fix if url contains +*... and HTML5 Media is enabled Bug 12965: Prevent to erase an existing item type Bug 14584: Encoding broken with system preferences Bug 11247: Improve tests Bug 14354: Prevent edition of items from other branches if IndependentBranches is on Bug 11273: FIX barcode generation in acquisition if hbyymmincr Bug 12525: Prevent adding several patron lists with the same name Bug 14470: Do not allow renew for on-site checkouts Bug 14655: Add a warning if the checkin will fail Bug 8723: Cover the existing behavior Bug 8723: Update the reserves table for item-level holds Bug 8723: Update hold_fill_targets, tmp_holdsqueue and linktracker tables Bug 14813: Fix encoding issues on editing help pages Bug 6756: Fix bad behaviors if AnonymousPatron is not defined Bug 6756: Add info messages Bug 7634: Prevent permanent_location to be set to NULL if not defined Bug 10005: Inventory - Add an option to not check in items Bug 14298: Add the new 'self_checkout' permissions Bug 14298: Use the new permission in the sco scripts Bug 14298: Add warning to the about page if the sco user does not have correct permissions Bug 14298: Add perms for other languages Joonas Kylm?l? (3): Bug 14703: Holidays description shows \r\n for every new line Bug 14579: 'You are not logged in' should link to log in page Bug 14683: Unable to clear SMS number Julian Maurice (1): Bug 14766: unimarc_field_4XX: escape ', ", \n, \r Katrin Fischer (1): Bug 14782: Add tests Kyle M Hall (3): Bug 12632: Hold limits ignored for record level holds with item level itemtypes Bug 14760: Disabled courses display in the course reserves list for items Bug 14640: 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out. Lari Taskula (1): Bug 14621: Messaging preferences table needs to be sorted Liz Rea (7): DBRev 3.18.10.01 Bug 14205: RM followup - DBIx updates Catching up dbix updates Bug 14298: Update database Bumping version number for release 3.18.11 Release notes Revert "Bug 14813: Fix encoding issues on editing help pages" Marc V?ron (1): Bug 14782: Add possibility to search patrons using the username (userid) Marcel de Rooy (3): Bug 11247: Add a simple unit test for TransformHtmlToXml Bug 14683: [QA Follow-up] Mixup between mobile and smsalertnumber Bug 14683: [QA Follow-up] Similar change for staff Paul Poulain (1): Bug 14766: Complete cataloguing plugin unimarc_field_4XX Srdjan (1): Bug 11247: Fix calls of TransformHtmlToXml Tomas Cohen Arazi (1): Bug 14245: (QA followup) already global ----------------------------------------------------------------------- hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Thu Oct 1 01:52:33 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Wed, 30 Sep 2015 23:52:33 +0000 Subject: [koha-commits] main Koha release repository branch 3.18.x updated. v3.18.11 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.18.x has been updated via 743095cc829e26044fbb12b8a2400a3754691abd (commit) via 2ff022ec8005d8342770aca383c579296c88f248 (commit) via 368e04d979a2263673539cc47312b03571932a52 (commit) via 04000eacbe1f42acec3be27357dbb8141f098aa3 (commit) via 23b7e06bf9e296eff70b09d593255263c1562c0c (commit) via 39e5ecc7ac001e9cad79886af642598a6100787c (commit) via 03c95d38e30de356bb4b61f3e3c45245507a7fa7 (commit) via 255d4023cda92ffcb2a9131434566d94c550bf0f (commit) via 1900642549f2ecac7abe3a5838ed4d0ebfd4d3da (commit) via 14f8a91733bf8726b5a0411babe7e21886a73441 (commit) via c7efb1619a81d71d2a496c489b96266890e338df (commit) via 723cac987c917341426617a72908b3448c9a51d1 (commit) via 4da312f724a26a74a8bea25fe302610ec8e695f1 (commit) via 4fd13caf84b18b5f0a025f8507f0aa159703808c (commit) via f1a8202ccd27ac1892ab35d30f0f2dc643ccf9bd (commit) via ea3ec5ed3d7d6b01c6e793ee66c02d4e0dab0772 (commit) via 2d583678aa86b9f71d523dd0c88fac5586217837 (commit) via 16ebbebe4f543990b60b5771488f35b8b619debe (commit) via 2ed639cfb4a2bb57888fcbf3cd678d36d6a5325c (commit) via 0c55f4487a0058c2c79520683b28206087d20581 (commit) via 5c014d2f7f2f9d2b64d0467adaaeb4a7b54d27d3 (commit) via ef217f48a43c292a944a0c6c721bc33937b6f4bf (commit) via aca61bd47561349750ec17773b62a1ea345901a8 (commit) from 9d7e88e32582c9561d20d5931a9864ccbc381b7f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 743095cc829e26044fbb12b8a2400a3754691abd Author: Liz Rea Date: Thu Oct 1 11:32:03 2015 +1300 Revert "Bug 14813: Fix encoding issues on editing help pages" This reverts commit 16ebbebe4f543990b60b5771488f35b8b619debe. Not actually applicable commit 2ff022ec8005d8342770aca383c579296c88f248 Author: Liz Rea Date: Wed Sep 23 13:29:06 2015 +1200 3.18.11 Release notes commit 368e04d979a2263673539cc47312b03571932a52 Author: Liz Rea Date: Wed Sep 23 13:20:53 2015 +1200 Bumping version number for release commit 04000eacbe1f42acec3be27357dbb8141f098aa3 Author: Liz Rea Date: Wed Sep 23 13:19:17 2015 +1200 Bug 14298: Update database commit 23b7e06bf9e296eff70b09d593255263c1562c0c Author: Jonathan Druart Date: Mon Sep 14 10:50:12 2015 +0100 Bug 14298: Add perms for other languages Signed-off-by: Katrin Fischer (cherry picked from commit cf098649a80ee9ee5fe7f505828b0eec56bef93d) Signed-off-by: Liz Rea commit 39e5ecc7ac001e9cad79886af642598a6100787c Author: Jonathan Druart Date: Wed Sep 2 16:30:15 2015 +0100 Bug 14298: Add warning to the about page if the sco user does not have correct permissions Signed-off-by: Chris Cormack Note: Made a little change, changed He should have, to They should have Signed-off-by: Katrin Fischer (cherry picked from commit f2663af7d1ead6efd7ccc121492a9f264e08b9fc) Signed-off-by: Liz Rea commit 03c95d38e30de356bb4b61f3e3c45245507a7fa7 Author: Jonathan Druart Date: Wed Sep 2 16:10:45 2015 +0100 Bug 14298: Use the new permission in the sco scripts Signed-off-by: Chris Cormack Note without this patch, you won't be able to access the SCO side. So don't panic if you cant use SCO with just the first patch Signed-off-by: Katrin Fischer (cherry picked from commit 047f0a486b8db459b0be20e052b9b3cdbf37a584) Signed-off-by: Liz Rea commit 255d4023cda92ffcb2a9131434566d94c550bf0f Author: Jonathan Druart Date: Wed Sep 2 16:09:35 2015 +0100 Bug 14298: Add the new 'self_checkout' permissions There is a security issue in the self checkout module. The user used to check items out must have the circulate => circulate_remaining_permissions permissions. So even if a user does not have a login/password or a barcode he cans access to the circulation module of the intranet. Imagine if the sco patron used is a superlibrarian... This patch set will change the behavior and adds a new permission to access to the sco module (circulate => self_checkout). This permission should be the only one defined for this patron. IMPORTANT NOTE: Hopefully, this only works if both interfaces use the same domains (but different ports). Test plan: 0/ Does not apply this patch set 1/ Create a patron with the circulate => circulate_remaining_permissions and some others. Note his userid/pwd (later 'sco/sco'). Turn on WebBasedSelfCheck and AutoSelfCheckAllowed Fill the AutoSelfCheckID and AutoSelfCheckPass wich 'sco' and 'sco' 2/ Log you out from the OPAC and the intranet 3/ Go on the sco page 4/ Note that your are automatically logged in 5/ Go on the circulation module on the intranet side 6/ Oops 7/ Apply this patch 8/ Execute the updatedatabase 9/ Note that the sco user only has the new permission circulate => self_checkout, others have been removed 10/ Try to reproduce the issue, it should not access anything on the intranet side 11/ Confirm that there is no regression in the sco module Signed-off-by: Chris Cormack Works well no regressions, changes the permissions appropriately. Signed-off-by: Katrin Fischer (cherry picked from commit 08c7606c36f4383b402480ddab8a01dfa9acdccf) Signed-off-by: Liz Rea commit 1900642549f2ecac7abe3a5838ed4d0ebfd4d3da Author: Aleisha Date: Wed Jul 22 01:37:30 2015 +0000 Bug 14585: Fixing up online help on main page To test: 1) Go to home page of staff client and click the Help 2) Notice: 'you should now 'got to' Koha' 'settings found in 'a'dministration.' (should be capitalized) 'Once that user is set you should use that user to log in rather than the root user set up as part of installation.' (could be worded better) 3) Apply patch, close Help, reload page, reopen Help 4) Notice: 'got to' --> 'go to' 'administration' --> 'Administration' 'Once that user is set you should use that user to log in rather than the root user set up as part of installation.' Signed-off-by: Joonas Kylm?l? Signed-off-by: Tomas Cohen Arazi (cherry picked from commit d810fd1094541ee4c95289df3f18bf765047335b) Signed-off-by: Chris Cormack (cherry picked from commit 14e3841f5104480842eba9848d9bf662647b2413) Signed-off-by: Liz Rea commit 14f8a91733bf8726b5a0411babe7e21886a73441 Author: Genevieve Plantin Date: Tue Sep 8 13:58:10 2015 -0400 Bug 13781: Fix missing heading columns for relative's checkouts table in check out patron page Theres was two missing heading columns Location and Fines in the Check out section of a Patron Tested both patches together. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit bcb6e9ea39dce065e8c7ff80b4d1b7b49e1735f4) Signed-off-by: Chris Cormack (cherry picked from commit b73c432887734ae2bd8de87b0c0d6fec1f6a1d4c) Signed-off-by: Liz Rea commit c7efb1619a81d71d2a496c489b96266890e338df Author: Tomas Cohen Arazi Date: Wed Sep 16 11:51:12 2015 -0300 Bug 14245: (QA followup) already global The original patch correctly unmasks the global variable (by removing the 'my' on the marc2ris function, but wrongly introduces a new global variable. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 7349777f14b8d4c11f74da2098568a6966800e5a) Signed-off-by: Chris Cormack (cherry picked from commit 2d4e38a25774e9a96d00ad69a46337f38fd40e0a) Signed-off-by: Liz Rea commit 723cac987c917341426617a72908b3448c9a51d1 Author: Bernardo Gonzalez Kriegel Date: Thu May 21 14:00:05 2015 -0300 Bug 14245: Problems with RIS export in unimarc Variable $itype is used an all C4/Ris.pm to switch between marc falvors, but is local and not passed along as argument. As a quick solution, is defined as global To test: 1) On UNIMARC setup, export a record as RIS, check that author (and other fields) are displayed incorrectly 2) Apply the patch 3) Export again, improved results 4) Run t/Ris.t There are other problems in this script, needs maintenance (e.g. no Modern::Perl friendly) Signed-off-by: Victor do Ros?rio Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit e15621fee2693059cce67882691ad8eae9a5c9b7) Signed-off-by: Chris Cormack (cherry picked from commit 4c7bd247ef456190199f941f5a4479e948341d70) Signed-off-by: Liz Rea commit 4da312f724a26a74a8bea25fe302610ec8e695f1 Author: Kyle M Hall Date: Tue Aug 25 10:35:28 2015 -0400 Bug 14640: 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out. This bug is dealing with the situation where an item is checked out to a patron that is not the next in line hold-wise for an item. In this case, Koha will warn the librarian that there are holds on the item and show the first person in line. Again, I want to stress that this is the case where the item *is not waiting* for a patron. The hold for the patron listed will just have a priority of 1. The only situation where the "Cancel hold" checkbox will function is when the priority 1 hold is an item level hold. This is due to the fact that CancelReserve is being passed the trio of biblionumber, borrowernumber, and itemnumber rather than the singular reserve_id. 1) place biblio level hold on a book to borrower A. 2) check out an item of the book to borrower B. 3) When confirming checkout, check the 'Cancel hold' check-box, and click the "Yes, check out" button. 4) Note the hold was not canceled 5) Apply this patch 6) Repeat steps 1 through 3 7) Note the hold was indeed canceled Signed-off-by: Joonas Kylm?l? Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit a37b3bb7f76b5ddea7400f5268c592c0cc578a8c) Signed-off-by: Chris Cormack (cherry picked from commit b565d3a62a0ae7980ac58f653182e0e6c0ccf914) Signed-off-by: Liz Rea commit 4fd13caf84b18b5f0a025f8507f0aa159703808c Author: Jonathan Druart Date: Tue Jul 14 15:02:42 2015 +0100 Bug 10005: Inventory - Add an option to not check in items The inventory tools automatically check in items, this patch adds it as an option. Test plan: 1/ Check an item out, fill a file with its barcode, and use this file in the inventory tools. 2/ Check the new checkbox and confirm that the item is not checked in 3/ Repeat again and don't check it, the behavior should be the same as before this patch. Signed-off-by: Jason Robb Signed-off-by: Katrin Fischer Added a missing . Patch works as expected. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit e5f604378a45d62e8b454cd390abb18b34ef53f8) Signed-off-by: Chris Cormack (cherry picked from commit 1b03fc78a1ac9f84464752c5f35e0ff54ffbbb14) Signed-off-by: Liz Rea commit f1a8202ccd27ac1892ab35d30f0f2dc643ccf9bd Author: Jonathan Druart Date: Wed Sep 2 14:28:52 2015 +0100 Bug 7634: Prevent permanent_location to be set to NULL if not defined The permanent_location is correctly filled when an item is added from the cataloguing module (routine set_item_default_location from cataloguing/additem.pl). But when records are imported, this filled is not managed. It's only on editing (_do_column_fixes_for_mod called from ModItem). This patch set the permanent_location item fields to the location value for all items created, even the imported ones. Test plan: 0/ Do not apply this patch 1/ Import a record with items using the "Stage MARC for import" tool 2/ Check the values for the permanent_location in the items table. They are set to NULL 3/ Apply this patch 4/ Repeat 2 and confirm that now the permanent_location values are set to the location values. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit a2ca59efb877945f7b2ebc92e7643d4cdaf9d4e1) Signed-off-by: Chris Cormack (cherry picked from commit 3d74a820b23b7b912dea969f88a865bc714be50c) Signed-off-by: Liz Rea commit ea3ec5ed3d7d6b01c6e793ee66c02d4e0dab0772 Author: Jonathan Druart Date: Tue Jul 14 11:38:41 2015 +0100 Bug 6756: Add info messages NOTE: Before patch "./misc/cronjobs/batch_anonymise.pl --help" had no message, and neither did the anonymizing tool in the staff client. After the patch, both had informative messages. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 1acddd0f1b41e9e5f75b75d9d101c8b0879c00c5) Signed-off-by: Chris Cormack (cherry picked from commit 715a7bf4f5ff7c05e310a5e98f7cdc177afd3e8f) Signed-off-by: Liz Rea commit 2d583678aa86b9f71d523dd0c88fac5586217837 Author: Jonathan Druart Date: Tue Jul 14 11:30:51 2015 +0100 Bug 6756: Fix bad behaviors if AnonymousPatron is not defined There are at least 2 wrong behaviors if the AnonymousPatron pref is not defined (0 or empty string). 1/ If you use the clean borrower tools, you will get a successful message when the nothing happened (the history has not been anonymised). 2/ At the OPAC, if a patron ask for delete his reading history, he will get an error message "The deletion of your reading history failed, because there is a problem with the configuration of this feature. Please help to fix the system by informing your libr ary of this error". IMO this should not happen, the history should be anonymised. With this patch, the old_issues.borrowernumber field will be set to NULL if the AnonymousPatron pref if not defined. Test plan: 1/ Fill the pref with "" or 0 2/ At the OPAC, go on the privacy tab and click on the "Immedia deletion" button. You should get a green and friendly message. Confirm that the history has been anonymised. 3/ Use the "Batch patron anonymization" tools (tools/cleanborrowers.pl) to anonymize the checkout history. Confirm that a) it works and b) you get a message. Try again with AnonymousPatron set to a valid patron. You should not see any changes with the current behaviors. NOTE: This patch tweaks C4/Circulation.pm and provides tests. applying just this, and running prove success. Reverting just C4/Circulation.pm fails, as expected. Tested OPAC stuff with both patches applied. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 224b1c7976567511f1d6715784274169e006edcf) Signed-off-by: Chris Cormack (cherry picked from commit 085272aec0af72e3178f2c6e6ae53f6ea1d48bf1) Signed-off-by: Liz Rea commit 16ebbebe4f543990b60b5771488f35b8b619debe Author: Jonathan Druart Date: Mon Sep 14 10:28:01 2015 +0100 Bug 14813: Fix encoding issues on editing help pages It has been introduced by bug 11944. Test plan: 1/ Install and set the fr-FR language (or ar-Arab). 2/ Go on the help page and edit it. 3/ The textarea should not contain encoding issues with this patch. Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit d671b8661cf02d8b039eb5230ab732fd1fde2301) Signed-off-by: Chris Cormack Conflicts: edithelp.pl commit 2ed639cfb4a2bb57888fcbf3cd678d36d6a5325c Author: Jonathan Druart Date: Fri Jul 10 15:18:48 2015 +0100 Bug 8723: Update hold_fill_targets, tmp_holdsqueue and linktracker tables Same as previous patch for 3 other tables. Test plan: Same as before but the hold should exist to the 3 tables before the move. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit c7a6745bc0e0241e5f39a12e2ff4e17678288b14) Signed-off-by: Chris Cormack (cherry picked from commit 74e6691cf84e51b20832b45cf7520aec85788771) Signed-off-by: Liz Rea commit 0c55f4487a0058c2c79520683b28206087d20581 Author: Jonathan Druart Date: Fri Jul 10 15:04:55 2015 +0100 Bug 8723: Update the reserves table for item-level holds If an item is moved from a biblio to another, the holds should be updated too. See discussion on the bug report for more information. Test plan: 1/ Place a item-level hold on biblio1 2/ Move the item to biblio2 3/ Confirm that the hold still exists and point to the biblio2 This patch should not change the existing behavior for bib-level holds. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 9f8f33e351e1ae5810441a0c9ff7226aafb63c8b) Signed-off-by: Chris Cormack (cherry picked from commit 0a0f8b09d947aabef21c6cb79e796786ce3be7d5) Signed-off-by: Liz Rea commit 5c014d2f7f2f9d2b64d0467adaaeb4a7b54d27d3 Author: Jonathan Druart Date: Fri Jul 10 14:15:42 2015 +0100 Bug 8723: Cover the existing behavior This patch cover the MoveItemFromBiblio subroutine Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit cb4ce631c316a41ac47a17bfdaa4e5591e0e37df) Signed-off-by: Chris Cormack (cherry picked from commit 3caa3703c272be52b6cf161a086271ca9be3eb01) Signed-off-by: Liz Rea commit ef217f48a43c292a944a0c6c721bc33937b6f4bf Author: Marc V?ron Date: Sat Sep 5 16:41:58 2015 +0200 Bug 14782: Add possibility to search patrons using the username (userid) This patch makes it possible to search for users using the username (userid / login name). To test: - Apply patch - Do searches from Home > Patrons - Search after a full username or parts of a username with Search fields = Standard and Search fields = Userid - Perform the searches from the top bar (expand with [+]) and from the "Filters" part at the left - Make sure that other searches behave as before Signed-off-by: Joonas Kylm?l? Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit a71cc14a52589f45bc30dad81b8c7fc0ac35d9fc) Signed-off-by: Chris Cormack (cherry picked from commit 04319600c32fc3145cfd2457258e97174e4f2cd6) Signed-off-by: Liz Rea commit aca61bd47561349750ec17773b62a1ea345901a8 Author: Katrin Fischer Date: Sun Sep 13 18:06:46 2015 +0200 Bug 14782: Add tests Run: perl t/db_dependent/Utils/Datatables_Members.t Signed-off-by: Tomas Cohen Arazi (cherry picked from commit f704fbebd86e0034cf285b2dd29c0d85cb2086a2) Signed-off-by: Chris Cormack (cherry picked from commit b609ddc5dbb02b631f776e9bc664d88e7c1beeae) Signed-off-by: Liz Rea ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 5 +- C4/Items.pm | 27 +- C4/Reserves.pm | 6 +- C4/Ris.pm | 6 +- C4/Utils/DataTables/Members.pm | 3 +- about.pl | 28 ++ .../data/mysql/de-DE/mandatory/userpermissions.sql | 1 + .../data/mysql/en/mandatory/userpermissions.sql | 1 + .../data/mysql/es-ES/mandatory/userpermissions.sql | 1 + .../mysql/fr-FR/1-Obligatoire/userpermissions.sql | 1 + .../data/mysql/it-IT/necessari/userpermissions.sql | 1 + .../mysql/nb-NO/1-Obligatorisk/userpermissions.sql | 1 + .../data/mysql/pl-PL/mandatory/userpermissions.sql | 1 + .../ru-RU/mandatory/permissions_and_user_flags.sql | 1 + .../uk-UA/mandatory/permissions_and_user_flags.sql | 1 + installer/data/mysql/updatedatabase.pl | 43 +++ .../prog/en/includes/patron-search.inc | 5 + koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 14 +- .../prog/en/modules/circ/circulation.tt | 2 + .../intranet-tmpl/prog/en/modules/help/mainpage.tt | 6 +- .../prog/en/modules/members/member.tt | 5 + .../prog/en/modules/tools/cleanborrowers.tt | 4 + .../prog/en/modules/tools/inventory.tt | 4 + kohaversion.pl | 2 +- misc/cronjobs/batch_anonymise.pl | 1 + misc/release_notes/release_notes_3_18_11.html | 352 ++++++++++++++++++++ ...notes_3_18_10.txt => release_notes_3_18_11.txt} | 208 ++++++++---- opac/sco/help.pl | 2 +- opac/sco/sco-main.pl | 3 +- opac/sco/sco-patron-image.pl | 2 +- svc/members/search | 2 +- t/db_dependent/Circulation/AnonymiseIssueHistory.t | 138 ++++++++ t/db_dependent/Items/MoveItemFromBiblio.t | 84 +++++ t/db_dependent/Utils/Datatables_Members.t | 25 +- tools/inventory.pl | 19 +- 35 files changed, 899 insertions(+), 106 deletions(-) create mode 100644 misc/release_notes/release_notes_3_18_11.html copy misc/release_notes/{release_notes_3_18_10.txt => release_notes_3_18_11.txt} (52%) create mode 100644 t/db_dependent/Circulation/AnonymiseIssueHistory.t create mode 100644 t/db_dependent/Items/MoveItemFromBiblio.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 2 04:39:58 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Oct 2015 02:39:58 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.20.00-657-g49a09f6 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 49a09f6db2e10596deae056fea9e54bd8f5cd046 (commit) from 3007208c70274a2bab326bc3ccf31bced32dab2b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 49a09f6db2e10596deae056fea9e54bd8f5cd046 Author: Robin Sheat Date: Fri Oct 2 13:31:48 2015 +1300 Bug 14938: fix dependencies Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: debian/control | 2 -- 1 file changed, 2 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 2 10:54:18 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Oct 2015 08:54:18 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.14-25-ga4fcb6a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via a4fcb6a535907acf68e58ab8de43ecb6b6c9942d (commit) via 3f7deae568227027fb3664b0109af2ce7b8d6c16 (commit) via 37f0bddb17ed53e7049c295c6e2b24c3392c888c (commit) via 53e060308d163fed9411c3d4a4b5027aba6832bc (commit) via 20e74039a306dfb279b551f704b46708c95a96ec (commit) via 3e7564e5938545d9ac3997b3f25d18ec975d2db3 (commit) via f8472ef26cf352e5ee9df2420d78fa2dca3db074 (commit) via 499bb94087c67f0a9a123c9c756e847cc6818bfd (commit) via 56054e34a6d1cea5f57817d699ac1fbb696fcb44 (commit) via 1180efe11e93d1e3004ec29e0962ac83ed54e461 (commit) via efa0ff294398f065f923309b3eba4783205b9c29 (commit) via beb77b06bd3867eca1d867e1fca0e62a629560a1 (commit) via 821aa63e4126331ad36164ac98f5f4093bbb72ed (commit) via 46559c51e7de4bfaa77eb5878d82c7b85707bfbd (commit) via 1016ba0f75d1fca4dcd8dda1f73311f1cb9237ef (commit) via f4ba93afd2241bf7689199674c3596135996971f (commit) via 087b6a43d9af1179485e7745bbf7c905f71d2a8f (commit) via 95fc0a6b2f27d4c584a5f7a4b127fedd2cd82124 (commit) via 6bb191aab575dbd7b6a03d5c9da1fa547a03acf3 (commit) via 643af3350915f375f1e60bfe5935d0827ef35b8c (commit) via 62c341301f3745b48bdee6363e258819e60b29e5 (commit) via f365143c184dfd96fb4bd98dd1873ac3feb26794 (commit) via 2e87354a74948e494965ee21e3ab6160c6467b2b (commit) via 7ef68ea59d1f30529645bb24fbd73082354dd833 (commit) via 22fa695d598a8f3345a883d15079f1021cbc0161 (commit) from 6edb2c2ab6147a0d4e60c600c6d9b37572736637 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a4fcb6a535907acf68e58ab8de43ecb6b6c9942d Author: Mason James Date: Sat Jul 25 20:51:52 2015 +1200 Bug 14602 - Fix failing t/Creators.t test to test.. 1/ run t/Creators.t test from git repo, get a FAIL 2/ apply patch 3/ repeat step 1, get a PASS mason at xen1:~/g/k/3.16.x$ sudo koha-shell -c 'export PERL5LIB=/home/mason/g/k/3.16.x ; cd /home/mason/g/k/3.16.x ; prove -v t/Creators.t' k316x1 t/Creators.t .. 1..16 ok 1 - use C4::Creators; ok 2 - use C4::Creators::PDF; ok 3 - testing new() works ok 4 - testing pdf file created ok 5 - testing Add() works ok 6 - testing Bookmark() works ok 7 - testing Compress() works ok 8 - testing Font() works ok 9 - testing FontSize() is set to 12 by default ok 10 - testing FontSize() can be set to a different value ok 11 - testing Page() works ok 12 - testing StrWidth() returns correct point width ok 13 - testing Text() writes from a given x-value ok 14 - testing Text() writes to the correct x-value ok 15 - testing End() works ok 16 - test file /tmp/4YjPQDExeS created OK ok All tests successful. Files=1, Tests=16, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.48 cusr 0.05 csys = 0.57 CPU) Result: PASS Signed-off-by: Liz Rea Signed-off-by: Marcel de Rooy Signed-off-by: Mason James commit 3f7deae568227027fb3664b0109af2ce7b8d6c16 Author: Marcel de Rooy Date: Fri Jul 3 11:02:22 2015 +0200 Bug 14382: [QA Follow-up] Bad regex alarm The regex /|date>>/ will match much more than you like :) The unescaped pipe is bad, but you also need to remove the >> because the split a few lines above it removes them already. This allows you to recover from an error like this one, running another report with a string parameter: The given date (india%) does not match the date format (us) at Koha/DateUtils.pm line 144. Signed-off-by: Marcel de Rooy Amended for possible spaces around the word date. commit 37f0bddb17ed53e7049c295c6e2b24c3392c888c Author: Mark Tompsett Date: Wed Jun 24 12:13:46 2015 -0400 Bug 14382: Non-ISO Date parameters generate empty reports. The issue is that SQL expects ISO dates, but the user may wish to view dates according to the dateformat system preference. By detecting a date preference, the non-ISO dates can be converted to ISO dates before being stuffed back into the SQL query to be executed. TEST PLAN --------- 1) Add a report with date parameters. -- I used 'Holds placed in date range' from http://wiki.koha-community.org/wiki/SQL_Reports_Library 2) Set your dateformat to YYYY-MM-DD 3) Run the report -- Note the SQL reads "... BETWEEN '{date formatted in YYYY-MM-DD}'..." -- If there is supposed to be data, there is some. 4) Set your dateformat to MM/DD/YYYY 5) Run the report -- Note the SQL reads "... BETWEEN '{date formatted in MM/DD/YYYY}'..." -- If there is supposed to be data, there is none. 6) Apply patch 7) Repeat steps 2-5 -- The SQL will always read YYYY-MM-DD (ISO) format. -- The report will have data, if there is some. 8) koha qa test tools. Signed-off-by: Amit Gupta Signed-off-by: Marcel de Rooy Adding a QA follow-up. Signed-off-by: Mason James commit 53e060308d163fed9411c3d4a4b5027aba6832bc Author: Marcel de Rooy Date: Tue Sep 1 16:11:54 2015 +0200 Bug 14683: [QA Follow-up] Similar change for staff Script memberentry.pl contained a similar line. Solution is simpler here. Test plan: [1] Add, change or clear the sms number at staff side. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit bdf4894c507f4bac6b2b79c7ca3b7a556d246ed5) Signed-off-by: Chris Cormack (cherry picked from commit c323e07c0c7ec403af15e40da7d82b997cb3eefc) Signed-off-by: Liz Rea commit 20e74039a306dfb279b551f704b46708c95a96ec Author: Marcel de Rooy Date: Fri Aug 28 09:13:09 2015 +0200 Bug 14683: [QA Follow-up] Mixup between mobile and smsalertnumber This is an issue discussed on older reports already in the past. Column mobile in borrowers is actually 'Other phone', not necessary a mobile number. The name of the field is confusing. (Renaming it is outside the scope of this report.) The field that we are editing here is smsalertnumber. It should not be compared with mobile at all. What could be the side-effect of this correction? === First, the change is only relevant for libraries with pref SMSSendDriver enabled. In the past patrons editing their message preferences saw mobile (read: other phone) in their smsalertnumber field (if the latter was still empty). If they saved it, it was copied to smsalertnumber. This change does not affect these patrons. They just have the same number in two columns. No big deal. What if a patron does not yet have a smsalertnumber? In that case no sms is sent in Letters.pm. So no change in behavior. If he submits opac-messaging now, he will no longer copy his other phone to smsalert [we cannot assume that it was mobile anyway!]. If he enters a mobile number, it will be saved correctly in the right field. Conclusion: this change will not break things or hurt anyone. It only prevents unwanted copying other phone to smsalertnumber. Also modified the compare to prevent uninitialized warnings. And removed a commented warn. Test plan: [1] Add, edit or delete the SMS number on opac-messaging regardless of the value of Other Phone (in the badly named mobile field). Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 9b8d7168beb27342c4c483a0812e3a6789fabced) Signed-off-by: Chris Cormack (cherry picked from commit bc720464216eca9d5283596af23d2c2c926e7093) Signed-off-by: Liz Rea commit 3e7564e5938545d9ac3997b3f25d18ec975d2db3 Author: Joonas Kylm?l? Date: Wed Aug 19 11:42:50 2015 +0000 Bug 14683: Unable to clear SMS number Enables to clear SMS number. To test: 1. Go to opac-messaging.pl 2. Insert SMS number and submit 3. Clear SMS number and submit 4. Observe that the sms number did not change 5. Apply patch 6. Clear SMS number and submit 7. Observe that the sms number changes Sponsored-by: Vaara-kirjastot Signed-off-by: Marcel de Rooy Adding a follow-up. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 5b1c7e4c359e974e5aca801579db72b356741a0f) Signed-off-by: Chris Cormack (cherry picked from commit 227d7b950e682300a7697ada4f6837a950f098e6) Signed-off-by: Liz Rea commit f8472ef26cf352e5ee9df2420d78fa2dca3db074 Author: Lari Taskula Date: Thu Jul 30 18:34:49 2015 +0300 Bug 14621: Messaging preferences table needs to be sorted I have been working with messaging preferences and I noticed a weird issue in Firefox on Ubuntu. On messaging preferences page, the table is unsorted and the content in rows are generated randomly on every page refresh. When you select/deselect checkboxes and refresh the page (without posting the changes), Firefox will remember your choices. Now the issue is that when the table is unsorted and the rows keep changing on page refresh, Firefox has trouble remembering your choices. This makes it appear as if the checkboxes are magically changing values on each page refresh. Here is a patch that prevents this problem by sorting the messaging settings. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 46ac35f8e11c06a784ca309b0dc876aff9469edb) Signed-off-by: Chris Cormack (cherry picked from commit 6c44d1f4645b4c98577d6af23b05b9608b421253) Signed-off-by: Liz Rea commit 499bb94087c67f0a9a123c9c756e847cc6818bfd Author: Kyle M Hall Date: Mon Aug 31 09:36:02 2015 -0400 Bug 14760: Disabled courses display in the course reserves list for items If an item is on reserve for two courses but one of those courses is disabled, both courses are still listed on opac-detail.pl! Test Plan: 1) Enable course reserves 2) Create two courses 3) Place one item on reserve for both courses 4) Disable one of the two courses 5) View the record details for that record/item 6) You should see both courses listed in the course reserves column 7) Apply this patch 8) Reload the page 9) You should now only see the active course in the course reseves column Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 73e9dcb70fcf24dc87af7c5af6f38102206863ae) Signed-off-by: Chris Cormack (cherry picked from commit 9c31f1af9bb7b87dd794f40dd2bc7673b720c674) Signed-off-by: Liz Rea commit 56054e34a6d1cea5f57817d699ac1fbb696fcb44 Author: Fridolin Somers Date: Tue Aug 25 11:33:04 2015 +0200 Bug 14721: OAI-PMH must return error when no results When getting records from OAI-PMH, an error must be returned if there is no results. See : http://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions Test plan : - Enable OAI webservice - Perform a query that will return no results. ie : /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2099-12-30&until=2099-12-31 => Without patch you get a response with : => With patch you get a response with error code : No records match the given criteria - Check a good query returns still results - Same test with ListIdentifiers verb Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 64992a05ce87af7bf595c8d6f0b9d528887a2e44) Signed-off-by: Chris Cormack (cherry picked from commit 3d8e059513db08f2070e33ea1562d7cdd915797c) Signed-off-by: Liz Rea commit 1180efe11e93d1e3004ec29e0962ac83ed54e461 Author: Julian Maurice Date: Fri Sep 4 08:57:08 2015 +0200 Bug 14766: unimarc_field_4XX: escape ', ", \n, \r Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit abd71d017ea68f4209e41b34282e8fce8170e175) Signed-off-by: Chris Cormack (cherry picked from commit c7dfbfedd3d298753b4d96d5ce50363c2cfc65fc) Signed-off-by: Liz Rea commit efa0ff294398f065f923309b3eba4783205b9c29 Author: Paul Poulain Date: Wed Aug 26 10:54:30 2015 +0200 Bug 14766: Complete cataloguing plugin unimarc_field_4XX Add subfields l, n and o for better UNIMARC compliance Signed-off-by: Chris Cormack Note: I just did a code audit here, as I don't know enough about UNIMARC to know if the 4XX fields should have these subfields. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 503dd6036974b4208bd5cd60a87bb28599987f45) Signed-off-by: Chris Cormack (cherry picked from commit 84ee44110a934632ddcc8da59aa805c45a79786e) Signed-off-by: Liz Rea commit beb77b06bd3867eca1d867e1fca0e62a629560a1 Author: Jonathan Druart Date: Tue Jul 14 13:12:46 2015 +0100 Bug 11273: FIX barcode generation in acquisition if hbyymmincr When AutoBarcode is activated and you have set AcqCreateItem to 'on order' there is a Javascript error when you try to generate a barcode for the item: TypeError: document.f is undefined http://localhost:8080/intranet-tmpl/lib/jquery/jquery.js Line 11 Test plan: 0/ a. Set AutoBarcode to hbyymmincr b. Set AcqCreateItem to 'on ordering' c. Set the plugin barcode.pl to the barcode field for the default and the ACQ frameworks 1/ Go on the add items page (cataloguing/additem.pl) and confirm that the plugin works as expected. 2/ Go on the New order page (acqui/neworderempty.pl) and confirm that the plugin works as expected. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 5b521eb394771ee305777f0b44098be5fdd11cc7) Signed-off-by: Chris Cormack (cherry picked from commit 272650cb3f1e2d3ac24559ede0049b263b829762) Signed-off-by: Liz Rea commit 821aa63e4126331ad36164ac98f5f4093bbb72ed Author: Jonathan Druart Date: Tue Jul 14 18:07:37 2015 +0100 Bug 14354: Prevent edition of items from other branches if IndependentBranches is on If IdependentBranches is ON, to edit/delete items from other branches you need to be superlibrarian. Currently a "simple" staff user cannot edit them from the edit item page but from the catalogue detail page. The edit links should not be displayed on this table. Test plan: O/ Set IndependentBranches to "Prevent". Create a record and add 2 items: Set homebranch to L1 for item I1. Set homebranch to L2 for item I2. 1/ With a superlibrarian user, you should be able to edit both items. 2/ With a "simple" user attached to L1, you should only be able to edit I1. The edit links should not be displayed for I2. Note that the checkbox is displayed on the catalogue detail page (item list), but on the batch tools, it won't be possible to select non-modifiable items. TODO: Add a server-side check. Indeed it is still possible to edit an item if the user know the url. Followed test plan. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit bcab2416399e93f5ce9b1083395c052046d5d02a) Signed-off-by: Chris Cormack (cherry picked from commit 28fe340ea75475903a1063f734dec45781d35f90) Signed-off-by: Liz Rea commit 46559c51e7de4bfaa77eb5878d82c7b85707bfbd Author: Jonathan Druart Date: Wed Sep 2 15:07:07 2015 +0100 Bug 11247: Improve tests This patch makes the tests non dependent on the DB and test the 3 marc flavours. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 6e0b61e2acea7c797c1da727474daf7d7a657574) Signed-off-by: Chris Cormack (cherry picked from commit 27ba1a6fa1a5be170d9bf04747f31caab15766b1) Signed-off-by: Liz Rea commit 1016ba0f75d1fca4dcd8dda1f73311f1cb9237ef Author: Marcel de Rooy Date: Wed Aug 26 14:09:53 2015 +0200 Bug 11247: Add a simple unit test for TransformHtmlToXml The unit test is db dependent (as Jonathan correctly remarked), since the sub checks a preference. Test plan: Run t/db_dependent/Biblio/TransformHtmlToXml.t Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit d1335a766d7b54c470701b0055fc99be2e7e7628) Signed-off-by: Chris Cormack (cherry picked from commit 74e46b7467aa69e5a77d0b7689ddd2d24d76805d) Signed-off-by: Liz Rea commit f4ba93afd2241bf7689199674c3596135996971f Author: Jonathan Druart Date: Tue Aug 18 18:40:31 2015 +0100 Bug 14584: Encoding broken with system preferences The pref are double encoded. From bug 12411: "This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944." They should not have been pushed together. Test plan: 1) You need an accentuated language installed. 2) Go to NoLoginInstructions pref, and add some accentuated message like "H?lo m?dames ? m?cie?x" 3) refresh opac home page, message should be gibberish 4) apply patch. Message should be ok now. Signed-off-by: Tomas Cohen Arazi Works as expected. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 813a047e236947a815c4be3c3dde38f19844b962) Signed-off-by: Chris Cormack (cherry picked from commit 270187404e87bdae985e70a590834ed2dc5d49c7) Signed-off-by: Liz Rea commit 087b6a43d9af1179485e7745bbf7c905f71d2a8f Author: Jonathan Druart Date: Fri Jul 10 16:11:48 2015 +0100 Bug 12965: Prevent to erase an existing item type On creating an item type, if it already exists, it will replace the existing one. This patch prevent that and display a message to the interface. Note: The fields are lost. Test plan: 1/ Create an item type 'AAA', description 'AAA' 2/ Edit it, update the description with 'BBB' 3/ Create an item type 'AAA' with a description 'CCC' => you should get a warning "already exists". Works well, no errors Signed-off-by: Amit Gupta Signed-off-by: Joonas Kylm?l? Signed-off-by: Katrin Fischer Warning message is triggered. Adding, editing and deleting item types still works. Signed-off-by: Tomas Cohen Arazi (cherry picked from commit eb12ee1e223b662cd1e89c0a56a5d1c083ba1ddc) Signed-off-by: Liz Rea commit 95fc0a6b2f27d4c584a5f7a4b127fedd2cd82124 Author: Jonathan Druart Date: Wed Jul 15 12:49:03 2015 +0100 Bug 12885: Fix if url contains +*... and HTML5 Media is enabled The special regex chars are not escaped in C4::HTML5Media. Test plan: 1/ Set 856$u=http://www.mrqe.com/lookup?talented+mr.+ripley 2/ Enable the pref HTML5Media 3/ Go on the detail page It should not explode. Signed-off-by: Mirko Tietgen Signed-off-by: Joonas Kylm?l? Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 085d766a0524e399d0c9c9e807d8c0acd0da6a19) Signed-off-by: Liz Rea commit 6bb191aab575dbd7b6a03d5c9da1fa547a03acf3 Author: Jonathan Druart Date: Mon Jul 13 17:34:53 2015 +0100 Bug 13943: Prevent the deletion of items if the user cancels On the edit items page, there is some weird JS code: if the user clicks on the delete link and then cancel, the item is deleted anyway. It's caused by the following JS code in browser.js $('a[href*="biblionumber="]').click(function (ev) { ev.preventDefault(); window.location = $(this).attr('href') + '&searchid=' + me.searchid; }); Test plan: - Do a search with multiple results - Go to the detail page (make sure results browser shows up!) - Use the "Edit items" link from the toolbar - Delete an item (try both way) - Choose "cancel" - Delete an item (try both way) and confirm the deletion You should see the browser after the deletion and the item should have been deleted correctly. - Edit an item (try both way) You should see the browser (did not work before this patch) Note: Before this patch, the 2 first columns didn't contain the edit/delete item links, now it's only the 1st one. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Much better! Signed-off-by: Tomas Cohen Arazi (cherry picked from commit f7214859df15abfe874141bcc1a32b57067f7c54) Signed-off-by: Liz Rea commit 643af3350915f375f1e60bfe5935d0827ef35b8c Author: Srdjan Date: Thu Nov 14 19:10:30 2013 +1300 Bug 11247: Fix calls of TransformHtmlToXml The ind_tag of TransformHtmlToXml is unused. Some calls to this function incorrectly revert indicator and ind_tag (which is not a problem when both are empty..) Patch of Srdjan Jankovic, amended and signed off by Marcel de Rooy. The following calls are fixed: call in acqui/addorder.pl: switched indicator with ind_tag call in acqui/addorderiso2709.pl replaced too acqui/finishreceive.pl replaced too These calls are fine: two calls in cataloguing/additem.pl are fine call in serials/serials-edit.pl is fine call in tools/batchMod.pl is fine The folllow-up patch adds a simple unit test. Signed-off-by: Marcel de Rooy With AcqCreateItem=='placing an order', tested if adding an order still worked (covered both addorder.pl and addorderiso2709.pl). Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 22b41063981de608402d1dd87f6aa9e2010245dd) Signed-off-by: Liz Rea commit 62c341301f3745b48bdee6363e258819e60b29e5 Author: Jonathan Druart Date: Wed Aug 19 16:24:32 2015 +0100 Bug 14696: useless use of String::Random in catalogue/search.pl Bug 10404 adds the use of String::Random to catalogue/search.pl but bug 11369 removes it without removing the import line. Test plan: git grep String::Random catalogue/search.pl should not return anything Signed-off-by: Joonas Kylm?l? Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 90285259e898f4734684edf10a64c252a180fdf6) Signed-off-by: Liz Rea commit f365143c184dfd96fb4bd98dd1873ac3feb26794 Author: Jonathan Druart Date: Fri Apr 24 10:02:19 2015 +0200 Bug 11880: Select what has been selected before The previous patch wants to select the barcode option when the user is on the item search for label, in all cases. So even if 'title' is selected, a search done, and there is no result, the barcode index is selected anyway. In this case, the title option should be kept. Test plan: Confirm that the barcode option is the default choice, but other values are kept if the search does not return any result. Followed test plan, behaves as expected. Tested with all choices. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 1f0ff90360c21e5e24df9f455681b1bf4ae92031) Signed-off-by: Liz Rea commit 2e87354a74948e494965ee21e3ab6160c6467b2b Author: Fr?d?rick Date: Fri Feb 28 16:21:46 2014 -0500 Bug 11880: Select the barcode index by default then searching for label items. Test case: * Go to "Tools -> Label creator -> Manage batches" * Click on the "New batch" button * Click on the "Add item(s)" button * A search window should open. The "Barcode" value should be selected in the the selectbox. Followed test case. Patch behaves as expected. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Liz Rea commit 7ef68ea59d1f30529645bb24fbd73082354dd833 Author: Joonas Kylm?l? Date: Tue Aug 25 07:24:54 2015 +0000 Bug 14703: Holidays description shows \r\n for every new line Adds a new line for the holiday's description instead of the string \r\n. Test plan: 1. In tools -> Calendar look at some holiday's description (Do a new holiday with description of multiple lines if there is not already) 2. Notice that there is characters \r\n if someone has put a newline in the holiday's description 3. Apply patch 4. See that the new lines show there now nicely Sponsored-by: Vaara-kirjastot Signed-off-by: Marcel de Rooy Amended slightly: no need to replace title. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Liz Rea commit 22fa695d598a8f3345a883d15079f1021cbc0161 Author: Kyle M Hall Date: Fri Aug 22 13:29:28 2014 -0400 Bug 12632: Hold limits ignored for record level holds with item level itemtypes The crux of the issue is that if you are using item level itemtypes, but are allowing biblio levels holds, those holds do not have items. So, in CanItemBeReserved, when Koha counts the number of holds to compare against the given rule, it will always give 0 ( except of course for found holds, and the occasional item-level hold ). So the query is saying "link each of these reserves to the reserved item, and count the number of reserves this patron where the itemtype is DVD". However, since these are all record level reserves, there are no items to link to, and so when it looks for all reserves this and item whose itemtype is DVD, it finds zero reserves! This patch solves the problem by looking first at the item level itemtype, and if it does not exist, then it looks at the record level itemtype. For installations using record level itemtypes, the behavior remains unchanged. Test plan: 1) Enable item level itemtypes 2) Create two records with one item each of a given itemtype 3) Create a single issuing rule and limit the holds allowed for that itemtype to 1 4) Place a record level hold on your first record 5) Attempt to place a record level hold for the same patron on your second record. You should not be able to but you can! 6) Apply this patch 7) Repeat step 5, note you can no longer place the hold! Signed-off-by: Paola Rossi Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Signed-off-by: Liz Rea ----------------------------------------------------------------------- Summary of changes: C4/Barcodes/ValueBuilder.pm | 10 ++- C4/Biblio.pm | 2 + C4/HTML5Media.pm | 2 +- C4/Members/Messaging.pm | 3 + C4/Reserves.pm | 10 ++- Koha/Template/Plugin/Koha.pm | 3 +- acqui/addorder.pl | 2 +- acqui/addorderiso2709.pl | 2 +- acqui/finishreceive.pl | 3 +- admin/itemtypes.pl | 38 ++++++---- catalogue/detail.pl | 9 ++- catalogue/search.pl | 1 - cataloguing/value_builder/unimarc_field_4XX.pl | 18 +++++ .../prog/en/modules/admin/itemtypes.tt | 16 ++++ .../prog/en/modules/catalogue/detail.tt | 7 +- .../prog/en/modules/cataloguing/additem.tt | 52 +++++++------ .../cataloguing/value_builder/unimarc_field_4XX.tt | 9 +++ .../intranet-tmpl/prog/en/modules/labels/search.tt | 28 +++---- .../prog/en/modules/tools/holidays.tt | 2 +- .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 18 +++-- labels/label-item-search.pl | 3 +- members/memberentry.pl | 14 ++-- opac/oai.pl | 16 ++++ opac/opac-messaging.pl | 10 +-- reports/guided_reports.pl | 7 +- t/Biblio/TransformHtmlToXml.t | 80 ++++++++++++++++++++ t/Creators.t | 11 +-- 27 files changed, 277 insertions(+), 99 deletions(-) create mode 100644 t/Biblio/TransformHtmlToXml.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 2 14:00:56 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Oct 2015 12:00:56 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.14-34-g4c9abf7 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 4c9abf7673d2ba02d02fd82c0d04fc4c7405017f (commit) via ebe73a3d6e836694cb010ec9518acf8b5d2b3268 (commit) via 65973b4dd3cb87b82811842fcad504c448102b4c (commit) via 2f8e9b1342bfa509865c264180caae6565f592a9 (commit) via 56d895ee0fd913f4346756b44c122fea90ebe34b (commit) via ea22b83b3688b9dcbd91e369c17dfe9b924bcf44 (commit) via 0d9b0f294888a1993bdb370dfb22a8885af66abf (commit) via 674438016c0fae72c151c3d9e2e6d414cafb26c6 (commit) via 0b615c8db9bf9efcd8dbc4b06b1fd4eff4ae1289 (commit) from a4fcb6a535907acf68e58ab8de43ecb6b6c9942d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4c9abf7673d2ba02d02fd82c0d04fc4c7405017f Author: Mason James Date: Sat Oct 3 00:06:45 2015 +1300 Bump version to to 3.16.15 commit ebe73a3d6e836694cb010ec9518acf8b5d2b3268 Author: Mason James Date: Sat Oct 3 00:53:58 2015 +1300 Add release notes commit 65973b4dd3cb87b82811842fcad504c448102b4c Author: genevieve Date: Tue Sep 8 13:58:10 2015 -0400 Bug 13781: Fix missing heading columns for relative's checkouts table in check out patron page Theres was two missing heading columns Location and Fines in the Check out section of a Patron Tested both patches together. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Mason James commit 2f8e9b1342bfa509865c264180caae6565f592a9 Author: genevieve Date: Fri Sep 4 09:15:26 2015 -0400 Bug 13781: Fix relatives's checkouts missing heading columns There was two missing heading columns (location and fine) and one hidden heading missing column (this hidden column is needing for sorting the table) it was taking the due_date column for the hidden column, so I added them Both patches tested together. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Mason James commit 56d895ee0fd913f4346756b44c122fea90ebe34b Author: Tomas Cohen Arazi Date: Wed Sep 16 11:51:12 2015 -0300 Bug 14245: (QA followup) already global The original patch correctly unmasks the global variable (by removing the 'my' on the marc2ris function, but wrongly introduces a new global variable. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mason James commit ea22b83b3688b9dcbd91e369c17dfe9b924bcf44 Author: Bernardo Gonzalez Kriegel Date: Thu May 21 14:00:05 2015 -0300 Bug 14245: Problems with RIS export in unimarc Variable $itype is used an all C4/Ris.pm to switch between marc falvors, but is local and not passed along as argument. As a quick solution, is defined as global To test: 1) On UNIMARC setup, export a record as RIS, check that author (and other fields) are displayed incorrectly 2) Apply the patch 3) Export again, improved results 4) Run t/Ris.t There are other problems in this script, needs maintenance (e.g. no Modern::Perl friendly) Signed-off-by: Victor do Ros?rio Signed-off-by: Jonathan Druart Signed-off-by: Mason James commit 0d9b0f294888a1993bdb370dfb22a8885af66abf Author: Jonathan Druart Date: Tue Jul 14 15:02:42 2015 +0100 Bug 10005: Inventory - Add an option to not check in items The inventory tools automatically check in items, this patch adds it as an option. Test plan: 1/ Check an item out, fill a file with its barcode, and use this file in the inventory tools. 2/ Check the new checkbox and confirm that the item is not checked in 3/ Repeat again and don't check it, the behavior should be the same as before this patch. Signed-off-by: Jason Robb Signed-off-by: Katrin Fischer Added a missing . Patch works as expected. Signed-off-by: Mason James commit 674438016c0fae72c151c3d9e2e6d414cafb26c6 Author: Jonathan Druart Date: Tue Jul 14 11:38:41 2015 +0100 Bug 6756: Add info messages NOTE: Before patch "./misc/cronjobs/batch_anonymise.pl --help" had no message, and neither did the anonymizing tool in the staff client. After the patch, both had informative messages. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Mason James commit 0b615c8db9bf9efcd8dbc4b06b1fd4eff4ae1289 Author: Jonathan Druart Date: Tue Jul 14 11:30:51 2015 +0100 Bug 6756: Fix bad behaviors if AnonymousPatron is not defined There are at least 2 wrong behaviors if the AnonymousPatron pref is not defined (0 or empty string). 1/ If you use the clean borrower tools, you will get a successful message when the nothing happened (the history has not been anonymised). 2/ At the OPAC, if a patron ask for delete his reading history, he will get an error message "The deletion of your reading history failed, because there is a problem with the configuration of this feature. Please help to fix the system by informing your libr ary of this error". IMO this should not happen, the history should be anonymised. With this patch, the old_issues.borrowernumber field will be set to NULL if the AnonymousPatron pref if not defined. Test plan: 1/ Fill the pref with "" or 0 2/ At the OPAC, go on the privacy tab and click on the "Immedia deletion" button. You should get a green and friendly message. Confirm that the history has been anonymised. 3/ Use the "Batch patron anonymization" tools (tools/cleanborrowers.pl) to anonymize the checkout history. Confirm that a) it works and b) you get a message. Try again with AnonymousPatron set to a valid patron. You should not see any changes with the current behaviors. NOTE: This patch tweaks C4/Circulation.pm and provides tests. applying just this, and running prove success. Reverting just C4/Circulation.pm fails, as expected. Tested OPAC stuff with both patches applied. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 5 +- C4/Ris.pm | 6 +- installer/data/mysql/updatedatabase.pl | 7 + .../prog/en/modules/circ/circulation.tt | 2 + .../prog/en/modules/members/moremember.tt | 3 + .../prog/en/modules/tools/cleanborrowers.tt | 4 + .../prog/en/modules/tools/inventory.tt | 4 + kohaversion.pl | 2 +- misc/cronjobs/batch_anonymise.pl | 1 + misc/release_notes/release_notes_3_16_15.html | 314 ++++++++++++++++++++ ..._notes_3_16_9.txt => release_notes_3_16_15.txt} | 226 +++++++------- t/db_dependent/Circulation/AnonymiseIssueHistory.t | 138 +++++++++ tools/inventory.pl | 19 +- 13 files changed, 595 insertions(+), 136 deletions(-) create mode 100644 misc/release_notes/release_notes_3_16_15.html copy misc/release_notes/{release_notes_3_16_9.txt => release_notes_3_16_15.txt} (60%) create mode 100644 t/db_dependent/Circulation/AnonymiseIssueHistory.t hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 2 15:00:03 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Oct 2015 13:00:03 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.14-38-g6855686 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via 6855686ff173540f07e0b5fd615a431bb8628c86 (commit) via 74b8002d59cadb0d68c2dd083c2bd38473c93831 (commit) via 0f7b0ac8299075b8b77218cff31d5c5900b90d37 (commit) via 0bac7826012b3536bfa62bf2fc1adee91da55b26 (commit) from 4c9abf7673d2ba02d02fd82c0d04fc4c7405017f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6855686ff173540f07e0b5fd615a431bb8628c86 Author: Mason James Date: Sat Oct 3 01:55:45 2015 +1300 Revert "Bug 6756: Add info messages" This reverts commit 674438016c0fae72c151c3d9e2e6d414cafb26c6. commit 74b8002d59cadb0d68c2dd083c2bd38473c93831 Author: Mason James Date: Sat Oct 3 01:55:30 2015 +1300 Revert "Bug 6756: Fix bad behaviors if AnonymousPatron is not defined" This reverts commit 0b615c8db9bf9efcd8dbc4b06b1fd4eff4ae1289. commit 0f7b0ac8299075b8b77218cff31d5c5900b90d37 Author: Jonathan Druart Date: Thu Jun 4 11:35:15 2015 +0200 Bug 14256: (follow-up) Check for unique constraint to regenerate random data There were some issues in the previous patch. This patch fixes the following: - rename $value with $original_value - remove $at_least_one_constraint_failed and $values_ok which make the code unnecessarily complicated - the constraints have to be checked only if no original value is passed - _buildColumnValue created a key to the default value hashref, it broke the test: last BUILD_VALUE if exists( $default_value->{$source} ); Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall commit 0bac7826012b3536bfa62bf2fc1adee91da55b26 Author: Tomas Cohen Arazi Date: Wed Jun 3 15:54:57 2015 -0300 Bug 14256: Check for unique constraint to regenerate random data Unique constraints should be checked when creating random data. Otherwise we get failures when the generated data already exists on the DB. This patch takes advantage of ->unique_constraints() to do the job, looping through all the unique constraints defined for the source. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Mason James ----------------------------------------------------------------------- Summary of changes: C4/Circulation.pm | 5 +- .../prog/en/modules/tools/cleanborrowers.tt | 4 - misc/cronjobs/batch_anonymise.pl | 1 - t/db_dependent/Circulation/AnonymiseIssueHistory.t | 138 ------ t/lib/TestBuilder.pm | 449 ++++++++++++++++++++ 5 files changed, 451 insertions(+), 146 deletions(-) delete mode 100644 t/db_dependent/Circulation/AnonymiseIssueHistory.t create mode 100644 t/lib/TestBuilder.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 2 15:05:13 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Oct 2015 13:05:13 +0000 Subject: [koha-commits] main Koha release repository branch 3.16.x updated. v3.16.14-40-ga03f608 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, 3.16.x has been updated via a03f6086798a871baca6178c94590c9602f6971c (commit) via 5f53246b5283a686c8736cdd7b2d9460efaf9e3a (commit) from 6855686ff173540f07e0b5fd615a431bb8628c86 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a03f6086798a871baca6178c94590c9602f6971c Author: Mason James Date: Sat Oct 3 02:08:02 2015 +1300 Revert "Bug 14256: Check for unique constraint to regenerate random data" This reverts commit 0bac7826012b3536bfa62bf2fc1adee91da55b26. commit 5f53246b5283a686c8736cdd7b2d9460efaf9e3a Author: Mason James Date: Sat Oct 3 02:06:36 2015 +1300 Revert "Bug 14256: (follow-up) Check for unique constraint to regenerate random data" This reverts commit 0f7b0ac8299075b8b77218cff31d5c5900b90d37. ----------------------------------------------------------------------- Summary of changes: t/lib/TestBuilder.pm | 449 -------------------------------------------------- 1 file changed, 449 deletions(-) delete mode 100644 t/lib/TestBuilder.pm hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 2 17:06:06 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Oct 2015 15:06:06 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.20.00-670-g6d40b4e Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6d40b4e320101d1f7bd81a0845f77b651cc2326f (commit) via ff693f14fc9b1b0684dfab13d9533f45ab976be4 (commit) via 945e7f5c04f11bb6950c5ef9149db541ad7a4087 (commit) via f937e0adbe4746d8ef3e08f91d1abf567ebf4fba (commit) via d2e7a9e4a848d291c1ca73620701774a4600073a (commit) via 5d256e6b4b4045ca6845292e19707dd087a9db1b (commit) via 4a43c3820555574ad7c83807b6b7a7db2032d340 (commit) via f1eb76c831c9c6bc36a8b9d996b67942efe89cf1 (commit) via bb3250260742b15e840774ac77d9086b5c4b3ea7 (commit) via a988e9425ce1f8f4bf28b46473adac941d634973 (commit) via 542ab0bce949eba3abc98ff1c433fe6099db105d (commit) via 098fd64621043d7109b5e50f77df8be616243e1f (commit) via ca268ad877a6712aa07cb7c873c918d6fdfac52d (commit) from 49a09f6db2e10596deae056fea9e54bd8f5cd046 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6d40b4e320101d1f7bd81a0845f77b651cc2326f Author: Kyle M Hall Date: Fri Oct 2 11:01:19 2015 -0400 Bug 14522: (QA followup) Remove POD and fix tests * Change POD to a brief comment * Fix UT so it doesn't fail on Sundays Signed-off-by: Tomas Cohen Arazi commit ff693f14fc9b1b0684dfab13d9533f45ab976be4 Author: Tomas Cohen Arazi Date: Fri Oct 2 11:39:33 2015 -0300 Bug 14522: (QA followup) tidy tests Signed-off-by: Tomas Cohen Arazi commit 945e7f5c04f11bb6950c5ef9149db541ad7a4087 Author: Kyle M Hall Date: Mon Sep 28 10:21:39 2015 -0400 Bug 14522: (QA followup) Remove $single_holidays global Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit f937e0adbe4746d8ef3e08f91d1abf567ebf4fba Author: Kyle M Hall Date: Fri Sep 25 13:03:02 2015 -0400 Bug 14522: (QA followup) Koha complains about missing C4::Dates on master Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit d2e7a9e4a848d291c1ca73620701774a4600073a Author: Mason James Date: Fri Sep 25 13:34:21 2015 +1200 Bug 14522: (followup) fix =cut typo http://bugs.koha-community.org/show_bug.cgi?id=14522 Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 5d256e6b4b4045ca6845292e19707dd087a9db1b Author: Mason James Date: Tue Jul 14 22:53:10 2015 +1200 Bug 14522: Use Koha::Cache for accessing single_holidays() this patch adds Koha::Cache functionality to the 'single_holidays' table it is a performance patch for the problem described in BZ14315, only http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 it replaces slooow DateTime holiday objects with simple Ymd strings (19991230), then stores the strings in an @array using Koha::Cache it does not attempt to add caching to all holiday tables - just the single_holidays table (at this stage on my test (master-cd9a827); nytprof showed a time reduction of the single_holidays() sub - from 61.7s to 587ms here are some before/after nytprof runs, (really on master-cd9a827, not 3.20) http://x1.kohaaloha.com/i/nyt-bz14522-before/home-mason-g-k-3-20-x-Koha-Calendar-pm-1485-line.html#237 http://x1.kohaaloha.com/i/nyt-bz14522-after/home-mason-g-k-3-20-x-Koha-Calendar-pm-1485-line.html#280 to test... 1/ add a bunch of single_holidays to your test koha, (my table has 400 holiday rows) 2/ add a loong circ rule for an itemtype (my rule has 140 days) 3/ checkout an item to a user (took me 67 secs) apply patch... 4/ return item 5/ repeats steps 1..3, (took me 6 secs) 6/ add/change/delete some various single_holidays, via Home->Tools->Calendar ensure that your various changes have indeed saved correctly for extra points... 7/ run tests t/Calendar.t and t/db_dependent/Holidays.t, with all tests pass OK sudo koha-shell -c ' export PERL5LIB=/home/mason/g/k/master ; \ cd /home/mason/g/k/master ; perl t/Calendar.t ; perl t/db_dependent/Holidays.t ' testkoha 8/ run QA tool, with all tests pass OK sudo koha-shell -c ' \ export KOHA_CONF=/etc/koha/sites/mayo2/koha-conf.xml \ export PERL5LIB=/home/mason/g/k/master:/home/mason/qa-test-tools/ ; \ cd /home/mason/g/k/master ; perl /home/mason/qa-test-tools/koha-qa.pl -c 1 ' testkoha Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi commit 4a43c3820555574ad7c83807b6b7a7db2032d340 Author: Marc V?ron Date: Thu Oct 1 10:51:18 2015 +0200 Bug 14929: Fix missing display of help page in contract management This patch renames / moves the file koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/acqcontract.tt to koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqcontract.tt To test: - Go to Home > Acquisition > [Vendor] > Contracts (/cgi-bin/koha/admin/aqcontract.pl?booksellerid=XXXX) - Verify that Help displays as appropriate. Signed-off-by: Magnus Enger Works as advertised. All the tabs similar to "Contracts" have working help pages. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit f1eb76c831c9c6bc36a8b9d996b67942efe89cf1 Author: Jonathan Druart Date: Wed Sep 16 09:41:41 2015 +0100 Bug 14832: Fix encoding issues when exporting in RIS Test plan: 1/ Make sure you have non ASCII chars in the title and the authors. 2/ Export the record in RIS You should not see any encoding problems. Signed-off-by: Magnus Enger Before patch: RIS file has wrongly encoded chars After patch: RIS file has no endcoding problems Tested on a NORMARC setup. Signed-off-by: Katrin Fischer Tested on a MARC21 and a UNIMARC database. Problem only confirmed for UNIMARC, but no regressions in MARC21. Signed-off-by: Tomas Cohen Arazi commit bb3250260742b15e840774ac77d9086b5c4b3ea7 Author: Jonathan Druart Date: Thu Sep 17 09:03:59 2015 +0100 Bug 14842: Wrong call to GetBranchItemRule From bug 7981: GetBranchItemRule expects an itemtype, a scalar. Here $itemtype is a hashref returned by C4::ItemType->get. So $itemtype->{itemtype} should be passed. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit a988e9425ce1f8f4bf28b46473adac941d634973 Author: Jonathan Druart Date: Thu Oct 1 11:58:41 2015 +0100 Bug 5371: (follow-up) Force no caching for private pages at the OPAC Same as previous patch for opac-messaging.pl and opac-readingrecord.pl Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 542ab0bce949eba3abc98ff1c433fe6099db105d Author: Jonathan Druart Date: Thu Sep 17 12:45:15 2015 +0100 Bug 5371: Force no caching for private pages at the OPAC In order no to slow too much the browsing, it is certainly not a good idea to add this cache-control value for all pages at the OPAC. This patch just adds where the author found it could be useful. Test plan: 1/ Login at the OPAC 2/ Go on the account page (opac/opac-account.pl) 3/ Click log out 4/ Use the back button of your browser Without this patch you will see the previous page. With this patch, the previous page will be reloaded and you will be redirected to the login form. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 098fd64621043d7109b5e50f77df8be616243e1f Author: Fr?d?ric Demians Date: Wed Sep 30 12:16:52 2015 +0200 Bug 14927: Returns item info when resumptionToken is used To test: - activate OAI-PMH with the inclusion of items as explained on bug 12252 - set the OAI-PMH:MaxCount to a low number, 50 for instance - go to the OAI-PMH page to get the records : [your koha catalogue]/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml - check that item data is included - get the resumptionToken at the end of the xml - got to the next page of records [your koha catalogue]/cgi-bin/koha/oai.pl?verb=ListRecords&resumptionToken=[your resumption token] - check that item data is now missing Apply the patch, and repeat previous steps: item data is back. Signed-off-by: Gaetan Boisson Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit ca268ad877a6712aa07cb7c873c918d6fdfac52d Author: Jonathan Druart Date: Tue Sep 15 11:44:32 2015 +0100 Bug 12311: Do not return a lost item if modified in a batch If a item is lost and issued, and you modify it in a batch, the item will be marked as returned. It should only be returned if the item is marked as lost. Test plan: 1/ Check an item out and mark it as lost 2/ Edit it in a batch (tools/batchMod.pl) and edit a field (notes for instance) 3/ The item should still be issued to the patron 4/ Edit it in a batch and edit the lost value, marked it as not lost 5/ The item should still be issued to the patron 6/ Edit it in a batch and edit the lost value, marked it as lost 7/ The item should have been returned. Signed-off-by: Hector Castro Works as advertised. Just one comment, lost status can be changed only if you change default framework to another framework then edit the item. If you change it in Item menu at left side of screen this will remove the item from patron?s checkouts and patron charged for lost item. Signed-off-by: Katrin Fischer For testing purposes the lost item field can be set to visible in the framework used. That will allow changing it without returning it at the same time. The other option is using the longoverdues.pl script. Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Calendar.pm | 56 +++++++++-- C4/Ris.pm | 2 +- Koha/Calendar.pm | 100 +++++++++++++------- circ/returns.pl | 2 +- .../{acqui/acqcontract.tt => admin/aqcontract.tt} | 0 opac/oai.pl | 3 +- opac/opac-account.pl | 3 +- opac/opac-basket.pl | 2 +- opac/opac-browser.pl | 2 +- opac/opac-discharge.pl | 2 +- opac/opac-memberentry.pl | 2 +- opac/opac-messaging.pl | 2 +- opac/opac-mymessages.pl | 2 +- opac/opac-passwd.pl | 2 +- opac/opac-privacy.pl | 2 +- opac/opac-readingrecord.pl | 2 +- opac/opac-reserve.pl | 3 +- opac/opac-search-history.pl | 2 +- opac/opac-user.pl | 3 +- t/Calendar.t | 37 +++++--- t/db_dependent/Holidays.t | 78 ++++++++------- tools/batchMod.pl | 2 +- tools/newHolidays.pl | 8 ++ 23 files changed, 208 insertions(+), 109 deletions(-) rename koha-tmpl/intranet-tmpl/prog/en/modules/help/{acqui/acqcontract.tt => admin/aqcontract.tt} (100%) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 2 19:33:27 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Oct 2015 17:33:27 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.20.00-676-gb8f0a59 Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via b8f0a595344d28d85383007138715d7db131f136 (commit) via 51aad946c6411a484ffde6934d541b9bb1dd2aa3 (commit) via 605f42a721b3a534d01b8f7c73502cfa810147ad (commit) via 2a319e7ae2a7e0d10450a6ca791eabbee01c0787 (commit) via 39dc8b5a9da902f9f90850421dc2815e448222e5 (commit) via 653d305452a27d19d929e2acff71643845686af3 (commit) from 6d40b4e320101d1f7bd81a0845f77b651cc2326f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b8f0a595344d28d85383007138715d7db131f136 Author: Tomas Cohen Arazi Date: Fri Oct 2 14:30:14 2015 -0300 Bug 14820: DBRev 3.21.00.031 Signed-off-by: Tomas Cohen Arazi commit 51aad946c6411a484ffde6934d541b9bb1dd2aa3 Author: Jonathan Druart Date: Tue Sep 22 11:55:55 2015 +0100 Bug 14141: Fix copy action Test plan: Try to copy a letter to a library which already have this letter (same letter_code) defined. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 605f42a721b3a534d01b8f7c73502cfa810147ad Author: Jonathan Druart Date: Tue Jul 14 12:00:33 2015 +0100 Bug 14141: Do not let edit the branch when updating/copying notice If a user modify the library when he's updating a notice, the notice will be duplicated, instead of modified. To reproduce: 1/ Go on the notice & slips tools (tools/letter.pl) 2/ Create a notice A for library L1 3/ Edit this notice and update the library with L2 4/ On the list view, you will observe that 2 notices A now exist, one for L1 and one for L2. The code in tools/letters.pl should be rebuilt completely, it becomes a house of cards. To prevent this bug, I suggest to not let the user modify the library value on editing a notice. It cans be done by copying the notice to another library and remove the original one. Counter patch welcomed. Test plan: 1/ Go on the notice & slips tools (tools/letter.pl). 2/ Create a notice A for library L1. 3/ Edit this notice: you are not able to modify the library anymore. 4/ Copy the notice to library L2. You are not able to modify the library neither. Works ok. Signed-off-by: Amit Gupta Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 2a319e7ae2a7e0d10450a6ca791eabbee01c0787 Author: Jonathan Druart Date: Mon Sep 14 16:01:48 2015 +0100 Bug 14811: Don't update permanent_location with CART or PROC The permanent_location should not be set to CART or PROC when the item is edited. Otherwise we lost an important info. Test plan: 0/ Set the ReturnToShelvingCart pref 1/ Create an item with location "on_my_shelf" 2/ Check the item in and out 3/ Look at the DB values, location should be "CART" and permanent_location unchanged (on_my_shelf) 4/ Edit the item, add a note for instance 5/ Without this patch, the permanent_location is erased with 'CART' and you have definitely lost the info. With this patch, the permanent_location is unchanged. Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 39dc8b5a9da902f9f90850421dc2815e448222e5 Author: Jonathan Druart Date: Tue Sep 15 10:36:44 2015 +0100 Bug 14820: Add missing prefs SMSSendUsername and SMSSendPassword These 2 system preferences are missing from the sysprefs.sql file. Test plan: Execute the updatedatabase script and confirm that the 2 prefs are now in the systempreferences table. Search for "sms" in the system preferences search box, you should see the 3 prefs. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 653d305452a27d19d929e2acff71643845686af3 Author: Jonathan Druart Date: Mon Sep 28 10:58:16 2015 +0100 Bug 14910: Redirect to the circulation module after a renew iIf a patron is renewed from the circulation module, the librarian should be redirected to the circulation module. This works correctly if the renew is done from the patron module (members). This is caused by a typo in the template: desintation vs destination. This patch also removes the cardnumber parameter to the setstatus.pl script, it is not needed given that borrowernumber is always passed. This has a good side-effect, it will fix bug 14691. The cardnumber does not exist anymore, so no need to escape it :) Test plan: 0/ Do not apply this patch 1/ Create a patron with a cardnumber with a quote (rm'me) and another one without a quote (rmme) 2/ Go on the checkouts page (circ/circulation.pl) 3/ Renew the 2 patrons => With rm'me you are redirected to the circ module - ok => With rmme you are redirected to the member module - nok 4/ Go on the patron detail page (members/moremember.pl) 5/ Renew the 2 patrons => you are redirected to the member module - ok 6/ Delete the patrons => Nothing happend with rm'me, there is a JS error on the page - nok => rmme is deleted - ok 7/ Apply the patch and recreate rmme 8/ Repeat 2, 3, 4, 5 => You are redirected to the correct module 9/ Delete the patrons => They are successfully deleted Signed-off-by: Magnus Enger Followed the test plan, works as advertised. (I did have some problems initially, but that was caused by me not using the interface in English...) Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi ----------------------------------------------------------------------- Summary of changes: C4/Items.pm | 6 ++++- Koha.pm | 2 +- installer/data/mysql/sysprefs.sql | 2 ++ installer/data/mysql/updatedatabase.pl | 12 ++++++++++ .../prog/en/includes/members-toolbar.inc | 4 ++-- .../prog/en/modules/admin/preferences/patrons.pref | 4 ++++ .../prog/en/modules/circ/circulation.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/tools/letter.tt | 24 ++++++++++++-------- members/setstatus.pl | 17 +++++++------- t/db_dependent/Items.t | 12 +++++++++- tools/letter.pl | 1 + 11 files changed, 63 insertions(+), 25 deletions(-) hooks/post-receive -- main Koha release repository From gitmaster at git.koha-community.org Fri Oct 2 20:22:54 2015 From: gitmaster at git.koha-community.org (Git repo owner) Date: Fri, 02 Oct 2015 18:22:54 +0000 Subject: [koha-commits] main Koha release repository branch master updated. v3.20.00-699-g6f81f8a Message-ID: This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "main Koha release repository". The branch, master has been updated via 6f81f8a0e2309447acc6e5bb74f444102d8adf56 (commit) via 3eb355e89203a17c04a7b533469ad7ae13e01908 (commit) via 4f5d26aa4970f8abf7455f411ce5bb2c3694f631 (commit) via 10c5109221f243e55a7ff4116fa56dec95c6fde4 (commit) via 4748b17887459ef1c4c9670725e02a42bdd4824a (commit) via 0eb3bd2f0168f9dde79bce3b800c999bf737a315 (commit) via c4b8c17e8b64fcd8b3e81533796927457136c2c6 (commit) via cc58bf3c81c4ad2e623d68edf94837b74b5b1d36 (commit) via 750601ac5b97cdb2d4cf97497b87c61e5083ba33 (commit) via c6ffbcd11ce8d933f35c0060c652c1408ad6c632 (commit) via 640abc852c87298c4f877817ef6b051c31512db1 (commit) via 37319996b0abf857bafa642e2f236a2782146e75 (commit) via e0c43b5825b71163151f512ac0c7a94a5dcd6d36 (commit) via e153d095d4736877883d80ba20e12b317073f49d (commit) via 3cfdc833bd832b034fc976e2082d0080947e2d4b (commit) via 4a14d1c82b05b150cecbec2a862b4f28fbb08586 (commit) via f7fe0dd787c03362a66423aa0b5c2428dd927d0d (commit) via 57c88aa5be8aee96c0870330c85d4d727d84c837 (commit) via 9bdd33de213632168d7b4838fd6d83b5a9db00b8 (commit) via d8c0b836d63e54c9a0be6714f0280d3397debdb4 (commit) via 431d217a5185af747a8e80080cb1f381585471fc (commit) via 49f2837b2e75511becd09059db99d209917647a7 (commit) via a4ee9151c195a89fe70de792a36f327baa6939f2 (commit) from b8f0a595344d28d85383007138715d7db131f136 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 6f81f8a0e2309447acc6e5bb74f444102d8adf56 Author: Tomas Cohen Arazi Date: Fri Oct 2 15:22:10 2015 -0300 Bug 10855: DBRev 3.21.00.032 Signed-off-by: Tomas Cohen Arazi commit 3eb355e89203a17c04a7b533469ad7ae13e01908 Author: Tomas Cohen Arazi Date: Fri Oct 2 15:14:22 2015 -0300 Bug 10855: (RM followup) DBIx update Signed-off-by: Tomas Cohen Arazi commit 4f5d26aa4970f8abf7455f411ce5bb2c3694f631 Author: Jonathan Druart Date: Thu Sep 3 15:38:44 2015 +0100 Bug 10855: (follow-up) Bug 10855: Remove additional field values when subscription is removed The subscriptionid should not be escaped and placeholders used. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 10c5109221f243e55a7ff4116fa56dec95c6fde4 Author: Julian Maurice Date: Thu Sep 3 14:05:07 2015 +0200 Bug 10855: Remove additional field values when subscription is removed Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi commit 4748b17887459ef1c4c9670725e02a42bdd4824a Author: Jonathan Druart Date: Wed Dec 4 16:28:26 2013 +0100 Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values Signed-off-by: Brendan Gallagher Signed-off-by: Tomas Cohen Arazi commit 0eb3bd2f0168f9dde79bce3b800c999bf737a315 Author: Jonathan Druart Date: Mon Jan 19 11:32:55 2015 +0100 Bug 10855: (follow-up) Search subscriptions by additional fields 1 occurrence of KohaAuthorisedValues had not been replaced with AuthorisedValues on fixing a previous conflict. Signed-off-by: Brendan Gallagher Signed-off-by: Tomas Cohen Arazi commit c4b8c17e8b64fcd8b3e81533796927457136c2c6 Author: Jonathan Druart Date: Thu Jan 15 15:36:27 2015 +0100 Bug 10855: Make tests to pass Some recent changes in master make these tests fail. Signed-off-by: Brendan Gallagher Signed-off-by: Tomas Cohen Arazi commit cc58bf3c81c4ad2e623d68edf94837b74b5b1d36 Author: Jonathan Druart Date: Mon Jan 20 10:27:48 2014 +0100 Bug 10855: Additional marc fields are not inserted In subscription-add.pl, the code for inserting additional_fields is not the same for updating and inserting. This patch refactores this code in code to do the same tests. Signed-off-by: Brendan Gallagher Signed-off-by: Tomas Cohen Arazi commit 750601ac5b97cdb2d4cf97497b87c61e5083ba33 Author: Jonathan Druart Date: Mon Dec 23 10:43:52 2013 +0100 Bug 10855: search with exact match if linked to an AV If a field is linked to an AV, the search should be an exact match. Signed-off-by: Brendan Gallagher Signed-off-by: Tomas Cohen Arazi commit c6ffbcd11ce8d933f35c0060c652c1408ad6c632 Author: Jonathan Druart Date: Tue Dec 17 13:53:21 2013 +0100 Bug 10855: Fix QA issues This patch fixes the following QA issues: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt FAIL forbidden patterns forbidden pattern: KohaAuthorisedValues plugin is deprecated (see bug 10626) (line 2) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/serials/add_fields.tt FAIL forbidden patterns forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 12) Signed-off-by: Brendan Gallagher Signed-off-by: Tomas Cohen Arazi commit 640abc852c87298c4f877817ef6b051c31512db1 Author: Jonathan Druart Date: Wed Dec 4 16:26:59 2013 +0100 Bug 10855: Squash several fixes Bug 10855: FIX: Add additional fields for closed subscriptions Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. Bug 10855: FIX conflicts with bug 7688 Bug 10855: Fix typo addition_fields -> additional_fields Bug 10855: A partial search should return the subscriptions If a search on an additional fields is done using a partial string ("foo" and the defined value is "foobar"), the subscription should appear in the result list. Test plan: Try to search a part of the string for an additional field. Bug 10855: Filtering on additional fields don't work if value is equal to 0 If you tried to filter on an additional field linked to an authorised value, that did not work if the value was 0. Bug 10855: Remove the advanced serial search box on the serial home page Bug 10855: FIX an add field should not be created if the marc field does not exist. This patch fixes the following: Create an add fields linked to a nonexistent marc field (does not exist in serials). Edit a subscription and save. Without this patch, an error occured: Software error: DBD::mysql::db do failed: Column 'value' cannot be null at /var/root-koha/bug-10855/Koha/AdditionalField.pm line 107. Bug 10855: Fix Type table vs tablename Koha::AdditionalField->all method take "tablename" not "table" in parameter". Signed-off-by: Brendan Gallagher Signed-off-by: Tomas Cohen Arazi commit 37319996b0abf857bafa642e2f236a2782146e75 Author: Jonathan Druart Date: Thu Aug 29 14:04:32 2013 +0200 Bug 10855: Search subscriptions by additional fields on the claim page Test plan: - create some serials in late. - go on serials/claims.pl. - choose a vendor. - verify that additional fields are displayed in new columns. - try filters on columns. - verify there is no regression on this page. Signed-off-by: Brendan Gallagher Signed-off-by: Tomas Cohen Arazi commit e0c43b5825b71163151f512ac0c7a94a5dcd6d36 Author: Jonathan Druart Date: Thu Aug 29 13:58:34 2013 +0200 Bug 10855: Search subscriptions by additional fields Now you will abble to search subscriptions by additional fields. The additional field values will be displayed in the table results. Test plan: - go on the subscriptions advanced search page (serials/serials-search.pl). - verify all searchable additional fields are displayed on the form. - combine 1 or more values and verify results are consistent. - verify the values are displayed in new columns of the table. - for field linked to an authorised value category, the description is displayed (not the code). Signed-off-by: Brendan Gallagher Signed-off-by: Tomas Cohen Arazi commit e153d095d4736877883d80ba20e12b317073f49d Author: Jonathan Druart Date: Thu Aug 29 13:37:40 2013 +0200 Bug 10855: New fields on adding/updating a subscription This patch adds the ability to add values for additional fields when adding/updating a subscription. Test plan (test the following on adding a new subscription and on editing an existent one): - add/edit a subscription. - verify all additional fields appears into the "Additional fields" block. - fill a value for af1 and af3. - fill others values if you are adding a new subscription. - save. - verify values appears on the detail of the subscription page. - verify the af2 field is automatically filled with the specified marc field of the notice. Signed-off-by: Brendan Gallagher Signed-off-by: Tomas Cohen Arazi commit 3cfdc833bd832b034fc976e2082d0080947e2d4b Author: Jonathan Druart Date: Thu Aug 29 13:32:30 2013 +0200 Bug 10855: interface configuration for adding new fields to subscriptions This patch adds an interface configuration for adding fields to subscriptions. Test plan: - go to serials/serials-home.pl - click on the "Add subscription fields" link on the left of the screen - try to add/update/delete new fields You are not abble to add a field with an authorised value category and a marcfield. Columns are sortable - for the rest, you should have, at least: * a new field named af1, sortable, linked to a category * a new field named af2, sortable, linked to a marcfield * a new field named af3, not sortable Signed-off-by: Brendan Gallagher Signed-off-by: Tomas Cohen Arazi commit 4a14d1c82b05b150cecbec2a862b4f28fbb08586 Author: Jonathan Druart Date: Thu Aug 29 12:43:27 2013 +0200 Bug 10855: Add unit tests for the new package Koha::AdditionalField Test plan: - prove t/db_dependent/AdditionalField.t Signed-off-by: Brendan Gallagher Signed-off-by: Tomas Cohen Arazi commit f7fe0dd787c03362a66423aa0b5c2428dd927d0d Author: Jonathan Druart Date: Thu Aug 29 12:42:41 2013 +0200 Bug 10855: Add the new package Koha::AdditionalField Signed-off-by: Brendan Gallagher Signed-off-by: Tomas Cohen Arazi commit 57c88aa5be8aee96c0870330c85d4d727d84c837 Author: Jonathan Druart Date: Wed Sep 16 09:01:26 2015 +0100 Bug 14829: Fix shortcuts in the cataloging and patron modules In these 2 modules, the shortcuts alt+q, alt+r and alt+u don't work as in other modules. The tab are not "built" in the correct order and the id returned to select the correct tab is wrong. Test plan: Go on the circ home page (circ/circulation-home.pl), the patron home page (members/members-home.pl) and the cataloging home page (cataloguing/addbooks.pl). On these 3 pages, without this patch, the shortcuts select different tabs. With this patch, the issue is fixed for all of them. Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit 9bdd33de213632168d7b4838fd6d83b5a9db00b8 Author: Fridolin Somers Date: Tue Aug 11 10:19:05 2015 +0200 Bug 14671: Allow correct translation of CAS authentication In authentication pages with CAS, the use of acronym or abbr tags does not allow a correct translation of the text. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983#c7 It does not help a lot end users to know that CAS is Central Authentication Service, I think. Now one can custom the login page with NoLoginInstructions syspref to describe how to use the authentication. This patch removes the use of acronym and abbr is authentication pages. Test plan (example with fr-FR locale) : - Without patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a " - Is is translated in : msgstr "Si vous avez un compte " - Apply patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a CAS account, %s please " - You can now translate it : msgstr "Si vous avez un compte CAS, %s veuillez " - Same test for intranet authentication page - Install the translation : cd misc/translator ; perl translate install fr-FR - Look at the result Signed-off-by: Hector Castro Works as advertised. Tranlated OK, tested in spanish es-ES Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi commit d8c0b836d63e54c9a0be6714f0280d3397debdb4 Author: Lari Taskula Date: Fri Sep 25 14:06:40 2015 +0000 Bug 14880: Keyboard shortcuts don't work after setting CircAutocompl to "Don't try" The issue is that CircAutocompl loads a script element under #header_search element. When this element is missing, it also messes up the indexing, because we were calculating the indexing of the found element by subtracting one from the found element's index (to eliminate the