[koha-commits] main Koha release repository branch master updated. v3.20.00-676-gb8f0a59
Git repo owner
gitmaster at git.koha-community.org
Fri Oct 2 19:33:27 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via b8f0a595344d28d85383007138715d7db131f136 (commit)
via 51aad946c6411a484ffde6934d541b9bb1dd2aa3 (commit)
via 605f42a721b3a534d01b8f7c73502cfa810147ad (commit)
via 2a319e7ae2a7e0d10450a6ca791eabbee01c0787 (commit)
via 39dc8b5a9da902f9f90850421dc2815e448222e5 (commit)
via 653d305452a27d19d929e2acff71643845686af3 (commit)
from 6d40b4e320101d1f7bd81a0845f77b651cc2326f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit b8f0a595344d28d85383007138715d7db131f136
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Fri Oct 2 14:30:14 2015 -0300
Bug 14820: DBRev 3.21.00.031
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 51aad946c6411a484ffde6934d541b9bb1dd2aa3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 22 11:55:55 2015 +0100
Bug 14141: Fix copy action
Test plan:
Try to copy a letter to a library which already have this letter (same
letter_code) defined.
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 605f42a721b3a534d01b8f7c73502cfa810147ad
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Jul 14 12:00:33 2015 +0100
Bug 14141: Do not let edit the branch when updating/copying notice
If a user modify the library when he's updating a notice, the notice
will be duplicated, instead of modified.
To reproduce:
1/ Go on the notice & slips tools (tools/letter.pl)
2/ Create a notice A for library L1
3/ Edit this notice and update the library with L2
4/ On the list view, you will observe that 2 notices A now exist, one
for L1 and one for L2.
The code in tools/letters.pl should be rebuilt completely, it becomes a
house of cards. To prevent this bug, I suggest to not let the user
modify the library value on editing a notice.
It cans be done by copying the notice to another library and remove the
original one.
Counter patch welcomed.
Test plan:
1/ Go on the notice & slips tools (tools/letter.pl).
2/ Create a notice A for library L1.
3/ Edit this notice: you are not able to modify the library anymore.
4/ Copy the notice to library L2. You are not able to modify the library
neither.
Works ok.
Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 2a319e7ae2a7e0d10450a6ca791eabbee01c0787
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Sep 14 16:01:48 2015 +0100
Bug 14811: Don't update permanent_location with CART or PROC
The permanent_location should not be set to CART or PROC when the item
is edited.
Otherwise we lost an important info.
Test plan:
0/ Set the ReturnToShelvingCart pref
1/ Create an item with location "on_my_shelf"
2/ Check the item in and out
3/ Look at the DB values, location should be "CART" and
permanent_location unchanged (on_my_shelf)
4/ Edit the item, add a note for instance
5/ Without this patch, the permanent_location is erased with 'CART' and
you have definitely lost the info.
With this patch, the permanent_location is unchanged.
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 39dc8b5a9da902f9f90850421dc2815e448222e5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Sep 15 10:36:44 2015 +0100
Bug 14820: Add missing prefs SMSSendUsername and SMSSendPassword
These 2 system preferences are missing from the sysprefs.sql file.
Test plan:
Execute the updatedatabase script and confirm that the 2 prefs are now
in the systempreferences table.
Search for "sms" in the system preferences search box, you should see
the 3 prefs.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
commit 653d305452a27d19d929e2acff71643845686af3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Sep 28 10:58:16 2015 +0100
Bug 14910: Redirect to the circulation module after a renew
iIf a patron is renewed from the circulation module, the librarian
should be redirected to the circulation module.
This works correctly if the renew is done from the patron module
(members).
This is caused by a typo in the template: desintation vs destination.
This patch also removes the cardnumber parameter to the setstatus.pl
script, it is not needed given that borrowernumber is always passed.
This has a good side-effect, it will fix bug 14691. The cardnumber does
not exist anymore, so no need to escape it :)
Test plan:
0/ Do not apply this patch
1/ Create a patron with a cardnumber with a quote (rm'me) and another
one without a quote (rmme)
2/ Go on the checkouts page (circ/circulation.pl)
3/ Renew the 2 patrons
=> With rm'me you are redirected to the circ module - ok
=> With rmme you are redirected to the member module - nok
4/ Go on the patron detail page (members/moremember.pl)
5/ Renew the 2 patrons
=> you are redirected to the member module - ok
6/ Delete the patrons
=> Nothing happend with rm'me, there is a JS error on the page - nok
=> rmme is deleted - ok
7/ Apply the patch and recreate rmme
8/ Repeat 2, 3, 4, 5
=> You are redirected to the correct module
9/ Delete the patrons
=> They are successfully deleted
Signed-off-by: Magnus Enger <magnus at libriotech.no>
Followed the test plan, works as advertised. (I did have some problems
initially, but that was caused by me not using the interface in
English...)
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
-----------------------------------------------------------------------
Summary of changes:
C4/Items.pm | 6 ++++-
Koha.pm | 2 +-
installer/data/mysql/sysprefs.sql | 2 ++
installer/data/mysql/updatedatabase.pl | 12 ++++++++++
.../prog/en/includes/members-toolbar.inc | 4 ++--
.../prog/en/modules/admin/preferences/patrons.pref | 4 ++++
.../prog/en/modules/circ/circulation.tt | 4 ++--
.../intranet-tmpl/prog/en/modules/tools/letter.tt | 24 ++++++++++++--------
members/setstatus.pl | 17 +++++++-------
t/db_dependent/Items.t | 12 +++++++++-
tools/letter.pl | 1 +
11 files changed, 63 insertions(+), 25 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list