[koha-commits] main Koha release repository branch master updated. v3.20.00-710-g58a0186

Mon Oct 5 17:34:43 CEST 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  58a0186dd243d011954e06dc314df2e462b1e1fe (commit)
       via  69400a635c98f2da7ddfc3d4902a087cff12dce3 (commit)
       via  26383113d0cc7edf58458795349b252dfbee25c6 (commit)
       via  1489bb7342f3e4391b598b80ea368cb03ff325a5 (commit)
       via  2f0e409f471fe4527defee41798a80b1e354ce3e (commit)
       via  122d41816bde4e5111d51d4937c240f343ad253b (commit)
       via  b36cec6cbaeb4c78dafdcd3138925a7c1d625dc4 (commit)
       via  4c1a0cb92936592ebb3600d429acf0aaa230bb26 (commit)
       via  45331a4a7c6b3e89f7bb47d808d9a7cab899e775 (commit)
       via  897beb20a5507625f03570d4b93dbec21a658ba3 (commit)
       via  b755e657e5d755283c6d47f94514bf4a94cde7ad (commit)
      from  6f81f8a0e2309447acc6e5bb74f444102d8adf56 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 58a0186dd243d011954e06dc314df2e462b1e1fe
Author: Winona Salesky <wsalesky at gmail.com>
Date:   Tue Sep 29 22:32:45 2015 -0400

    Bug 14917: 700/710/711 fix path for icon in XSLT

    Added theme and materialTypeLabel parameters back into showAuthor template call
    for 7xx display in OPAC display.

    Test Plan:
    1) Apply this patch
    2) Ensure you are using the default XSLT setting for the staff and opac record details
    3) Find or create a record with MARC tags 700,710,711
    5) Click title to review record details.
    6) Link to icon following contributor names should appear.

    Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
    Works as expected. Magnifying glass icon corrected

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    Edit: I shortened the commit subject and put most of it in the commit message.

commit 69400a635c98f2da7ddfc3d4902a087cff12dce3
Author: Remi Mayrand-Provencher <remi.mayrand-provencher at inLibro.com>
Date:   Wed May 20 13:26:23 2015 -0400

    Bug 14518: Allow deleting records with holds (and no item) after confirmation

    Cleaning up records with no item but holds is impossible since
    the code does not consider the result from the confirmation popup.

    This situation happens to our client in their (annual) cleanup.

    I. Setup
    Create the following if needed:
    1) A patron for placing holds and checkouts
    2) A test bibliographic record
    3) An item for the record. Set the barcode to "DELETEME"

    II. Corrupting the Database
    1) Checkout the item "DELETEME"
    2) Place a record level hold on the test record (next available item)
    3) Checkin the item "DELETEME"
    4) MySQL: DELETE FROM items WHERE barcode="DELETEME";

    III. Deleting the record.
    1) On the test record's details page: Edit -> Delete record
    2) Click 'yes' in the prompt
    3) Nothing happens.

    IV. Fixing the bug
    1) Apply the patch
    2) Repeat step III to delete the record
    3) Record is deleted

    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
    Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
    Note: It's not possible in Koha to place a hold on a
    record with items, so the effect described here is more
    likely to be the result of a migration issue or another
    bug. But doesn't hurt to provide a way out :)
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 26383113d0cc7edf58458795349b252dfbee25c6
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Jul 10 11:56:14 2015 +0100

    Bug 6379: Fix if the reviewer is not the same patron

    get_approval_rows does a left join on tags_approval.approved_by =
    borrowers.borrowernumber

    This means it cannot return the approval tags for a given patron.

    Note that this patch could be time-consuming if there is a lot of tags
    in the DB.

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 1489bb7342f3e4391b598b80ea368cb03ff325a5
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Wed Mar 25 13:44:25 2015 +0100

    Bug 6379: Remove link from unapproved tags

    At the OPAC, if the tag is not approved, the tag's link did not return
    any result.

    This patch removes the link.
    Test plan:
    1/ Set TagsModeration to 'Require'
    2/ Create tags at the OPAC
    3/ Approve a couple
    4/ Confirm that unapproved tags does not have links.

    Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
    works as described, no errors

    For the (approved) link to work I need to install YAML::XS

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 2f0e409f471fe4527defee41798a80b1e354ce3e
Author: Julian Maurice <julian.maurice at biblibre.com>
Date:   Fri Oct 2 09:25:18 2015 +0200

    Bug 14940: Fix sorting in opac-topissues.pl

    There is hidden text in "Checkouts" cells that prevent DataTables to
    sort numerically.
    This patch adds the 'title-numeric' sort plugin and use it in
    opac-topissues.pl

    Column 'Checkouts' in Home > Most popular items sorts as expected
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 122d41816bde4e5111d51d4937c240f343ad253b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jul 14 16:44:37 2015 +0100

    Bug 14528: Inconsistency in permissions check when listing shelves

    The svc script needed borrowers when the shelves.pl needed catalogue.
    There is no sense to have different permissions here.

    Test plan:
    1/ Remove the borrowers permission to a user
    2/ Use this user to log in
    3/ Go on the shelf list
    4/ Without this patch, you should get an endless "Processing..." which
    is fixed if you apply it.

    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit b36cec6cbaeb4c78dafdcd3138925a7c1d625dc4
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date:   Mon Oct 5 12:23:26 2015 -0300

    Bug 14888: (QA followup) remove unused lib/var

    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 4c1a0cb92936592ebb3600d429acf0aaa230bb26
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Oct 2 08:48:05 2015 +0100

    Bug 14888: Add tests for Koha::Cit[y|ies]

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 45331a4a7c6b3e89f7bb47d808d9a7cab899e775
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Oct 2 08:34:51 2015 +0100

    Bug 14888: Update copyright and wording

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit 897beb20a5507625f03570d4b93dbec21a658ba3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Sep 24 15:00:57 2015 +0100

    Bug 14888: Add Koha::Cit[y|ies] classes

    Tested both patches together, works as expected
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit b755e657e5d755283c6d47f94514bf4a94cde7ad
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Sep 24 15:01:31 2015 +0100

    Bug 14888: use Koha::Cit[y|ies] in admin/itemtypes

    Test plan:
    Add/edit/remove cities from the administration module
    (admin/cities.pl).
    You should get message feedback after each action.

    Tested both patches together, works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-----------------------------------------------------------------------

Summary of changes:
 Koha/{Biblio.pm => Cities.pm}                      |   20 +-
 Koha/{Branch.pm => City.pm}                        |   14 +-
 admin/cities.pl                                    |  165 +++++++-------
 .../intranet-tmpl/prog/en/includes/cat-toolbar.inc |    4 -
 .../intranet-tmpl/prog/en/modules/admin/cities.tt  |  233 +++++++++++---------
 .../opac-tmpl/bootstrap/en/modules/opac-tags.tt    |    9 +-
 .../bootstrap/en/modules/opac-topissues.tt         |    4 +-
 .../bootstrap/en/xslt/MARC21slim2OPACDetail.xsl    |    2 +
 koha-tmpl/opac-tmpl/bootstrap/js/datatables.js     |   26 +++
 opac/opac-tags.pl                                  |   26 ++-
 svc/virtualshelves/search                          |    2 +-
 t/db_dependent/Koha/Cities.t                       |   46 ++++
 12 files changed, 326 insertions(+), 225 deletions(-)
 copy Koha/{Biblio.pm => Cities.pm} (80%)
 copy Koha/{Branch.pm => City.pm} (82%)
 create mode 100644 t/db_dependent/Koha/Cities.t

hooks/post-receive
-- 
main Koha release repository