[koha-commits] main Koha release repository branch master updated. v3.20.00-727-g736e2a4
Git repo owner
gitmaster at git.koha-community.org
Tue Oct 6 15:59:00 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 736e2a440e1b6f38f73c3a34b82d95d746e03639 (commit)
via bf94ccdfac6c5b7d226d80f6d5319704b6cfd85f (commit)
via fb59c5c7c440da6bb2a721efde6597847ebd8e6b (commit)
via 09cb7e9043084674fa0f972028211088745cb49e (commit)
via dc7a71e8f9fea1749e271781383c1d8adc34c902 (commit)
via ffae621749c52cff77c01cd184f6ec604843a14d (commit)
via 1acb998beb245ff038ea81e72d765eb101ca6b0a (commit)
via d1cd0bff64b3e0cae8808c9f8872dd57a66bb8de (commit)
via d17cb79309c896a0d9b7fb3babdf6fa3b1cfefd7 (commit)
via e954c98199548995ead5a839376971c1615cea9a (commit)
via a7818b35c781fe273aed15ffd55c9b5bd7ded1fd (commit)
via a8a9c7b7fd75bda5fb9b1ced2cc9600a289b0fa6 (commit)
via 011f439740a51079718c64be7648fbaac3c79a82 (commit)
via 559b22f6a9435f8b4651b123cdf3077c9ee186f2 (commit)
via 4f4c5e67efc33a974523139b0bc0e57fae9cfc46 (commit)
via ed5d8e1c5a2b0055853a1331b7f6d3764f81d0f1 (commit)
from 7c066239f38ac03dad12fd57cbfdae1745fa9fbf (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 736e2a440e1b6f38f73c3a34b82d95d746e03639
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 6 10:39:26 2015 -0300
Bug 10020: (RM followup) DBIx update
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit bf94ccdfac6c5b7d226d80f6d5319704b6cfd85f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 6 10:33:15 2015 -0300
Bug 10020: DBRev 3.21.00.033
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit fb59c5c7c440da6bb2a721efde6597847ebd8e6b
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Apr 10 13:19:32 2015 +0200
Bug 10020: Remove code related to ethnicity
This is a(nother) vestige of Koha (2.2?).
This patch removes unused code related to the 'ethnicity'.
In detail:
There is no way to fill the ethnicity table.
There is no way to fill the borrowers.ethnicity and borrowers.ethnotes.
BUT if borrowers.ethnicity exists, the value is displayed on
members/moremember.pl (and only here).
Test plan:
Apply this patch and confirm there is no regression on
adding/updating/deleting patrons.
Note that you don't see the ethnicity value on the moremember.pl page even if a patron has it.
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 09cb7e9043084674fa0f972028211088745cb49e
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date: Fri Apr 10 13:19:50 2015 +0200
Bug 10020: Remove DB table and fields related to ethnicity
This patch remove the ethnicity table and the ethnicity and ethnotes
fields from the 3 tables: borrowers, deletedborrowers and
borrower_modifications IF no data exist.
Test plan:
0/ Apply this patch and update the Koha::Schema
(misc/devel/update_dbix_class_files.pl).
1/ Make sure the ethnicity has at least 1 entry
2/ Launch the updatedb entry and confirm you get a warning message and
the DB structure is not updated.
3/ truncate the ethnicity table and fill ethnicity (or ethnotes) for at least 1
row of the borrowers table.
4/ Launch the updatedb entry and confirm you get a warning message and
the DB structure is not updated.
5/ Make sure the ethnicity table is empty as well as the ethniciy and
the ethnotes fields of borrowers, deletedborrowers and
borrower_modifications
6/ Launch the updatedb entry and confirm you don't get the warning
message and the DB structure is updated (ie. table and fields dropped).
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit dc7a71e8f9fea1749e271781383c1d8adc34c902
Author: Marc Véron <veron at veron.ch>
Date: Sun Oct 4 20:39:44 2015 +0200
Bug 14951: Remove C4::Dates from plugins/*.pl files
This patch removes C4::Dates from:
- plugins/plugins-home.pl
- plugins/run.pl
C4::Dates seem not to be used here, removed.
For testing refer to:
http://manual.koha-community.org/3.20/en/pluginsystem.html
http://manual.koha-community.org/3.20/en/pluginsystem.html
Signed-off-by: Joonas Kylmälä <j.kylmala at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit ffae621749c52cff77c01cd184f6ec604843a14d
Author: Marc Véron <veron at veron.ch>
Date: Mon Oct 5 16:22:12 2015 +0200
Bug 14923: Remove C4::Dates from labels/label-item-search.pl
This patch removes C4::Dates from labels/label-item-search.pl
To test:
- Go to Home > Tools > Labels home > Manage label batches
- Click "Add item(s)"
- Verify that selection with date after and date before works
the same as without patch.
Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com>
Works as advertised. Tested with bad dates
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Todo later: Some checks should be added on client side.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 1acb998beb245ff038ea81e72d765eb101ca6b0a
Author: Barton Chittenden <barton at bywatersolutions.com>
Date: Mon Sep 21 08:57:43 2015 -0700
Bug 14858: removed record length limit test
Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit d1cd0bff64b3e0cae8808c9f8872dd57a66bb8de
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 6 11:50:36 2015 +0100
Bug 14950: Remove unused variable $today_iso
This variable is not used anymore in the template (and has never been
used...).
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit d17cb79309c896a0d9b7fb3babdf6fa3b1cfefd7
Author: Marc Véron <veron at veron.ch>
Date: Sun Oct 4 20:11:26 2015 +0200
Bug 14950: Assign default value for YYYY, MM and DD
[was Remove C4::Dates from tools/batchMod.pl]
This patch replace the YYYY, MM and DD if defined in the default values.
This patch also removes C4::Dates from tools/batchMod.pl
To test:
- In MARC bibliographic Default framework, define a default value
for one of the in Tag 952 Subfield struture, e.g. for
subfield x Non-public note. You can define it under
'Advancde constraints'. Define the value similar to the following:
Year:YYYY Month:MM Day:DD
- Got to Home > Tools > Batch item modification
- Enter one ore more barcodes you want to modify
- Check checkbox 'Populate fields with defautl values from defautl framework
- Click 'Continue'
- Verify on the follwing screen that the field in Edit form is populated
as appropriate (in our example 'x - Non public note')
- Click 'Save'
- Verify that the items are updated as appropriate
Signed-off-by: Joonas Kylmälä <j.kylmala at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended commit message: This is a bug fix and can be backported. The
YYYY, MM and DD were not replaced correctly before this patch.
I got Year:2015-10-06 Month: Day:
now I correctly get Year: 2015 Month: 10 Day: 06
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit e954c98199548995ead5a839376971c1615cea9a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Mon Oct 5 09:20:02 2015 +0100
Bug 14739: Adapt wording in breadcrumbs if a new batch is created
Don't display "Manage batch number 0" but "Create new batch"
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit a7818b35c781fe273aed15ffd55c9b5bd7ded1fd
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Oct 2 09:51:07 2015 +0100
Bug 14739: Fix plack compatibility
perlcritic raised "Declare variables outside of the condition"
Works as expected
Signed-off-by: Josef Moravec <josef.moravec at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit a8a9c7b7fd75bda5fb9b1ced2cc9600a289b0fa6
Author: Nick Clemens <nick at quecheelibrary.org>
Date: Thu Sep 10 06:35:37 2015 -0400
Bug 14739: Add several patrons to a new batch will create a new batch per patron added
This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search
To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup
3 - Add items to batch using the popup, borrowernumbers should populate to the form
4 - Click add items again and items should be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above
11 - Create a new label batch
12 - Click add items with no data, popup item search should appear
13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page
14 - When adding using form the 'Enter by itemnumber' button should be marked automatically
15 - Submit items and confirm they are added to batch
16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber"
17 - Click add items, no items should be added
18 - Repopulate form with barcodes, check 'Enter by barcode'
19 - Click add items, items should be added correctly
20 - Test various combinations of radio buttons and numbers and using form or not
Signed-off-by: Barton Chittenden <barton at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 011f439740a51079718c64be7648fbaac3c79a82
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 6 13:59:04 2015 +0100
Bug 5144: Don't display the failed_holds param in the url if not needed
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 559b22f6a9435f8b4651b123cdf3077c9ee186f2
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Oct 6 13:54:22 2015 +0100
Bug 5144: Add test on carp message
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 4f4c5e67efc33a974523139b0bc0e57fae9cfc46
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Oct 5 07:50:18 2015 -0400
Bug 5144: Duplicate holds allowed if patron clicks back button after placing hold
Koha is currently not engineered to handle multiple holds per record.
Until such time that is does, we should not allow them to be created.
Test Plan:
1) Apply this patch
2) Log in to the opac
3) Place a hold
4) Hit the back button on your browser
5) Place the hold again
6) Note the new message
Signed-off-by: David Kuhn <kuhn at monterey.org>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit ed5d8e1c5a2b0055853a1331b7f6d3764f81d0f1
Author: Kyle M Hall <kyle at bywatersolutions.com>
Date: Mon Oct 5 07:50:03 2015 -0400
Bug 5144: Add unit test
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
-----------------------------------------------------------------------
Summary of changes:
C4/Members.pm | 50 ------------------
C4/Reserves.pm | 50 ++++++++++++------
Koha.pm | 2 +-
Koha/Schema/Result/Borrower.pm | 20 +-------
Koha/Schema/Result/BorrowerModification.pm | 20 +-------
Koha/Schema/Result/Deletedborrower.pm | 20 +-------
installer/data/mysql/kohastructure.sql | 17 ------
installer/data/mysql/updatedatabase.pl | 54 ++++++++++++++++++++
.../prog/en/modules/labels/label-edit-batch.tt | 44 +++++++++++-----
.../intranet-tmpl/prog/en/modules/labels/result.tt | 13 ++---
.../prog/en/modules/members/members-update.tt | 2 -
.../prog/en/modules/members/moremember-brief.tt | 4 --
.../prog/en/modules/members/moremember.tt | 4 --
.../prog/en/modules/patroncards/edit-batch.tt | 48 +++++++++++++----
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 7 +++
labels/label-edit-batch.pl | 28 ++++++----
labels/label-item-search.pl | 39 ++++++++------
members/memberentry.pl | 17 +-----
members/moremember.pl | 5 --
misc/batchRebuildItemsTables.pl | 1 -
opac/opac-reserve.pl | 6 ++-
opac/opac-user.pl | 20 +++-----
patroncards/edit-batch.pl | 28 +++++++---
plugins/plugins-home.pl | 1 -
plugins/run.pl | 1 -
t/Borrower.t | 12 +----
t/db_dependent/Holds.t | 10 ++--
t/db_dependent/Members.t | 3 --
t/db_dependent/Reserves.t | 25 +++++++--
tools/batchMod.pl | 15 +++---
30 files changed, 281 insertions(+), 285 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list