[koha-commits] main Koha release repository branch master updated. v3.20.00-742-gcc87d60
Git repo owner
gitmaster at git.koha-community.org
Tue Oct 6 18:12:55 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via cc87d60b4afd274b6282dfd2e79ce8ffa845ef1f (commit)
via 0e789ef5688b70065ea631cbfde6306f10eeed99 (commit)
via 00d85593b97fd91217e5bf08da92f99a643fb455 (commit)
via fa99f75bdc469da5d76fe1c90c1db9295c61618c (commit)
via 4fa33e055c127ab3bc9579640172cc55fd73b5d5 (commit)
via 0d99ca8ac97396b5901cef6b498fe0609ab7a576 (commit)
via 507f84f23363746aa9d5912dcb4101e8dad97668 (commit)
via c69203d0ad7bd0c98c8ff46048c07a1986ef9332 (commit)
via 1045d8f9b5796d569f26d0a5a2b0542c04594772 (commit)
via 21d0e014adf3d7fc4ea22a0fb11d9845aac1f93e (commit)
via e5caccb17a563f19e18789a41d4d9ef127dd34c9 (commit)
via 764b8b7e905e541a8e6de65a94f2ceed0fdef111 (commit)
via 226a10232a6c43e1bbbaaa3f0ce7a4066eda9e48 (commit)
via bbd66ad767a28829084ab554a9f24ccd7e046216 (commit)
via 0ba37ddeba81483664b807948a72410e1fc89df3 (commit)
from 736e2a440e1b6f38f73c3a34b82d95d746e03639 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit cc87d60b4afd274b6282dfd2e79ce8ffa845ef1f
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 6 11:51:48 2015 -0300
Bug 14667: (QA followup) remove useless labels-menu.inc file
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 0e789ef5688b70065ea631cbfde6306f10eeed99
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 6 11:37:15 2015 -0300
Bug 14667: (QA followup) make the UI show 'Label creator' consistently
The tool is documented and accessed (via Tools >) as 'Label creator'. But the
pages titles say 'Labels' and the breadcumbs 'Labels home'. It should be called
'Label creator' for consistency. This patch changes the tt files so they are
consistent.
It also makes the title show the same page name as the breadcumbs.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 00d85593b97fd91217e5bf08da92f99a643fb455
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Tue Aug 18 17:40:46 2015 +0100
Bug 14667: Make some strings translatable
This patch 1/ Fixes a regression introduced by the previous patch: the
"Are you sure to delete..." strings was translatable and 2/ Make the
table headers translatable.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit fa99f75bdc469da5d76fe1c90c1db9295c61618c
Author: Liz Rea <wizzyrea at gmail.com>
Date: Wed Aug 5 03:36:10 2015 +0000
Bug 14667: UI/UX improvements for the Label creator
Note: It would be good to adopt these same changes in the Patron Card creator for consistency and push
them in conjunction with these changes. -Chris_n
Reasoning
Librarians will be doing label things in the following frequencies, from most frequent to least frequent:
1. Creating new label batches - every day/every few days
2. Managing existing label batches - every day/every few days
3. Managing existing label layouts - as needed, infrequent
5. Managing existing label templates - as needed, infrequent
6. Creating new label layouts - as needed, infrequent
7. Creating new label templates - as needed, infrequent
8. Managing existing printer profiles - possibly once only!
9. Creating new printer profiles - possibly once only!
This change to the label creator aims to make the most frequently used items easily accessible at the top of the main area,
reduces clutter on the page, and makes the label creator fall in line with UI paradigms found elsewhere in Koha.
To test:
Open the label creator: More -> Tools -> Label creator
Note that the toolbar has changed. It should be consistent across all of the label creator (it is an include).
+ New menu:
Label batch
1. make sure it looks ok - toolbar buttons are consistent at the top of the main block.
2. add items both by barcode, and by search (note this patch does not touch the pop up window. Another day.)
3. note that the usual buttons have moved below the textarea, and now have icons.
4. delete and export single items using the buttons corresponding to each item
5. select multiple and use the buttons above the table to remove and export selected items
6. export a full batch
7. deduplicate a batch
There should be no regressions in functionality.
Layout
1. This menu item should take you directly to the "Edit layout" screen.
2. no functional changes here.
3. note toolbar at top is consistent
Label template
1. this menu item should take you directly to the "Edit label template" page.
2. no functional changes here.
3. note toolbar at top is consistent.
Printer profile
1. this menu item should take you directly to the "Edit printer profile" page.
2. no functional changes here.
3. note toolbar at top is consistent.
+ Manage menu:
Label batches
1. This menu item should take you directly to the "currently available batches" page.
2. select a batch to edit using the buttons
3. select a batch to delete using the buttons - it should ask for confirm.
4. select several batches using the tickboxes, and select Export selected. Batches should be exported as normal.
5. note toolbar at top is consistent.
Layouts
1. This menu item should take you directly to the "currently available layouts" page.
2. select a layout to edit using the buttons
3. select a layout to delete using the buttons
4. note toolbar at top is consistent.
Label templates
1. This menu item should take you directly to the "currently available templates" page.
2. select a template to edit using the buttons
3. select a template to delete using the buttons
4. note toolbar at top is consistent.
Printer profiles
1. This menu item should take you directly to the "currently available profiles" page.
2. select a profile to edit using the buttons
3. select a profile to delete using the buttons
4. note toolbar at top is consistent
+ General
* note that sidebar now only has "labels home" instead of the full "manage" list. It seemed redundant with the toolbar tidied up.
Please note that I am happy to take suggestions/amendments to these changes.
Signed-off-by: Chris Nighswonger <cnighswonger at foundations.edu>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 4fa33e055c127ab3bc9579640172cc55fd73b5d5
Author: Amit Gupta <amit.gupta at informaticsglobal.com>
Date: Thu Sep 17 12:52:59 2015 +0530
Bug 14840: Added new cron script send membership expiry reminder notices in crontab.example file
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Amended: Added koha-common.cron.daily.
Note that the cronjob only does something when the pref is set now.
See corresponding change on bug 6810.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 0d99ca8ac97396b5901cef6b498fe0609ab7a576
Author: Tomas Cohen Arazi <tomascohen at theke.io>
Date: Tue Oct 6 11:18:32 2015 -0300
Bug 6810: DBRev 3.21.00.034
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 507f84f23363746aa9d5912dcb4101e8dad97668
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Fri Sep 18 13:22:42 2015 +0200
Bug 6810: [QA Follow-up] Exit cronjob if pref not set
As per suggestion of Robin on report 14840, it would be better to always
run the cronjob and only do something when the pref is set.
This patch adds a test in the cronjob and clears the former default of 14
days.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Removed the pref and ran the dbrev again: Fine.
Run the cronjob with -c -v -n: Prints exit warning.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit c69203d0ad7bd0c98c8ff46048c07a1986ef9332
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Sep 16 16:26:14 2015 +0200
Bug 6810: [QA Follow-up] Some minor tidying up of cron script
Moved some POD lines and removed some duplicated POD lines.
Corrected some indentation.
Did some minor spelling changes, rewording.
Removed the C4::Dates module. No longer needed.
Removed a label in front of the for statement.
Removed the Do you wish to continue-code. Should not be in a cron job.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 1045d8f9b5796d569f26d0a5a2b0542c04594772
Author: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Date: Wed Sep 16 14:49:11 2015 +0200
Bug 6810: [QA Follow-up] Move test file to db_dependent
Note that this was already mentioned by Jonathan on comment48.
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 21d0e014adf3d7fc4ea22a0fb11d9845aac1f93e
Author: Amit Gupta <amit.gupta at informaticsglobal.com>
Date: Fri Jun 26 22:51:28 2015 +0530
Bug 6810: Fix QA failures
- remove DateTime->now()
- use Koha::DateUtils->dt_from_string;
- use Pod2usage for the usage
- use Modern::Perl
- use branches table
- Change letter code from MEMEXP to MEMBERSHIP_EXPIRY
- review comments implemented
- fix qa script comments
Bug 6810 - Fix QA failures
- MembershipExpiryDaysNotice system preferences arragned alphabetical order.
Bug 6810 - Add sample notices
- review comments implemented
- default value of is_html field in letter table is 0
Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit e5caccb17a563f19e18789a41d4d9ef127dd34c9
Author: Alex Arnaud <alex.arnaud at biblibre.com>
Date: Thu Jun 11 12:17:07 2015 +0200
Bug 6810: Add new systempreference (MembershipExpiryDaysNotice)
Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>
Bug 6810 - Fix QA failures
- Use KohaDates to convert dateexpiry
- remove MYSQL specifics methods for date handling in
GetUpcomingMembershipExpires
- make the script membership_expiry.pl write in Koha system logs
- add tests
Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>
Bug 6810 - Fix QA failures:
- use Koha::DateUtils instead of Koha::Template::Plugin::KohaDates,
- Add test with syspref MembershipExpiryDaysNotice equals 0 and undef,
- fix (new) test failure (when MembershipExpiryDaysNotice is undef).
Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 764b8b7e905e541a8e6de65a94f2ceed0fdef111
Author: Amit Gupta <amitddng135 at gmail.com>
Date: Tue Oct 8 13:50:51 2013 +0530
Bug 6810: Send membership expiry reminder notices.
A new crontab based perl script to send membership expiry reminders. A
system preference controls the number of days in advance of membership
expiry that the notices will be sent on.
To Test:
1) Create a new Patron and set membership expiry date 14 days from the
date of registration.
2) Check your systemprefence ( MemExpDayNotice to 14 days default value)
3) Manual testing Run ( perl membership_expiry.pl -h)
It would give you various option:
This script prepares for membership expiry reminders to be sent to
patrons. It queues them in the message queue, which is processed by
the process_message_queue.pl cronjob.
See the comments in the script for directions on changing the script.
This script has the following parameters :
-c Confirm and remove this help & warning
-n send No mail. Instead, all mail messages are printed on screen.
Useful for testing purposes.
-v verbose
Do you wish to continue? (y/n)
4) Choose option for ex: perl membership_expiry.pl -c
5) Go to your koha database and check message_queue table you see some
results.
6) Run (perl process_message_queue.pl) it will send email to those
patron whose membership after 14 days from today.
7) Cron testing: (10 1 * * * $KOHA_CRON_PATH/membership_expiry.pl -c)
8) Set your 15 * * * * $KOHA_CRON_PATH/process_message_queue.pl
9) After running membership_expiry.pl, (process_message_queue.pl will
send emails to those patron whose membership after 14 days from
today).
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 226a10232a6c43e1bbbaaa3f0ce7a4066eda9e48
Author: Jesse Weaver <pianohacker at gmail.com>
Date: Mon Sep 14 16:22:12 2015 -0600
Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to GetNormalizedUPC
Signed-off-by: Alexis Rodegerdts <arodegerdts at wallawallawa.gov>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit bbd66ad767a28829084ab554a9f24ccd7e046216
Author: Jesse Weaver <pianohacker at gmail.com>
Date: Fri Jul 24 14:33:56 2015 -0600
Bug 14607: (QA followup) Fix typo in shelfbrowser.inc
Signed-off-by: Alexis Rodegerdts <arodegerdts at wallawallawa.gov>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 0ba37ddeba81483664b807948a72410e1fc89df3
Author: Jesse Weaver <pianohacker at gmail.com>
Date: Fri Jul 24 14:33:56 2015 -0600
Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN
Test plan (requires Baker and Taylor cover images to be set up and enabled):
1. Create a record with an ISBN that does not have a cover and a UPC
that does. 141985934X/085391174929 is one set that works well.
2. Verify that the record shows up as "No image available" in the
following OPAC locations: shelf browser, reviews, lists, search and
reading record. This will require adding reviews/checkouts/etc. for
the record in question.
3. Apply patch.
4. Check the locations again, and verify that the record now has a
valid cover image.
Signed-off-by: Alexis Rodegerdts <arodegerdts at wallawallawa.gov>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
-----------------------------------------------------------------------
Summary of changes:
C4/Letters.pm | 5 +
C4/Members.pm | 25 +++
Koha.pm | 2 +-
debian/koha-common.cron.daily | 1 +
.../data/mysql/de-DE/mandatory/sample_notices.sql | 3 +-
.../data/mysql/en/mandatory/sample_notices.sql | 3 +-
.../data/mysql/es-ES/mandatory/sample_notices.sql | 3 +-
.../mysql/fr-FR/1-Obligatoire/sample_notices.sql | 3 +-
installer/data/mysql/it-IT/necessari/notices.sql | 3 +-
.../mysql/nb-NO/1-Obligatorisk/sample_notices.sql | 3 +-
.../data/mysql/pl-PL/mandatory/sample_notices.sql | 3 +-
.../data/mysql/ru-RU/mandatory/sample_notices.sql | 3 +-
installer/data/mysql/sysprefs.sql | 1 +
.../data/mysql/uk-UA/mandatory/sample_notices.sql | 3 +-
installer/data/mysql/updatedatabase.pl | 14 ++
.../intranet-tmpl/prog/en/includes/labels-menu.inc | 8 -
.../prog/en/includes/labels-toolbar.inc | 27 +--
.../prog/en/modules/admin/preferences/patrons.pref | 5 +
.../prog/en/modules/labels/label-edit-batch.tt | 44 ++---
.../prog/en/modules/labels/label-edit-layout.tt | 13 +-
.../prog/en/modules/labels/label-edit-profile.tt | 12 +-
.../prog/en/modules/labels/label-edit-template.tt | 13 +-
.../prog/en/modules/labels/label-home.tt | 30 +--
.../prog/en/modules/labels/label-manage.tt | 58 +++---
.../prog/en/modules/labels/label-print.tt | 2 +-
.../bootstrap/en/includes/shelfbrowser.inc | 5 +-
.../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 9 +-
.../bootstrap/en/modules/opac-opensearch.tt | 3 +-
.../bootstrap/en/modules/opac-readingrecord.tt | 5 +-
.../opac-tmpl/bootstrap/en/modules/opac-results.tt | 12 +-
.../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 5 +-
.../bootstrap/en/modules/opac-showreviews-rss.tt | 3 +-
.../bootstrap/en/modules/opac-showreviews.tt | 5 +-
.../opac-tmpl/bootstrap/en/modules/opac-user.tt | 14 +-
labels/label-edit-batch.pl | 1 +
labels/label-manage.pl | 18 +-
misc/cronjobs/crontab.example | 4 +
misc/cronjobs/membership_expiry.pl | 198 ++++++++++++++++++++
opac/opac-readingrecord.pl | 1 +
opac/opac-user.pl | 4 +-
.../Members/GetUpcomingMembershipExpires.t | 117 ++++++++++++
41 files changed, 518 insertions(+), 173 deletions(-)
delete mode 100644 koha-tmpl/intranet-tmpl/prog/en/includes/labels-menu.inc
create mode 100755 misc/cronjobs/membership_expiry.pl
create mode 100644 t/db_dependent/Members/GetUpcomingMembershipExpires.t
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list