[koha-commits] main Koha release repository branch 3.18.x updated. v3.18.11-4-gfda6ea7

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.18.x has been updated
       via  fda6ea7c322fccf79b07bec04d68c9c79a8a382d (commit)
       via  d33fc314274b6e03608e95bf9d2a38a874882a8a (commit)
       via  d43ac5bfa6d7c9ced14e4df8aa8046c78012f9eb (commit)
       via  2bdb186a028e192e90ea421268b7f889c5031641 (commit)
      from  743095cc829e26044fbb12b8a2400a3754691abd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fda6ea7c322fccf79b07bec04d68c9c79a8a382d
Author: Jonathan Druart <jonathan.druart at biblibre.com>
Date:   Fri Feb 6 16:19:14 2015 +0100

    Bug 13675: Do not set aqorders.budget_id to NULL
    
    C4::Acquisition::ModReceiveOrder updates the aqorders with
    budget_id=NULL if no budget_id given in parameter.
    Actually the same budget_id should be used.
    In tests (especially t/db_dependent/Acquisition/TransferOrder.t),
    ModReceiveOrder is not called with a budget_id param and set to NULL the
    budget_id value.
    
    test plan:
      prove t/db_dependent/Acquisition/TransferOrder.t
    should return green
    
    Note that this bug should not appear using the interface.
    
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    The fix makes sense, and running
     $ prove t/db_dependent/Acq*
    returns all green. koha-qa.pl also likes it.
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
    (cherry picked from commit 2df541712fd691ee817568ed9d14e94bba13424e)
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>

commit d33fc314274b6e03608e95bf9d2a38a874882a8a
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jul 14 15:33:34 2015 +0100

    Bug 14509: Reject invalid passwords
    
    Bug 10177 rejects password with leading or trailing whitespaces, but
    only on the member-password page.
    It's not consistent to only do this check on 1 place.
    This patch adds the check for the 2 other places: memberentry and at the
    OPAC.
    
    Test plan:
    1/ Edit a patron and set a password with leading and/or trailing
    whitespaces. You should not be allowed to do it (no server side check).
    2/ Same at the OPAC ("Change you password" tab). Here there is a server
    side check.
    
    Followed test plan. Works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    (cherry picked from commit 1b8f3194e9f616f46260c849eda5a9f6c717d5fa)
    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
    (cherry picked from commit a19c1257eb9a91426b42b7bad94f211cd9f046a4)
    Signed-off-by: Liz Rea <wizzyrea at gmail.com>

commit d43ac5bfa6d7c9ced14e4df8aa8046c78012f9eb
Author: Brandon <brandon_h27 at hotmail.com>
Date:   Thu Jan 15 22:42:52 2015 +0000

    Bug 10177 - Whitespace is accepted within the password but leading and trailing spaces are not.
    
    Test plan:
    1: Go to your patron
    2: Go to change username and/or password.
    3: Change password to something with spaces in the middle. Notice it is invalid.
    4: Apply this patch.
    5: Change password again using spaces in the middle. Notice it is accepted.
    6: Change password with leading and/or trailing spaces, notice they are not accepted.
    
    Applied bothe patches. Followed test plan. Patch behaves as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 2bdb186a028e192e90ea421268b7f889c5031641
Author: Brandon <brandon_h27 at hotmail.com>
Date:   Wed Jan 14 22:30:01 2015 +0000

    Bug 10177 - whitespace is a valid password causing pernicious perturbations.
    
    Test plan:
    Go to your patron, go to change username and/or password. change
    password to whitespace, notice it is accepted, apply this patch,
    change password again, to whitespace, notice password is not valid.
    
    Followed test plan. Patch behaves as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-----------------------------------------------------------------------

Summary of changes:
 C4/Acquisition.pm                                           |    2 +-
 koha-tmpl/intranet-tmpl/prog/en/js/members.js               |   11 +++++++++++
 .../prog/en/modules/members/member-password.tt              |    6 ++++++
 .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt |    1 +
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-passwd.tt     |    3 +++
 opac/opac-passwd.pl                                         |    8 +++++++-
 6 files changed, 29 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
main Koha release repository