[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.04-13-g2943112

[Git repo owner]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  2943112a2844f7106de0139bb449c3b3ef27fb02 (commit)
       via  54cf2cc340e7f2abe96cdcfcb8aa4bb82031df79 (commit)
      from  f302e98452e16804628b84f246eba73e2d7b0e59 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2943112a2844f7106de0139bb449c3b3ef27fb02
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Sep 22 11:55:55 2015 +0100

    Bug 14141: Fix copy action
    
    Test plan:
    Try to copy a letter to a library which already have this letter (same
    letter_code) defined.
    
    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    (cherry picked from commit 51aad946c6411a484ffde6934d541b9bb1dd2aa3)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

commit 54cf2cc340e7f2abe96cdcfcb8aa4bb82031df79
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Tue Jul 14 12:00:33 2015 +0100

    Bug 14141: Do not let edit the branch when updating/copying notice
    
    If a user modify the library when he's updating a notice, the notice
    will be duplicated, instead of modified.
    
    To reproduce:
    1/ Go on the notice & slips tools (tools/letter.pl)
    2/ Create a notice A for library L1
    3/ Edit this notice and update the library with L2
    4/ On the list view, you will observe that 2 notices A now exist, one
    for L1 and one for L2.
    
    The code in tools/letters.pl should be rebuilt completely, it becomes a
    house of cards. To prevent this bug, I suggest to not let the user
    modify the library value on editing a notice.
    It cans be done by copying the notice to another library and remove the
    original one.
    Counter patch welcomed.
    
    Test plan:
    1/ Go on the notice & slips tools (tools/letter.pl).
    2/ Create a notice A for library L1.
    3/ Edit this notice: you are not able to modify the library anymore.
    4/ Copy the notice to library L2. You are not able to modify the library
    neither.
    
    Works ok.
    
    Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>
    Signed-off-by: Nick Clemens <nick at quecheelibrary.org>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at unc.edu.ar>
    (cherry picked from commit 605f42a721b3a534d01b8f7c73502cfa810147ad)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 .../intranet-tmpl/prog/en/modules/tools/letter.tt  |   24 ++++++++++++--------
 tools/letter.pl                                    |    1 +
 2 files changed, 16 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
main Koha release repository