[koha-commits] main Koha release repository branch 3.20.x updated. v3.20.04-16-g0ff168c

Git repo owner gitmaster at git.koha-community.org
Fri Oct 23 14:54:51 CEST 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, 3.20.x has been updated
       via  0ff168c82ce940ef862e1d695c0e3ac66369dbe6 (commit)
      from  006a44cc6cc4a25f95d1344318600f8a79f31b5f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0ff168c82ce940ef862e1d695c0e3ac66369dbe6
Author: Lari Taskula <larit at student.uef.fi>
Date:   Fri Sep 25 14:06:40 2015 +0000

    Bug 14880: Keyboard shortcuts don't work after setting CircAutocompl to "Don't try"
    
    The issue is that CircAutocompl loads a script element under #header_search
    element. When this element is missing, it also messes up the indexing,
    because we were calculating the indexing of the found element by subtracting
    one from the found element's index (to eliminate the <script> element).
    
    Thats why the shortcut key problem in this bug takes you one too to the left,
    because we are still subtracting one from the index even though there is no
    <script> element anymore.
    
    This patches selects only the div elements and gets the index from them.
    No subtractions needed.
    
    To test keys:
    1. Set CircAutocompl system preference to Don't try.
    2. Try the shortcut keys. They will work incorrectly like this:
       Alt+U = Search catalogue
       Alt+R = Check out
       Alt+Q = Check in
    3. Set CircAutocompl system preference to Try.
    4. Try the shortcut keys. They will work correctly like this:
       Alt+U = Check out
       Alt+R = Check in
       ALt+Q = Search catalogue
    5. Apply patch
    6. Repeat step 1 and 4.
    7. Repeat step 3 and 4.
    8. Observe that regardless of CircAutocompl, shortcut keys worked correctly.
    
    Followed test plan, works as expected.
    Signed-off-by: Marc Véron <veron at veron.ch>
    
    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
    (cherry picked from commit d8c0b836d63e54c9a0be6714f0280d3397debdb4)
    Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-----------------------------------------------------------------------

Summary of changes:
 koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


hooks/post-receive
-- 
main Koha release repository


More information about the koha-commits mailing list