[koha-commits] main Koha release repository branch master updated. v3.20.00-965-g03891d2

Tue Oct 27 21:06:31 CET 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".

The branch, master has been updated
       via  03891d2edc4e03c94e2d9ea326fee978f34c086d (commit)
       via  d3c9dac7ac04a51bca533a69f2107f3ca80f6751 (commit)
       via  b99901136c2ad80b15a5fab3c708a1d4f16c956e (commit)
       via  38f92df4e5f0ff5397e228bcf76f102db681c54c (commit)
       via  babdd2f7f49d9e378aae3304e8dc3a4239d2685b (commit)
      from  356299b9433ee55a30cdcb25a5aff1b880b87a69 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 03891d2edc4e03c94e2d9ea326fee978f34c086d
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Oct 19 09:28:16 2015 +0100

    Bug 14722: CSV is only available for biblio records

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit d3c9dac7ac04a51bca533a69f2107f3ca80f6751
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Oct 19 09:20:41 2015 +0100

    Bug 14722: Add POD for some options

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit b99901136c2ad80b15a5fab3c708a1d4f16c956e
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Oct 19 09:11:48 2015 +0100

    Bug 14722: rename the script

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

commit 38f92df4e5f0ff5397e228bcf76f102db681c54c
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Fri Aug 21 17:26:44 2015 +0100

    Bug 14722: Refactor the export tool

    Why a refactoring was need for this script?
    The export tool (tools/export.pl) can be called from the command line
    and some parts of code were unnecessarity complicated (just look at the
    code, you will understand).

    Worse still, the script does not provide the same options for both
    interface. For instance you cannot export records given a range of
    biblionumbers, authids, callnumbers, etc. from the commandline.

    What does this patch?
    1/ Important: The script tools/export.pl does not work anymore if called from
    the command line (should be in the release notes).
    2/ The code used to generated a file (csv, iso2709 or xml) has been moved to a new
    module (Koha::Exporter::Record) and tests have been provided.
    3/ No change is done on the web interface
    4/ Some new options have been added to the commandline script
    (misc/export.pl):
        - starting_authid
        - ending_authid
        - authtype
        - starting_biblionumber
        - ending_biblionumber
        - itemtype
        - starting_callnumber
        - ending_callnumber
        - start_accession
        - end_accession
    5/ There is a change in the behavior if an error occurs:
    Can't call method "as_usmarc" on an undefined value at Koha/Exporter/Record.pm line 114.
    record (number 5530) is invalid and therefore not exported because its reopening generates warnings above at Koha/Exporter/Record.pm line 117.

    Before this patch, they were not displayed (using the command line).

    What does not do this patch?
    It does not provide the 'clean', 'timestamp' and 'deleted_barcodes' options to
    the web interface (same as before).

    What about the perfs?
    With a DB with ~800 biblios (MARC21)
    Before: perl tools/export.pl 14.79s user 0.83s system 71% cpu 21.905 total
    After:  perl misc/export.pl  17.19s user 0.84s system 75% cpu 24.018 total

    With a DB with ~6400 biblios (UNIMARC)
    Before: perl tools/export.pl 26.55s user 0.76s system 76% cpu 35.498 total
    After:  perl misc/export.pl  26.78s user 0.84s system 80% cpu 34.494 total

    How to test this patch?
    Test plan:
    A. Web interface:
    1/ On the current master, export some records, biblios and authorities (with
    the 3 differents exports) playing with the different filters (item type,
    libraries, callnumber, accession date, don't export items, remove
    non-local items, don't export fields, etc.).
    2/ Apply this patch, export again the same records, and compare the
    generated files. They must be identical!
    3/ Confirm that the export features on the checkout list
    (circ/circulation.pl) works as before this patch.

    B. The command line
    1/ On the current master, export some records, biblios and authorities (with
    the 2 differents exports) playing with the different options (date,
    deleted_barcodes, clean).
    2/ Apply this patch, export again the same records, and compare the
    generated files. They must be identical!

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

commit babdd2f7f49d9e378aae3304e8dc3a4239d2685b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Aug 24 09:18:07 2015 +0100

    Bug 14722: Add Koha::Biblioitem[s]

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

    Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
    Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-----------------------------------------------------------------------

Summary of changes:
 Koha/{City.pm => Biblioitem.pm}    |    6 +-
 Koha/{Cities.pm => Biblioitems.pm} |   10 +-
 Koha/Exporter/Record.pm            |  219 +++++++++++
 misc/export_records.pl             |  333 +++++++++++++++++
 t/db_dependent/Exporter/Record.t   |  166 +++++++++
 tools/export.pl                    |  717 +++++++++---------------------------
 6 files changed, 910 insertions(+), 541 deletions(-)
 copy Koha/{City.pm => Biblioitem.pm} (89%)
 copy Koha/{Cities.pm => Biblioitems.pm} (85%)
 create mode 100644 Koha/Exporter/Record.pm
 create mode 100755 misc/export_records.pl
 create mode 100644 t/db_dependent/Exporter/Record.t

hooks/post-receive
-- 
main Koha release repository