[koha-commits] main Koha release repository branch master updated. v3.20.00-968-gd9426dd
Git repo owner
gitmaster at git.koha-community.org
Thu Oct 29 12:49:23 CET 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via d9426ddfc5c4b9bc91f39117e7a96adc1aae47ef (commit)
via 4c103508b2d631a2b70dda005763b4d50b3d289b (commit)
via 93d6de4bf025c33f48ec9b2d4de72f49135ae6d7 (commit)
from 03891d2edc4e03c94e2d9ea326fee978f34c086d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d9426ddfc5c4b9bc91f39117e7a96adc1aae47ef
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 28 10:43:55 2015 +0000
Bug 14100: Fix Search.t tests
So, this one is VERY weird, let me try to explain what I have
understood.
Bisecting using run prove t/db_dependent/Search.t, I have found that the
following commit make the test fail:
commit 0f63f89f66e40cc01ef02da3654fcfb404c9001d
Bug 14100: Generic solution for language overlay - Item types
The error is
DBI bind_columns: invalid number of arguments: got handle + 0, expected handle + between 1 and -1
Usage: $h->bind_columns(\$var1 [, \$var2, ...]) at /usr/lib/i386-linux-gnu/perl5/5.20/DBI.pm line 2065.
Note that the interface (admin/itemtypes.pl) which calls the same
subroutine with the same parameter (style => 'array') works great.
The problem comes from the change in C4::Search::searchResults, if I
only apply the change done to this subroutine on 0f63f89f^1, I reproduce
the issue.
Looking closely at how %itemtypes is built, we could actually call
GetItemTypes with the style => 'hash' to get exactly what we want.
The following piece prove it for you:
use Test::More;
use C4::Koha;
my $i = GetItemTypes;
my $j = GetItemTypes(style => 'array');
my %itemtypes;
for my $itemtype ( @$j ) {
$itemtypes{ $itemtype->{itemtype} } = $itemtype;
}
is_deeply( \%itemtypes, $i);
So changing the code accordingly and just forget this last hour...
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 4c103508b2d631a2b70dda005763b4d50b3d289b
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 28 09:11:54 2015 +0000
Bug 14100: Fix t/db_dependent/Items.t
prove t/db_dependent/Items.t
Undefined subroutine &C4::Languages::getlanguage called at C4/Items.pm line 1304.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 93d6de4bf025c33f48ec9b2d4de72f49135ae6d7
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Oct 28 08:58:15 2015 +0000
Bug 14100: Fix test xt/author/valid_templates complaining on opac-topissues.tt
undef error - Undefined subroutine &C4::Languages::getlanguage called at C4/Koha.pm line 250.
Test plan:
prove xt/author/valid-templates.t
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
-----------------------------------------------------------------------
Summary of changes:
C4/Items.pm | 1 +
C4/Koha.pm | 2 ++
C4/Search.pm | 9 ++-------
3 files changed, 5 insertions(+), 7 deletions(-)
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list