[koha-commits] main Koha release repository branch master updated. v3.20.00-529-g7f65aaa
Git repo owner
gitmaster at git.koha-community.org
Mon Sep 7 16:54:22 CEST 2015
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "main Koha release repository".
The branch, master has been updated
via 7f65aaac748833b57f9f1c8ae754d66c7e144d81 (commit)
via e2e50e0b06587f45c5370b313ff7a7d7a432bcd5 (commit)
via 65ae7af277d6f64ef42f961c290ab92768a90df3 (commit)
via 2dc5ae238ae0eb58040be4612cae641330b868ba (commit)
via fc4f7fe67577917df9ca4201257bea822832a3c4 (commit)
via e0ed9cbcf60a74dbe2690e6c34c5a311744f49ae (commit)
via 658e787834784dec7d7782f45061b66e22211423 (commit)
via 80abbe1fa358dee58580004e436aef3f0b449430 (commit)
via bef18fad1e52292df5d8c641eac6ff31f5e4f7ed (commit)
via f4ccbcfabd73c8c1ed88c796bd3cb7febe0a68c8 (commit)
via 0b17dd3634948af0c92d5de023159fee4b8a3f5e (commit)
from 297479cc9adb74e050fb630c342413f67ca7c5a8 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7f65aaac748833b57f9f1c8ae754d66c7e144d81
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jul 15 11:50:18 2015 +0100
Bug 12525: Prevent adding several patron lists with the same name
If you add patron to a patron list, from the patron search result, a
list is created when you click on "Save".
The list is considered as new each time.
To reproduce:
1/ Launch a patron search
2/ Select 1 patron, and create a new list 'aaa'
3/ Select another patron and click Save again
2 lists are created
Test plan:
1/ Launch a patron search
2/ Select 1 patron, and create a new list 'aaa'
The dropdown list should be populated with this new list, and should be
selected
3/ Select another patron and click Save again
Only 1 list should be created
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit e2e50e0b06587f45c5370b313ff7a7d7a432bcd5
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Wed Jul 15 11:36:26 2015 +0100
Bug 12525: FIX patron lists dropdown is empty
On the patrons home page, the dropdown list is not populated.
Test plan:
1/ Go on the patrons home page (members/members-home.pl)
2/ Launch a search
3/ The dropdown list close to "Add selected patrons to" should contain
all your patron lists
NOTE: Initially tested with both which created lists.
git reset --hard origin/master
And then dropdown list was missing them.
Applied just this one, and they were listed.
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 65ae7af277d6f64ef42f961c290ab92768a90df3
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Fri Sep 4 14:53:37 2015 +0100
Bug 14343: Remove the DT pagination
It does not make sense to have 2 paginations here.
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 2dc5ae238ae0eb58040be4612cae641330b868ba
Author: Lyon3 Team <koha at univ-lyon3.fr>
Date: Fri Jun 5 15:37:57 2015 +0200
Bug 14343: Incorrect links to results pages in Receive Shipment List
Numbered links have incorrect url. Links to result pages
don't work in Receive Shipment List (but fortunately, Next
and Previous buttons work) It's because the booksellerid is
not furnished in the url.
Test Plan :
1) Go to Acquisitions module, enter a bookseller name that you
know you can get many page of invoices for and search for it.
2) click on Receive shipment button.
3) On bottom of the first results page, click on page number 2
link. (cf joined screencast)
You'll see that the results include invoices from other
booksellerid. Indeed, I suppose that you get results from all booksellerid.
Intall patch and redo 3 steps.
NOTE: I did not follow this test plan.
I read the acqui/parcels.pl code.
The template parameter numbers is assigned in a function which has
no reference to booksellerid at all!
Additionally, the booksellerid is set directly elsewhere.
It is also strange that the booksellerid references before and after
this loop do not use the numbers.booksellerid, but just booksellerid.
The change from numbers.booksellerid to booksellerid is correct!
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit fc4f7fe67577917df9ca4201257bea822832a3c4
Author: Fridolin Somers <fridolin.somers at biblibre.com>
Date: Thu Aug 6 09:36:42 2015 +0200
Bug 14649: Followup - correct budget_period_id in fund name link
Now that fund name is displayed in the table as a link, you see that arg budget_period_id is never defined in this link.
This is because the template var is [% budget_line.budget_period_id %] instead of [% budget_period_id %].
This looks like a mistake when converting from tmpl to tt.
Test plan :
- Without patch
- Look for a planning with funds :
/cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS
- Click on a fund name
=> You see in URL that budget_period_id is empty :
/cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id=
- Apply patch
- Look for a planning with funds :
/cgi-bin/koha/admin/aqplan.pl?budget_period_id=2&authcat=MONTHS
- Click on a fund name
=> you see in URL that budget_period_id is defined like in planning page :
/cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_id=6&budget_period_id=2
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit e0ed9cbcf60a74dbe2690e6c34c5a311744f49ae
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Aug 6 07:19:06 2015 +0100
Bug 14649: Fix regression - display fund name on budget planning
A patch from bug 11714 removes 'budget_name_indent', which was useless.
The script and the template should use the budget_name value.
Note that this patch impacts the CSV export, which does not work, so it cannot be
tested.
Test plan:
Edit a fund and click on one of the Planning value (by months, etc.)
The "Fund name" column should be correctly populated with the fund
names.
Signed-off-by: Fridolin Somers <fridolin.somers at biblibre.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 658e787834784dec7d7782f45061b66e22211423
Author: Blou <philippe.blouin at inlibro.com>
Date: Wed Sep 2 09:59:45 2015 -0400
Bug 14726: Checkout summary doesn't show title
Right after checking out, a small box appear with "Checkout out: Some Title (32154001669305). Due on 24/09/2015".
The title doesn't appear anymore (since the move to db schemas). This fixes it.
Test:
1) checkout ANY item, for ANY user
2) Look at summary right below the checkout input box. The title doesn't show up.
3) apply patch, reproduce same steps (after checkin if same item). Title appears.
Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace at sub.su.se>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Todo: You need to track what are the queries generated here.
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 80abbe1fa358dee58580004e436aef3f0b449430
Author: Mason James <mtj at kohaaloha.com>
Date: Sat Jul 25 20:51:52 2015 +1200
Bug 14602: Fix failing t/Creators.t test
to test..
1/ run t/Creators.t test from git repo, get a FAIL
2/ apply patch
3/ repeat step 1, get a PASS
mason at xen1:~/g/k/3.16.x$ sudo koha-shell -c 'export PERL5LIB=/home/mason/g/k/3.16.x ; cd /home/mason/g/k/3.16.x ; prove -v t/Creators.t' k316x1
t/Creators.t ..
1..16
ok 1 - use C4::Creators;
ok 2 - use C4::Creators::PDF;
ok 3 - testing new() works
ok 4 - testing pdf file created
ok 5 - testing Add() works
ok 6 - testing Bookmark() works
ok 7 - testing Compress() works
ok 8 - testing Font() works
ok 9 - testing FontSize() is set to 12 by default
ok 10 - testing FontSize() can be set to a different value
ok 11 - testing Page() works
ok 12 - testing StrWidth() returns correct point width
ok 13 - testing Text() writes from a given x-value
ok 14 - testing Text() writes to the correct x-value
ok 15 - testing End() works
ok 16 - test file /tmp/4YjPQDExeS created OK
ok
All tests successful.
Files=1, Tests=16, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.48 cusr 0.05 csys = 0.57 CPU)
Result: PASS
Signed-off-by: Liz Rea <liz at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit bef18fad1e52292df5d8c641eac6ff31f5e4f7ed
Author: Blou <philippe.blouin at inlibro.com>
Date: Thu Sep 3 10:44:15 2015 -0400
Bug 14779: Cannot paginate reviews
When having more than 20 (or numSearchResults) reviews waiting to be approved in <site>/cgi-bin/koha/reviews/reviewswaiting.pl?status=1,
the paging at the bottom only offset by 1 entry, instead of moving a full page (20 entries) ahead.
The simple fix uses 'page' instead of 'offset'.
TEST:
1) Modify numSearchResult preference to a low (5?) value.
2) create X comments, where X is greater than the value above.
3) approve them all (although this step is probably unnecessary)
4) Go to tools >> comments (approved comments tab)
5) You see X entries. Click on page 2 at bottom. Link should show "offset=2")
6) You get same results, except the first one which "slided out".
Apply patch, redo step 4-5.
With patch, paging works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit f4ccbcfabd73c8c1ed88c796bd3cb7febe0a68c8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date: Thu Sep 3 09:53:18 2015 +0100
Bug 14472: (follow-up) Wrong ISSN search index in record matching rules
Follow-up for
- it-IT unimarc
- ru-RU unimarc
- uk-UA unimarc
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
commit 0b17dd3634948af0c92d5de023159fee4b8a3f5e
Author: Amit Gupta <amit.gupta at informaticsglobal.com>
Date: Mon Jun 29 21:42:08 2015 +0530
Bug 14472: Wrong ISSN search index in record matching rules
To Test
---------
1) Apply the patch
2) Export some MARC bibliographic records from Koha
3) Import those same MARC bibliographic records using the
"ISSN(022$a)" record matching rule.
4) The incoming records should match perfectly
5) Check the mysql tables (marc_matchers, matchpoints,
matcher_matchpoints, matchpoint_components,
matchpoint_component_norms) to make sure the values were
inserted as expected.
For new Koha installation
1) create the koha database
2) Go to the staff client page, and do a "fresh" install making
sure to select lots of optional marc 21 matching rules so
the .../marc21/optional/marc21_default_matching_rules.sql
gets triggered.
3) Check the mysql tables (marc_matchers, matchpoints,
matcher_matchpoints, matchpoint_components,
matchpoint_component_norms) to make sure the values were
inserted as expected.
Bug 14472 - Added Atomic Update to fix wrong issn search index
- Fix comments
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
-----------------------------------------------------------------------
Summary of changes:
admin/aqplan.pl | 5 ++---
...472_Wrong_ISSN_search_index_in_record_matching_rules.sql | 1 +
.../marc21/optional/marc21_default_matching_rules.sql | 2 +-
.../marc21/optional/marc21_default_matching_rules.sql | 2 +-
.../marc21/optional/marc21_default_matching_rules.sql | 2 +-
.../marc21/Optionnel/marc21_default_matching_rules.sql | 2 +-
.../marc21/optional/marc21_default_matching_rules.sql | 2 +-
.../unimarc/opzionali/unimarc_default_matching_rules.sql | 2 +-
.../marc21/optional/marc21_default_matching_rules.sql | 2 +-
.../marc21/optional/marc21_default_matching_rules.sql | 2 +-
.../marc21/optional/marc21_default_matching_rules.sql | 2 +-
.../unimarc/optional/unimarc_default_matching_rules.sql | 2 +-
.../marc21/optional/marc21_default_matching_rules.sql | 2 +-
.../unimarc/optional/unimarc_default_matching_rules.sql | 2 +-
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt | 4 ++--
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tt | 2 +-
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +-
koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 10 ++++++++++
members/members-home.pl | 2 ++
reviews/reviewswaiting.pl | 5 +++--
t/Creators.t | 11 ++++++-----
21 files changed, 40 insertions(+), 26 deletions(-)
create mode 100644 installer/data/mysql/atomicupdate/bug_14472_Wrong_ISSN_search_index_in_record_matching_rules.sql
hooks/post-receive
--
main Koha release repository
More information about the koha-commits
mailing list